Re: [PR] feat: allow closing a curve on polar line series [echarts]

2023-11-16 Thread via GitHub
yassilah commented on PR #17720: URL: https://github.com/apache/echarts/pull/17720#issuecomment-1814115609 Hi! So I got rid of the loop implementation for ECPolyline, which will use the ECPolygon `buildPath` method when `loop: true` instead. I tried to get rid of the `getPoints` function en

Re: [PR] feat: allow closing a curve on polar line series [echarts]

2023-10-10 Thread via GitHub
yassilah commented on code in PR #17720: URL: https://github.com/apache/echarts/pull/17720#discussion_r1352041387 ## src/chart/line/poly.ts: ## @@ -211,12 +211,34 @@ function drawSegment( return k; } +function getPoints(shape: ECPolygonShape|ECPolylineShape) { +let p

Re: [PR] feat: allow closing a curve on polar line series [echarts]

2023-10-10 Thread via GitHub
Ovilia commented on code in PR #17720: URL: https://github.com/apache/echarts/pull/17720#discussion_r1352022653 ## src/chart/line/poly.ts: ## @@ -211,12 +211,34 @@ function drawSegment( return k; } +function getPoints(shape: ECPolygonShape|ECPolylineShape) { +let poi