Repository: fineract
Updated Branches:
  refs/heads/develop 95ff9ab3c -> 17fd243ae


Resolving 3 integration tests related to bulk import and remoing some sysouts 
and correcting 322.2 migration script


Project: http://git-wip-us.apache.org/repos/asf/fineract/repo
Commit: http://git-wip-us.apache.org/repos/asf/fineract/commit/17fd243a
Tree: http://git-wip-us.apache.org/repos/asf/fineract/tree/17fd243a
Diff: http://git-wip-us.apache.org/repos/asf/fineract/diff/17fd243a

Branch: refs/heads/develop
Commit: 17fd243ae3799beb12901c8830e4196f46669180
Parents: 95ff9ab
Author: Nazeer Hussain Shaik <nazeer.sh...@confluxtechnologies.com>
Authored: Fri Dec 15 13:16:00 2017 +0530
Committer: Nazeer Hussain Shaik <nazeer.sh...@confluxtechnologies.com>
Committed: Fri Dec 15 13:16:00 2017 +0530

----------------------------------------------------------------------
 .../client/ClientEntityImportHandlerTest.java   | 15 ++---
 .../loan/LoanImportHandlerTest.java             | 16 ++---
 .../savings/SavingsImportHandlerTest.java       | 15 ++---
 .../loan/LoanWorkbookPopulatorTest.java         | 11 ++-
 .../savings/SavingsWorkbookPopulateTest.java    | 11 ++-
 .../importhandler/loan/LoanImportHandler.java   |  1 -
 .../BulkImportWorkbookPopulatorServiceImpl.java |  1 -
 .../api/CreditBureauConfigurationAPI.java       |  1 -
 .../service/NotificationDomainServiceImpl.java  |  1 -
 .../AddressWritePlatformServiceImpl.java        |  2 -
 ...ntFamilyMembersWritePlatformServiceImpl.java |  1 -
 .../loanaccount/api/LoansApiResource.java       |  5 --
 .../core_db/V322_2__email_business_rules.sql    | 70 --------------------
 13 files changed, 23 insertions(+), 127 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/client/ClientEntityImportHandlerTest.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/client/ClientEntityImportHandlerTest.java
 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/client/ClientEntityImportHandlerTest.java
index b2038e8..95174e2 100644
--- 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/client/ClientEntityImportHandlerTest.java
+++ 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/client/ClientEntityImportHandlerTest.java
@@ -20,6 +20,7 @@ package 
org.apache.fineract.integrationtests.bulkimport.importhandler.client;
 
 import com.jayway.restassured.builder.RequestSpecBuilder;
 import com.jayway.restassured.builder.ResponseSpecBuilder;
+import com.jayway.restassured.http.ContentType;
 import com.jayway.restassured.specification.RequestSpecification;
 import com.jayway.restassured.specification.ResponseSpecification;
 import 
org.apache.fineract.infrastructure.bulkimport.constants.ClientEntityConstants;
@@ -52,13 +53,9 @@ public class ClientEntityImportHandlerTest {
     @Before
     public void setup() {
         Utils.initializeRESTAssured();
-        this.requestSpec = new RequestSpecBuilder().build();
-        this.requestSpec
-                .header("Authorization",
-                        "Basic "
-                                + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
-        this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200)
-                .build();
+        this.requestSpec = new 
RequestSpecBuilder().setContentType(ContentType.JSON).build();
+        this.requestSpec.header("Authorization", "Basic " + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
+        this.responseSpec = new 
ResponseSpecBuilder().expectStatusCode(200).build();
     }
 
     @Test
@@ -118,9 +115,7 @@ public class ClientEntityImportHandlerTest {
         
firstClientRow.createCell(ClientEntityConstants.SUBMITTED_ON_COL).setCellValue(submittedDate);
         
firstClientRow.createCell(ClientEntityConstants.ADDRESS_ENABLED).setCellValue("False");
 
-        String currentdirectory = new File("").getAbsolutePath();
-        File directory=new File(currentdirectory+"\\src\\integrationTest\\" +
-                "resources\\bulkimport\\importhandler\\client");
+        File directory=new 
File(System.getProperty("user.home")+"\\Fineract\\bulkimport\\integration_tests\\importhandler\\client")
 ;
         if (!directory.exists())
             directory.mkdirs();
         File file= new File(directory+"\\ClientEntity.xls");

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/loan/LoanImportHandlerTest.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/loan/LoanImportHandlerTest.java
 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/loan/LoanImportHandlerTest.java
index 72ddeb8..66a3539 100644
--- 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/loan/LoanImportHandlerTest.java
+++ 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/loan/LoanImportHandlerTest.java
@@ -20,9 +20,9 @@ package 
org.apache.fineract.integrationtests.bulkimport.importhandler.loan;
 
 import com.jayway.restassured.builder.RequestSpecBuilder;
 import com.jayway.restassured.builder.ResponseSpecBuilder;
+import com.jayway.restassured.http.ContentType;
 import com.jayway.restassured.specification.RequestSpecification;
 import com.jayway.restassured.specification.ResponseSpecification;
-import 
org.apache.fineract.infrastructure.bulkimport.constants.ClientEntityConstants;
 import org.apache.fineract.infrastructure.bulkimport.constants.LoanConstants;
 import 
org.apache.fineract.infrastructure.bulkimport.constants.TemplatePopulateImportConstants;
 import org.apache.fineract.integrationtests.common.*;
@@ -52,13 +52,9 @@ public class LoanImportHandlerTest {
     @Before
     public void setup() {
         Utils.initializeRESTAssured();
-        this.requestSpec = new RequestSpecBuilder().build();
-        this.requestSpec
-                .header("Authorization",
-                        "Basic "
-                                + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
-        this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200)
-                .build();
+        this.requestSpec = new 
RequestSpecBuilder().setContentType(ContentType.JSON).build();
+        this.requestSpec.header("Authorization", "Basic " + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
+        this.responseSpec = new 
ResponseSpecBuilder().expectStatusCode(200).build();
     }
 
     @Test
@@ -148,9 +144,7 @@ public class LoanImportHandlerTest {
         
firstLoanRow.createCell(LoanConstants.LAST_REPAYMENT_DATE_COL).setCellValue(date);
         
firstLoanRow.createCell(LoanConstants.REPAYMENT_TYPE_COL).setCellValue(extrasSheet.getRow(1).getCell(3).getStringCellValue());
 
-        String currentdirectory = new File("").getAbsolutePath();
-        File directory=new File(currentdirectory+"\\src\\integrationTest\\" +
-                "resources\\bulkimport\\importhandler\\loan");
+        File directory=new 
File(System.getProperty("user.home")+"\\Fineract\\bulkimport\\integration_tests\\importhandler\\loan")
 ;
         if (!directory.exists())
             directory.mkdirs();
         File file= new File(directory+"\\Loan.xls");

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/savings/SavingsImportHandlerTest.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/savings/SavingsImportHandlerTest.java
 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/savings/SavingsImportHandlerTest.java
index c26594d..50d7d57 100644
--- 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/savings/SavingsImportHandlerTest.java
+++ 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/importhandler/savings/SavingsImportHandlerTest.java
@@ -20,6 +20,7 @@ package 
org.apache.fineract.integrationtests.bulkimport.importhandler.savings;
 
 import com.jayway.restassured.builder.RequestSpecBuilder;
 import com.jayway.restassured.builder.ResponseSpecBuilder;
+import com.jayway.restassured.http.ContentType;
 import com.jayway.restassured.specification.RequestSpecification;
 import com.jayway.restassured.specification.ResponseSpecification;
 import org.apache.fineract.infrastructure.bulkimport.constants.LoanConstants;
@@ -56,13 +57,9 @@ public class SavingsImportHandlerTest {
     @Before
     public void setup() {
         Utils.initializeRESTAssured();
-        this.requestSpec = new RequestSpecBuilder().build();
-        this.requestSpec
-                .header("Authorization",
-                        "Basic "
-                                + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
-        this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200)
-                .build();
+        this.requestSpec = new 
RequestSpecBuilder().setContentType(ContentType.JSON).build();
+        this.requestSpec.header("Authorization", "Basic " + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
+        this.responseSpec = new 
ResponseSpecBuilder().expectStatusCode(200).build();
     }
 
     @Test
@@ -128,9 +125,7 @@ public class SavingsImportHandlerTest {
         
firstSavingsRow.createCell(SavingsConstants.ALLOW_OVER_DRAFT_COL).setCellValue("False");
         
firstSavingsRow.createCell(SavingsConstants.OVER_DRAFT_LIMIT_COL).setCellValue(savingsProductSheet.getRow(1).getCell(15).getNumericCellValue());
 
-        String currentdirectory = new File("").getAbsolutePath();
-        File directory=new File(currentdirectory+"\\src\\integrationTest\\" +
-                "resources\\bulkimport\\importhandler\\savings");
+        File directory=new 
File(System.getProperty("user.home")+"\\Fineract\\bulkimport\\integration_tests\\importhandler\\savings")
 ;
         if (!directory.exists())
             directory.mkdirs();
         File file= new File(directory+"\\Savings.xls");

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java
 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java
index 3ba92a6..b76fac7 100644
--- 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java
+++ 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java
@@ -20,6 +20,7 @@ package 
org.apache.fineract.integrationtests.bulkimport.populator.loan;
 
 import com.jayway.restassured.builder.RequestSpecBuilder;
 import com.jayway.restassured.builder.ResponseSpecBuilder;
+import com.jayway.restassured.http.ContentType;
 import com.jayway.restassured.specification.RequestSpecification;
 import com.jayway.restassured.specification.ResponseSpecification;
 import 
org.apache.fineract.infrastructure.bulkimport.constants.TemplatePopulateImportConstants;
@@ -48,13 +49,9 @@ public class LoanWorkbookPopulatorTest {
     @Before
     public void setup(){
         Utils.initializeRESTAssured();
-        this.requestSpec=new RequestSpecBuilder().build();
-        this.requestSpec
-                .header("Authorization",
-                        "Basic "
-                                + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
-        this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200)
-                .build();
+        this.requestSpec = new 
RequestSpecBuilder().setContentType(ContentType.JSON).build();
+        this.requestSpec.header("Authorization", "Basic " + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
+        this.responseSpec = new 
ResponseSpecBuilder().expectStatusCode(200).build();
     }
     @Test
     public void testLoanWorkbookPopulate() throws IOException {

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java
 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java
index 29ea6c4..e1aaeb5 100644
--- 
a/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java
+++ 
b/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java
@@ -20,6 +20,7 @@ package 
org.apache.fineract.integrationtests.bulkimport.populator.savings;
 
 import com.jayway.restassured.builder.RequestSpecBuilder;
 import com.jayway.restassured.builder.ResponseSpecBuilder;
+import com.jayway.restassured.http.ContentType;
 import com.jayway.restassured.specification.RequestSpecification;
 import com.jayway.restassured.specification.ResponseSpecification;
 import 
org.apache.fineract.infrastructure.bulkimport.constants.TemplatePopulateImportConstants;
@@ -48,13 +49,9 @@ public class SavingsWorkbookPopulateTest {
     @Before
     public void setup(){
         Utils.initializeRESTAssured();
-        this.requestSpec=new RequestSpecBuilder().build();
-        this.requestSpec
-                .header("Authorization",
-                        "Basic "
-                                + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
-        this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200)
-                .build();
+        this.requestSpec = new 
RequestSpecBuilder().setContentType(ContentType.JSON).build();
+        this.requestSpec.header("Authorization", "Basic " + 
Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey());
+        this.responseSpec = new 
ResponseSpecBuilder().expectStatusCode(200).build();
     }
 
     @Test

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java
 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java
index 1cfe401..2199fa7 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/loan/LoanImportHandler.java
@@ -34,7 +34,6 @@ import 
org.apache.fineract.infrastructure.bulkimport.importhandler.helper.DateSe
 import 
org.apache.fineract.infrastructure.bulkimport.importhandler.helper.EnumOptionDataValueSerializer;
 import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
 import org.apache.fineract.infrastructure.core.data.EnumOptionData;
-import org.apache.fineract.infrastructure.core.exception.*;
 import org.apache.fineract.portfolio.loanaccount.data.*;
 import org.apache.poi.ss.usermodel.*;
 import org.joda.time.LocalDate;

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java
 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java
index c329ef4..14cf410 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java
@@ -272,7 +272,6 @@ public class BulkImportWorkbookPopulatorServiceImpl 
implements BulkImportWorkboo
     if (staffId == null){
       staff =
           (List) this.staffReadPlatformService.retrieveAllStaff(null, null, 
Boolean.FALSE, null);
-    //System.out.println("Staff List size : "+staff.size());
     }else {
       staff = new ArrayList<>();
       staff.add(this.staffReadPlatformService.retrieveStaff(staffId));

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/api/CreditBureauConfigurationAPI.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/api/CreditBureauConfigurationAPI.java
 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/api/CreditBureauConfigurationAPI.java
index 2838ce3..91425d2 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/api/CreditBureauConfigurationAPI.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/creditbureau/api/CreditBureauConfigurationAPI.java
@@ -152,7 +152,6 @@ public class CreditBureauConfigurationAPI {
        @Consumes({ MediaType.APPLICATION_JSON })
        @Produces({ MediaType.APPLICATION_JSON })
        public String getConfiguration(@PathParam("organisationCreditBureauId") 
final Long organisationCreditBureauId, @Context final UriInfo uriInfo) {
-               // System.out.println("config triggered");
 
                
this.context.authenticatedUser().validateHasReadPermission(this.resourceNameForPermissions);
 

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java
 
b/fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java
index 6617cbd..f6c8e4c 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java
@@ -595,7 +595,6 @@ public class NotificationDomainServiceImpl implements 
NotificationDomainService
                List<Role> allRoles = roleRepository.findAll();
                for (Role curRole : allRoles) {
                        if (curRole.hasPermissionTo(permission) || 
curRole.hasPermissionTo("ALL_FUNCTIONS")) {
-                               System.out.println(curRole + " Role has 
permission");
                                String memberType = curRole.getName();
                                topicSubscribers = 
topicSubscriberReadPlatformService.getSubscribers(entityId, entityType, 
memberType);
                        }

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/AddressWritePlatformServiceImpl.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/AddressWritePlatformServiceImpl.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/AddressWritePlatformServiceImpl.java
index 3f62d40..913ad2b 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/AddressWritePlatformServiceImpl.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/address/service/AddressWritePlatformServiceImpl.java
@@ -77,8 +77,6 @@ public class AddressWritePlatformServiceImpl implements 
AddressWritePlatformServ
                this.context.authenticatedUser();
                this.fromApiJsonDeserializer.validateForCreate(command.json(), 
true);
 
-               System.out.println("request " + command.json());
-
                if (command.longValueOfParameterNamed("stateProvinceId") != 
null) {
                        stateId = 
command.longValueOfParameterNamed("stateProvinceId");
                        stateIdobj = this.codeValueRepository.getOne(stateId);

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientFamilyMembersWritePlatformServiceImpl.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientFamilyMembersWritePlatformServiceImpl.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientFamilyMembersWritePlatformServiceImpl.java
index e26b542..e8b7af7 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientFamilyMembersWritePlatformServiceImpl.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientFamilyMembersWritePlatformServiceImpl.java
@@ -415,7 +415,6 @@ public class ClientFamilyMembersWritePlatformServiceImpl 
implements ClientFamily
                
                this.context.authenticatedUser();
                
-               System.out.println("clientFamilyMemberId 
"+clientFamilyMemberId);
                apiJsonDeserializer.validateForDelete(clientFamilyMemberId);
                
                ClientFamilyMembers clientFamilyMember=null;

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
index b1c6223..22eca70 100644
--- 
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
+++ 
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
@@ -629,12 +629,7 @@ public class LoansApiResource {
 
         final ApiRequestJsonSerializationSettings settings = 
this.apiRequestParameterHelper.process(uriInfo.getQueryParameters(),
                 mandatoryResponseParameters);
-        long end = System.currentTimeMillis() ;
-        System.out.println("LoansApiResource.retrieveLoan() Time took: 
"+(end-start));
-        start = System.currentTimeMillis() ;
         String toReturn = this.toApiJsonSerializer.serialize(settings, 
loanAccount, this.LOAN_DATA_PARAMETERS);
-        end = System.currentTimeMillis() ;
-        System.out.println("LoansApiResource.retrieveLoan() Time took to 
Serialize: "+(end-start));
         return toReturn ;
     }
 

http://git-wip-us.apache.org/repos/asf/fineract/blob/17fd243a/fineract-provider/src/main/resources/sql/migrations/core_db/V322_2__email_business_rules.sql
----------------------------------------------------------------------
diff --git 
a/fineract-provider/src/main/resources/sql/migrations/core_db/V322_2__email_business_rules.sql
 
b/fineract-provider/src/main/resources/sql/migrations/core_db/V322_2__email_business_rules.sql
index 58440a5..96079bf 100644
--- 
a/fineract-provider/src/main/resources/sql/migrations/core_db/V322_2__email_business_rules.sql
+++ 
b/fineract-provider/src/main/resources/sql/migrations/core_db/V322_2__email_business_rules.sql
@@ -17,76 +17,6 @@
 -- under the License.
 --
 
-INSERT INTO `stretchy_report_parameter` (`report_id`, `parameter_id`, 
`report_parameter_name`)
-VALUES
-( (SELECT id from stretchy_report where report_name = 'Active Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Active Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Prospective Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Prospective Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Active Loan Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Active Loan Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Active Loan Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'cycleXSelect'), 'Cycle X'),
-( (SELECT id from stretchy_report where report_name = 'Active Loan Clients - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'cycleYSelect'), 'Cycle Y'),
-( (SELECT id from stretchy_report where report_name = 'Loans in arrears - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loans in arrears - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loans in arrears - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loans in arrears - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Loans disbursed to 
clients - Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loans disbursed to 
clients - Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loans disbursed to 
clients - Email'), (SELECT id from stretchy_parameter where parameter_name = 
'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loans disbursed to 
clients - Email'), (SELECT id from stretchy_parameter where parameter_name = 
'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Loans disbursed to 
clients - Email'), (SELECT id from stretchy_parameter where parameter_name = 
'cycleXSelect'), 'Cycle X'),
-( (SELECT id from stretchy_report where report_name = 'Loans disbursed to 
clients - Email'), (SELECT id from stretchy_parameter where parameter_name = 
'cycleYSelect'), 'Cycle Y'),
-( (SELECT id from stretchy_report where report_name = 'Loan payments due - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan payments due - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan payments due - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loan payments due - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Dormant Prospects - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Dormant Prospects - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Active Group Leaders - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Active Group Leaders - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Due 
(Overdue Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Due 
(Overdue Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Due 
(Overdue Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Due 
(Overdue Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Due 
(Overdue Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'overdueXSelect'), 'overdueX'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Due 
(Overdue Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'overdueYSelect'), 'overdueY'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Active Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Active Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Active Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Active Loans) - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Overdue Loans)  - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Overdue Loans)  - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Overdue Loans)  - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Overdue Loans)  - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Overdue Loans)  - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'overdueXSelect'), 'overdueX'),
-( (SELECT id from stretchy_report where report_name = 'Loan Payments Received 
(Overdue Loans)  - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'overdueYSelect'), 'overdueY'),
-( (SELECT id from stretchy_report where report_name = 'Happy Birthday - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Happy Birthday - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Fully Repaid - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan Fully Repaid - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Fully Repaid - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loan Fully Repaid - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Loans Outstanding after 
final instalment date - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loans Outstanding after 
final instalment date - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'toYSelect'), 'toY'),
-( (SELECT id from stretchy_report where report_name = 'Loans Outstanding after 
final instalment date - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'fromXSelect'), 'fromX'),
-( (SELECT id from stretchy_report where report_name = 'Loans Outstanding after 
final instalment date - Email'), (SELECT id from stretchy_parameter where 
parameter_name = 'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Rejected - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan Rejected - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Rejected - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'DefaultLoan'), 'loanId'),
-( (SELECT id from stretchy_report where report_name = 'Loan Rejected - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'DefaultClient'), 'clientId'),
-( (SELECT id from stretchy_report where report_name = 'Loan Rejected - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'DefaultGroup'), 'groupId'),
-( (SELECT id from stretchy_report where report_name = 'Loan Rejected - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'SelectLoanType'), 'loanType'),
-( (SELECT id from stretchy_report where report_name = 'Loan Approved - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan Approved - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Approved - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'DefaultLoan'), 'loanId'),
-( (SELECT id from stretchy_report where report_name = 'Loan Approved - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'DefaultClient'), 'clientId'),
-( (SELECT id from stretchy_report where report_name = 'Loan Approved - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'DefaultGroup'), 'groupId'),
-( (SELECT id from stretchy_report where report_name = 'Loan Approved - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'SelectLoanType'), 'loanType'),
-( (SELECT id from stretchy_report where report_name = 'Loan Repayment - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'OfficeIdSelectOne'), 'Office'),
-( (SELECT id from stretchy_report where report_name = 'Loan Repayment - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'loanOfficerIdSelectAll'), 'Loanofficer'),
-( (SELECT id from stretchy_report where report_name = 'Loan Repayment - 
Email'), (SELECT id from stretchy_parameter where parameter_name = 
'SelectLoanType'), 'loanType');
-
 INSERT INTO `m_permission` (`grouping`, `code`, `entity_name`, `action_name`, 
`can_maker_checker`)
 VALUES
 ('report', 'READ_Active Clients - Email', 'Active Clients - Email', 'READ', 0),

Reply via email to