[GitHub] [fineract] vorburger commented on issue #610: remove Tomcat Jasper JSP Engine, as we don't use JSP

vorburger commented on issue #610: remove Tomcat Jasper JSP Engine, as we don't use JSP URL: https://github.com/apache/fineract/pull/610#issuecomment-508287557 I may actually need Jasper later again when upgrading Tomcat 7.0.54 to 8.5.42 (where `com.radcortez.gradle:openjpa-gradle-plugin`

[GitHub] [fineract] vorburger closed pull request #610: remove Tomcat Jasper JSP Engine, as we don't use JSP

vorburger closed pull request #610: remove Tomcat Jasper JSP Engine, as we don't use JSP URL: https://github.com/apache/fineract/pull/610 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] vorburger opened a new pull request #610: remove Tomcat Jasper JSP Engine, as we don't use JSP

vorburger opened a new pull request #610: remove Tomcat Jasper JSP Engine, as we don't use JSP URL: https://github.com/apache/fineract/pull/610 This probably also makes integration test start-up a (little) bit faster. This

[GitHub] [fineract] vorburger opened a new pull request #609: require Java 11

vorburger opened a new pull request #609: require Java 11 URL: https://github.com/apache/fineract/pull/609 This has a number of pre-requisites, and this PR as is today does not work. As other PRs get merged over the coming days & weeks, we'll eventually be able to get this to pass.

[GitHub] [fineract] vorburger commented on issue #601: {WIP, DO NOT MERGE} add classpath duplicates detection test

vorburger commented on issue #601: {WIP, DO NOT MERGE} add classpath duplicates detection test URL: https://github.com/apache/fineract/pull/601#issuecomment-508275422 This will definitely first also require #607 (and probably more).

[GitHub] [fineract] vorburger opened a new pull request #608: bump OpenJPA version from 2.4.1 to 2.4.3 for Java 11 compliance

vorburger opened a new pull request #608: bump OpenJPA version from 2.4.1 to 2.4.3 for Java 11 compliance URL: https://github.com/apache/fineract/pull/608 This will require # (which in turn first requires a few other minor PRs to be merged). The upgrade is because 2.4.1 was not yet

[GitHub] [fineract] vorburger opened a new pull request #607: use openjpa (with real dependencies) instead of shaded openjpa-all

vorburger opened a new pull request #607: use openjpa (with real dependencies) instead of shaded openjpa-all URL: https://github.com/apache/fineract/pull/607 Because the openjpa-all.jar is "shaded" and that causes classpath duplicate problems.

[GitHub] [fineract] vorburger opened a new pull request #606: remove Apache BVal @NotEmpty annotation use

vorburger opened a new pull request #606: remove Apache BVal @NotEmpty annotation use URL: https://github.com/apache/fineract/pull/606 I'm not sure if this even worked? There's no test coverage for it. This is required to be able to (easily) switch from openjpa-all to openjpa.

[GitHub] [fineract] vorburger opened a new pull request #603: mmake OpenJPA version easier to change

vorburger opened a new pull request #603: mmake OpenJPA version easier to change URL: https://github.com/apache/fineract/pull/603 by making it only in 1 place instead of in 2 This does not actually change the version (but a follow-up will).

[GitHub] [fineract] vorburger commented on issue #601: {WIP, DO NOT MERGE} add classpath duplicates detection test

vorburger commented on issue #601: {WIP, DO NOT MERGE} add classpath duplicates detection test URL: https://github.com/apache/fineract/pull/601#issuecomment-508263697 Perhaps this PR (also..) should wait until we're fully done with the Gradle upgrade (although I initally built it to help

[GitHub] [fineract] vorburger commented on issue #601: {WIP, DO NOT MERGE} add classpath duplicates detection test

vorburger commented on issue #601: {WIP, DO NOT MERGE} add classpath duplicates detection test URL: https://github.com/apache/fineract/pull/601#issuecomment-508260086 Please do not merge this yet, I just noticed that we actually have a bigger problem to fix first in #602, then rebase this

[fineract] branch develop updated: add missing license header to .dockerignore

This is an automated email from the ASF dual-hosted git repository. conradsp pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 629cd4d add missing license header to

[GitHub] [fineract] conradsp merged pull request #600: add missing license header to .dockerignore

conradsp merged pull request #600: add missing license header to .dockerignore URL: https://github.com/apache/fineract/pull/600 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [fineract] conradsp commented on issue #600: add missing license header to .dockerignore

conradsp commented on issue #600: add missing license header to .dockerignore URL: https://github.com/apache/fineract/pull/600#issuecomment-508241620 @vorburger - I verified that it builds correctly.  Merging now. This is

[GitHub] [fineract] conradsp commented on issue #599: add suitable .dockerignore

conradsp commented on issue #599: add suitable .dockerignore URL: https://github.com/apache/fineract/pull/599#issuecomment-508240717 Thanks @vorburger! Darn RAT checks! :) On Wed, Jul 3, 2019 at 2:58 PM Michael Vorburger ⛑️ < notificati...@github.com> wrote: > @conradsp

[GitHub] [fineract] vorburger commented on issue #599: add suitable .dockerignore

vorburger commented on issue #599: add suitable .dockerignore URL: https://github.com/apache/fineract/pull/599#issuecomment-508234724 @conradsp you merged this wihout noticing it broke the build... :smile: #600 fixes it.