miPlodder commented on issue #68: View Group functionality added
URL: https://github.com/apache/fineract-cn-mobile/pull/68#issuecomment-509368136
@therajanmaurya Please review this PR.
This is an automated message from the
awasum commented on issue #12: Fixing the issue FINCN-101:Group Definition
Minimum and Maximum Numbe…
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/12#issuecomment-509363064
@cabrelkemfang @markvanveen Please take some time to look at this problem
when we run `npm run
awasum commented on issue #12: Fixing the issue FINCN-101:Group Definition
Minimum and Maximum Numbe…
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/12#issuecomment-509324460
Travis is not picking up?
This is
kengneruphine opened a new pull request #12: Fixing the issue FINCN-101:Group
Definition Minimum and Maximum Numbe…
URL: https://github.com/apache/fineract-cn-fims-web-app/pull/12
…rs should not be decimals
## Description
- Created a custom number-input property called
awasum closed pull request #12: Fixing the issue FINCN-101:Group Definition
Minimum and Maximum Numbe…
URL: https://github.com/apache/fineract-cn-fims-web-app/pull/12
This is an automated message from the Apache Git
awasum commented on issue #12: Fixing the issue FINCN-101:Group Definition
Minimum and Maximum Numbe…
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/12#issuecomment-509307681
https://github.com/apache/fineract-cn-fims-web-app/pull/12/conflicts
awasum commented on issue #12: Fixing the issue FINCN-101:Group Definition
Minimum and Maximum Numbe…
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/12#issuecomment-509307363
@kengneruphine Conflicts?
This is
kengneruphine commented on issue #17: FINCN-168: Fix tslint to make Travis CI
pass
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509299852
Yeah,I will send the commit
This is an automated
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509299516
Maybe you add a new commit under #12 fixing the tslint...
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509298876
This is giving me merge conlicts..If you have it already on ur local
setup..send a new PR to fix this and I will close this
kengneruphine commented on issue #17: FINCN-168: Fix tslint to make Travis CI
pass
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509297866
@awasum, from the travis log, I see errors about Group Unit tests. If you
pull the commits from the PR: #12 , It will
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509286276
Travis build failure
logs:https://travis-ci.com/apache/fineract-cn-fims-web-app/builds/118153337
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509282566
Do you know how we can fix it @kengneruphine ?
This is an
kengneruphine commented on issue #17: FINCN-168: Fix tslint to make Travis CI
pass
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509277292
Hey @awasum , The error is not in the with the Group test. It is from the
Teller service from the
conradsp commented on issue #617: replace Apache BVal @NotEmpty annotation by
javax.validation (re. FINERACT-777)
URL: https://github.com/apache/fineract/pull/617#issuecomment-509224293
This looks good - I agree with using javax.validation and removing bval. I
have validated that it
This is an automated email from the ASF dual-hosted git repository.
conradsp pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 8bdc134 replace Apache BVal @NotEmpty
conradsp merged pull request #617: replace Apache BVal @NotEmpty annotation by
javax.validation (re. FINERACT-777)
URL: https://github.com/apache/fineract/pull/617
This is an automated message from the Apache Git Service.
marta-jankovics commented on issue #14: interoperable - config, build
URL:
https://github.com/apache/fineract-cn-fims-web-app/pull/14#issuecomment-509170777
> @marta-jankovics , Will you be able to address @myrle-krantz 's question?
>
> Is there an API for this UI update?
Hi
marta-jankovics commented on issue #606: remove only use of Apache BVal
@NotEmpty annotation (in InteropIdentifierRequest/Response)
URL: https://github.com/apache/fineract/pull/606#issuecomment-509165632
> GitHub someone doesn't let me re-open this PR anymore, so #617.
Hi @vorburger
mohitsinha commented on issue #615: add "Instructions how to run for local
development" to README
URL: https://github.com/apache/fineract/pull/615#issuecomment-509163522
@vorburger Thanks a lot. Now I understand.
This is an
vorburger commented on issue #607: use openjpa (with real dependencies) instead
of shaded openjpa-all
URL: https://github.com/apache/fineract/pull/607#issuecomment-509123585
I've looked into this again (see forced push updated), but it will need more
work to pass.. the change from
vorburger commented on issue #617: replace Apache BVal @NotEmpty annotation by
javax.validation (re. FINERACT-777)
URL: https://github.com/apache/fineract/pull/617#issuecomment-509119474
@marta-jankovics @conradsp
This is
vorburger commented on issue #606: remove only use of Apache BVal @NotEmpty
annotation (in InteropIdentifierRequest/Response)
URL: https://github.com/apache/fineract/pull/606#issuecomment-509118455
Nah, re-opening this after all... what we really should do here, to avoid
future confusion,
vorburger commented on issue #606: remove only use of Apache BVal @NotEmpty
annotation (in InteropIdentifierRequest/Response)
URL: https://github.com/apache/fineract/pull/606#issuecomment-509112580
Erm... further work on #607 has now revealed that we actually very much do
need a Bean
vorburger closed pull request #606: remove only use of Apache BVal @NotEmpty
annotation (in InteropIdentifierRequest/Response)
URL: https://github.com/apache/fineract/pull/606
This is an automated message from the Apache
vorburger edited a comment on issue #606: remove only use of Apache BVal
@NotEmpty annotation (in InteropIdentifierRequest/Response)
URL: https://github.com/apache/fineract/pull/606#issuecomment-509105476
Oh and BTW I just stumbled upon this in `fineract-provider/build.gradle` :
vorburger commented on issue #606: remove only use of Apache BVal @NotEmpty
annotation (in InteropIdentifierRequest/Response)
URL: https://github.com/apache/fineract/pull/606#issuecomment-509105476
Oh and BTW I just stumbled upon the `exclude module:
'org.apache.bval.bundle'` in
vorburger commented on issue #615: add "Instructions how to run for local
development" to README
URL: https://github.com/apache/fineract/pull/615#issuecomment-509104653
@awasum @mohitsinha re. giving more details about test failures on Travis
CI, you may be be interested in reading the
vorburger commented on issue #606: remove only use of Apache BVal @NotEmpty
annotation (in InteropIdentifierRequest/Response)
URL: https://github.com/apache/fineract/pull/606#issuecomment-509102619
> so to me it seems that if you replace @notempty with @NotNull you would
affect the
vorburger commented on issue #596: re-enable commented out
TemplateMergeServiceTest.compileHelloTemplate (which actually passes)
URL: https://github.com/apache/fineract/pull/596#issuecomment-509098546
FTR: I lococally tested that `./gradlew test` still passes on `develop` with
this merged
mohitsinha commented on issue #615: add "Instructions how to run for local
development" to README
URL: https://github.com/apache/fineract/pull/615#issuecomment-509093097
@awasum But the root cause of this infrequent random failure should be found
out. Making the test reports public after
31 matches
Mail list logo
