[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-06 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687846652 @vorburger yup I will fix this in a day or two. @ptuomola thanks for the suggestion!! This is an aut

[GitHub] [fineract] vorburger commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-06 Thread GitBox
vorburger commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687845780 @thesmallstar the suggestion from @ptuomola in the last comment on FINERACT-1095 to use e.g. `"loanStatus": ["all","active","overpaid"], "loanProducts": ["65","97","73","82"]

[GitHub] [fineract] vorburger commented on pull request #1290: Added and Enforced AbbreviationAsWordInName Checkstyle (FINERACT-821)

2020-09-06 Thread GitBox
vorburger commented on pull request #1290: URL: https://github.com/apache/fineract/pull/1290#issuecomment-687845113 @thesmallstar hope you saw @ptuomola review feedback on this PR and will have remember to update it when you have a moment? Tx! -

[GitHub] [fineract] vorburger merged pull request #1284: add Merge Strategy section to README

2020-09-06 Thread GitBox
vorburger merged pull request #1284: URL: https://github.com/apache/fineract/pull/1284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[fineract] branch develop updated: add Merge Strategy section to README (#1284)

2020-09-06 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 4b435c7 add Merge Strategy section to RE

[fineract] branch vorburger-README-merge-strategy updated (742acb4 -> 13e1536)

2020-09-06 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-README-merge-strategy in repository https://gitbox.apache.org/repos/asf/fineract.git. from 742acb4 Update .github/PULL_REQUEST_TEMPLATE.MD add 13e1536 Update .github/PULL_

[fineract] branch vorburger-README-merge-strategy updated (23e8a25 -> 742acb4)

2020-09-06 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-README-merge-strategy in repository https://gitbox.apache.org/repos/asf/fineract.git. from 23e8a25 Update .github/PULL_REQUEST_TEMPLATE.MD add 742acb4 Update .github/PULL_

[fineract] branch vorburger-README-merge-strategy updated (5360090 -> 23e8a25)

2020-09-06 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-README-merge-strategy in repository https://gitbox.apache.org/repos/asf/fineract.git. from 5360090 Update .github/PULL_REQUEST_TEMPLATE.MD add 23e8a25 Update .github/PULL_

[fineract] branch vorburger-README-merge-strategy updated (de78469 -> 5360090)

2020-09-06 Thread vorburger
This is an automated email from the ASF dual-hosted git repository. vorburger pushed a change to branch vorburger-README-merge-strategy in repository https://gitbox.apache.org/repos/asf/fineract.git. from de78469 improve PR Template (and move commit message blurb in README) add 5360090