[fineract] branch dependabot/github_actions/actions/setup-java-c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c created (now 5581d12cc)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-java-c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c in repository https://gitbox.apache.org/repos/asf/fineract.git at 5581d12cc chore(deps): bump acti

[GitHub] [fineract] dependabot[bot] opened a new pull request, #2791: chore(deps): bump actions/setup-java from 19eeec562b37d29a1ad055b7de9c280bd0906d8d to c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c

dependabot[bot] opened a new pull request, #2791: URL: https://github.com/apache/fineract/pull/2791 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 19eeec562b37d29a1ad055b7de9c280bd0906d8d to c3ac5dd0ed8db40fedb61c32fbe677e6b355e94c. Commits https://gith

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040266949 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private GetClien

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265923 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265769 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -555,6 +523

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265519 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -24,92 +24,96 @@ import java.util.List; impor

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040265338 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Ap

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040264438 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Ap

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039990728 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -479,10 +476,10 @@ public Map update(final JsonCo

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039989747 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -229,7 +232,7 @@ public static Client createNew(f

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039890596 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -293,7 +297,7 @@ public static ClientData templ

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039890825 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -379,7 +383,7 @@ public static ClientData clien

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039887260 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientPersonImportHandler.java: ## @@ -95,7 +

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039886014 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039881056 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/mapper/ClientMapper.java: ## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apa

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039880418 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -436,4 +352,251 @@ public String retrie

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039811298 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -24,92 +24,96 @@ import java.util.List; import java.util.Set;

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039804761 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -555,6 +523,7 @@ public Comma

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039802744 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247,16 @@ public Comm

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039800321 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -479,10 +476,10 @@ public Map update(final JsonCommand command) {

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039796013 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -229,7 +232,7 @@ public static Client createNew(final AppUser curre

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039793683 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -379,7 +383,7 @@ public static ClientData clientIdentifier(final

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039793234 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -293,7 +297,7 @@ public static ClientData template(final Long off

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039791113 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientPersonImportHandler.java: ## @@ -95,7 +97,7 @@ private Cl

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039786406 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7 +143,7 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039786406 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/client/ClientEntityImportHandler.java: ## @@ -141,7 +143,7 @@ private

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039704997 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -34,82 +36,83 @@ import org.apache.fineract.or

[GitHub] [fineract] ruchiD opened a new pull request, #2790: FINERACT-1818-Loan-Retrieve-Api-data-addition

ruchiD opened a new pull request, #2790: URL: https://github.com/apache/fineract/pull/2790 ## Description 1.Added computation of amount summation for various Loan Transactions based on transaction type and reverse status, for summary in Loan get by loanId api. 2.Added Loan Transaction

[GitHub] [fineract] forking-renovate[bot] commented on pull request #2787: chore(deps): update all non-major dependencies

forking-renovate[bot] commented on PR #2787: URL: https://github.com/apache/fineract/pull/2787#issuecomment-1337464480 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may hav

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039662977 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +757,18 @@ public boolean isStaff() {

[fineract] branch develop updated: FINERACT-1825: Fix end of month handling

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new e5f4cc819 FINERACT-1825: Fix end of month

[GitHub] [fineract] adamsaghy merged pull request #2789: FINERACT-1825: Fix end of month handling

adamsaghy merged PR #2789: URL: https://github.com/apache/fineract/pull/2789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@finerac

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039618936 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039617750 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039608506 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +60,7 @@ public interfa

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039606278 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientReposit

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039605644 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientReposit

[fineract] branch develop updated (4ba40c241 -> a708251c6)

This is an automated email from the ASF dual-hosted git repository. arnold pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git from 4ba40c241 chore(deps): update actions/setup-java digest to 19eeec5 add a708251c6 FINERACT-1760: Fix reversal e

[GitHub] [fineract] galovics merged pull request #2785: FINERACT-1760: Fix reversal external id handling

galovics merged PR #2785: URL: https://github.com/apache/fineract/pull/2785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039581083 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ##

[GitHub] [fineract] galovics commented on a diff in pull request #2788: FINERACT-1827: Fix to set obligation met date for installment with chargeback transa…

galovics commented on code in PR #2788: URL: https://github.com/apache/fineract/pull/2788#discussion_r1039567356 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DelinquencyAndChargebackIntegrationTest.java: ## @@ -281,6 +285,26 @@ public void testLoanCla

[GitHub] [fineract] totemcaf commented on a diff in pull request #2712: FINERACT-1789: retrieveSchedulerDetail fails if no records founds

totemcaf commented on code in PR #2712: URL: https://github.com/apache/fineract/pull/2712#discussion_r1039549134 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformServiceJpaRepositoryImpl.java: ## @@ -102,10 +102,10 @@ publi

[GitHub] [fineract] totemcaf commented on a diff in pull request #2712: FINERACT-1789: retrieveSchedulerDetail fails if no records founds

totemcaf commented on code in PR #2712: URL: https://github.com/apache/fineract/pull/2712#discussion_r1039548957 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformServiceJpaRepositoryImpl.java: ## @@ -102,10 +102,10 @@ publi

[GitHub] [fineract] adamsaghy opened a new pull request, #2789: FINERACT-1825: Fix end of month handling

adamsaghy opened a new pull request, #2789: URL: https://github.com/apache/fineract/pull/2789 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039521823 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/mapper/ClientMapper.java: ## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apache Software Founda

[GitHub] [fineract] dependabot[bot] closed pull request #2784: chore(deps): bump actions/setup-java from 3.6.0 to 3.7.0

dependabot[bot] closed pull request #2784: chore(deps): bump actions/setup-java from 3.6.0 to 3.7.0 URL: https://github.com/apache/fineract/pull/2784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] dependabot[bot] commented on pull request #2784: chore(deps): bump actions/setup-java from 3.6.0 to 3.7.0

dependabot[bot] commented on PR #2784: URL: https://github.com/apache/fineract/pull/2784#issuecomment-1337222001 Looks like actions/setup-java is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[fineract] branch develop updated (0162ffe1e -> 4ba40c241)

This is an automated email from the ASF dual-hosted git repository. arnold pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git from 0162ffe1e FINERACT-1760: Fix error handling for loan charge details add 4ba40c241 chore(deps): update actions/

[GitHub] [fineract] galovics merged pull request #2786: chore(deps): update actions/setup-java digest to 19eeec5

galovics merged PR #2786: URL: https://github.com/apache/fineract/pull/2786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039302792 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java: ## @@ -0,0 +1,199 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039293985 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g --add-expor

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039293985 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. # -org.gradle.jvmargs=-Xmx2g --add-expor

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039292804 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -290,6 +247,15 @@ public Comm

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039288976 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformService.java: ## @@ -60,4 +60,7 @@ public interface ClientReadPlatf

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039287520 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientRepository extends JpaRep

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039287147 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java: ## @@ -29,4 +29,35 @@ interface ClientRepository extends JpaRep

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039285495 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -763,30 +757,18 @@ public boolean isStaff() { return this.

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039284331 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/data/ClientData.java: ## @@ -34,82 +36,83 @@ import org.apache.fineract.organisation.office.

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039275106 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private GetClientsGroups() {}

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039275106 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java: ## @@ -252,6 +252,8 @@ private GetClientsGroups() {}

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039270839 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResource.java: ## @@ -436,4 +352,251 @@ public String retrieveTransferTemplate

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039264757 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -91,6 +84,29 @

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039265325 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java: ## @@ -489,4 +491,11 @@ public boolean

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039264757 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -91,6 +84,29 @