[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #20: Bump express from 4.16.3 to 4.18.2

2022-12-07 Thread GitBox
sonarcloud[bot] commented on PR #20: URL: https://github.com/apache/fineract-cn-group-finance/pull/20#issuecomment-1342106610 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #20: Bump express from 4.16.3 to 4.18.2

2022-12-07 Thread GitBox
dependabot[bot] opened a new pull request, #20: URL: https://github.com/apache/fineract-cn-group-finance/pull/20 Bumps [express](https://github.com/expressjs/express) from 4.16.3 to 4.18.2. Release notes Sourced from https://github.com/expressjs/express/releases;>express's

[fineract-cn-group-finance] branch dependabot/npm_and_yarn/express-4.18.2 created (now 61e2d61)

2022-12-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/express-4.18.2 in repository https://gitbox.apache.org/repos/asf/fineract-cn-group-finance.git at 61e2d61 Bump express from 4.16.3 to 4.18.2 No new revisions

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042815557 ## gradle.properties: ## @@ -16,7 +16,7 @@ # specific language governing permissions and limitations # under the License. #

[fineract-cn-fims-web-app] branch dependabot/npm_and_yarn/qs-6.2.4 created (now de73370)

2022-12-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/qs-6.2.4 in repository https://gitbox.apache.org/repos/asf/fineract-cn-fims-web-app.git at de73370 Bump qs from 6.2.3 to 6.2.4 No new revisions were added by

[GitHub] [fineract-cn-fims-web-app] dependabot[bot] opened a new pull request, #35: Bump qs from 6.2.3 to 6.2.4

2022-12-07 Thread GitBox
dependabot[bot] opened a new pull request, #35: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/35 Bumps [qs](https://github.com/ljharb/qs) from 6.2.3 to 6.2.4. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md;>qs's changelog. 6.2.4

[fineract] branch develop updated: FINERACT-1760: Batch API for datatable query update

2022-12-07 Thread arnold
This is an automated email from the ASF dual-hosted git repository. arnold pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new e08de FINERACT-1760: Batch API for

[GitHub] [fineract] galovics merged pull request #2793: FINERACT-1760: Batch API for datatable query update

2022-12-07 Thread GitBox
galovics merged PR #2793: URL: https://github.com/apache/fineract/pull/2793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #19: Bump qs from 6.3.2 to 6.3.3

2022-12-07 Thread GitBox
sonarcloud[bot] commented on PR #19: URL: https://github.com/apache/fineract-cn-group-finance/pull/19#issuecomment-1341556621 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #19: Bump qs from 6.3.2 to 6.3.3

2022-12-07 Thread GitBox
dependabot[bot] opened a new pull request, #19: URL: https://github.com/apache/fineract-cn-group-finance/pull/19 Bumps [qs](https://github.com/ljharb/qs) from 6.3.2 to 6.3.3. Changelog Sourced from https://github.com/ljharb/qs/blob/main/CHANGELOG.md;>qs's changelog. 6.3.3

[fineract-cn-group-finance] branch dependabot/npm_and_yarn/qs-6.3.3 created (now d7d2686)

2022-12-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/qs-6.3.3 in repository https://gitbox.apache.org/repos/asf/fineract-cn-group-finance.git at d7d2686 Bump qs from 6.3.2 to 6.3.3 No new revisions were added by

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042269698 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -463,7 +459,7 @@ public boolean isWithdrawn() {

[GitHub] [fineract] adamsaghy opened a new pull request, #2793: FINERACT-1760: Batch API for datatable query update

2022-12-07 Thread GitBox
adamsaghy opened a new pull request, #2793: URL: https://github.com/apache/fineract/pull/2793 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042242044 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientDomainServiceImpl.java: ## @@ -0,0 +1,225 @@ +/** + *

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042072148 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@ public Collection

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041911963 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/Client.java: ## @@ -358,7 +324,7 @@ private void validate() { } -private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

2022-12-07 Thread GitBox
adamsaghy commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1041911174 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientDomainServiceImpl.java: ## @@ -0,0 +1,225 @@ +/** + * Licensed to the Apache