[GitHub] [fineract] taskain7 opened a new pull request, #2887: [FINERACT-1859] Missing configuration for business event

2023-01-16 Thread GitBox
taskain7 opened a new pull request, #2887: URL: https://github.com/apache/fineract/pull/2887 ## Description Event configuration was missing for `LoanAccountsStayedLockedBusinessEvent` Event sourca package has been changed to root package. -- This is an automated message from the

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2881: FINERACT-1856: Fix to update datatable entry is failing after column added lately

2023-01-16 Thread GitBox
adamsaghy commented on code in PR #2881: URL: https://github.com/apache/fineract/pull/2881#discussion_r1071389564 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DatatableIntegrationTest.java: ## @@ -426,6 +430,89 @@ public void

[GitHub] [fineract] b0c1 opened a new pull request, #2886: FINERACT-1724 - Replayed bulk transaction fix

2023-01-16 Thread GitBox
b0c1 opened a new pull request, #2886: URL: https://github.com/apache/fineract/pull/2886 FINERACT-1724 - Replayed bulk transaction fix [x] - Remove bulk transaction from ReplayedTransactionBusinessEventService [x] - Create Aspect and custom annotation for CommandHandler and Tasklet

[GitHub] [fineract] b0c1 closed pull request #2885: FINERACT-1724 - Replayed bulk transaction fix

2023-01-16 Thread GitBox
b0c1 closed pull request #2885: FINERACT-1724 - Replayed bulk transaction fix URL: https://github.com/apache/fineract/pull/2885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [fineract] b0c1 opened a new pull request, #2885: FINERACT-1724 - Replayed bulk transaction fix

2023-01-16 Thread GitBox
b0c1 opened a new pull request, #2885: URL: https://github.com/apache/fineract/pull/2885 FINERACT-1724 - Replayed bulk transaction fix [x] - Remove bulk transaction from ReplayedTransactionBusinessEventService [x] - Create Aspect and custom annotation for CommandHandler and Tasklet

[GitHub] [fineract] galovics merged pull request #2884: chore(deps): update dependency org.mockito:mockito-bom to v5

2023-01-16 Thread GitBox
galovics merged PR #2884: URL: https://github.com/apache/fineract/pull/2884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2881: FINERACT-1856: Fix to update datatable entry is failing after column added lately

2023-01-16 Thread GitBox
adamsaghy commented on code in PR #2881: URL: https://github.com/apache/fineract/pull/2881#discussion_r1071289781 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -430,7 +430,8 @@ public

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2881: FINERACT-1856: Fix to update datatable entry is failing after column added lately

2023-01-16 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2881: URL: https://github.com/apache/fineract/pull/2881#discussion_r1071252666 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DatatableIntegrationTest.java: ## @@ -426,6 +430,92 @@ public void

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2881: FINERACT-1856: Fix to update datatable entry is failing after column added lately

2023-01-16 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2881: URL: https://github.com/apache/fineract/pull/2881#discussion_r1071246923 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -430,7

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2881: Fix to update datatable entry is failing after column added lately

2023-01-16 Thread GitBox
adamsaghy commented on code in PR #2881: URL: https://github.com/apache/fineract/pull/2881#discussion_r1071003269 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/DatatableIntegrationTest.java: ## @@ -426,6 +430,92 @@ public void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2881: Fix to update datatable entry is failing after column added lately

2023-01-16 Thread GitBox
adamsaghy commented on code in PR #2881: URL: https://github.com/apache/fineract/pull/2881#discussion_r1070995800 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientWritePlatformServiceJpaRepositoryImpl.java: ## @@ -430,7 +430,8 @@ public

[GitHub] [fineract] IOhacker merged pull request #2872: FINERACT-1848 Add support for plugins

2023-01-15 Thread GitBox
IOhacker merged PR #2872: URL: https://github.com/apache/fineract/pull/2872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] renovate-bot opened a new pull request, #2884: chore(deps): update dependency org.mockito:mockito-bom to v5

2023-01-15 Thread GitBox
renovate-bot opened a new pull request, #2884: URL: https://github.com/apache/fineract/pull/2884 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2883: chore(deps): update all non-major dependencies

2023-01-15 Thread GitBox
renovate-bot opened a new pull request, #2883: URL: https://github.com/apache/fineract/pull/2883 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2882: FINERACT-1854: Undo last disbursal function deletes all disbursals on…

2023-01-15 Thread GitBox
josehernandezfintecheandomx opened a new pull request, #2882: URL: https://github.com/apache/fineract/pull/2882 … the last date ## Description When a loan with multitranches have two (or more) disbursals on it, and we call the` /loans/{loanId}?command=undolastdisbursal` or

[GitHub] [fineract] github-actions[bot] closed pull request #2565: FINERACT-1715: Introduce Lombok to cob module

2023-01-14 Thread GitBox
github-actions[bot] closed pull request #2565: FINERACT-1715: Introduce Lombok to cob module URL: https://github.com/apache/fineract/pull/2565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [fineract] github-actions[bot] closed pull request #2743: FINERACT-1805 - Treat share transactions separately

2023-01-14 Thread GitBox
github-actions[bot] closed pull request #2743: FINERACT-1805 - Treat share transactions separately URL: https://github.com/apache/fineract/pull/2743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2881: Fix to update datatable entry is failing after column added lately

2023-01-13 Thread GitBox
josehernandezfintecheandomx opened a new pull request, #2881: URL: https://github.com/apache/fineract/pull/2881 ## Description Fix to update datatable entry is failing after column added lately [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284)

[GitHub] [fineract] ruchiD opened a new pull request, #2880: FINERACT-1694-External-event-producer-batch-size-configuration

2023-01-13 Thread GitBox
ruchiD opened a new pull request, #2880: URL: https://github.com/apache/fineract/pull/2880 ## Description 1.Removed static configuration(environment variable) for event batch read size for producer. 2.Introduced new global configuration "external-event-batch-size" to configure batch

[GitHub] [fineract] taskain7 opened a new pull request, #2879: [FINERACT-1852] Swagger schema inconsistency for Business Step Config

2023-01-12 Thread GitBox
taskain7 opened a new pull request, #2879: URL: https://github.com/apache/fineract/pull/2879 ## Description Swagger schema provides the correct response type for the following APIs: - GET /jobs/names - GET /jobs/{jobName}/steps - PUT /jobs/{jobName}/available-steps -

[GitHub] [fineract] taskain7 commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-12 Thread GitBox
taskain7 commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1068752548 ## fineract-provider/src/main/java/org/apache/fineract/cob/api/LoanCOBCatchUpApiResource.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2878: FINERACT-1853: General accounting summary table reports

2023-01-12 Thread GitBox
josehernandezfintecheandomx opened a new pull request, #2878: URL: https://github.com/apache/fineract/pull/2878 ## Description `Transaction summary` and `Trial Balance Summary` reports have to be added to Fineract as standard reports

[GitHub] [fineract] galovics merged pull request #2877: FINERACT-1734-Loan-Repayment-Due-Overdue-Separate-Business-Events

2023-01-12 Thread GitBox
galovics merged PR #2877: URL: https://github.com/apache/fineract/pull/2877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2877: FINERACT-1734-Loan-Repayment-Due-Overdue-Separate-Business-Events

2023-01-11 Thread GitBox
ruchiD opened a new pull request, #2877: URL: https://github.com/apache/fineract/pull/2877 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-11 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1067432126 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientLoanCreditBalanceRefundandRepaymentTypeIntegrationTest.java: ## @@

[GitHub] [fineract] galovics merged pull request #2876: FINERACT-1724: Added ExternalEventConfigurationApi to FineractClient

2023-01-11 Thread GitBox
galovics merged PR #2876: URL: https://github.com/apache/fineract/pull/2876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-11 Thread GitBox
galovics commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1067253956 ## fineract-provider/src/main/java/org/apache/fineract/cob/api/LoanCOBCatchUpApiResource.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] galovics opened a new pull request, #2876: FINERACT-1724: Added ExternalEventConfigurationApi to FineractClient

2023-01-11 Thread GitBox
galovics opened a new pull request, #2876: URL: https://github.com/apache/fineract/pull/2876 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2874: FINERACT-1851

2023-01-11 Thread GitBox
galovics merged PR #2874: URL: https://github.com/apache/fineract/pull/2874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2875: FINERACT-1818-Credit-Refund-Payout-Not-Getting-Created-Test

2023-01-11 Thread GitBox
galovics merged PR #2875: URL: https://github.com/apache/fineract/pull/2875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2873: FINERACT-1734-LoanBalanceChanged-Business-Event-Chargeback

2023-01-11 Thread GitBox
galovics merged PR #2873: URL: https://github.com/apache/fineract/pull/2873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2867: FINERACT-1734 - Loan Account Delinquency Changed event - fix

2023-01-11 Thread GitBox
galovics merged PR #2867: URL: https://github.com/apache/fineract/pull/2867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] taskain7 commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-11 Thread GitBox
taskain7 commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1066752039 ## fineract-provider/src/main/java/org/apache/fineract/cob/api/LoanCOBCatchUpApiResource.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] ruchiD opened a new pull request, #2875: FINERACT-1818-Credit-Refund-Payout-Not-Getting-Created-Test

2023-01-11 Thread GitBox
ruchiD opened a new pull request, #2875: URL: https://github.com/apache/fineract/pull/2875 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-11 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1066694008 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -120,6 +141,16 @@ public void execute(List loanIds,

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-11 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1066687503 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -96,6 +99,26 @@ public CommandProcessingResult

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-11 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1066683156 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/AsyncLoanCOBExecutorServiceImpl.java: ## @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-11 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1066679786 ## fineract-provider/src/main/java/org/apache/fineract/cob/api/LoanCOBCatchUpApiResource.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] wkigenyi opened a new pull request, #2874: FINERACT-1851

2023-01-10 Thread GitBox
wkigenyi opened a new pull request, #2874: URL: https://github.com/apache/fineract/pull/2874 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] ruchiD opened a new pull request, #2873: FINERACT-1734-LoanBalanceChanged-Business-Event-Chargeback

2023-01-10 Thread GitBox
ruchiD opened a new pull request, #2873: URL: https://github.com/apache/fineract/pull/2873 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] wkigenyi closed pull request #2871: Fineract-1851

2023-01-10 Thread GitBox
wkigenyi closed pull request #2871: Fineract-1851 URL: https://github.com/apache/fineract/pull/2871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] IOhacker opened a new pull request, #2872: FINERACT-1848 Add support for plugins

2023-01-10 Thread GitBox
IOhacker opened a new pull request, #2872: URL: https://github.com/apache/fineract/pull/2872 ## Description FINERACT-1848 Add support for plugins publishing the fineract provider library and adding the extra class path which can be used for containers to mount volumens with with

[GitHub] [fineract] wkigenyi opened a new pull request, #2871: Fineract-1851

2023-01-10 Thread GitBox
wkigenyi opened a new pull request, #2871: URL: https://github.com/apache/fineract/pull/2871 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2023-01-10 Thread GitBox
galovics commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1065847510 ## fineract-provider/src/main/java/org/apache/fineract/cob/api/LoanCOBCatchUpApiResource.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] taskain7 closed pull request #2870: Revert "FINERACT-1818-Credit-Refund-Payout-Not-Getting-Created"

2023-01-10 Thread GitBox
taskain7 closed pull request #2870: Revert "FINERACT-1818-Credit-Refund-Payout-Not-Getting-Created" URL: https://github.com/apache/fineract/pull/2870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] taskain7 opened a new pull request, #2870: Revert "FINERACT-1818-Credit-Refund-Payout-Not-Getting-Created"

2023-01-10 Thread GitBox
taskain7 opened a new pull request, #2870: URL: https://github.com/apache/fineract/pull/2870 Reverts apache/fineract#2869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [fineract] galovics merged pull request #2850: fix(deps): update non-major

2023-01-10 Thread GitBox
galovics merged PR #2850: URL: https://github.com/apache/fineract/pull/2850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] taskain7 merged pull request #2869: FINERACT-1818-Credit-Refund-Payout-Not-Getting-Created

2023-01-10 Thread GitBox
taskain7 merged PR #2869: URL: https://github.com/apache/fineract/pull/2869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2868: FINERACT-1724: Added the possibility to use username and password for…

2023-01-10 Thread GitBox
galovics merged PR #2868: URL: https://github.com/apache/fineract/pull/2868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-10 Thread GitBox
adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1065583905 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientLoanCreditBalanceRefundandRepaymentTypeIntegrationTest.java: ## @@ -438,4 +439,73 @@

[GitHub] [fineract] taskain7 merged pull request #2866: [FINERACT-1842] Wrong entityId is returned upon disbursing a loan

2023-01-10 Thread GitBox
taskain7 merged PR #2866: URL: https://github.com/apache/fineract/pull/2866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2869: FINERACT-1818-Credit-Refund-Payout-Not-Getting-Created

2023-01-09 Thread GitBox
ruchiD opened a new pull request, #2869: URL: https://github.com/apache/fineract/pull/2869 ## Description Fixed issue with refunds with chargeback. Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2861: FINERACT-1785: Specified due date charges/fees cannot be applied on disbursement date

2023-01-09 Thread GitBox
galovics merged PR #2861: URL: https://github.com/apache/fineract/pull/2861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2863: chore(deps): update all non-major dependencies

2023-01-09 Thread GitBox
galovics merged PR #2863: URL: https://github.com/apache/fineract/pull/2863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics opened a new pull request, #2868: FINERACT-1724: Added the possibility to use username and password for…

2023-01-09 Thread GitBox
galovics opened a new pull request, #2868: URL: https://github.com/apache/fineract/pull/2868 … JMS for remote jobs + the ability to disable remote jobs completely for non-batch instances ## Description Describe the changes made and why they were made. Ignore if these

[GitHub] [fineract] renovate-bot closed pull request #2862: chore(deps): update actions/upload-artifact digest to 0b7f8ab - autoclosed

2023-01-09 Thread GitBox
renovate-bot closed pull request #2862: chore(deps): update actions/upload-artifact digest to 0b7f8ab - autoclosed URL: https://github.com/apache/fineract/pull/2862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [fineract] galovics merged pull request #2865: chore(deps): bump actions/upload-artifact from 3.1.1 to 3.1.2

2023-01-09 Thread GitBox
galovics merged PR #2865: URL: https://github.com/apache/fineract/pull/2865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1064775626 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanTransactionChargebackTest.java: ## @@ -114,7 +116,7 @@ public void

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1064771698 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java: ## @@ -913,6 +913,15 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-09 Thread GitBox
adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1064756703 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanTransactionChargebackTest.java: ## @@ -114,7 +116,7 @@ public void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-09 Thread GitBox
adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1064749265 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java: ## @@ -913,6 +913,15 @@ public CommandWrapperBuilder

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2861: FINERACT-1785: Specified due date charges/fees cannot be applied on disbursement date

2023-01-09 Thread GitBox
adamsaghy commented on code in PR #2861: URL: https://github.com/apache/fineract/pull/2861#discussion_r1064743604 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleProcessingWrapper.java: ## @@ -142,6 +143,9 @@ private

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-09 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1064625539 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientLoanCreditBalanceRefundandRepaymentTypeIntegrationTest.java: ## @@

[GitHub] [fineract] b0c1 opened a new pull request, #2867: FINERACT-1734 - Loan Account Delinquency Changed event definition fix

2023-01-09 Thread GitBox
b0c1 opened a new pull request, #2867: URL: https://github.com/apache/fineract/pull/2867 FINERACT-1734 - Loan Account Delinquency Changed event definition fix [x] Fix Charge data because not fetched the content ## Description Describe the changes made and why they were made.

[GitHub] [fineract] taskain7 opened a new pull request, #2866: [FINERACT-1842] Wrong entityId is returned upon disbursing a loan

2023-01-09 Thread GitBox
taskain7 opened a new pull request, #2866: URL: https://github.com/apache/fineract/pull/2866 ## Description entityId in the HTTP response is the Loan ID now. entityExternalId in the HTTP response is the Loan external ID now. subEntityId in the HTTP response is the Disbursement

[GitHub] [fineract] dependabot[bot] opened a new pull request, #2865: chore(deps): bump actions/upload-artifact from 3.1.1 to 3.1.2

2023-01-08 Thread GitBox
dependabot[bot] opened a new pull request, #2865: URL: https://github.com/apache/fineract/pull/2865 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.1 to 3.1.2. Release notes Sourced from

[GitHub] [fineract] renovate-bot opened a new pull request, #2864: chore(deps): update io.rest-assured:4.5.1 to v5 (major)

2023-01-08 Thread GitBox
renovate-bot opened a new pull request, #2864: URL: https://github.com/apache/fineract/pull/2864 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2863: chore(deps): update all non-major dependencies

2023-01-08 Thread GitBox
renovate-bot opened a new pull request, #2863: URL: https://github.com/apache/fineract/pull/2863 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2862: chore(deps): update actions/upload-artifact digest to 0b7f8ab

2023-01-08 Thread GitBox
renovate-bot opened a new pull request, #2862: URL: https://github.com/apache/fineract/pull/2862 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2861: Fix/waive loan charge with disbursement date

2023-01-07 Thread GitBox
josehernandezfintecheandomx opened a new pull request, #2861: URL: https://github.com/apache/fineract/pull/2861 ## Description When trying to apply specified due date fees on the date of the loan’s disbursement date, it won’t be effective.

[GitHub] [fineract] IOhacker merged pull request #2847: FINERACT-1846: Translate Flyway migrations to Liquibase for version 1…

2023-01-06 Thread GitBox
IOhacker merged PR #2847: URL: https://github.com/apache/fineract/pull/2847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] IOhacker commented on pull request #2847: FINERACT-1846: Translate Flyway migrations to Liquibase for version 1…

2023-01-06 Thread GitBox
IOhacker commented on PR #2847: URL: https://github.com/apache/fineract/pull/2847#issuecomment-1374087230 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fineract] IOhacker merged pull request #2857: FINERACT-1849: Fix to use notes in Savings Accounts

2023-01-06 Thread GitBox
IOhacker merged PR #2857: URL: https://github.com/apache/fineract/pull/2857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] IOhacker commented on pull request #2857: FINERACT-1849: Fix to use notes in Savings Accounts

2023-01-06 Thread GitBox
IOhacker commented on PR #2857: URL: https://github.com/apache/fineract/pull/2857#issuecomment-1374083502 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fineract] galovics merged pull request #2860: FINERACT-1724: Extended the event framework sinks to be ActiveMQ topics as well in addition to ActiveMQ queues

2023-01-06 Thread GitBox
galovics merged PR #2860: URL: https://github.com/apache/fineract/pull/2860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-06 Thread GitBox
adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1063438155 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientLoanCreditBalanceRefundandRepaymentTypeIntegrationTest.java: ## @@ -438,4 +439,76 @@

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-06 Thread GitBox
adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1063436939 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/BatchApiTest.java: ## @@ -1830,7 +1825,7 @@ public void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-06 Thread GitBox
adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1063436619 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/BatchApiTest.java: ## @@ -1808,19 +1806,16 @@ public void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-06 Thread GitBox
adamsaghy commented on code in PR #2852: URL: https://github.com/apache/fineract/pull/2852#discussion_r1063435445 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java: ## @@ -1063,9 +1063,10 @@

[GitHub] [fineract] taskain7 merged pull request #2856: FINERACT-1724: Swagger enhancements

2023-01-06 Thread GitBox
taskain7 merged PR #2856: URL: https://github.com/apache/fineract/pull/2856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on pull request #2852: FINERACT-1847: Removing Edit function from Goodwill Credit or Payout Refund or Merch…

2023-01-06 Thread GitBox
galovics commented on PR #2852: URL: https://github.com/apache/fineract/pull/2852#issuecomment-1373577096 @josehernandezfintecheandomx test is still failing ``` Test applyLoanTransactionChargeback() FAILED java.lang.AssertionError: 1 expectation failed. Expected

[GitHub] [fineract] galovics merged pull request #2854: FINERACT-1806: Charge-off API

2023-01-06 Thread GitBox
galovics merged PR #2854: URL: https://github.com/apache/fineract/pull/2854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics opened a new pull request, #2860: FINERACT-1724: Extended the event framework sinks to be ActiveMQ topics as well in addition to ActiveMQ queues

2023-01-06 Thread GitBox
galovics opened a new pull request, #2860: URL: https://github.com/apache/fineract/pull/2860 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2854: FINERACT-1806: Charge-off API

2023-01-06 Thread GitBox
adamsaghy commented on code in PR #2854: URL: https://github.com/apache/fineract/pull/2854#discussion_r1063302793 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java: ## @@ -2644,6 +2644,57 @@

[GitHub] [fineract] galovics merged pull request #2859: chore(deps): bump actions/setup-node from 3.5.1 to 3.6.0

2023-01-06 Thread GitBox
galovics merged PR #2859: URL: https://github.com/apache/fineract/pull/2859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2858: chore(deps): bump actions/checkout from 3.2.0 to 3.3.0

2023-01-06 Thread GitBox
galovics merged PR #2858: URL: https://github.com/apache/fineract/pull/2858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2854: FINERACT-1806: Charge-off API

2023-01-06 Thread GitBox
adamsaghy commented on code in PR #2854: URL: https://github.com/apache/fineract/pull/2854#discussion_r1063253027 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanAccountData.java: ## @@ -253,6 +253,7 @@ public class LoanAccountData {

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2854: FINERACT-1806: Charge-off API

2023-01-06 Thread GitBox
adamsaghy commented on code in PR #2854: URL: https://github.com/apache/fineract/pull/2854#discussion_r1063252189 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java: ## @@ -2644,6 +2644,57 @@

[GitHub] [fineract] galovics commented on a diff in pull request #2854: FINERACT-1806: Charge-off API

2023-01-06 Thread GitBox
galovics commented on code in PR #2854: URL: https://github.com/apache/fineract/pull/2854#discussion_r1063245470 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java: ## @@ -456,6 +460,8 @@ private String

[GitHub] [fineract-cn-mariadb] jakoguta opened a new pull request, #10: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #10: URL: https://github.com/apache/fineract-cn-mariadb/pull/10 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-template] jakoguta opened a new pull request, #14: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #14: URL: https://github.com/apache/fineract-cn-template/pull/14 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-payroll] jakoguta opened a new pull request, #19: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #19: URL: https://github.com/apache/fineract-cn-payroll/pull/19 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-mobile] jakoguta opened a new pull request, #197: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #197: URL: https://github.com/apache/fineract-cn-mobile/pull/197 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-demo-server] jakoguta opened a new pull request, #35: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #35: URL: https://github.com/apache/fineract-cn-demo-server/pull/35 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-accounting] jakoguta opened a new pull request, #24: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #24: URL: https://github.com/apache/fineract-cn-accounting/pull/24 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-fims-web-app] jakoguta opened a new pull request, #38: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #38: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/38 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-service-starter] jakoguta opened a new pull request, #13: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #13: URL: https://github.com/apache/fineract-cn-service-starter/pull/13 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from

[GitHub] [fineract-cn-default-setup] jakoguta opened a new pull request, #11: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #11: URL: https://github.com/apache/fineract-cn-default-setup/pull/11 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the

[GitHub] [fineract-cn-rhythm] jakoguta opened a new pull request, #20: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #20: URL: https://github.com/apache/fineract-cn-rhythm/pull/20 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the Apache

[GitHub] [fineract-cn-office] jakoguta opened a new pull request, #20: Remove Travis build status from README.md

2023-01-05 Thread GitBox
jakoguta opened a new pull request, #20: URL: https://github.com/apache/fineract-cn-office/pull/20 Due to the removal of the Travis build scripts from the project. The build status in the README.md is now misleading and needs to be removed. -- This is an automated message from the Apache

<    1   2   3   4   5   6   7   8   9   10   >