[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-12-02 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037908085 ## fineract-provider/src/main/java/org/apache/fineract/cob/api/LoanCOBCatchUpApiResource.java: ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract-cn-fims-web-app] dependabot[bot] opened a new pull request, #34: Bump decode-uri-component from 0.2.0 to 0.2.2

2022-12-02 Thread GitBox
dependabot[bot] opened a new pull request, #34: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/34 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from

[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #18: Bump decode-uri-component from 0.2.0 to 0.2.2

2022-12-01 Thread GitBox
sonarcloud[bot] commented on PR #18: URL: https://github.com/apache/fineract-cn-group-finance/pull/18#issuecomment-1334798614 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #18: Bump decode-uri-component from 0.2.0 to 0.2.2

2022-12-01 Thread GitBox
dependabot[bot] opened a new pull request, #18: URL: https://github.com/apache/fineract-cn-group-finance/pull/18 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from

[GitHub] [fineract] dependabot[bot] opened a new pull request, #2784: chore(deps): bump actions/setup-java from 3.6.0 to 3.7.0

2022-12-01 Thread GitBox
dependabot[bot] opened a new pull request, #2784: URL: https://github.com/apache/fineract/pull/2784 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.6.0 to 3.7.0. Release notes Sourced from

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2783: FINERACT-1760: Client and External Id

2022-12-01 Thread GitBox
josehernandezfintecheandomx opened a new pull request, #2783: URL: https://github.com/apache/fineract/pull/2783 ## Description The `externalId` of a client is unique, We have added an API to manage clients using the `externalId` We can to decide whether an externalId is not

[GitHub] [fineract] galovics merged pull request #2782: FINERACT-1760: Fix error handling for loan charge details

2022-12-01 Thread GitBox
galovics merged PR #2782: URL: https://github.com/apache/fineract/pull/2782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-12-01 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037483923 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -94,6 +99,20 @@ public CommandProcessingResult

[GitHub] [fineract] galovics closed pull request #2732: FINERACT-1734-Negative-balance-event

2022-12-01 Thread GitBox
galovics closed pull request #2732: FINERACT-1734-Negative-balance-event URL: https://github.com/apache/fineract/pull/2732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fineract] galovics commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-12-01 Thread GitBox
galovics commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1037387206 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -116,6 +135,12 @@ public void execute(List loanIds,

[GitHub] [fineract] adamsaghy opened a new pull request, #2782: FINERACT-1760: Fix error handling for loan charge details

2022-12-01 Thread GitBox
adamsaghy opened a new pull request, #2782: URL: https://github.com/apache/fineract/pull/2782 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] github-actions[bot] commented on pull request #2716: Add Collaboration Documentation

2022-11-30 Thread GitBox
github-actions[bot] commented on PR #2716: URL: https://github.com/apache/fineract/pull/2716#issuecomment-1332930346 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] galovics merged pull request #2770: [FINERACT-1678] Resilient manager instance

2022-11-30 Thread GitBox
galovics merged PR #2770: URL: https://github.com/apache/fineract/pull/2770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2780: FINERACT-1724: Minor cleanup

2022-11-30 Thread GitBox
galovics merged PR #2780: URL: https://github.com/apache/fineract/pull/2780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #2781: FINERACT-1760: Fix error handling

2022-11-30 Thread GitBox
adamsaghy merged PR #2781: URL: https://github.com/apache/fineract/pull/2781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy opened a new pull request, #2781: FINERACT-1760: Fix error handling

2022-11-30 Thread GitBox
adamsaghy opened a new pull request, #2781: URL: https://github.com/apache/fineract/pull/2781 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2772: FINERACT-1744

2022-11-30 Thread GitBox
galovics merged PR #2772: URL: https://github.com/apache/fineract/pull/2772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics opened a new pull request, #2780: FINERACT-1724: Minor cleanup

2022-11-30 Thread GitBox
galovics opened a new pull request, #2780: URL: https://github.com/apache/fineract/pull/2780 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2779: FINERACT-1724: Fixed fineract-client generation to handle non-require…

2022-11-29 Thread GitBox
galovics merged PR #2779: URL: https://github.com/apache/fineract/pull/2779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2778: [FINERACT-1678] Fix Inline COB execution

2022-11-29 Thread GitBox
galovics merged PR #2778: URL: https://github.com/apache/fineract/pull/2778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics opened a new pull request, #2779: FINERACT-1724: Fixed fineract-client generation to handle non-require…

2022-11-29 Thread GitBox
galovics opened a new pull request, #2779: URL: https://github.com/apache/fineract/pull/2779 …d request bodies in APIs ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2778: [FINERACT-1678] Fix Inline COB execution

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2778: URL: https://github.com/apache/fineract/pull/2778#discussion_r1034978343 ## fineract-provider/src/test/java/org/apache/fineract/cob/common/InitialisationTaskletStepDefinitions.java: ## @@ -48,23 +59,42 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2778: [FINERACT-1678] Fix Inline COB execution

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2778: URL: https://github.com/apache/fineract/pull/2778#discussion_r1034975382 ## fineract-provider/src/main/java/org/apache/fineract/cob/common/InitialisationTasklet.java: ## @@ -41,11 +47,18 @@ public class InitialisationTasklet implements

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2778: [FINERACT-1678] Fix Inline COB execution

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2778: URL: https://github.com/apache/fineract/pull/2778#discussion_r1034968902 ## fineract-provider/src/test/java/org/apache/fineract/cob/common/InitialisationTaskletStepDefinitions.java: ## @@ -48,11 +59,22 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2778: [FINERACT-1678] Fix Inline COB execution

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2778: URL: https://github.com/apache/fineract/pull/2778#discussion_r1034968902 ## fineract-provider/src/test/java/org/apache/fineract/cob/common/InitialisationTaskletStepDefinitions.java: ## @@ -48,11 +59,22 @@ public

[GitHub] [fineract-site] vidakovic closed pull request #27: 1.7.0 -> 1.7.1

2022-11-29 Thread GitBox
vidakovic closed pull request #27: 1.7.0 -> 1.7.1 URL: https://github.com/apache/fineract-site/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-site] vidakovic merged pull request #26: Update some links to https

2022-11-29 Thread GitBox
vidakovic merged PR #26: URL: https://github.com/apache/fineract-site/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-site] vidakovic commented on pull request #27: 1.7.0 -> 1.7.1

2022-11-29 Thread GitBox
vidakovic commented on PR #27: URL: https://github.com/apache/fineract-site/pull/27#issuecomment-1330843724 @raboof thanks Arnout... you read my mind :+1:, fixed it already. Closing this (I had also other changes). -- This is an automated message from the Apache Git Service. To respond

[GitHub] [fineract] taskain7 opened a new pull request, #2778: [FINERACT-1678] Fix Inline COB execution

2022-11-29 Thread GitBox
taskain7 opened a new pull request, #2778: URL: https://github.com/apache/fineract/pull/2778 ## Description Fixing the Inline Loan COB execution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1034877184 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/InlineLoanCOBBuildExecutionContextTasklet.java: ## @@ -37,30 +41,41 @@ import

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1034872675 ## fineract-provider/src/main/java/org/apache/fineract/cob/common/InitialisationTasklet.java: ## @@ -41,11 +47,17 @@ public class InitialisationTasklet implements

[GitHub] [fineract] taskain7 commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-11-29 Thread GitBox
taskain7 commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1034856658 ## fineract-provider/src/main/java/org/apache/fineract/cob/data/OldestCOBProcessedLoanDTO.java: ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1034856058 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/InlineLoanCOBBuildExecutionContextTasklet.java: ## @@ -37,30 +41,40 @@ import

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1034855249 ## fineract-provider/src/main/java/org/apache/fineract/cob/data/OldestCOBProcessedLoanDTO.java: ## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2777: [FINERACT-1678] Loan COB Catch Up

2022-11-29 Thread GitBox
adamsaghy commented on code in PR #2777: URL: https://github.com/apache/fineract/pull/2777#discussion_r1034853850 ## fineract-provider/src/main/java/org/apache/fineract/cob/common/InitialisationTasklet.java: ## @@ -41,11 +47,16 @@ public class InitialisationTasklet implements

[GitHub] [fineract] taskain7 opened a new pull request, #2777: [FINERACT-1678] Loan COB Catch Up

2022-11-29 Thread GitBox
taskain7 opened a new pull request, #2777: URL: https://github.com/apache/fineract/pull/2777 ## Description - API that retrieves the oldest processed Loan, date and the current business date - API that for Loan COB catch up, COB will run on every old processed loan until the

[GitHub] [fineract] galovics merged pull request #2775: FINERACT-1760-Link-Transaction-Reverse-Replay

2022-11-29 Thread GitBox
galovics merged PR #2775: URL: https://github.com/apache/fineract/pull/2775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] b0c1 commented on a diff in pull request #2772: FINERACT-1744

2022-11-29 Thread GitBox
b0c1 commented on code in PR #2772: URL: https://github.com/apache/fineract/pull/2772#discussion_r1034721246 ## fineract-provider/src/main/java/org/apache/fineract/commands/jobs/PurgeProcessedCommandsConfig.java: ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] galovics merged pull request #2776: [FINERACT-1678] Fix Job API with empty request body

2022-11-29 Thread GitBox
galovics merged PR #2776: URL: https://github.com/apache/fineract/pull/2776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] taskain7 opened a new pull request, #2776: [FINERACT-1678] Fix Job API with empty request body

2022-11-29 Thread GitBox
taskain7 opened a new pull request, #2776: URL: https://github.com/apache/fineract/pull/2776 ## Description Fix Job API with empty request body -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [fineract] galovics merged pull request #2763: FINERACT-1734-Repayment-Due-Events-Payload-Extension

2022-11-29 Thread GitBox
galovics merged PR #2763: URL: https://github.com/apache/fineract/pull/2763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2774: FINERACT-1760: Raise transaction replayed business event

2022-11-29 Thread GitBox
galovics merged PR #2774: URL: https://github.com/apache/fineract/pull/2774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-site] IOhacker merged pull request #25: Add notice about demo server availability and Apache Fineract versions

2022-11-28 Thread GitBox
IOhacker merged PR #25: URL: https://github.com/apache/fineract-site/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-site] IOhacker opened a new pull request, #25: Add notice about demo server availability and Apache Fineract versions

2022-11-28 Thread GitBox
IOhacker opened a new pull request, #25: URL: https://github.com/apache/fineract-site/pull/25 Add notice about demo server availability and Apache Fineract versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [fineract] ruchiD opened a new pull request, #2775: FINERACT-1760-Link-Transaction-Reverse-Replay

2022-11-28 Thread GitBox
ruchiD opened a new pull request, #2775: URL: https://github.com/apache/fineract/pull/2775 ## Description 1.Added new transaction relationship for reverse and replay scenario. 2.Linking New transaction and reversed transaction with Replayed relationship with New transaction id

[GitHub] [fineract] galovics merged pull request #2766: chore(deps): update all non-major dependencies

2022-11-28 Thread GitBox
galovics merged PR #2766: URL: https://github.com/apache/fineract/pull/2766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy opened a new pull request, #2774: FINERACT-1760: Raise transaction replayed business event

2022-11-28 Thread GitBox
adamsaghy opened a new pull request, #2774: URL: https://github.com/apache/fineract/pull/2774 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy merged pull request #2773: FINERACT-1822: Fix Undo waive loan charge API response inconsistency

2022-11-28 Thread GitBox
adamsaghy merged PR #2773: URL: https://github.com/apache/fineract/pull/2773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] forking-renovate[bot] commented on pull request #2766: chore(deps): update all non-major dependencies

2022-11-28 Thread GitBox
forking-renovate[bot] commented on PR #2766: URL: https://github.com/apache/fineract/pull/2766#issuecomment-1329607028 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may

[GitHub] [fineract] galovics commented on pull request #2768: FINERACT-1821 Postgresql Support for Tellers ->Cashiers->Transactions

2022-11-28 Thread GitBox
galovics commented on PR #2768: URL: https://github.com/apache/fineract/pull/2768#issuecomment-1329602218 > @galovics I will, I have found more TIME and DATE_ADD functions in the code related to Teller/Cashiers classes, seems that this functionality was not fully tested with Postgresql as

[GitHub] [fineract] galovics merged pull request #2754: FINERACT-1706: Fix Delinquency Classification for scenario

2022-11-28 Thread GitBox
galovics merged PR #2754: URL: https://github.com/apache/fineract/pull/2754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2772: FINERACT-1744

2022-11-28 Thread GitBox
galovics commented on code in PR #2772: URL: https://github.com/apache/fineract/pull/2772#discussion_r1033904528 ## fineract-provider/src/main/java/org/apache/fineract/commands/jobs/PurgeProcessedCommandsConfig.java: ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy opened a new pull request, #2773: FINERACT-1822: Fix Undo waive loan charge API response inconsistency

2022-11-28 Thread GitBox
adamsaghy opened a new pull request, #2773: URL: https://github.com/apache/fineract/pull/2773 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] b0c1 opened a new pull request, #2772: FINERACT-1744

2022-11-28 Thread GitBox
b0c1 opened a new pull request, #2772: URL: https://github.com/apache/fineract/pull/2772 FINERACT-1744 - [x] Purge Processed Commands Jobs - [x] Refactor CommandProcessingResultType to CommandProcessingStatus ## Description Describe the changes made and why they were

[GitHub] [fineract] galovics merged pull request #2767: fix(deps): update non-major

2022-11-28 Thread GitBox
galovics merged PR #2767: URL: https://github.com/apache/fineract/pull/2767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-site] IOhacker merged pull request #24: Fix url and index extension

2022-11-28 Thread GitBox
IOhacker merged PR #24: URL: https://github.com/apache/fineract-site/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-site] vidakovic merged pull request #23: FINERACT-1820: Update for Authentication in Legacy Docs

2022-11-28 Thread GitBox
vidakovic merged PR #23: URL: https://github.com/apache/fineract-site/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2759: FINERACT-1678: Introducing Last COB Business Date for loans

2022-11-28 Thread GitBox
galovics merged PR #2759: URL: https://github.com/apache/fineract/pull/2759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2771: FINERACT-1724

2022-11-28 Thread GitBox
galovics merged PR #2771: URL: https://github.com/apache/fineract/pull/2771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2771: FINERACT-1724

2022-11-28 Thread GitBox
galovics commented on code in PR #2771: URL: https://github.com/apache/fineract/pull/2771#discussion_r1033609855 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java: ## @@ -2119,6 +2119,10 @@ public

[GitHub] [fineract] forking-renovate[bot] commented on pull request #2767: fix(deps): update non-major

2022-11-28 Thread GitBox
forking-renovate[bot] commented on PR #2767: URL: https://github.com/apache/fineract/pull/2767#issuecomment-1329162595 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may

[GitHub] [fineract] IOhacker commented on pull request #2768: FINERACT-1821 Postgresql Support for Tellers ->Cashiers->Transactions

2022-11-28 Thread GitBox
IOhacker commented on PR #2768: URL: https://github.com/apache/fineract/pull/2768#issuecomment-1329106870 @galovics I will, I have found more TIME and DATE_ADD functions in the code related to Teller/Cashiers classes, seems that this functionality was not fully tested with Postgresql as

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2753: FINERACT-1816: Create client with datatable subentity type

2022-11-28 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2753: URL: https://github.com/apache/fineract/pull/2753#discussion_r1033519637 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientTest.java: ## @@ -263,4 +282,51 @@ public void

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2753: FINERACT-1816: Create client with datatable subentity type

2022-11-28 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2753: URL: https://github.com/apache/fineract/pull/2753#discussion_r1033519398 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientTest.java: ## @@ -263,4 +282,51 @@ public void

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2753: FINERACT-1816: Create client with datatable subentity type

2022-11-28 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2753: URL: https://github.com/apache/fineract/pull/2753#discussion_r1033519115 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientTest.java: ## @@ -263,4 +282,51 @@ public void

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2753: FINERACT-1816: Create client with datatable subentity type

2022-11-28 Thread GitBox
josehernandezfintecheandomx commented on code in PR #2753: URL: https://github.com/apache/fineract/pull/2753#discussion_r1033517991 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientTest.java: ## @@ -263,4 +282,51 @@ public void

[GitHub] [fineract] b0c1 commented on a diff in pull request #2771: FINERACT-1724

2022-11-28 Thread GitBox
b0c1 commented on code in PR #2771: URL: https://github.com/apache/fineract/pull/2771#discussion_r1033516577 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java: ## @@ -2119,6 +2119,10 @@ public

[GitHub] [fineract] galovics commented on a diff in pull request #2771: FINERACT-1724

2022-11-28 Thread GitBox
galovics commented on code in PR #2771: URL: https://github.com/apache/fineract/pull/2771#discussion_r1033478517 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java: ## @@ -2119,6 +2119,10 @@ public

[GitHub] [fineract] galovics commented on a diff in pull request #2753: FINERACT-1816: Create client with datatable subentity type

2022-11-28 Thread GitBox
galovics commented on code in PR #2753: URL: https://github.com/apache/fineract/pull/2753#discussion_r1033407082 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientTest.java: ## @@ -263,4 +282,51 @@ public void

[GitHub] [fineract] galovics merged pull request #2756: FINERACT-1744 - Idempotency support

2022-11-28 Thread GitBox
galovics merged PR #2756: URL: https://github.com/apache/fineract/pull/2756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2769: FINERACT-1760: Enhanced external id support for loan charges

2022-11-28 Thread GitBox
galovics merged PR #2769: URL: https://github.com/apache/fineract/pull/2769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] b0c1 opened a new pull request, #2771: FINERACT-1724

2022-11-28 Thread GitBox
b0c1 opened a new pull request, #2771: URL: https://github.com/apache/fineract/pull/2771 FINERACT-1724 - [x] eliminate sonar security hotspots - [x] eliminate sonar bugs ## Description Describe the changes made and why they were made. Ignore if these details are

[GitHub] [fineract] taskain7 opened a new pull request, #2770: [FINERACT-1678] Resilient manager instance

2022-11-28 Thread GitBox
taskain7 opened a new pull request, #2770: URL: https://github.com/apache/fineract/pull/2770 ## Description Handling the case when Batch Manager instance fails during Batch Worker isntances are processing the job execution. -- This is an automated message from the Apache Git

[GitHub] [fineract] adamsaghy opened a new pull request, #2769: FINERACT-1760: Enhanced external id support for loan charges

2022-11-28 Thread GitBox
adamsaghy opened a new pull request, #2769: URL: https://github.com/apache/fineract/pull/2769 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] IOhacker opened a new pull request, #2768: FINERACT-1821 Postgresql Support for Tellers ->Cashiers->Transactions

2022-11-27 Thread GitBox
IOhacker opened a new pull request, #2768: URL: https://github.com/apache/fineract/pull/2768 ## Description Postgresql now is supported for getting the Tellers ->Cashiers->Transactions ## Checklist Please make sure these boxes are checked before submitting your pull

[GitHub] [fineract] renovate-bot opened a new pull request, #2767: fix(deps): update non-major

2022-11-27 Thread GitBox
renovate-bot opened a new pull request, #2767: URL: https://github.com/apache/fineract/pull/2767 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2766: chore(deps): update all non-major dependencies

2022-11-27 Thread GitBox
renovate-bot opened a new pull request, #2766: URL: https://github.com/apache/fineract/pull/2766 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age |

[GitHub] [fineract] taskain7 commented on a diff in pull request #2759: FINERACT-1678: Introducing Last COB Business Date for loans

2022-11-27 Thread GitBox
taskain7 commented on code in PR #2759: URL: https://github.com/apache/fineract/pull/2759#discussion_r1033044966 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/AbstractLoanItemProcessor.java: ## @@ -40,17 +42,25 @@ public abstract class

[GitHub] [fineract-site] IOhacker commented on pull request #23: FINERACT-1820: Update for Authentication in Legacy Docs

2022-11-27 Thread GitBox
IOhacker commented on PR #23: URL: https://github.com/apache/fineract-site/pull/23#issuecomment-1328345333 Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fineract-site] vidakovic commented on pull request #23: FINERACT-1820: Update for Authentication in Legacy Docs

2022-11-27 Thread GitBox
vidakovic commented on PR #23: URL: https://github.com/apache/fineract-site/pull/23#issuecomment-1328324162 How about putting them under "/docs/legacy" and renaming the file to "index.html"... then people don't have to remember that name and we can distribute a clean URL... and we have

[GitHub] [fineract] galovics merged pull request #2765: FINERACT-1820: Update for Authentication in Legacy Docs

2022-11-27 Thread GitBox
galovics merged PR #2765: URL: https://github.com/apache/fineract/pull/2765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] b0c1 commented on a diff in pull request #2756: FINERACT-1744 - Idempotency support

2022-11-26 Thread GitBox
b0c1 commented on code in PR #2756: URL: https://github.com/apache/fineract/pull/2756#discussion_r1032877064 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exceptionmapper/DuplicateCommandExceptionMapper.java: ## @@ -0,0 +1,41 @@ +/** + * Licensed to

[GitHub] [fineract] IOhacker opened a new pull request, #2765: FINERACT-1820: Update for Authentication in Legacy Docs

2022-11-26 Thread GitBox
IOhacker opened a new pull request, #2765: URL: https://github.com/apache/fineract/pull/2765 ## Description Update for Authentication in Legacy Docs ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [X]

[GitHub] [fineract-site] IOhacker opened a new pull request, #23: Add legacy documentation

2022-11-26 Thread GitBox
IOhacker opened a new pull request, #23: URL: https://github.com/apache/fineract-site/pull/23 Add legacy documentation for matching the URLs in the Fineract Source Code/Swagger -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] adamsaghy merged pull request #2764: FINERACT-1760: Enhanced external id support for loan transactions

2022-11-26 Thread GitBox
adamsaghy merged PR #2764: URL: https://github.com/apache/fineract/pull/2764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2763: FINERACT-1734-Repayment-Due-Events-Payload-Extension

2022-11-26 Thread GitBox
galovics commented on code in PR #2763: URL: https://github.com/apache/fineract/pull/2763#discussion_r1032763735 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanRepaymentBusinessEventSerializer.java:

[GitHub] [fineract] adamsaghy opened a new pull request, #2764: FINERACT-1760: Enhanced external id support for loan transactions

2022-11-26 Thread GitBox
adamsaghy opened a new pull request, #2764: URL: https://github.com/apache/fineract/pull/2764 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics commented on pull request #2754: FINERACT-1706: Fix Delinquency Classification for scenario

2022-11-26 Thread GitBox
galovics commented on PR #2754: URL: https://github.com/apache/fineract/pull/2754#issuecomment-1328013367 @josehernandezfintecheandomx Nope. There was a test. It's been passing for the original implementation. You changed the implementation yet the test didn't break, meaning that the test

[GitHub] [fineract] galovics commented on a diff in pull request #2756: FINERACT-1744 - Idempotency support

2022-11-26 Thread GitBox
galovics commented on code in PR #2756: URL: https://github.com/apache/fineract/pull/2756#discussion_r1032762861 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/AbstractIdempotentCommandException.java: ## @@ -0,0 +1,45 @@ +/** + * Licensed

[GitHub] [fineract] ruchiD opened a new pull request, #2763: FINERACT-1734-Repayment-Due-Events-Payload-Extension

2022-11-25 Thread GitBox
ruchiD opened a new pull request, #2763: URL: https://github.com/apache/fineract/pull/2763 ## Description Extended Loan Repayment due and overdue events payload data. Describe the changes made and why they were made. Ignore if these details are present on the associated

[GitHub] [fineract] galovics commented on a diff in pull request #2756: FINERACT-1744 - Idempotency support

2022-11-25 Thread GitBox
galovics commented on code in PR #2756: URL: https://github.com/apache/fineract/pull/2756#discussion_r1030613828 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -64,83 +67,70 @@ public class

[GitHub] [fineract] galovics commented on a diff in pull request #2759: FINERACT-1678: Introducing Last COB Business Date for loans

2022-11-25 Thread GitBox
galovics commented on code in PR #2759: URL: https://github.com/apache/fineract/pull/2759#discussion_r1032212242 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/AbstractLoanItemProcessor.java: ## @@ -40,17 +42,25 @@ public abstract class

[GitHub] [fineract] galovics merged pull request #2762: FINERACT-1724 - sonar security hotspot fix

2022-11-25 Thread GitBox
galovics merged PR #2762: URL: https://github.com/apache/fineract/pull/2762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] taskain7 commented on a diff in pull request #2759: FINERACT-1678: Introducing Last COB Business Date for loans

2022-11-24 Thread GitBox
taskain7 commented on code in PR #2759: URL: https://github.com/apache/fineract/pull/2759#discussion_r1031970636 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/jobparameterprovider/LoanCOBJobParameterProviderImpl.java: ## @@ -0,0 +1,82 @@

[GitHub] [fineract] b0c1 opened a new pull request, #2762: FINERACT-1724

2022-11-24 Thread GitBox
b0c1 opened a new pull request, #2762: URL: https://github.com/apache/fineract/pull/2762 FINERACT-1724 - [x] eliminate sonar security hotspots ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated

[GitHub] [fineract] adamsaghy merged pull request #2758: FINERACT-1760: Enhanced external id support for loan transactions

2022-11-24 Thread GitBox
adamsaghy merged PR #2758: URL: https://github.com/apache/fineract/pull/2758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #2760: FINERACT-1819: Fix for GL entries for Credit Balance Refund transaction

2022-11-24 Thread GitBox
adamsaghy merged PR #2760: URL: https://github.com/apache/fineract/pull/2760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2758: FINERACT-1760: Enhanced external id support for loan transactions

2022-11-24 Thread GitBox
adamsaghy commented on code in PR #2758: URL: https://github.com/apache/fineract/pull/2758#discussion_r1031775599 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java: ## @@ -193,9 +177,9 @@

[GitHub] [fineract] galovics commented on a diff in pull request #2758: FINERACT-1760: Enhanced external id support for loan transactions

2022-11-24 Thread GitBox
galovics commented on code in PR #2758: URL: https://github.com/apache/fineract/pull/2758#discussion_r1031771133 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/AccountTransfersWritePlatformServiceImpl.java: ## @@ -541,8 +539,10 @@ public

[GitHub] [fineract] galovics merged pull request #2757: FINERACT-1724: Batch API support for Loan chargeback and fineract cli…

2022-11-24 Thread GitBox
galovics merged PR #2757: URL: https://github.com/apache/fineract/pull/2757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    2   3   4   5   6   7   8   9   10   11   >