[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2760: FINERACT-1819: Fix for GL entries for Credit Balance Refund transaction

josehernandezfintecheandomx commented on code in PR #2760: URL: https://github.com/apache/fineract/pull/2760#discussion_r1031681488 ## fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java: ## @@ -569,8

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2758: FINERACT-1760: Enhanced external id support for loan transactions

adamsaghy commented on code in PR #2758: URL: https://github.com/apache/fineract/pull/2758#discussion_r1031662312 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/ExternalId.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2758: FINERACT-1760: Enhanced external id support for loan transactions

adamsaghy commented on code in PR #2758: URL: https://github.com/apache/fineract/pull/2758#discussion_r1031662120 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/ExternalId.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] galovics commented on a diff in pull request #2759: FINERACT-1678: Introducing Last COB Business Date for loans

galovics commented on code in PR #2759: URL: https://github.com/apache/fineract/pull/2759#discussion_r1031629950 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/JobStarter.java: ## @@ -45,14 +50,19 @@ public class JobStarter { private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2760: FINERACT-1819: Fix for GL entries for Credit Balance Refund transaction

adamsaghy commented on code in PR #2760: URL: https://github.com/apache/fineract/pull/2760#discussion_r1031632171 ## fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java: ## @@ -569,8 +569,8 @@ private

[GitHub] [fineract] galovics merged pull request #2750: FINERACT-1815: Fix datatable put call with resource id

galovics merged PR #2750: URL: https://github.com/apache/fineract/pull/2750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2758: FINERACT-1760: Enhanced external id support for loan transactions

adamsaghy commented on code in PR #2758: URL: https://github.com/apache/fineract/pull/2758#discussion_r1031582421 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformService.java: ## @@ -155,4 +156,7 @@ LoanScheduleData

[GitHub] [fineract] galovics commented on a diff in pull request #2758: FINERACT-1760: Enhanced external id support for loan transactions

galovics commented on code in PR #2758: URL: https://github.com/apache/fineract/pull/2758#discussion_r1031431071 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/ExternalId.java: ## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] galovics merged pull request #2761: FINERACT-1678--Extending-jobs-with-module-system-documentation

galovics merged PR #2761: URL: https://github.com/apache/fineract/pull/2761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2761: FINERACT-1678--Extending-jobs-with-module-system-documentation

ruchiD opened a new pull request, #2761: URL: https://github.com/apache/fineract/pull/2761 ## Description Ascii doc documentation for custom job module. Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2760: Fix for GL entries for Credit Balance Refund transaction

josehernandezfintecheandomx opened a new pull request, #2760: URL: https://github.com/apache/fineract/pull/2760 ## Description Currently In Fineract 'credit balance refund' transaction is posting wrong GL entries. In resume they GL accounts used are inverted Ignore if these

[GitHub] [fineract] taskain7 opened a new pull request, #2759: [FINERACT-1678] Introducing `Last COB Business Date` for loans

taskain7 opened a new pull request, #2759: URL: https://github.com/apache/fineract/pull/2759 ## Description Loans store the last date when the Loan COB job was done on it. Custom parameters can be added for job execution via API. -- This is an automated message from the

[GitHub] [fineract] adamsaghy opened a new pull request, #2758: FINERACT-1760: Enhanced external id support for loan transactions

adamsaghy opened a new pull request, #2758: URL: https://github.com/apache/fineract/pull/2758 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] github-actions[bot] commented on pull request #2644: Add customer documentation for read/write/batch API operation performance enhancing separation

github-actions[bot] commented on PR #2644: URL: https://github.com/apache/fineract/pull/2644#issuecomment-1325793927 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2648: Refine documentation for tuning and indexing to optimize performance based on PostgreSQL and Eclipselink enhancements.

github-actions[bot] commented on PR #2648: URL: https://github.com/apache/fineract/pull/2648#issuecomment-1325793910 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] vidakovic commented on pull request #2732: FINERACT-1734-Negative-balance-event

vidakovic commented on PR #2732: URL: https://github.com/apache/fineract/pull/2732#issuecomment-1325564573 @ruchiD @galovics ... what's the status of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [fineract] vidakovic merged pull request #2752: FINERACT-1794: Address improvement in file upload APIs

vidakovic merged PR #2752: URL: https://github.com/apache/fineract/pull/2752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #2750: FINERACT-1815: Fix datatable put call with resource id

josehernandezfintecheandomx commented on PR #2750: URL: https://github.com/apache/fineract/pull/2750#issuecomment-1325230641 > @josehernandezfintecheandomx can you pls change the commit message & PR title to have a Fineract ticket in it? Thanks. @galovics Title updated -- This is

[GitHub] [fineract] galovics opened a new pull request, #2757: FINERACT-1724: Batch API support for Loan chargeback and fineract cli…

galovics opened a new pull request, #2757: URL: https://github.com/apache/fineract/pull/2757 …ent adjustments ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2755: FINERACT-1678-Extending-jobs-with-module-system

galovics merged PR #2755: URL: https://github.com/apache/fineract/pull/2755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] vidakovic commented on a diff in pull request #2752: FINERACT-1794: Address improvement in file upload APIs

vidakovic commented on code in PR #2752: URL: https://github.com/apache/fineract/pull/2752#discussion_r1030519369 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/FileSystemContentPathSanitizer.java: ## @@ -0,0 +1,138 @@

[GitHub] [fineract] vidakovic commented on a diff in pull request #2752: FINERACT-1794: Address improvement in file upload APIs

vidakovic commented on code in PR #2752: URL: https://github.com/apache/fineract/pull/2752#discussion_r1030500916 ## fineract-provider/src/main/resources/application.properties: ## @@ -70,6 +70,17 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on pull request #2754: FINERACT-1706: Fix Delinquency Classification for scenario

josehernandezfintecheandomx commented on PR #2754: URL: https://github.com/apache/fineract/pull/2754#issuecomment-1325033147 > No tests to cover this functional change. Please add them. The IT already there is in the DelinquencyAndChargebackIntegrationTest even the test has comment

[GitHub] [fineract] galovics commented on pull request #2750: Fix datatable put call with resource id

galovics commented on PR #2750: URL: https://github.com/apache/fineract/pull/2750#issuecomment-1324987542 @josehernandezfintecheandomx can you pls change the commit message & PR title to have a Fineract ticket in it? Thanks. -- This is an automated message from the Apache Git Service. To

[GitHub] [fineract] galovics commented on pull request #2753: Create client with datatable subentity type

galovics commented on PR #2753: URL: https://github.com/apache/fineract/pull/2753#issuecomment-1324987262 @josehernandezfintecheandomx can you pls change the commit message & PR title to have a Fineract ticket in it? Thanks. -- This is an automated message from the Apache Git Service. To

[GitHub] [fineract] b0c1 opened a new pull request, #2756: FINERACT-1744 - Idempotency support

b0c1 opened a new pull request, #2756: URL: https://github.com/apache/fineract/pull/2756 ## Description FINERACT-1744 - Idempotency support - [x] Idempotency write move to filters - [x] Idempotency integration test with success and failure - [x] Added response status code to

[GitHub] [fineract] galovics commented on a diff in pull request #2752: FINERACT-1794: Address improvement in file upload APIs

galovics commented on code in PR #2752: URL: https://github.com/apache/fineract/pull/2752#discussion_r1030375861 ## fineract-provider/src/test/resources/application-test.properties: ## @@ -60,6 +60,16 @@

[GitHub] [fineract] galovics merged pull request #2751: FINERACT-1724: Minor cleanup around client transaction services

galovics merged PR #2751: URL: https://github.com/apache/fineract/pull/2751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2755: FINERACT-1678-Extending-jobs-with-module-system

ruchiD opened a new pull request, #2755: URL: https://github.com/apache/fineract/pull/2755 ## Description 1.Created new job using module system in fineract->custom->acme->loan->job module 2.Created Job configuration,Job Step and tasklet 3.Created Liquibase change log to add job

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2754: FINERACT-1706: Fix Delinquency Classification for scenario

josehernandezfintecheandomx opened a new pull request, #2754: URL: https://github.com/apache/fineract/pull/2754 ## Description Fix Delinquency Classification for scenario Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] github-actions[bot] commented on pull request #2671: FINERACT-1775: Introduce Lombok to monetary module

github-actions[bot] commented on PR #2671: URL: https://github.com/apache/fineract/pull/2671#issuecomment-1324392642 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #17: Bump engine.io and karma

sonarcloud[bot] commented on PR #17: URL: https://github.com/apache/fineract-cn-group-finance/pull/17#issuecomment-1323858721 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #17: Bump engine.io and karma

dependabot[bot] opened a new pull request, #17: URL: https://github.com/apache/fineract-cn-group-finance/pull/17 Bumps [engine.io](https://github.com/socketio/engine.io) to 6.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be

[GitHub] [fineract-cn-fims-web-app] dependabot[bot] opened a new pull request, #33: Bump engine.io and karma

dependabot[bot] opened a new pull request, #33: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/33 Bumps [engine.io](https://github.com/socketio/engine.io) to 6.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies need to be

[GitHub] [fineract-cn-rhythm] fynmanoj closed pull request #19: Remove Eureka Client Side Load Balancing

fynmanoj closed pull request #19: Remove Eureka Client Side Load Balancing URL: https://github.com/apache/fineract-cn-rhythm/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [fineract-cn-portfolio] fynmanoj closed pull request #23: Removed Eureka Client Side Load balancing

fynmanoj closed pull request #23: Removed Eureka Client Side Load balancing URL: https://github.com/apache/fineract-cn-portfolio/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [fineract-cn-group] fynmanoj merged pull request #17: Removed Eureka Client Side Load Balancing

fynmanoj merged PR #17: URL: https://github.com/apache/fineract-cn-group/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-cn-notifications] fynmanoj merged pull request #23: Removed Eureka Client Side Load Balancing

fynmanoj merged PR #23: URL: https://github.com/apache/fineract-cn-notifications/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-cn-cheques] fynmanoj merged pull request #13: Remove Client Side Load Balancer

fynmanoj merged PR #13: URL: https://github.com/apache/fineract-cn-cheques/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-cn-accounting] fynmanoj merged pull request #23: Remove Client Side Load Balancer

fynmanoj merged PR #23: URL: https://github.com/apache/fineract-cn-accounting/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2750: Fix datatable put call with resource id

josehernandezfintecheandomx commented on code in PR #2750: URL: https://github.com/apache/fineract/pull/2750#discussion_r1028893426 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1415,14

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2753: Create client with datatable subentity type

josehernandezfintecheandomx opened a new pull request, #2753: URL: https://github.com/apache/fineract/pull/2753 ## Description Make difference for datatables between PERSON and ENTITY upon client creation Ignore if these details are present on the associated [Apache Fineract

[GitHub] [fineract] vidakovic opened a new pull request, #2752: FINERACT-1794: Address improvement in file upload APIs

vidakovic opened a new pull request, #2752: URL: https://github.com/apache/fineract/pull/2752 More rigours file validation to be introduces when file is uploaded to fineract. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2750: Fix datatable put call with resource id

adamsaghy commented on code in PR #2750: URL: https://github.com/apache/fineract/pull/2750#discussion_r1028458912 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1415,14 +1415,22 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2750: Fix datatable put call with resource id

adamsaghy commented on code in PR #2750: URL: https://github.com/apache/fineract/pull/2750#discussion_r1028443041 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1415,14 +1415,22 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2750: Fix datatable put call with resource id

adamsaghy commented on code in PR #2750: URL: https://github.com/apache/fineract/pull/2750#discussion_r1028443041 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1415,14 +1415,22 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2750: Fix datatable put call with resource id

adamsaghy commented on code in PR #2750: URL: https://github.com/apache/fineract/pull/2750#discussion_r1028443041 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1415,14 +1415,22 @@ private

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2750: Fix datatable put call with resource id

josehernandezfintecheandomx commented on code in PR #2750: URL: https://github.com/apache/fineract/pull/2750#discussion_r1028442715 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1415,14

[GitHub] [fineract] galovics opened a new pull request, #2751: FINERACT-1724: Minor cleanup around client transaction services

galovics opened a new pull request, #2751: URL: https://github.com/apache/fineract/pull/2751 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2747: FINERACT-1724 - Thitsa Works integration refactoring

galovics merged PR #2747: URL: https://github.com/apache/fineract/pull/2747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy merged pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy merged PR #2739: URL: https://github.com/apache/fineract/pull/2739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2750: Fix datatable put call with resource id

galovics commented on code in PR #2750: URL: https://github.com/apache/fineract/pull/2750#discussion_r1027950095 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java: ## @@ -1415,14 +1415,22 @@ private

[GitHub] [fineract] ezolnbl-dpc closed pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc closed pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling URL: https://github.com/apache/fineract/pull/2718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2750: Fix datatable put call with resource id

josehernandezfintecheandomx opened a new pull request, #2750: URL: https://github.com/apache/fineract/pull/2750 ## Description Update Datatable One to Many Entry `PUT` for: `resource_id` field in response is populated with `datatableEntryId` Ignore if these details are

[GitHub] [fineract] github-actions[bot] commented on pull request #2666: FINERACT-1778: Introduce Lombok to staff module

github-actions[bot] commented on PR #2666: URL: https://github.com/apache/fineract/pull/2666#issuecomment-1320689650 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] vidakovic merged pull request #2749: FINERACT-1807: Extension point - data service

vidakovic merged PR #2749: URL: https://github.com/apache/fineract/pull/2749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] vidakovic commented on a diff in pull request #2749: FINERACT-1807: Extension point - data service

vidakovic commented on code in PR #2749: URL: https://github.com/apache/fineract/pull/2749#discussion_r1026628141 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/starter/DataQueriesAutoConfiguration.java: ## @@ -0,0 +1,56 @@ +/** + * Licensed

[GitHub] [fineract] galovics commented on a diff in pull request #2749: FINERACT-1807: Extension point - data service

galovics commented on code in PR #2749: URL: https://github.com/apache/fineract/pull/2749#discussion_r1026625483 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/starter/DataQueriesAutoConfiguration.java: ## @@ -0,0 +1,56 @@ +/** + * Licensed to

[GitHub] [fineract] galovics merged pull request #2748: FINERACT-1724: Swagger fix for loan transaction API

galovics merged PR #2748: URL: https://github.com/apache/fineract/pull/2748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] vidakovic opened a new pull request, #2749: FINERACT-1807: Extension point - data service

vidakovic opened a new pull request, #2749: URL: https://github.com/apache/fineract/pull/2749 Community request to be able to override "ReadWriteNonCoreDataService". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2748: FINERACT-1724: Swagger fix for loan transaction API

adamsaghy commented on code in PR #2748: URL: https://github.com/apache/fineract/pull/2748#discussion_r1026405942 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java: ## @@ -185,6 +185,38 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2748: FINERACT-1724: Swagger fix for loan transaction API

adamsaghy commented on code in PR #2748: URL: https://github.com/apache/fineract/pull/2748#discussion_r1026405579 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java: ## @@ -185,6 +185,38 @@ private

[GitHub] [fineract] galovics opened a new pull request, #2748: FINERACT-1724: Swagger fix for loan transaction API

galovics opened a new pull request, #2748: URL: https://github.com/apache/fineract/pull/2748 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] b0c1 opened a new pull request, #2747: FINERACT-1724 - Thitsa Works integration refactoring

b0c1 opened a new pull request, #2747: URL: https://github.com/apache/fineract/pull/2747 ## Description - [x] Refactoring ThitsaWorksCreditBureauIntegrationWritePlatformServiceImpl - [x] Fix NullPointerException and test added to

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1025977302 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,132 @@ +/** + * Licensed

[GitHub] [fineract] github-actions[bot] commented on pull request #2607: Add customer documentation for effective date

github-actions[bot] commented on PR #2607: URL: https://github.com/apache/fineract/pull/2607#issuecomment-1319383473 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2679: Refine documentation on new reliable event handling framework built on Kafka

github-actions[bot] commented on PR #2679: URL: https://github.com/apache/fineract/pull/2679#issuecomment-1319383435 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] adamsaghy merged pull request #2746: FINERACT-1706: Fix chargeback transaction amount zero

adamsaghy merged PR #2746: URL: https://github.com/apache/fineract/pull/2746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2746: FINERACT-1706: Fix chargeback transaction amount zero

adamsaghy commented on code in PR #2746: URL: https://github.com/apache/fineract/pull/2746#discussion_r1025749359 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanTransactionChargebackTest.java: ## @@ -66,7 +67,8 @@ public void setup() {

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1025239837 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/LoanCollectionDomainService.java: ## @@ -0,0 +1,36 @@ +/** +

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1025230005 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanEventApiJsonValidator.java: ## @@ -237,7 +237,7 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1025229194 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java: ## @@ -233,15

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1025228461 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java: ## @@ -217,12

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1025228167 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyWritePlatformServiceImpl.java: ## @@ -152,61

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1025226388 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,89

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2746: FINERACT-1706: Fix chargeback transaction amount zero

josehernandezfintecheandomx opened a new pull request, #2746: URL: https://github.com/apache/fineract/pull/2746 ## Description There was an issue allowing chargeback transaction with amount in zero Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics merged pull request #2745: FINERACT-1734-Repayment-due-event

galovics merged PR #2745: URL: https://github.com/apache/fineract/pull/2745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2745: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2745: URL: https://github.com/apache/fineract/pull/2745#discussion_r1023786435 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -19,33 +19,30 @@ package

[GitHub] [fineract] galovics commented on a diff in pull request #2745: FINERACT-1734-Repayment-due-event

galovics commented on code in PR #2745: URL: https://github.com/apache/fineract/pull/2745#discussion_r1024893901 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -19,33 +19,30 @@ package

[GitHub] [fineract] galovics commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

galovics commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1024879572 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,89 +104,22 @@ public

[GitHub] [fineract] github-actions[bot] commented on pull request #2677: FINERACT-1737: Introduce Lombok to smscampaigns module

github-actions[bot] commented on PR #2677: URL: https://github.com/apache/fineract/pull/2677#issuecomment-1317860827 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1024596855 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,132 @@ +/** + * Licensed

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1024091951 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java: ## @@ -718,6 +721,9 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1024086328 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,132 @@ +/** + * Licensed

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1024083766 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,89

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1024083142 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java: ## @@ -140,6 +140,9 @@

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1024081035 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6781,15 +6781,19 @@ public Collection

[GitHub] [fineract] galovics merged pull request #2740: FINERACT-1724: Unit and Integration test for Credit Bureau

galovics merged PR #2740: URL: https://github.com/apache/fineract/pull/2740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2745: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2745: URL: https://github.com/apache/fineract/pull/2745#discussion_r1023792846 ## fineract-provider/src/test/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStepTest.java: ## @@ -95,11 +94,12 @@ public void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2745: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2745: URL: https://github.com/apache/fineract/pull/2745#discussion_r1023788446 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -19,33 +19,30 @@ package

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2745: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2745: URL: https://github.com/apache/fineract/pull/2745#discussion_r1023786435 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -19,33 +19,30 @@ package

[GitHub] [fineract] galovics commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

galovics commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023711751 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,132 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023686034 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,132 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023676642 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java: ## @@ -140,6 +140,9 @@ public class

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023678632 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,89 +103,23 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023676642 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java: ## @@ -140,6 +140,9 @@ public class

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023669228 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -6781,15 +6781,19 @@ public Collection getLoanCharges() {

[GitHub] [fineract] galovics merged pull request #2744: FINERACT-1724 - Fix possible null values

galovics merged PR #2744: URL: https://github.com/apache/fineract/pull/2744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023496337 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,52

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023496166 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -174,20

<    3   4   5   6   7   8   9   10   11   12   >