[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023495965 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,85 @@ +/** + * Licensed

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023495787 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,120 @@ +/** + * Licensed

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1023495694 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanTransactionChargebackTest.java: ## @@ -160,7 +159,7 @@ public void

[GitHub] [fineract] github-actions[bot] commented on pull request #2608: Add transaction idempotency customer docs

github-actions[bot] commented on PR #2608: URL: https://github.com/apache/fineract/pull/2608#issuecomment-1316070177 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2680: Refine documentation on integration of Spring Batch for parallelization of batch jobs

github-actions[bot] commented on PR #2680: URL: https://github.com/apache/fineract/pull/2680#issuecomment-1316070134 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] ruchiD opened a new pull request, #2745: FINERACT-1734-Repayment-due-event

ruchiD opened a new pull request, #2745: URL: https://github.com/apache/fineract/pull/2745 ## Description Refactored for api change for retrieving repayment installments. Describe the changes made and why they were made. Ignore if these details are present on the associated

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1022885029 ## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanTransactionChargebackTest.java: ## @@ -160,7 +159,7 @@ public void

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1022467315 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,52 +111,30 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1022466751 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,120 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] b0c1 commented on a diff in pull request #2744: FINERACT-1724 - Fix possible null values

b0c1 commented on code in PR #2744: URL: https://github.com/apache/fineract/pull/2744#discussion_r1022109497 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java: ## @@ -133,17 +133,9 @@ private void reject(Long loanId,

[GitHub] [fineract] galovics commented on a diff in pull request #2744: FINERACT-1724 - Fix possible null values

galovics commented on code in PR #2744: URL: https://github.com/apache/fineract/pull/2744#discussion_r1021800789 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBApiFilter.java: ## @@ -133,17 +133,9 @@ private void reject(Long loanId,

[GitHub] [fineract] b0c1 opened a new pull request, #2744: FINERACT-1724 - Fix possible null values

b0c1 opened a new pull request, #2744: URL: https://github.com/apache/fineract/pull/2744 ## Description Describe the changes made and why they were made. Small modifications to resolve some sonar issues. Covered by existing unit and integration tests. ## Checklist

[GitHub] [fineract] galovics merged pull request #2741: chore(deps): update all non-major dependencies

galovics merged PR #2741: URL: https://github.com/apache/fineract/pull/2741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2743: FINERACT-1805 - Treat share transactions separately

galovics commented on code in PR #2743: URL: https://github.com/apache/fineract/pull/2743#discussion_r1021673446 ## fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/JournalEntryReadPlatformServiceImpl.java: ## @@ -204,7 +204,12 @@ public

[GitHub] [fineract] galovics merged pull request #2742: fix(deps): update non-major

galovics merged PR #2742: URL: https://github.com/apache/fineract/pull/2742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2738: [FINERACT-1678] Loan COB - skip non-owned locked loan accounts

galovics merged PR #2738: URL: https://github.com/apache/fineract/pull/2738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1021285475 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] wkigenyi opened a new pull request, #2743: FINRACT-1805 - Treat share transactions separately

wkigenyi opened a new pull request, #2743: URL: https://github.com/apache/fineract/pull/2743 ## Description Loan and Savings transactionIds start with a single capital letter (L and S repectively) but share transactions start with 2 capital letters (SH). Originally all

[GitHub] [fineract] renovate-bot opened a new pull request, #2742: fix(deps): update non-major

renovate-bot opened a new pull request, #2742: URL: https://github.com/apache/fineract/pull/2742 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2741: chore(deps): update all non-major dependencies

renovate-bot opened a new pull request, #2741: URL: https://github.com/apache/fineract/pull/2741 [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age |

[GitHub] [fineract] github-actions[bot] commented on pull request #2498: FINERACT-1725: Introduce Lombok to JournalEntry module

github-actions[bot] commented on PR #2498: URL: https://github.com/apache/fineract/pull/2498#issuecomment-1312869740 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2664: FINERACT-1776: Introduce Lombok to office module

github-actions[bot] commented on PR #2664: URL: https://github.com/apache/fineract/pull/2664#issuecomment-1312602440 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2738: [FINERACT-1678] Loan COB - skip non-owned locked loan accounts

adamsaghy commented on code in PR #2738: URL: https://github.com/apache/fineract/pull/2738#discussion_r1020345529 ## fineract-provider/src/test/java/org/apache/fineract/cob/loan/ApplyLoanLockTaskletStepDefinitions.java: ## @@ -58,11 +58,10 @@ public

[GitHub] [fineract] b0c1 opened a new pull request, #2740: FINERACT-1724: Unit and Integration test for Credit Bureau

b0c1 opened a new pull request, #2740: URL: https://github.com/apache/fineract/pull/2740 ## Description - [x] Unit test for ThitsaWorksCreditBureauIntegrationWritePlatformServiceImpl - [x] Integration test for CreditBureau with WireMock ## Checklist Please make

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1020197414 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1020193034 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyUtils.java: ## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1020192526 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -174,20 +154,27 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1020191376 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,52 +111,30 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

adamsaghy commented on code in PR #2739: URL: https://github.com/apache/fineract/pull/2739#discussion_r1020042142 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -109,52 +111,30 @@ public

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2739: FINERACT-1706: Fix Loan Delinquency Classification after Repayment

josehernandezfintecheandomx opened a new pull request, #2739: URL: https://github.com/apache/fineract/pull/2739 ## Description The delinquency calculation must to happen as of the latest unpaid chargeback transaction date in order to reflect the right delinquency days and amount

[GitHub] [fineract] github-actions[bot] commented on pull request #2490: Add business date customer document

github-actions[bot] commented on PR #2490: URL: https://github.com/apache/fineract/pull/2490#issuecomment-1311070168 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2572: FINERACT-1716: Introduce Lombok to commands module

github-actions[bot] commented on PR #2572: URL: https://github.com/apache/fineract/pull/2572#issuecomment-1311070144 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2578: FINERACT-1732: Introduce Lombok to bulkimport module

github-actions[bot] commented on PR #2578: URL: https://github.com/apache/fineract/pull/2578#issuecomment-1311070112 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2573: FINERACT-1727: Introduce Lombok to accountnumberformat module

github-actions[bot] commented on PR #2573: URL: https://github.com/apache/fineract/pull/2573#issuecomment-1311070126 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2592: FINERACT-1743: Introduce Lombok to documentmanagement module

github-actions[bot] commented on PR #2592: URL: https://github.com/apache/fineract/pull/2592#issuecomment-1311070064 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2591: FINERACT-1742: Introduce Lombok to dataqueries module

github-actions[bot] commented on PR #2591: URL: https://github.com/apache/fineract/pull/2591#issuecomment-1311070092 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] github-actions[bot] commented on pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performanc

github-actions[bot] commented on PR #2642: URL: https://github.com/apache/fineract/pull/2642#issuecomment-1311070037 This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. -- This is an automated message from the Apache Git

[GitHub] [fineract] galovics merged pull request #2737: FINERACT-1734-Deliquency-range-event

galovics merged PR #2737: URL: https://github.com/apache/fineract/pull/2737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

galovics commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1018965771 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -64,69 +66,58 @@ public class

[GitHub] [fineract] galovics commented on a diff in pull request #2737: FINERACT-1734-Deliquency-range-event

galovics commented on code in PR #2737: URL: https://github.com/apache/fineract/pull/2737#discussion_r1018891140 ## fineract-avro-schemas/src/main/avro/loan/v1/LoanAccountDelinquencyRangeDataV1.avsc: ## @@ -0,0 +1,39 @@ +{ +"name": "LoanAccountDelinquencyRangeDataV1", +

[GitHub] [fineract] taskain7 opened a new pull request, #2738: [FINERACT-1678] Loan COB - skip non-owned locked loan accounts

taskain7 opened a new pull request, #2738: URL: https://github.com/apache/fineract/pull/2738 ## Description Loan COB processing should skip loan accounts that are already hard locked or already processed by other COB processing. -- This is an automated message from the Apache Git

[GitHub] [fineract] adamsaghy merged pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy merged PR #2724: URL: https://github.com/apache/fineract/pull/2724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2737: FINERACT-1734-Deliquency-range-event

ruchiD opened a new pull request, #2737: URL: https://github.com/apache/fineract/pull/2737 ## Description Describe the changes made and why they were made. 1.Created new Avro schema for LoanAccountDelinquencyRangeDataV1 having id, accountno, externalId, delinquencyRange

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017853889 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java: ## @@ -264,11 +263,10 @@ public Collection

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017849749 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeReadPlatformServiceImpl.java: ## @@ -443,11 +444,11 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017848918 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/handler/LoanChargeAdjustmentCommandHandler.java: ## @@ -0,0 +1,42 @@ +/** + * Licensed

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017847620 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionRelationRepository.java: ## @@ -25,7 +25,6 @@ public interface

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017846772 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanInstallmentCharge.java: ## @@ -322,4 +323,9 @@ public

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017838156 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanCharge.java: ## @@ -1101,4 +1105,18 @@ public ChargeTimeType

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017824748 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -3379,7 +3379,7 @@ public List

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017822970 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/DefaultLoanLifecycleStateMachine.java: ## @@ -164,54 +161,59 @@ private

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017820414 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanChargesApiResource.java: ## @@ -224,13 +220,16 @@ public String

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

adamsaghy commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017818374 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeEnumerations.java: ## @@ -191,4 +192,36 @@ public static EnumOptionData

[GitHub] [fineract] galovics commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

galovics commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017795117 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanChargesApiResource.java: ## @@ -224,13 +220,16 @@ public String

[GitHub] [fineract] b0c1 closed pull request #2736: Null check fix and remove code smell

b0c1 closed pull request #2736: Null check fix and remove code smell URL: https://github.com/apache/fineract/pull/2736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [fineract] vidakovic commented on pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

vidakovic commented on PR #2730: URL: https://github.com/apache/fineract/pull/2730#issuecomment-1308162940 Thanks for not getting discouraged by the comments, we mean well ... and be sure that our own PRs get through the same process... and not everyone is making it and get's approved .

[GitHub] [fineract] ezolnbl-dpc commented on pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on PR #2718: URL: https://github.com/apache/fineract/pull/2718#issuecomment-1308038567 failed command:  success command:

[GitHub] [fineract-cn-fims-web-app] dependabot[bot] opened a new pull request, #32: Bump loader-utils and @angular/cli

dependabot[bot] opened a new pull request, #32: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/32 Removes [loader-utils](https://github.com/webpack/loader-utils). It's no longer used after updating ancestor dependency [@angular/cli](https://github.com/angular/angular-cli).

[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #16: Bump loader-utils and @angular/cli

sonarcloud[bot] commented on PR #16: URL: https://github.com/apache/fineract-cn-group-finance/pull/16#issuecomment-1307872889 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #16: Bump loader-utils and @angular/cli

dependabot[bot] opened a new pull request, #16: URL: https://github.com/apache/fineract-cn-group-finance/pull/16 Removes [loader-utils](https://github.com/webpack/loader-utils). It's no longer used after updating ancestor dependency [@angular/cli](https://github.com/angular/angular-cli).

[GitHub] [fineract] vidakovic commented on a diff in pull request #2724: FINERACT-1761: New Charge Adjustment transaction

vidakovic commented on code in PR #2724: URL: https://github.com/apache/fineract/pull/2724#discussion_r1017010859 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java: ## @@ -1215,7

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1017032812 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exceptionmapper/DuplicateCommandExceptionMapper.java: ## @@ -0,0 +1,52 @@ +/** + *

[GitHub] [fineract] wkigenyi closed pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi closed pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read URL: https://github.com/apache/fineract/pull/2730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [fineract] wkigenyi commented on pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on PR #2730: URL: https://github.com/apache/fineract/pull/2730#issuecomment-1307693293 @vidakovic @galovics @adamsaghy I am closing this PR and redoing it in a better way -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [fineract] galovics merged pull request #2735: [FINERACT-1678] LoanCOBApiFIlter throws NPE when user is not authenticated

galovics merged PR #2735: URL: https://github.com/apache/fineract/pull/2735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2731: [FINERACT-1678] Introducing synchronous COB execution for loan account changing APIs

galovics merged PR #2731: URL: https://github.com/apache/fineract/pull/2731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] b0c1 opened a new pull request, #2736: Null check elimination and remove code smell

b0c1 opened a new pull request, #2736: URL: https://github.com/apache/fineract/pull/2736 ## Description Added null checks and removed some code smell. ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write

[GitHub] [fineract] taskain7 opened a new pull request, #2735: [FINERACT-1678] LoanCOBApiFIlter throws NPE when user is not authenticated

taskain7 opened a new pull request, #2735: URL: https://github.com/apache/fineract/pull/2735 ## Description Fix for NPE in LoanCOBApiFIlter that was thrown when user was not authenticated. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] taskain7 commented on a diff in pull request #2731: [FINERACT-1678] Introducing synchronous COB execution for loan account changing APIs

taskain7 commented on code in PR #2731: URL: https://github.com/apache/fineract/pull/2731#discussion_r1016374509 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/InlineExecutorService.java: ## @@ -21,7 +21,9 @@ import

[GitHub] [fineract] galovics merged pull request #2734: chore(deps): bump gradle/wrapper-validation-action from 9aa31f26bc8e536d1faf4b332bb8365350743a18 to 1.0.5

galovics merged PR #2734: URL: https://github.com/apache/fineract/pull/2734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] wkigenyi commented on pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on PR #2730: URL: https://github.com/apache/fineract/pull/2730#issuecomment-1306842568 @adamsaghy thanks I am changing this PR to draft until I have addressed the change requests. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] dependabot[bot] opened a new pull request, #2734: chore(deps): bump gradle/wrapper-validation-action from 9aa31f26bc8e536d1faf4b332bb8365350743a18 to 1.0.5

dependabot[bot] opened a new pull request, #2734: URL: https://github.com/apache/fineract/pull/2734 Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 9aa31f26bc8e536d1faf4b332bb8365350743a18 to 1.0.5. This release includes the previously

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1015965670 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandSaver.java: ## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1015960496 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1015956605 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/config/jpa/JpaExceptionHandler.java: ## @@ -0,0 +1,88 @@ +/** + * Licensed to the

[GitHub] [fineract] wkigenyi commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015899866 ## fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapperRepository.java: ## @@ -18,6 +18,25 @@ */ package

[GitHub] [fineract] wkigenyi commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015892593 ## fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapperRepository.java: ## @@ -18,6 +18,25 @@ */ package

[GitHub] [fineract] vidakovic merged pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic merged PR #2727: URL: https://github.com/apache/fineract/pull/2727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] wkigenyi commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015870711 ## fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapperRepository.java: ## @@ -18,6 +18,25 @@ */ package

[GitHub] [fineract] vidakovic commented on a diff in pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic commented on code in PR #2727: URL: https://github.com/apache/fineract/pull/2727#discussion_r1015705204 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractPlatformTenantConnection.java: ## @@ -171,10 +171,12 @@ public int

[GitHub] [fineract] galovics commented on a diff in pull request #2712: FINERACT-1789: retrieveSchedulerDetail fails if no records founds

galovics commented on code in PR #2712: URL: https://github.com/apache/fineract/pull/2712#discussion_r1015691696 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedularWritePlatformServiceJpaRepositoryImpl.java: ## @@ -102,10 +102,10 @@

[GitHub] [fineract] vidakovic commented on a diff in pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic commented on code in PR #2727: URL: https://github.com/apache/fineract/pull/2727#discussion_r1015690800 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractPlatformTenantConnection.java: ## @@ -171,10 +171,12 @@ public int

[GitHub] [fineract] galovics commented on a diff in pull request #2727: FINERACT-1795: Improve resilience of command processing service

galovics commented on code in PR #2727: URL: https://github.com/apache/fineract/pull/2727#discussion_r1015683775 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractPlatformTenantConnection.java: ## @@ -171,10 +171,12 @@ public int

[GitHub] [fineract] wkigenyi commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015684506 ## fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationMapperWritePlatformServiceImpl.java: ## @@ -38,4 +38,14 @@ public Long

[GitHub] [fineract] galovics commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

galovics commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015670573 ## fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapperRepository.java: ## @@ -18,6 +18,25 @@ */ package

[GitHub] [fineract] galovics commented on a diff in pull request #2731: [FINERACT-1678] Introducing synchronous COB execution for loan account changing APIs

galovics commented on code in PR #2731: URL: https://github.com/apache/fineract/pull/2731#discussion_r1015663181 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/InlineLoanCOBExecutorServiceImpl.java: ## @@ -66,7 +66,7 @@ @Service @Slf4j

[GitHub] [fineract] galovics merged pull request #2733: FINERACT-1724: Added loan external ID into transaction events

galovics merged PR #2733: URL: https://github.com/apache/fineract/pull/2733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] wkigenyi commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015632520 ## fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapperRepository.java: ## @@ -18,6 +18,25 @@ */ package

[GitHub] [fineract] adamsaghy commented on pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

adamsaghy commented on PR #2730: URL: https://github.com/apache/fineract/pull/2730#issuecomment-1305862264 @wkigenyi Please dont forget to squash all the 10 commits into 1, before the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic commented on PR #2727: URL: https://github.com/apache/fineract/pull/2727#issuecomment-1305716436 Added documentation and more cleanups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [fineract] galovics commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

galovics commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015374250 ## fineract-provider/src/main/java/org/apache/fineract/notification/domain/NotificationMapperRepository.java: ## @@ -18,6 +18,25 @@ */ package

[GitHub] [fineract] galovics merged pull request #2729: chore(deps): update all non-major dependencies

galovics merged PR #2729: URL: https://github.com/apache/fineract/pull/2729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics opened a new pull request, #2733: FINERACT-1724: Added loan external ID into transaction events

galovics opened a new pull request, #2733: URL: https://github.com/apache/fineract/pull/2733 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] codeKonnects closed pull request #2726: Simple fin

codeKonnects closed pull request #2726: Simple fin URL: https://github.com/apache/fineract/pull/2726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2731: [FINERACT-1678] Introducing synchronous COB execution for loan account changing APIs

galovics commented on code in PR #2731: URL: https://github.com/apache/fineract/pull/2731#discussion_r1015304993 ## fineract-provider/src/main/java/org/apache/fineract/cob/service/LoanAccountLockServiceImpl.java: ## @@ -51,4 +51,11 @@ public boolean isLoanHardLocked(Long

[GitHub] [fineract] galovics commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

galovics commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1015303111 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] galovics merged pull request #2728: chore(deps): update gradle/wrapper-validation-action digest to 9aa31f2

galovics merged PR #2728: URL: https://github.com/apache/fineract/pull/2728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] ruchiD opened a new pull request, #2732: FINERACT-1734-Negative-balance-event

ruchiD opened a new pull request, #2732: URL: https://github.com/apache/fineract/pull/2732 ## Description Describe the changes made and why they were made. 1.New Event for Loan overpaid event 2.Business step for COB for checking loan account overpaid. This step checks if loan

[GitHub] [fineract] wkigenyi commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

wkigenyi commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015296482 ## fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationReadPlatformServiceImpl.java: ## @@ -94,9 +95,8 @@ private boolean

[GitHub] [fineract] galovics commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

galovics commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1015240931 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandSaver.java: ## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation

<    4   5   6   7   8   9   10   11   12   13   >