[GitHub] [fineract] taskain7 opened a new pull request, #2731: [FINERACT-1678] Introducing synchronous COB execution for loan account changing APIs

taskain7 opened a new pull request, #2731: URL: https://github.com/apache/fineract/pull/2731 ## Description When a loan is soft locked by COB partitioning during write operation, then the Inline COB runs on the loan instead of regular COB and after that the write operation goes

[GitHub] [fineract] galovics merged pull request #2725: FINERACT-1724: Refactoring the business event serializers for better extensibility

galovics merged PR #2725: URL: https://github.com/apache/fineract/pull/2725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] vidakovic commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

vidakovic commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r101562 ## fineract-provider/src/main/java/org/apache/fineract/notification/api/NotificationApiResource.java: ## @@ -85,7 +89,16 @@ public String

[GitHub] [fineract] vidakovic commented on a diff in pull request #2730: FINERACT-1673: Add an endpoint for marking a single notification as read

vidakovic commented on code in PR #2730: URL: https://github.com/apache/fineract/pull/2730#discussion_r1015107141 ## fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationReadPlatformServiceImpl.java: ## @@ -94,9 +95,8 @@ private boolean

[GitHub] [fineract] vidakovic commented on pull request #2730: [FINERACT-1673] Add an endpoint for marking a single notification as read

vidakovic commented on PR #2730: URL: https://github.com/apache/fineract/pull/2730#issuecomment-1305203125 Could you please follow the general formatting rules for PRs? Otherwise they don't get automatically linked to their Jira issues. The correct PR title would be `FINERACT-1673: Add an

[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic commented on PR #2727: URL: https://github.com/apache/fineract/pull/2727#issuecomment-1305199981 Alright... I think that's it. Removed some overly complex error handling for some retry scenarios and fixed a hidden issue in one of the retry fallback functions (missing return type

[GitHub] [fineract] wkigenyi opened a new pull request, #2730: [FINERACT-1673] Add an endpoint for marking a single notification as read

wkigenyi opened a new pull request, #2730: URL: https://github.com/apache/fineract/pull/2730 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] wkigenyi closed pull request #2708: [FINERACT-1673] Use JPA Notifications and provide for updating a single notification

wkigenyi closed pull request #2708: [FINERACT-1673] Use JPA Notifications and provide for updating a single notification URL: https://github.com/apache/fineract/pull/2708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [fineract] renovate-bot opened a new pull request, #2729: chore(deps): update all non-major dependencies

renovate-bot opened a new pull request, #2729: URL: https://github.com/apache/fineract/pull/2729 [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

[GitHub] [fineract] renovate-bot opened a new pull request, #2728: chore(deps): update gradle/wrapper-validation-action digest to 9aa31f2

renovate-bot opened a new pull request, #2728: URL: https://github.com/apache/fineract/pull/2728 [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change |

[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic commented on PR #2727: URL: https://github.com/apache/fineract/pull/2727#issuecomment-1304896136 Adjusting the tests took more time than should be necessary... the whole tenant based database setup is impossible to mock for testing... there are just to many factories inside of

[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic commented on PR #2727: URL: https://github.com/apache/fineract/pull/2727#issuecomment-1304861821 I think I found it... tricky. Needed to re-throw exception in `logCommand` fallback method; it was swallowing the exceptions and that resulted utlimately in the HTTP 204 code. --

[GitHub] [fineract] vidakovic commented on pull request #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic commented on PR #2727: URL: https://github.com/apache/fineract/pull/2727#issuecomment-1304852539 I've investigated that failure a bit and can't make any sense of it. The server side exception mapping seems to be OK as far as I can tell (investigated all execution paths).

[GitHub] [fineract] vidakovic commented on pull request #2726: Simple fin

vidakovic commented on PR #2726: URL: https://github.com/apache/fineract/pull/2726#issuecomment-1304761442 @codeKonnects Could you please create first a Jira ticket and describe a little bit more in detail what you are trying to fix here? Just to give reviewers a little bit more context

[GitHub] [fineract] vidakovic opened a new pull request, #2727: FINERACT-1795: Improve resilience of command processing service

vidakovic opened a new pull request, #2727: URL: https://github.com/apache/fineract/pull/2727 Improve the resilience of the command processing service and make retry (and other parameters) configurable (provide reasonable defaults). The current retry mechanics in place are causing

[GitHub] [fineract] github-actions[bot] closed pull request #2190: FINERACT-1431: Country Drop down for Passport - identities

github-actions[bot] closed pull request #2190: FINERACT-1431: Country Drop down for Passport - identities URL: https://github.com/apache/fineract/pull/2190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] codeKonnects opened a new pull request, #2726: Simple fin

codeKonnects opened a new pull request, #2726: URL: https://github.com/apache/fineract/pull/2726 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics opened a new pull request, #2725: FINERACT-1724: Refactoring the business event serializers for better extensibility

galovics opened a new pull request, #2725: URL: https://github.com/apache/fineract/pull/2725 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] fynmanoj closed pull request #2676: FINERACT-1748: Loan prepayment issue after advance payment

fynmanoj closed pull request #2676: FINERACT-1748: Loan prepayment issue after advance payment URL: https://github.com/apache/fineract/pull/2676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [fineract] fynmanoj merged pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue

fynmanoj merged PR #2690: URL: https://github.com/apache/fineract/pull/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue

logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue URL: https://github.com/apache/fineract/pull/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] fynmanoj merged pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment

fynmanoj merged PR #2703: URL: https://github.com/apache/fineract/pull/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] fynmanoj merged pull request #2709: FINERACT-1781:Interest is wrong for the first instalment.

fynmanoj merged PR #2709: URL: https://github.com/apache/fineract/pull/2709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy opened a new pull request, #2724: FINERACT-1761: New Charge Adjustment transaction - part 1

adamsaghy opened a new pull request, #2724: URL: https://github.com/apache/fineract/pull/2724 ## Description **Contains:** - Introducing new transaction: Loan Charge Adjustment - Introduce Loan Charge Service and move existing loan charge business logics - Introduce new

[GitHub] [fineract] galovics merged pull request #2723: FINERACT-1724: Added loanId to LoanTransactionData and extended the respective Avro schema

galovics merged PR #2723: URL: https://github.com/apache/fineract/pull/2723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2722: FINERACT-1724: Swagger enhancements + Batch API enhancements

galovics merged PR #2722: URL: https://github.com/apache/fineract/pull/2722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2720: FINERACT-1734-Repayment-due-event

galovics merged PR #2720: URL: https://github.com/apache/fineract/pull/2720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

galovics commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1012695068 ## fineract-provider/src/test/java/org/apache/fineract/cob/loan/CheckLoanRepaymentDueBusinessStepTest.java: ## @@ -0,0 +1,111 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] galovics closed pull request #2721: FINERACT-1724: Making the LoanNotFoundException backward compatible again

galovics closed pull request #2721: FINERACT-1724: Making the LoanNotFoundException backward compatible again URL: https://github.com/apache/fineract/pull/2721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012269720 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012267251 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -147,6 +151,34 @@ public

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012270850 ## fineract-provider/src/main/java/org/apache/fineract/commands/data/AuditSearchData.java: ## @@ -34,5 +34,5 @@ public final class AuditSearchData { private

[GitHub] [fineract] ezolnbl-dpc commented on pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on PR #2718: URL: https://github.com/apache/fineract/pull/2718#issuecomment-1301192450 > The build is failing and this change is now calling for unit tests. Please work on it a little more. will do -- This is an automated message from the Apache Git Service.

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012264867 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012269720 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012269420 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exceptionmapper/DuplicateCommandExceptionMapper.java: ## @@ -0,0 +1,52 @@ +/** + *

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012267525 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/exception/DuplicateCommandException.java: ## @@ -0,0 +1,54 @@ +/** + * Licensed to the

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012267251 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -147,6 +151,34 @@ public

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012265792 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] ezolnbl-dpc commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1012264824 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1011873009 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1011825904 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentDueBusinessStep.java: ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1011861354 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1011861354 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] galovics merged pull request #2668: FINERACT-1706: Delinquency classification including Chargeback transactions

galovics merged PR #2668: URL: https://github.com/apache/fineract/pull/2668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics opened a new pull request, #2723: FINERACT-1724: Added loanId to LoanTransactionData and extended the respective Avro schema

galovics opened a new pull request, #2723: URL: https://github.com/apache/fineract/pull/2723 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics commented on a diff in pull request #2722: FINERACT-1724: Swagger enhancements + Batch API enhancements

galovics commented on code in PR #2722: URL: https://github.com/apache/fineract/pull/2722#discussion_r1011845141 ## fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategyProvider.java: ## @@ -103,6 +103,8 @@ private static void init() {

[GitHub] [fineract] ruchiD commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

ruchiD commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1011838295 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1011828277 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentOverdueBusinessStep.java: ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2720: FINERACT-1734-Repayment-due-event

adamsaghy commented on code in PR #2720: URL: https://github.com/apache/fineract/pull/2720#discussion_r1011825904 ## fineract-provider/src/main/java/org/apache/fineract/cob/loan/CheckLoanRepaymentDueBusinessStep.java: ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2722: FINERACT-1724: Swagger enhancements + Batch API enhancements

adamsaghy commented on code in PR #2722: URL: https://github.com/apache/fineract/pull/2722#discussion_r1011816931 ## fineract-provider/src/main/java/org/apache/fineract/batch/command/CommandStrategyProvider.java: ## @@ -103,6 +103,8 @@ private static void init() {

[GitHub] [fineract] galovics opened a new pull request, #2722: FINERACT-1724: Swagger enhancements + Batch API enhancements

galovics opened a new pull request, #2722: URL: https://github.com/apache/fineract/pull/2722 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] galovics opened a new pull request, #2721: FINERACT-1724: Making the LoanNotFoundException backward compatible a…

galovics opened a new pull request, #2721: URL: https://github.com/apache/fineract/pull/2721 …gain ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] ruchiD opened a new pull request, #2720: FINERACT-1734-Repayment-due-event

ruchiD opened a new pull request, #2720: URL: https://github.com/apache/fineract/pull/2720 ## Description Changes made to 1.created new business steps for repayment due and repayment overdue events. 2.created new events for repayment due and repayment overdue. 3.Added global

[GitHub] [fineract] tapaswenipathak opened a new pull request, #2719: Add documentation for Cucumber Test Framework

tapaswenipathak opened a new pull request, #2719: URL: https://github.com/apache/fineract/pull/2719 - [x] Draft documentation for QA/testers on how to write new tests and leverage the Cucumber Test framework - [x] Draft documentation for developers on how to write code leveraging new

[GitHub] [fineract] galovics commented on a diff in pull request #2718: FINEARCT-1744 add command execution 2 step transaction handling

galovics commented on code in PR #2718: URL: https://github.com/apache/fineract/pull/2718#discussion_r1011570061 ## fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java: ## @@ -69,45 +76,43 @@ public class

[GitHub] [fineract] galovics merged pull request #2713: [FINERACT-1678] Bypassing loan account write protection

galovics merged PR #2713: URL: https://github.com/apache/fineract/pull/2713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] galovics merged pull request #2715: Fix no enum constant http methods

galovics merged PR #2715: URL: https://github.com/apache/fineract/pull/2715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue

logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue URL: https://github.com/apache/fineract/pull/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment

logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment URL: https://github.com/apache/fineract/pull/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] wkigenyi closed pull request #2717: [Fineract-1788] - Use JPA for notification queries

wkigenyi closed pull request #2717: [Fineract-1788] - Use JPA for notification queries URL: https://github.com/apache/fineract/pull/2717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [fineract] ezolnbl-dpc opened a new pull request, #2718: FINEARCT-1744 add command execution 2 step transaction handling

ezolnbl-dpc opened a new pull request, #2718: URL: https://github.com/apache/fineract/pull/2718 ## Description Check FINERACT-1744 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit

[GitHub] [fineract] wkigenyi opened a new pull request, #2717: [Fineract-1788] - Use JPA for notification queries

wkigenyi opened a new pull request, #2717: URL: https://github.com/apache/fineract/pull/2717 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] vidakovic merged pull request #2701: FINERACT-1783: Customizeable LoanRepaymentScheduleTransactionProcessor

vidakovic merged PR #2701: URL: https://github.com/apache/fineract/pull/2701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment

logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment URL: https://github.com/apache/fineract/pull/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment

logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment URL: https://github.com/apache/fineract/pull/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] vidakovic commented on a diff in pull request #2701: FINERACT-1783: Customizeable LoanRepaymentScheduleTransactionProcessor

vidakovic commented on code in PR #2701: URL: https://github.com/apache/fineract/pull/2701#discussion_r101891 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanSummaryData.java: ## @@ -96,7 +96,7 @@ public LoanSummaryData(final

[GitHub] [fineract] vidakovic commented on a diff in pull request #2701: FINERACT-1783: Customizeable LoanRepaymentScheduleTransactionProcessor

vidakovic commented on code in PR #2701: URL: https://github.com/apache/fineract/pull/2701#discussion_r101208 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -226,9 +225,11 @@ public class Loan extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2701: FINERACT-1783: Customizeable LoanRepaymentScheduleTransactionProcessor

adamsaghy commented on code in PR #2701: URL: https://github.com/apache/fineract/pull/2701#discussion_r1009801810 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -226,9 +225,11 @@ public class Loan extends

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2701: FINERACT-1783: Customizeable LoanRepaymentScheduleTransactionProcessor

adamsaghy commented on code in PR #2701: URL: https://github.com/apache/fineract/pull/2701#discussion_r1009800415 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanSummaryData.java: ## @@ -96,7 +96,7 @@ public LoanSummaryData(final

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2701: FINERACT-1783: Customizeable LoanRepaymentScheduleTransactionProcessor

adamsaghy commented on code in PR #2701: URL: https://github.com/apache/fineract/pull/2701#discussion_r1009771497 ## fineract-doc/src/docs/en/chapters/architecture/modules.adoc: ## @@ -1,91 +1,3 @@ = Modules -NOTE: Currently modules are a proof of concept feature in

[GitHub] [fineract] tapaswenipathak opened a new pull request, #2716: Add Collaboration Documentation

tapaswenipathak opened a new pull request, #2716: URL: https://github.com/apache/fineract/pull/2716 - [x] Draft documentation related to automated code checks, static analysis, and other build-level automation that has been introduced to improve code quality and reduce friction of upstream

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #2715: Fix no enum constant http methods

josehernandezfintecheandomx opened a new pull request, #2715: URL: https://github.com/apache/fineract/pull/2715 ## Description There was an `IllegalArgument` exception using the `HTTPMethods` instead of the `HttpMethod` from Spring

[GitHub] [fineract-cn-group-finance] sonarcloud[bot] commented on pull request #15: Bump socket.io-parser and karma

sonarcloud[bot] commented on PR #15: URL: https://github.com/apache/fineract-cn-group-finance/pull/15#issuecomment-1295798425 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [fineract-cn-group-finance] dependabot[bot] opened a new pull request, #15: Bump socket.io-parser and karma

dependabot[bot] opened a new pull request, #15: URL: https://github.com/apache/fineract-cn-group-finance/pull/15 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) to 4.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These

[GitHub] [fineract] vidakovic merged pull request #2714: FINERACT-1791: Remove Travis CI from documentation and syncronize the MariaDB version to version 10.9 in all the documents

vidakovic merged PR #2714: URL: https://github.com/apache/fineract/pull/2714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-cn-fims-web-app] dependabot[bot] opened a new pull request, #31: Bump socket.io-parser and karma

dependabot[bot] opened a new pull request, #31: URL: https://github.com/apache/fineract-cn-fims-web-app/pull/31 Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) to 4.2.1 and updates ancestor dependency [karma](https://github.com/karma-runner/karma). These dependencies

[GitHub] [fineract] logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue

logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue URL: https://github.com/apache/fineract/pull/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] IOhacker commented on pull request #2714: FINERACT-1791: Remove Travis CI from documentation and syncronize the MariaDB version to version 10.9 in all the documents

IOhacker commented on PR #2714: URL: https://github.com/apache/fineract/pull/2714#issuecomment-1295745797 Now the tests have been completed and passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] IOhacker opened a new pull request, #2714: FINERACT-1791

IOhacker opened a new pull request, #2714: URL: https://github.com/apache/fineract/pull/2714 ## Description - Travis CI text has been replaced to reflect the current use of GitHub Actions - MariaDB version has been updated to version 10.9 ## Checklist Please make

[GitHub] [fineract-site] vorburger merged pull request #22: Update index.html

vorburger merged PR #22: URL: https://github.com/apache/fineract-site/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract-site] jdailey opened a new pull request, #22: Update index.html

jdailey opened a new pull request, #22: URL: https://github.com/apache/fineract-site/pull/22 Changing top description to match most recent discussions and adding trademark sign. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [fineract] galovics merged pull request #2711: FINERACT-1694-Validating-event-configuration

galovics merged PR #2711: URL: https://github.com/apache/fineract/pull/2711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] taskain7 opened a new pull request, #2713: [FINERACT-1678] Bypassing loan account write protection

taskain7 opened a new pull request, #2713: URL: https://github.com/apache/fineract/pull/2713 ## Description Loan write API protection can be bypassed by permitted users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [fineract] logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment

logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment URL: https://github.com/apache/fineract/pull/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] galovics commented on a diff in pull request #2668: FINERACT-1706: Delinquency classification including Chargeback transactions

galovics commented on code in PR #2668: URL: https://github.com/apache/fineract/pull/2668#discussion_r1007996827 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionRepository.java: ## @@ -18,11 +18,31 @@ */ package

[GitHub] [fineract] galovics merged pull request #2705: [FINERACT-1678] Reject write API calls for hard-locked loan accounts

galovics merged PR #2705: URL: https://github.com/apache/fineract/pull/2705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue

logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue URL: https://github.com/apache/fineract/pull/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue

logoutdhaval closed pull request #2690: FINERACT-1745: Loan Schedule Final Installment calculation issue URL: https://github.com/apache/fineract/pull/2690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2668: FINERACT-1706: Delinquency classification including Chargeback transactions

josehernandezfintecheandomx commented on code in PR #2668: URL: https://github.com/apache/fineract/pull/2668#discussion_r1007621513 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/data/CollectionData.java: ## @@ -20,71 +20,27 @@ import

[GitHub] [fineract] josehernandezfintecheandomx commented on a diff in pull request #2668: FINERACT-1706: Delinquency classification including Chargeback transactions

josehernandezfintecheandomx commented on code in PR #2668: URL: https://github.com/apache/fineract/pull/2668#discussion_r1007621291 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/delinquency/service/DelinquencyReadPlatformServiceImpl.java: ## @@ -97,4 +107,88

[GitHub] [fineract] totemcaf opened a new pull request, #2712: FINERACT-1789: retrieveSchedulerDetail fails if no records founds

totemcaf opened a new pull request, #2712: URL: https://github.com/apache/fineract/pull/2712 Also fixed typo in name ## Description org.apache.fineract.infrastructure.jobs.service.SchedularWritePlatformServiceJpaRepositoryImpl#retrieveSchedulerDetail retrieve ScheduleDetail

[GitHub] [fineract] luckyman20 commented on pull request #2565: FINERACT-1715: Introduce Lombok to cob module

luckyman20 commented on PR #2565: URL: https://github.com/apache/fineract/pull/2565#issuecomment-1293775484 @galovics I do not see any conflicts while merging with the base branch. @hmg65 Please squash the commits. -- This is an automated message from the Apache Git Service. To

[GitHub] [fineract] ruchiD commented on a diff in pull request #2711: FINERACT-1694-Validating-event-configuration

ruchiD commented on code in PR #2711: URL: https://github.com/apache/fineract/pull/2711#discussion_r1007093019 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/ExternalEventConfigurationValidationService.java: ## @@ -0,0 +1,96 @@ +/**

[GitHub] [fineract] ruchiD commented on a diff in pull request #2711: FINERACT-1694-Validating-event-configuration

ruchiD commented on code in PR #2711: URL: https://github.com/apache/fineract/pull/2711#discussion_r1007093019 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/ExternalEventConfigurationValidationService.java: ## @@ -0,0 +1,96 @@ +/**

[GitHub] [fineract] galovics commented on a diff in pull request #2711: FINERACT-1694-Validating-event-configuration

galovics commented on code in PR #2711: URL: https://github.com/apache/fineract/pull/2711#discussion_r1007050432 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/ExternalEventConfigurationValidationService.java: ## @@ -0,0 +1,96 @@

[GitHub] [fineract] ruchiD opened a new pull request, #2711: FINERACT-1694-Validating-event-configuration

ruchiD opened a new pull request, #2711: URL: https://github.com/apache/fineract/pull/2711 ## Description Changes made for validating event configuration upon application startup for all tenants. All event types should appear in the configuration table with either enabled or

[GitHub] [fineract] galovics merged pull request #2710: FINERACT-1787: Fineract using wrong business date due to lack of resetting the ActionContext

galovics merged PR #2710: URL: https://github.com/apache/fineract/pull/2710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment

logoutdhaval closed pull request #2703: FINERACT-1786: Repayment schedule is wrong with late repayment URL: https://github.com/apache/fineract/pull/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2668: FINERACT-1706: Delinquency classification including Chargeback transactions

adamsaghy commented on code in PR #2668: URL: https://github.com/apache/fineract/pull/2668#discussion_r1003129551 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java: ## @@ -3356,6 +3356,18 @@ private List

<    5   6   7   8   9   10   11   12   13   14   >