[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1048940880 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -559,11 +559,143 @@ public Collection

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1045521379 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@ public Collection

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1042072148 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -370,77 +305,141 @@ public Collection

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client by External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1040923233 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java: ## @@ -545,90 +543,77 @@ public ClientData

[GitHub] [fineract] galovics commented on a diff in pull request #2783: FINERACT-1760: Client and External Id

galovics commented on code in PR #2783: URL: https://github.com/apache/fineract/pull/2783#discussion_r1039521823 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/client/mapper/ClientMapper.java: ## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apache Software