[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-11-19 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-730561952 @ptuomola @vorburger thanks, on it :) Sorry for delaying this long, I have been juggling between college exams, assignments and health :( I will be done with my fin

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-28 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-700315401 @vorburger oops, I missed to ping you after I pushed new changes. I think we can merge this now? This i

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-25 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698608546 @vorburger @ptuomola @luckyman20 Thank you for waiting a long time for these here is the update: 1. As mentioned by @ptuomola for using the implementation ["a","b"]

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-24 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-698608546 @vorburger @ptuomola @luckyman20 Thank you for waiting a long time for these here is the update: 1. As mentioned by @ptuomola for using the implementation ["a","b"]

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-22 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696933182 @vorburger yes already working on it! This is an automated message from the Apache Git Service. To respon

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-22 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-696933182 @vorburger yes already working on it! This is an automated message from the Apache Git Service. To respon

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-12 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-691527335 @vorburger sorry for the delay, I am in between of my college mid-semester exams, I will continue working as soon as I am done with it(hopefully no sooner than 19th Sept).

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-09-06 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-687846652 @vorburger yup I will fix this in a day or two. @ptuomola thanks for the suggestion!! This is an aut

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-30 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-683417327 @ptuomola @vorburger , From my discussions with @luckyman20 we came to the conclusion that we cannot send two parameters from the community-app, do you see any other solu

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-25 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680306593 @luckyman20 and I, are still not able to figure out how to do this on the frontend, I will try to get it done tomorrow, after which we can merge this. ---

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-25 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680306139 @vorburger It would be nice if we could merge this rn, Since this is blocking the work for removing SQL String concatenation, I will have enough time and I am making an is

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-25 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-680266177 @vorburger @ptuomola taking exceptionally long time to write tests since it is really hard to understand how loans work :(

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-24 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-679000910 @vorburger yes yes, I am in conversion with @luckyman20 we are trying to resolve the frontend part. We should confirm it by today, And then find the best way for this.

[GitHub] [fineract] thesmallstar commented on pull request #1251: FINERACT-1095 Added status parameter in Loans API

2020-08-17 Thread GitBox
thesmallstar commented on pull request #1251: URL: https://github.com/apache/fineract/pull/1251#issuecomment-675096834 @vorburger @ptuomola @luckyman20 As soon as this is merged, we can completely remove sqlsearch and the PRs #1171 and #1123 can be merged with minor changes. And we