[GitHub] [fineract-cn-fims-web-app] awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass

2019-09-04 Thread GitBox
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass URL: https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-528058284 This is no longer necessary as its handled in https://github.com/apache/fineract-cn-fims-web-app/pull/19 SO am closing. ---

[GitHub] [fineract-cn-fims-web-app] awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass

2019-07-08 Thread GitBox
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass URL: https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509299516 Maybe you add a new commit under #12 fixing the tslint... Thi

[GitHub] [fineract-cn-fims-web-app] awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass

2019-07-08 Thread GitBox
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass URL: https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509298876 This is giving me merge conlicts..If you have it already on ur local setup..send a new PR to fix this and I will close this one

[GitHub] [fineract-cn-fims-web-app] awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass

2019-07-08 Thread GitBox
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass URL: https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509286276 Travis build failure logs:https://travis-ci.com/apache/fineract-cn-fims-web-app/builds/118153337 -

[GitHub] [fineract-cn-fims-web-app] awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass

2019-07-08 Thread GitBox
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass URL: https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-509282566 Do you know how we can fix it @kengneruphine ? This is an auto

[GitHub] [fineract-cn-fims-web-app] awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass

2019-07-06 Thread GitBox
awasum commented on issue #17: FINCN-168: Fix tslint to make Travis CI pass URL: https://github.com/apache/fineract-cn-fims-web-app/pull/17#issuecomment-508920754 "npm run tslint" now passing but tests and builds are still failing. Seems there is a problem with Group tests... Could be