gyfora commented on pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#issuecomment-1056499408
@wangyang0918 @morhidi @Aitozi @bgeng777
If you guys have time to review this today, I would be happy to merge it at
the end of the day
--
This is an autom
gyfora commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r817423845
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##
@@ -27,27 +27,82 @@
i
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-table-store.git
The following commit(s) were added to refs/heads/master by this push:
new b980af0 [FLINK-26442] Allow Ma
This is an automated email from the ASF dual-hosted git repository.
gaoyunhaii pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 152ad4f [FLINK-25243][k8s] Increase the k8s
tweise commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r817364192
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/Observer.java
##
@@ -27,27 +27,82 @@
i
wangyang0918 merged pull request #32:
URL: https://github.com/apache/flink-kubernetes-operator/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
wangyang0918 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
The following commit(s) were added to refs/heads/main by this push:
new 11944da [FLINK-26367] Move
SteNicholas commented on pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#issuecomment-1056142660
@wangyang0918, thanks for your suggestion. I have addressed your comments
mentioned above. Please help to review again.
--
This is an automated message fro
wangyang0918 commented on a change in pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#discussion_r817323906
##
File path: flink-kubernetes-webhook/pom.xml
##
@@ -50,6 +50,12 @@ under the License.
${flink.version}
+
wangyang0918 commented on pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#issuecomment-1056132882
The e2e tests failed because of `ClassNotFoundException`. So we may need to
change the dependencies of `flink-kubernetes-webhook`.
```
2022-03-02 0
SteNicholas commented on pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#issuecomment-1056105693
@wangyang0918 @gyfora @tweise, could you please help to review the simple
change?
--
This is an automated message from the Apache Git Service.
To respond t
SteNicholas removed a comment on pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#issuecomment-1056103407
@wangyang0918 @gyfora @tweise[](https://github.com/SteNicholas), could you
please help to review the simple change?
--
This is an automated message
SteNicholas commented on pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#issuecomment-1056103407
@wangyang0918 @gyfora @tweise[](https://github.com/SteNicholas), could you
please help to review the simple change?
--
This is an automated message from th
SteNicholas removed a comment on pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#issuecomment-1056101159
@wangyang0918 @gyfora @tweise, could you please help to review the simple
change?
--
This is an automated message from the Apache Git Service.
To r
SteNicholas commented on pull request #32:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/32#issuecomment-1056101159
@wangyang0918 @gyfora @tweise, could you please help to review the simple
change?
--
This is an automated message from the Apache Git Service.
To respond t
SteNicholas opened a new pull request #32:
URL: https://github.com/apache/flink-kubernetes-operator/pull/32
[FLINK-26136](https://issues.apache.org/jira/browse/FLINK-26136) has
introduced a unified validator, the validation in `FlinkService#cancelJob`
should move to `DefaultDeploymentValid
Aitozi commented on a change in pull request #31:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/31#discussion_r817296067
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/BaseReconciler.java
##
@@ -41,17 +43,
gyfora commented on a change in pull request #26:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/26#discussion_r817137800
##
File path: helm/flink-operator/crds/flinkdeployments.flink.apache.org-v1.yml
##
@@ -9073,6 +9073,13 @@ spec:
savepoint
This is an automated email from the ASF dual-hosted git repository.
knaufk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 1947fb1 [hotfix][docs][table] Fix docs for SHA1
add 176aaed [hotfix] Fix deprecated method call in the docs (#1
morhidi commented on a change in pull request #27:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/27#discussion_r816983564
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##
@@ -80,6 +83,1
gyfora commented on a change in pull request #27:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/27#discussion_r816981833
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##
@@ -80,6 +83,17
gyfora commented on a change in pull request #31:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/31#discussion_r816979441
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobManagerDeploymentStatus.java
##
@@
gyfora commented on a change in pull request #31:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/31#discussion_r816978839
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/BaseReconciler.java
##
@@ -41,17 +43,
Aitozi opened a new pull request #31:
URL: https://github.com/apache/flink-kubernetes-operator/pull/31
As described in issue, this pr is meant to make some option configurable,
with some minor code snippet improvements.
--
This is an automated message from the Apache Git Service.
To res
This is an automated email from the ASF dual-hosted git repository.
fpaul pushed a commit to branch release-1.14
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.14 by this push:
new a36c9f7 [hotfix][docs][table] Fix doc
This is an automated email from the ASF dual-hosted git repository.
fpaul pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 225f2dd [FLINK-26296][docs] Add missing documentation for
JobResultStore and repeatable resource cleanup strategy
This is an automated email from the ASF dual-hosted git repository.
fpaul pushed a commit to branch release-1.13
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.13 by this push:
new 167f71d [hotfix][docs][table] Fix doc
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 3f06f97 [FLINK-26373][connector/kinesis] Rename KinesisDataStreams
module and classes into KinesisStreams
add 2
This is an automated email from the ASF dual-hosted git repository.
dannycranmer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 3f06f97 [FLINK-26373][connector/kinesis] R
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-table-store.git
The following commit(s) were added to refs/heads/master by this push:
new 6b7efeb [FLINK-26031] Support
This is an automated email from the ASF dual-hosted git repository.
wangyang0918 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
The following commit(s) were added to refs/heads/main by this push:
new 4df566d [FLINK-26405] Impr
wangyang0918 merged pull request #30:
URL: https://github.com/apache/flink-kubernetes-operator/pull/30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
twalthr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from e16ef6b [FLINK-25792][connectors] Changed repeated yielding in write
to non blocking flush after complete request,
wangyang0918 commented on pull request #30:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/30#issuecomment-1055325374
> Looks good to me but I have kind of lost my self-confidence 😄
Hmm... My bad.
--
This is an automated message from the Apache Git Service.
To resp
This is an automated email from the ASF dual-hosted git repository.
dannycranmer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 493bf3d05e43dfa24f04b4c4f06458837ad399b6
Author: Zichen Liu
AuthorDate: Mon Feb 7 13:17:28 2022 +
[FLINK-2
This is an automated email from the ASF dual-hosted git repository.
dannycranmer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit e16ef6bb7ced7c66bd00b7dfe2c7199d7303a54c
Author: Zichen Liu
AuthorDate: Thu Feb 24 19:45:23 2022 +
[FLINK-
This is an automated email from the ASF dual-hosted git repository.
dannycranmer pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 9055279 [hotfix] [runtime] Remove unused method
ResourceManager#getNumberRequiredTaskManagers()
new 493bf
bgeng777 commented on pull request #30:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/30#issuecomment-1055262666
Sorry for bothering you guys again @wangyang0918 @gyfora .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
dwysakowicz pushed a commit to branch release-1.14
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.14 by this push:
new ba92ddf [FLINK-25026]
Unaligne
bgeng777 commented on a change in pull request #29:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/29#discussion_r816621065
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##
bgeng777 opened a new pull request #30:
URL: https://github.com/apache/flink-kubernetes-operator/pull/30
- Use `HighAvailabilityMode.isHighAvailabilityModeActivated()` to improve
the check process of HA mode
- This PR is a followup of #29
--
This is an automated message from the A
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-table-store.git
The following commit(s) were added to refs/heads/master by this push:
new 55385ae [hotfix] Refactor Oper
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-table-store.git
The following commit(s) were added to refs/heads/master by this push:
new af4be76 [FLINK-26208] Introduc
wangyang0918 commented on a change in pull request #29:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/29#discussion_r816600887
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
###
This is an automated email from the ASF dual-hosted git repository.
leonard pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 9055279 [hotfix] [runtime] Remove unused method
gyfora commented on a change in pull request #29:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/29#discussion_r816577823
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
##
@@
This is an automated email from the ASF dual-hosted git repository.
twalthr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 4f65c79 [hotfix][docs][table] Document the new
This is an automated email from the ASF dual-hosted git repository.
knaufk pushed a commit to branch release-1.14
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.14 by this push:
new dc78e66 [Hotfix][doc] Fix typo in ja
wangyang0918 commented on a change in pull request #29:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/29#discussion_r816555181
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultDeploymentValidator.java
###
asfgit closed pull request #28:
URL: https://github.com/apache/flink-kubernetes-operator/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
asfgit closed pull request #29:
URL: https://github.com/apache/flink-kubernetes-operator/pull/29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
gyfora pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git.
from a5ecd44 [FLINK-26356] Directly use service name to make up rest
endpoint
new 38c366d [FLINK-
This is an automated email from the ASF dual-hosted git repository.
gyfora pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
commit 38c366de0d8fa11751051eadbddcf19cb1f31e8f
Author: Gyula Fora
AuthorDate: Fri Feb 25 15:45:42 2022 +0100
This is an automated email from the ASF dual-hosted git repository.
gyfora pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
commit 61799f33905fb93c2e90599c0439a5df03190506
Author: bgeng777
AuthorDate: Tue Mar 1 13:49:47 2022 +0800
54 matches
Mail list logo
