wangyang0918 removed a comment on pull request #40:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/40#issuecomment-1058898913
cc @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
gyfora commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819339549
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##
@@ -109,6 +110,
gyfora commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819339549
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##
@@ -109,6 +110,
This is an automated email from the ASF dual-hosted git repository.
jark pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from acab7e0 [hotfix][connector/kafka] Cleanup unused helper method in
KafkaTestEnvironmentImpl
add 8d9489d [FLINK-25
gyfora merged pull request #36:
URL: https://github.com/apache/flink-kubernetes-operator/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
gyfora pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
The following commit(s) were added to refs/heads/main by this push:
new d7f9482 [FLINK-26436] InformerEv
wangyang0918 commented on pull request #39:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/39#issuecomment-1058900671
@leinenglian Please create a ticket
[here](https://issues.apache.org/jira/projects/FLINK/issues) if you believe it
is a bug.
When an agreement is reached
wangyang0918 commented on pull request #40:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/40#issuecomment-1058898913
cc @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wangyang0918 opened a new pull request #40:
URL: https://github.com/apache/flink-kubernetes-operator/pull/40
When we compile the flink-kubernetes-operator, we could find the following
overlapping classes of fabric8 kubernetes client dependencies. I propose to add
a flink-kubernetes-shaded
SteNicholas commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r81937
##
File path: README.md
##
@@ -83,3 +83,29 @@ Considering the cost of running the builds, the stability,
and the maintainabili
All th
Aitozi commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1058841888
> I'm ok with `k8soperator` :) . But I think the `PrometheusReporter` should
already handle the illegal metric name. I will take a closer look then.
@morhid
wangyang0918 commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819269364
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##
@@ -109,6
tweise commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819255456
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##
@@ -109,6 +110,
tweise commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819252985
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##
@@ -109,6 +110,
SteNicholas commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819238796
##
File path: README.md
##
@@ -83,3 +83,29 @@ Considering the cost of running the builds, the stability,
and the maintainabili
All th
This is an automated email from the ASF dual-hosted git repository.
wangyang0918 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
commit f25960db293c729196c0dd29a13d032cbf2a1890
Author: Matyas Orhidi
AuthorDate: Mon Feb 28 18:48:58 20
This is an automated email from the ASF dual-hosted git repository.
wangyang0918 pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git.
from a9a4781 [FLINK-26447] Clean up webhook jar and dependency management
new 1b90737 [hotfi
wangyang0918 merged pull request #33:
URL: https://github.com/apache/flink-kubernetes-operator/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
This is an automated email from the ASF dual-hosted git repository.
wangyang0918 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
commit 1b90737d5fa2af6e7452c682f75f4d04311890fd
Author: Matyas Orhidi
AuthorDate: Mon Feb 28 16:46:25 20
wangyang0918 commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819222369
##
File path: README.md
##
@@ -83,3 +83,29 @@ Considering the cost of running the builds, the stability,
and the maintainabili
All t
wangyang0918 commented on a change in pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#discussion_r819215977
##
File path: README.md
##
@@ -84,3 +84,62 @@ Considering the cost of running the builds, the stability,
and the maintainabili
All t
This is an automated email from the ASF dual-hosted git repository.
leonard pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from ffe353a [FLINK-26049][checkpoint] Adding CheckpointStatsTracker logic
without pending checkpoint
add 5064765
wangyang0918 commented on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1058750206
For this configuration, maybe we could set the rest service exposed type to
`ClusterIP` in `FlinkUtils#loadDefaultConfig()` if it is not configured
explicit
wangyang0918 commented on pull request #36:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/36#issuecomment-1058745253
> I fixed the comments @wangyang0918 . Btw this feature will not be required
in the future, as the operator SDK community is adding built in support for
thi
tweise commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819198680
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18 @
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819130686
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819125410
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##
@@ -109,6 +110
tweise commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819110232
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18 @
tweise commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819106604
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/JobReconciler.java
##
@@ -109,6 +110,
morhidi edited a comment on pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#issuecomment-1058520122
> @morhidi what happens when the user simultaneously changes the deployment
spec and annotates for savepoint?
>
> Seems like in that case savepointi
morhidi commented on pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#issuecomment-1058520122
> @morhidi what happens when the user simultaneously changes the deployment
spec and annotates for savepoint?
>
> Seems like in that case savepointing will
gyfora commented on pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#issuecomment-1058487105
@morhidi what happens when the user simultaneously changes the deployment
spec and annotates for savepoint?
Seems like in that case savepointing will be ex
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819047486
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
gyfora commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819015544
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18 @
gyfora commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r819014844
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18 @
morhidi commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1058295882
`k8soperator ` it is then :) @gyfora @Aitozi @SteNicholas , PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit ffe353a305e677340d344d3fa45994536757e323
Author: fanrui <1996fan...@gmail.com>
AuthorDate: Mon Feb 28 18:12:34 2022 +08
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 33e3b75bb74dad5f75ad0bea788906e24c3df4e8
Author: fanrui <1996fan...@gmail.com>
AuthorDate: Mon Feb 28 17:45:12 2022 +08
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 5ce2e062cdb1c7dfd7e641cd7f10de04440a0583
Author: fanrui <1996fan...@gmail.com>
AuthorDate: Mon Feb 28 11:35:09 2022 +08
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 26d7c09 [FLINK-26407][end-to-end-tests] Increase timeouts for
MetricsAvailabilityITCase.
new 5ce2e06 [FLINK
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818824911
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/SavepointUtils.java
##
@@ -0,0 +1,43 @@
+
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818819491
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
SteNicholas commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818809377
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/SavepointUtils.java
##
@@ -0,0 +1,43
gyfora commented on pull request #36:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/36#issuecomment-1058201396
I fixed the comments @wangyang0918 . Btw this feature will not be required
in the future, as the operator SDK community is adding built in support for
this as we
mbalassi commented on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1058184615
Thanks @wangyang0918!
I missed the loadbalancer issue, because I was testing with a job the had
the following in the flinkConfig: 😄
```
kubernetes.
gyfora merged pull request #37:
URL: https://github.com/apache/flink-kubernetes-operator/pull/37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
gyfora pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
The following commit(s) were added to refs/heads/main by this push:
new a9a4781 [FLINK-26447] Clean up w
wangyang0918 commented on a change in pull request #36:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/36#discussion_r818740156
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/OperatorUtils.java
##
@@ -0,0 +1,64
wangyang0918 commented on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1058088824
> Hi @wangyang0918!
>
> Could you specify what the issue you encountered is? I have tested cases
similar to the one you mention and did not run into p
wangyang0918 commented on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1058085167
I think we might have following issues what cause the k8s operator could not
work.
* FLINK-26436, we are watching the deployment in all namespaces
* Th
This is an automated email from the ASF dual-hosted git repository.
lzljs3620320 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-table-store.git
The following commit(s) were added to refs/heads/master by this push:
new 2765184 [hotfix] Let FileStore
mbalassi removed a comment on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1058049770
Hi @wangyang0918!
Could you specify what the issue you encountered is? I have tested cases
similar to the one you mention and did not run into pro
mbalassi commented on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1058049770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
SteNicholas commented on pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#issuecomment-1058049497
@gyfora, I have verified the above commit which is validated successly and
previously I didn't remove all flink dependencies in `flink-kubernetes-webhook`
mo
gyfora commented on pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#issuecomment-1058045383
> Please check this commit:
[gyfora@80f020b](https://github.com/gyfora/flink-kubernetes-operator/commit/80f020b3915aee2fdafdc1a38f09c14764d6150e)
>
> Seems
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818655194
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/SavepointUtils.java
##
@@ -0,0 +1,43 @@
+
gyfora commented on pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#issuecomment-1058041198
Please check this commit:
https://github.com/gyfora/flink-kubernetes-operator/commit/80f020b3915aee2fdafdc1a38f09c14764d6150e
Seems to work for me
--
T
SteNicholas commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818642022
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169
SteNicholas commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818639806
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/SavepointUtils.java
##
@@ -0,0 +1,43
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818634529
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818627177
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818631505
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818631505
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
morhidi commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818627177
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169,18
SteNicholas commented on a change in pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#discussion_r818624385
##
File path:
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##
@@ -168,4 +169
SteNicholas commented on a change in pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#discussion_r818615013
##
File path: docker-entrypoint.sh
##
@@ -31,7 +31,8 @@ elif [ "$1" = "operator" ]; then
elif [ "$1" = "webhook" ]; then
echo "St
morhidi commented on pull request #38:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/38#issuecomment-1058006348
cc @wangyang0918 @gyfora @tweise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
SteNicholas commented on a change in pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#discussion_r818615013
##
File path: docker-entrypoint.sh
##
@@ -31,7 +31,8 @@ elif [ "$1" = "operator" ]; then
elif [ "$1" = "webhook" ]; then
echo "St
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a commit to branch release-1.13
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.13 by this push:
new 0bfb320 [FLINK-26407][end-to-end-tes
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a commit to branch release-1.14
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/release-1.14 by this push:
new 2b32f3c1 [FLINK-26407][end-to-end-tes
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
The following commit(s) were added to refs/heads/master by this push:
new 26d7c09 [FLINK-26407][end-to-end-tests] Increase
Aitozi edited a comment on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057985804
I'm ok with `k8soperator` :) . But I think the `PrometheusReporter` should
already handle the illegal metric name. I will take a closer look then.
--
Thi
Aitozi commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057985804
I'm ok with `k8soperator` :) . But I think the `PrometheusReporter` should
also handle the illegal metric name. I will take a look then.
--
This is an automated
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from ec25a4d [FLINK-24474] set default for taskmanager.host
add 932934a [FLINK-26352][runtime-web] Add missing licen
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from fbfdb0e [FLINK-25958][runtime] Report failed statistic if adding of
completed checkpoint to checkpoint store fails
gyfora commented on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1057977092
@wangyang0918 do you mean that we have to create an additional role for the
operator itself?
--
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
mapohl pushed a commit to branch dev-master
in repository https://gitbox.apache.org/repos/asf/flink-docker.git
The following commit(s) were added to refs/heads/dev-master by this push:
new 14abb80 [FLINK-24474] reset taskm
gyfora commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057973817
I dont mind the `k8soperator` if the number doesnt cause a problem 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
wangyang0918 commented on pull request #35:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/35#issuecomment-1057969100
@mbalassi Sorry for the late response. I am afraid after this change, the
k8s operator could not work well if the flink-kubernetes-operator runs in
`default
SteNicholas edited a comment on pull request #36:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/36#issuecomment-1057525338
@gyfora , in general, the pull request LGTM. Could you please add the unit
tests for `FlinkDeploymentController`?
--
This is an automated message fr
SteNicholas edited a comment on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057952808
@morhidi, what about naming to `k8soperator`? cc @gyfora WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message
SteNicholas commented on pull request #36:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/36#issuecomment-1057959644
@gyfora, thanks for your updates of the tests. There are something else
conflicts here and please resolve the conflicts.
--
This is an automated message fr
SteNicholas commented on a change in pull request #36:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/36#discussion_r818573486
##
File path:
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentControllerTest.java
#
gyfora commented on pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#issuecomment-1057958237
I will test and merge this later today! thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
SteNicholas commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057952808
@morhidi, what about naming to `k8soperator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
SteNicholas commented on pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#issuecomment-1057941063
@gyfora, sorry for the mistake to validate the changes on kubeclient using
directly executing the java command.
--
This is an automated message from the Ap
morhidi commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057931763
> > @Aitozi @SteNicholas how about calling the group `kubernetesoperator`.
To align with `jobmanager`, `taskmanager` used in core flink. It seems to be
more safe
SteNicholas commented on a change in pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#discussion_r818544131
##
File path: docker-entrypoint.sh
##
@@ -31,7 +31,8 @@ elif [ "$1" = "operator" ]; then
elif [ "$1" = "webhook" ]; then
echo "St
gyfora commented on a change in pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#discussion_r818539338
##
File path: docker-entrypoint.sh
##
@@ -31,7 +31,8 @@ elif [ "$1" = "operator" ]; then
elif [ "$1" = "webhook" ]; then
echo "Startin
gyfora commented on a change in pull request #37:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/37#discussion_r818539179
##
File path: docker-entrypoint.sh
##
@@ -31,7 +31,8 @@ elif [ "$1" = "operator" ]; then
elif [ "$1" = "webhook" ]; then
echo "Startin
SteNicholas commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057913062
> @Aitozi @SteNicholas how about calling the group `kubernetesoperator`. To
align with `jobmanager`, `taskmanager` used in core flink. It seems to be more
sa
morhidi commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057901353
> @morhidi Thanks for the updating. Regarding to the group name, I check the
code in
`org.apache.flink.metrics.prometheus.AbstractPrometheusReporter#replaceInval
asfgit closed pull request #35:
URL: https://github.com/apache/flink-kubernetes-operator/pull/35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: c
This is an automated email from the ASF dual-hosted git repository.
mbalassi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git
The following commit(s) were added to refs/heads/main by this push:
new f977e12 [FLINK-26308] Limit RB
Aitozi commented on pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#issuecomment-1057894381
@morhidi Thanks for the updating. Regarding to the group name, I check the
code in
`org.apache.flink.metrics.prometheus.AbstractPrometheusReporter#replaceInvalidC
morhidi commented on a change in pull request #33:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/33#discussion_r818493054
##
File path: helm/flink-operator/templates/flink-operator.yaml
##
@@ -46,6 +46,10 @@ spec:
image: "{{ .Values.image.repository
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 906f3244a3febf3bfe5221290d4cd3ad4746765f
Author: Anton Kalashnikov
AuthorDate: Wed Feb 23 16:55:31 2022 +0100
[FL
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit fbfdb0e468356fe71826eb6b185ecda9bc8b1de3
Author: Anton Kalashnikov
AuthorDate: Wed Feb 23 16:59:58 2022 +0100
[FL
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit dc419b5639f68bcb0b773763f24179dd3536d713
Author: Anton Kalashnikov
AuthorDate: Wed Feb 23 16:45:26 2022 +0100
[FL
This is an automated email from the ASF dual-hosted git repository.
pnowojski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 1e7d45d53b7ea7b9cfadf2e293ba790f3a9e90c3
Author: Anton Kalashnikov
AuthorDate: Wed Feb 23 16:41:20 2022 +0100
[FL
1 - 100 of 113 matches
Mail list logo
