[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #41: [FLINK-26377] Extract the Reconciler interface

2022-03-05 Thread GitBox
Aitozi commented on pull request #41: URL: https://github.com/apache/flink-kubernetes-operator/pull/41#issuecomment-1059785574 I have addressed your comments @tweise @SteNicholas , please take a look again. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink-kubernetes-operator] Aitozi commented on pull request #41: [FLINK-26377] Extract the Reconciler interface

2022-03-05 Thread GitBox
Aitozi commented on pull request #41: URL: https://github.com/apache/flink-kubernetes-operator/pull/41#issuecomment-1059785481 > > I introduced the enum Mode to distinguish the different run mode in this pr, It is for internal use now, If we have the consensus for the operator supported m

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #41: [FLINK-26377] Extract the Reconciler interface

2022-03-05 Thread GitBox
Aitozi commented on a change in pull request #41: URL: https://github.com/apache/flink-kubernetes-operator/pull/41#discussion_r820117650 ## File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/FlinkReconciler.java ## @@ -0,0 +1,40

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #41: [FLINK-26377] Extract the Reconciler interface

2022-03-05 Thread GitBox
Aitozi commented on a change in pull request #41: URL: https://github.com/apache/flink-kubernetes-operator/pull/41#discussion_r820117621 ## File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/FlinkReconcilerFactory.java ## @@ -0,

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #41: [FLINK-26377] Extract the Reconciler interface

2022-03-05 Thread GitBox
Aitozi commented on a change in pull request #41: URL: https://github.com/apache/flink-kubernetes-operator/pull/41#discussion_r820114806 ## File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/FlinkReconcilerFactory.java ## @@ -0,

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #41: [FLINK-26377] Extract the Reconciler interface

2022-03-05 Thread GitBox
Aitozi commented on a change in pull request #41: URL: https://github.com/apache/flink-kubernetes-operator/pull/41#discussion_r820113901 ## File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/FlinkReconciler.java ## @@ -0,0 +1,40

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #41: [FLINK-26377] Extract the Reconciler interface

2022-03-05 Thread GitBox
Aitozi commented on a change in pull request #41: URL: https://github.com/apache/flink-kubernetes-operator/pull/41#discussion_r820113889 ## File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/FlinkReconcilerFactory.java ## @@ -0,

[flink] branch master updated: [FLINK-25799][docs] Translate table/filesystem.md page into Chinese (#18655)

2022-03-05 Thread jark
This is an automated email from the ASF dual-hosted git repository. jark pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git The following commit(s) were added to refs/heads/master by this push: new 8f88e8f [FLINK-25799][docs] Translate table/filesy

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #43: [hotfix] Make flink-kubernetes-shaded dep provided

2022-03-05 Thread GitBox
gyfora merged pull request #43: URL: https://github.com/apache/flink-kubernetes-operator/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[flink-kubernetes-operator] branch main updated: [hotfix] Make flink-kubernetes-shaded dep provided

2022-03-05 Thread gyfora
This is an automated email from the ASF dual-hosted git repository. gyfora pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/flink-kubernetes-operator.git The following commit(s) were added to refs/heads/main by this push: new ae5ab71 [hotfix] Make flink-kube

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #40: FLINK-26476 Introduce flink-kubernetes-shaded to avoid overlapping classes

2022-03-05 Thread GitBox
wangyang0918 commented on pull request #40: URL: https://github.com/apache/flink-kubernetes-operator/pull/40#issuecomment-1059722479 My bad. The root cause is that the goals for the Shade Plugin are bound to the package phase. -- This is an automated message from the Apache Git Service.

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #40: FLINK-26476 Introduce flink-kubernetes-shaded to avoid overlapping classes

2022-03-05 Thread GitBox
gyfora commented on pull request #40: URL: https://github.com/apache/flink-kubernetes-operator/pull/40#issuecomment-1059720899 https://github.com/apache/flink-kubernetes-operator/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #43: [hotfix] Make flink-kubernetes-shaded dep provided

2022-03-05 Thread GitBox
gyfora commented on pull request #43: URL: https://github.com/apache/flink-kubernetes-operator/pull/43#issuecomment-1059720881 cc @wangyang0918 @tweise -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request #43: [hotfix] Make flink-kubernetes-shaded dep provided

2022-03-05 Thread GitBox
gyfora opened a new pull request #43: URL: https://github.com/apache/flink-kubernetes-operator/pull/43 Solves a problem where we had a compile dependency on a fatjar which does not really work in many cases. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #40: FLINK-26476 Introduce flink-kubernetes-shaded to avoid overlapping classes

2022-03-05 Thread GitBox
gyfora commented on pull request #40: URL: https://github.com/apache/flink-kubernetes-operator/pull/40#issuecomment-1059719518 I found the problem, will push a fix soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us