[FLINK-8126] [build] Fix and update checkstyle Update to the latest checkstyle version and fix the errors not previously detected.
This closes #5044. Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/c6879cd5 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/c6879cd5 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/c6879cd5 Branch: refs/heads/master Commit: c6879cd59a10f6a371ec6b08b0a38ef34719b054 Parents: 7c07d6d Author: Greg Hogan <c...@greghogan.com> Authored: Tue Nov 21 14:05:53 2017 -0500 Committer: zentol <ches...@apache.org> Committed: Wed Nov 22 11:53:09 2017 +0100 ---------------------------------------------------------------------- .../streaming/connectors/fs/RollingSink.java | 2 -- .../connectors/fs/bucketing/BucketingSink.java | 2 -- .../fs/bucketing/BucketingSinkTest.java | 1 - .../connectors/kafka/FlinkKafkaProducer08.java | 4 +-- .../internals/Kafka08PartitionDiscoverer.java | 1 - .../connectors/kafka/KafkaConsumer08Test.java | 1 - .../connectors/kafka/FlinkKafkaProducer09.java | 4 +-- .../kafka/FlinkKafkaConsumerBaseTest.java | 1 - .../kafka/KafkaAvroTableSourceTestBase.java | 1 - .../connectors/kafka/KafkaTestEnvironment.java | 1 - .../kinesis/FlinkKinesisProducer.java | 1 - .../kinesis/FlinkKinesisConsumerTest.java | 1 - .../kinesis/FlinkKinesisProducerTest.java | 2 -- .../kinesis/util/KinesisConfigUtilTest.java | 1 - .../state/benchmark/RocksDBPerformanceTest.java | 8 ++--- flink-core/pom.xml | 2 +- .../fs/hdfs/HadoopDataInputStreamTest.java | 1 - .../flink/fs/s3hadoop/S3FileSystemFactory.java | 1 - .../flink/fs/s3presto/S3FileSystemFactory.java | 1 - .../fs/s3presto/PrestoS3FileSystemTest.java | 2 -- .../java/typeutils/runtime/AvroSerializer.java | 2 -- .../org/apache/flink/api/java/io/CsvReader.java | 7 +++-- .../store/ZooKeeperMesosWorkerStore.java | 1 - flink-optimizer/pom.xml | 2 +- flink-runtime/pom.xml | 2 +- .../misc/KryoSerializerRegistrationsTest.java | 1 - .../flink/networking/NetworkFailureHandler.java | 1 - .../test/checkpointing/SavepointITCase.java | 1 - .../completeness/TypeInfoTestCoverageTest.java | 1 - pom.xml | 2 +- tools/maven/checkstyle.xml | 32 +++++++++----------- 31 files changed, 31 insertions(+), 59 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java index 9e54775..4cd38a1 100644 --- a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java +++ b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/RollingSink.java @@ -33,12 +33,10 @@ import org.apache.flink.streaming.connectors.fs.bucketing.BucketingSink; import org.apache.flink.util.Preconditions; import org.apache.commons.lang3.time.StopWatch; - import org.apache.hadoop.fs.FSDataOutputStream; import org.apache.hadoop.fs.FileSystem; import org.apache.hadoop.fs.Path; import org.apache.hadoop.hdfs.DistributedFileSystem; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java index 55400c6..bd2ace1 100644 --- a/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java +++ b/flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java @@ -42,12 +42,10 @@ import org.apache.flink.streaming.runtime.tasks.ProcessingTimeService; import org.apache.flink.util.Preconditions; import org.apache.commons.lang3.time.StopWatch; - import org.apache.hadoop.fs.FSDataOutputStream; import org.apache.hadoop.fs.FileSystem; import org.apache.hadoop.fs.Path; import org.apache.hadoop.hdfs.DistributedFileSystem; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java b/flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java index 695b696..d6852ef 100644 --- a/flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java +++ b/flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java @@ -52,7 +52,6 @@ import org.apache.hadoop.hdfs.MiniDFSCluster; import org.apache.hadoop.io.IntWritable; import org.apache.hadoop.io.SequenceFile; import org.apache.hadoop.io.Text; - import org.junit.AfterClass; import org.junit.Assert; import org.junit.Assume; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer08.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer08.java b/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer08.java index 2fce9f9..d2f17d2 100644 --- a/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer08.java +++ b/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer08.java @@ -138,7 +138,7 @@ public class FlinkKafkaProducer08<IN> extends FlinkKafkaProducerBase<IN> { * * @deprecated This is a deprecated constructor that does not correctly handle partitioning when * producing to multiple topics. Use - * {@link FlinkKafkaProducer08(String, SerializationSchema, Properties, FlinkKafkaPartitioner)} instead. + * {@link #FlinkKafkaProducer08(String, SerializationSchema, Properties, FlinkKafkaPartitioner)} instead. */ @Deprecated public FlinkKafkaProducer08(String topicId, SerializationSchema<IN> serializationSchema, Properties producerConfig, KafkaPartitioner<IN> customPartitioner) { @@ -155,7 +155,7 @@ public class FlinkKafkaProducer08<IN> extends FlinkKafkaProducerBase<IN> { * * @deprecated This is a deprecated constructor that does not correctly handle partitioning when * producing to multiple topics. Use - * {@link FlinkKafkaProducer08(String, KeyedSerializationSchema, Properties, FlinkKafkaPartitioner)} instead. + * {@link #FlinkKafkaProducer08(String, KeyedSerializationSchema, Properties, FlinkKafkaPartitioner)} instead. */ @Deprecated public FlinkKafkaProducer08(String topicId, KeyedSerializationSchema<IN> serializationSchema, Properties producerConfig, KafkaPartitioner<IN> customPartitioner) { http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08PartitionDiscoverer.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08PartitionDiscoverer.java b/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08PartitionDiscoverer.java index 9730114..5f7c370 100644 --- a/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08PartitionDiscoverer.java +++ b/flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08PartitionDiscoverer.java @@ -25,7 +25,6 @@ import kafka.javaapi.PartitionMetadata; import kafka.javaapi.TopicMetadata; import kafka.javaapi.TopicMetadataRequest; import kafka.javaapi.consumer.SimpleConsumer; - import org.apache.kafka.clients.consumer.ConsumerConfig; import org.apache.kafka.common.Node; import org.slf4j.Logger; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumer08Test.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumer08Test.java b/flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumer08Test.java index 8627ccb..3fd8bef 100644 --- a/flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumer08Test.java +++ b/flink-connectors/flink-connector-kafka-0.8/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumer08Test.java @@ -27,7 +27,6 @@ import org.apache.flink.streaming.connectors.kafka.internals.Kafka08PartitionDis import org.apache.flink.util.NetUtils; import org.apache.kafka.clients.consumer.ConsumerConfig; - import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Matchers; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer09.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer09.java b/flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer09.java index 946f7e9..407bad5 100644 --- a/flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer09.java +++ b/flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer09.java @@ -142,7 +142,7 @@ public class FlinkKafkaProducer09<IN> extends FlinkKafkaProducerBase<IN> { * * @deprecated This is a deprecated constructor that does not correctly handle partitioning when * producing to multiple topics. Use - * {@link FlinkKafkaProducer09(String, SerializationSchema, Properties, FlinkKafkaPartitioner)} instead. + * {@link #FlinkKafkaProducer09(String, SerializationSchema, Properties, FlinkKafkaPartitioner)} instead. */ @Deprecated public FlinkKafkaProducer09(String topicId, SerializationSchema<IN> serializationSchema, Properties producerConfig, KafkaPartitioner<IN> customPartitioner) { @@ -160,7 +160,7 @@ public class FlinkKafkaProducer09<IN> extends FlinkKafkaProducerBase<IN> { * * @deprecated This is a deprecated constructor that does not correctly handle partitioning when * producing to multiple topics. Use - * {@link FlinkKafkaProducer09(String, org.apache.flink.streaming.util.serialization.KeyedDeserializationSchema, Properties, FlinkKafkaPartitioner)} instead. + * {@link #FlinkKafkaProducer09(String, org.apache.flink.streaming.util.serialization.KeyedDeserializationSchema, Properties, FlinkKafkaPartitioner)} instead. */ @Deprecated public FlinkKafkaProducer09(String topicId, KeyedSerializationSchema<IN> serializationSchema, Properties producerConfig, KafkaPartitioner<IN> customPartitioner) { http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java index 59ce666..168cfd5 100644 --- a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java +++ b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java @@ -45,7 +45,6 @@ import org.apache.flink.util.Preconditions; import org.apache.flink.util.SerializedValue; import org.apache.commons.collections.map.LinkedMap; - import org.junit.Assert; import org.junit.Test; import org.mockito.Matchers; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSourceTestBase.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSourceTestBase.java b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSourceTestBase.java index 871a6f6..557a20f 100644 --- a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSourceTestBase.java +++ b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSourceTestBase.java @@ -25,7 +25,6 @@ import org.apache.flink.table.api.Types; import org.apache.avro.Schema; import org.apache.avro.specific.SpecificRecordBase; - import org.junit.Test; import java.sql.Timestamp; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java index 6851474..8a287d3 100644 --- a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java +++ b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestEnvironment.java @@ -28,7 +28,6 @@ import org.apache.flink.streaming.util.serialization.KeyedDeserializationSchemaW import org.apache.flink.streaming.util.serialization.KeyedSerializationSchema; import kafka.server.KafkaServer; - import org.apache.kafka.clients.consumer.ConsumerRecord; import java.util.ArrayList; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java b/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java index 28aa4b3..2256073 100644 --- a/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java +++ b/flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java @@ -36,7 +36,6 @@ import com.amazonaws.services.kinesis.producer.UserRecordResult; import com.google.common.util.concurrent.FutureCallback; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java index 78ca160..2b1fcf4 100644 --- a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java +++ b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java @@ -48,7 +48,6 @@ import org.apache.flink.streaming.util.serialization.SimpleStringSchema; import com.amazonaws.services.kinesis.model.HashKeyRange; import com.amazonaws.services.kinesis.model.SequenceNumberRange; import com.amazonaws.services.kinesis.model.Shard; - import org.junit.Assert; import org.junit.Rule; import org.junit.Test; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducerTest.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducerTest.java b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducerTest.java index 2cd0c17..702ab0b 100644 --- a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducerTest.java +++ b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducerTest.java @@ -34,9 +34,7 @@ import org.apache.flink.util.InstantiationUtil; import com.amazonaws.services.kinesis.producer.KinesisProducer; import com.amazonaws.services.kinesis.producer.KinesisProducerConfiguration; import com.amazonaws.services.kinesis.producer.UserRecordResult; - import com.google.common.util.concurrent.SettableFuture; - import org.junit.Assert; import org.junit.Rule; import org.junit.Test; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java ---------------------------------------------------------------------- diff --git a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java index ddb300e..b52dce2 100644 --- a/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java +++ b/flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtilTest.java @@ -22,7 +22,6 @@ import org.apache.flink.streaming.connectors.kinesis.config.ConsumerConfigConsta import org.apache.flink.streaming.connectors.kinesis.config.ProducerConfigConstants; import com.amazonaws.services.kinesis.producer.KinesisProducerConfiguration; - import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/RocksDBPerformanceTest.java ---------------------------------------------------------------------- diff --git a/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/RocksDBPerformanceTest.java b/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/RocksDBPerformanceTest.java index 1667e55..533196e 100644 --- a/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/RocksDBPerformanceTest.java +++ b/flink-contrib/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/benchmark/RocksDBPerformanceTest.java @@ -77,7 +77,7 @@ public class RocksDBPerformanceTest extends TestLogger { .setCreateIfMissing(true) .setMergeOperatorName(RocksDBKeyedStateBackend.MERGE_OPERATOR_NAME); - final WriteOptions write_options = new WriteOptions() + final WriteOptions writeOptions = new WriteOptions() .setSync(false) .setDisableWAL(true); @@ -88,7 +88,7 @@ public class RocksDBPerformanceTest extends TestLogger { final long beginInsert = System.nanoTime(); for (int i = 0; i < num; i++) { - rocksDB.merge(write_options, keyBytes, valueBytes); + rocksDB.merge(writeOptions, keyBytes, valueBytes); } final long endInsert = System.nanoTime(); log.info("end insert - duration: {} ms", (endInsert - beginInsert) / 1_000_000); @@ -154,7 +154,7 @@ public class RocksDBPerformanceTest extends TestLogger { .setCreateIfMissing(true) .setMergeOperatorName(RocksDBKeyedStateBackend.MERGE_OPERATOR_NAME); - final WriteOptions write_options = new WriteOptions() + final WriteOptions writeOptions = new WriteOptions() .setSync(false) .setDisableWAL(true); @@ -170,7 +170,7 @@ public class RocksDBPerformanceTest extends TestLogger { final long beginInsert = System.nanoTime(); for (int i = 0; i < num; i++) { unsafe.putInt(keyTemplate, offset, i); - rocksDB.put(write_options, keyTemplate, valueBytes); + rocksDB.put(writeOptions, keyTemplate, valueBytes); } final long endInsert = System.nanoTime(); log.info("end insert - duration: {} ms", (endInsert - beginInsert) / 1_000_000); http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-core/pom.xml ---------------------------------------------------------------------- diff --git a/flink-core/pom.xml b/flink-core/pom.xml index d100158..18c84e8 100644 --- a/flink-core/pom.xml +++ b/flink-core/pom.xml @@ -168,7 +168,7 @@ under the License. <dependency> <groupId>com.puppycrawl.tools</groupId> <artifactId>checkstyle</artifactId> - <version>6.19</version> + <version>8.4</version> </dependency> </dependencies> <executions> http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStreamTest.java ---------------------------------------------------------------------- diff --git a/flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStreamTest.java b/flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStreamTest.java index c6cf0eb..21c18bc 100644 --- a/flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStreamTest.java +++ b/flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HadoopDataInputStreamTest.java @@ -23,7 +23,6 @@ import org.apache.flink.core.memory.ByteArrayInputStreamWithPos; import org.apache.hadoop.fs.FSDataInputStream; import org.apache.hadoop.fs.PositionedReadable; import org.apache.hadoop.fs.Seekable; - import org.junit.Assert; import org.junit.Test; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java ---------------------------------------------------------------------- diff --git a/flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java b/flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java index af04952..bd272e5 100644 --- a/flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java +++ b/flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java @@ -25,7 +25,6 @@ import org.apache.flink.runtime.fs.hdfs.HadoopFileSystem; import org.apache.flink.runtime.util.HadoopUtils; import org.apache.hadoop.fs.s3a.S3AFileSystem; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-filesystems/flink-s3-fs-presto/src/main/java/org/apache/flink/fs/s3presto/S3FileSystemFactory.java ---------------------------------------------------------------------- diff --git a/flink-filesystems/flink-s3-fs-presto/src/main/java/org/apache/flink/fs/s3presto/S3FileSystemFactory.java b/flink-filesystems/flink-s3-fs-presto/src/main/java/org/apache/flink/fs/s3presto/S3FileSystemFactory.java index dabbfda..8847dc9 100644 --- a/flink-filesystems/flink-s3-fs-presto/src/main/java/org/apache/flink/fs/s3presto/S3FileSystemFactory.java +++ b/flink-filesystems/flink-s3-fs-presto/src/main/java/org/apache/flink/fs/s3presto/S3FileSystemFactory.java @@ -25,7 +25,6 @@ import org.apache.flink.runtime.fs.hdfs.HadoopFileSystem; import org.apache.flink.runtime.util.HadoopUtils; import com.facebook.presto.hive.PrestoS3FileSystem; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemTest.java ---------------------------------------------------------------------- diff --git a/flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemTest.java b/flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemTest.java index 8b17ccf..7e2d12a 100644 --- a/flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemTest.java +++ b/flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemTest.java @@ -25,9 +25,7 @@ import org.apache.flink.runtime.fs.hdfs.HadoopFileSystem; import com.amazonaws.auth.AWSCredentialsProvider; import com.amazonaws.auth.AWSStaticCredentialsProvider; import com.amazonaws.services.s3.AmazonS3Client; - import com.facebook.presto.hive.PrestoS3FileSystem; - import org.junit.Test; import java.lang.reflect.Field; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-formats/flink-avro/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java ---------------------------------------------------------------------- diff --git a/flink-formats/flink-avro/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java b/flink-formats/flink-avro/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java index 228e672..f380199 100644 --- a/flink-formats/flink-avro/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java +++ b/flink-formats/flink-avro/src/main/java/org/apache/flink/api/java/typeutils/runtime/AvroSerializer.java @@ -32,12 +32,10 @@ import org.apache.flink.util.InstantiationUtil; import org.apache.flink.util.Preconditions; import com.esotericsoftware.kryo.Kryo; - import org.apache.avro.generic.GenericData; import org.apache.avro.reflect.ReflectDatumReader; import org.apache.avro.reflect.ReflectDatumWriter; import org.apache.avro.util.Utf8; - import org.objenesis.strategy.StdInstantiatorStrategy; import java.io.IOException; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---------------------------------------------------------------------- diff --git a/flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java b/flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java index 684911a..df90d54 100644 --- a/flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java +++ b/flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java @@ -23,15 +23,16 @@ import org.apache.flink.annotation.PublicEvolving; import org.apache.flink.api.java.ExecutionEnvironment; import org.apache.flink.api.java.Utils; import org.apache.flink.api.java.operators.DataSource; -//CHECKSTYLE.OFF: AvoidStarImport|ImportOrder -import org.apache.flink.api.java.tuple.*; -//CHECKSTYLE.ON: AvoidStarImport|ImportOrder import org.apache.flink.api.java.typeutils.PojoTypeInfo; import org.apache.flink.api.java.typeutils.TupleTypeInfo; import org.apache.flink.api.java.typeutils.TypeExtractor; import org.apache.flink.core.fs.Path; import org.apache.flink.util.Preconditions; +//CHECKSTYLE.OFF: AvoidStarImport|ImportOrder +import org.apache.flink.api.java.tuple.*; +//CHECKSTYLE.ON: AvoidStarImport|ImportOrder + import java.util.ArrayList; import java.util.Arrays; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java ---------------------------------------------------------------------- diff --git a/flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java b/flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java index 9f2fa44..d9ca18c 100644 --- a/flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java +++ b/flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/store/ZooKeeperMesosWorkerStore.java @@ -28,7 +28,6 @@ import org.apache.flink.runtime.zookeeper.ZooKeeperVersionedValue; import org.apache.flink.util.FlinkException; import org.apache.mesos.Protos; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-optimizer/pom.xml ---------------------------------------------------------------------- diff --git a/flink-optimizer/pom.xml b/flink-optimizer/pom.xml index 2341a96..ec0e832 100644 --- a/flink-optimizer/pom.xml +++ b/flink-optimizer/pom.xml @@ -87,7 +87,7 @@ under the License. <dependency> <groupId>com.puppycrawl.tools</groupId> <artifactId>checkstyle</artifactId> - <version>6.19</version> + <version>8.4</version> </dependency> </dependencies> <executions> http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-runtime/pom.xml ---------------------------------------------------------------------- diff --git a/flink-runtime/pom.xml b/flink-runtime/pom.xml index ce264f3..4abf658 100644 --- a/flink-runtime/pom.xml +++ b/flink-runtime/pom.xml @@ -264,7 +264,7 @@ under the License. <dependency> <groupId>com.puppycrawl.tools</groupId> <artifactId>checkstyle</artifactId> - <version>6.19</version> + <version>8.4</version> </dependency> </dependencies> <executions> http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-runtime/src/test/java/org/apache/flink/runtime/misc/KryoSerializerRegistrationsTest.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/misc/KryoSerializerRegistrationsTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/misc/KryoSerializerRegistrationsTest.java index cbe9394..a654012 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/misc/KryoSerializerRegistrationsTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/misc/KryoSerializerRegistrationsTest.java @@ -23,7 +23,6 @@ import org.apache.flink.api.java.typeutils.runtime.kryo.KryoSerializer; import com.esotericsoftware.kryo.Kryo; import com.esotericsoftware.kryo.Registration; - import org.junit.Test; import java.io.BufferedReader; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java ---------------------------------------------------------------------- diff --git a/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java b/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java index 383961c..07d2341 100644 --- a/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java +++ b/flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/networking/NetworkFailureHandler.java @@ -30,7 +30,6 @@ import org.jboss.netty.channel.ExceptionEvent; import org.jboss.netty.channel.MessageEvent; import org.jboss.netty.channel.SimpleChannelUpstreamHandler; import org.jboss.netty.channel.socket.ClientSocketChannelFactory; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java ---------------------------------------------------------------------- diff --git a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java index 16e238b..75f0aa4 100644 --- a/flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java +++ b/flink-tests/src/test/java/org/apache/flink/test/checkpointing/SavepointITCase.java @@ -80,7 +80,6 @@ import org.apache.flink.shaded.guava18.com.google.common.collect.Multimap; import akka.actor.ActorRef; import akka.actor.ActorSystem; import akka.testkit.JavaTestKit; - import org.junit.Assert; import org.junit.Rule; import org.junit.Test; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/flink-tests/src/test/java/org/apache/flink/test/completeness/TypeInfoTestCoverageTest.java ---------------------------------------------------------------------- diff --git a/flink-tests/src/test/java/org/apache/flink/test/completeness/TypeInfoTestCoverageTest.java b/flink-tests/src/test/java/org/apache/flink/test/completeness/TypeInfoTestCoverageTest.java index 92ab013..b52884c 100644 --- a/flink-tests/src/test/java/org/apache/flink/test/completeness/TypeInfoTestCoverageTest.java +++ b/flink-tests/src/test/java/org/apache/flink/test/completeness/TypeInfoTestCoverageTest.java @@ -23,7 +23,6 @@ import org.apache.flink.api.common.typeutils.TypeInformationTestBase; import org.apache.flink.util.TestLogger; import org.junit.Test; - import org.reflections.Reflections; import java.lang.reflect.Modifier; http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/pom.xml ---------------------------------------------------------------------- diff --git a/pom.xml b/pom.xml index b70389a..170de59 100644 --- a/pom.xml +++ b/pom.xml @@ -1061,7 +1061,7 @@ under the License. <dependency> <groupId>com.puppycrawl.tools</groupId> <artifactId>checkstyle</artifactId> - <version>6.19</version> + <version>8.4</version> </dependency> </dependencies> <executions> http://git-wip-us.apache.org/repos/asf/flink/blob/c6879cd5/tools/maven/checkstyle.xml ---------------------------------------------------------------------- diff --git a/tools/maven/checkstyle.xml b/tools/maven/checkstyle.xml index 514453e..a0168b0 100644 --- a/tools/maven/checkstyle.xml +++ b/tools/maven/checkstyle.xml @@ -64,12 +64,6 @@ This file is based on the checkstyle file of Apache Beam. <!--<property name="fileNamePattern" value=".*Tests\.java$" />--> <!--</module>--> - <!-- Allow use of comment to suppress javadocstyle --> - <module name="SuppressionCommentFilter"> - <property name="offCommentFormat" value="CHECKSTYLE.OFF\: ([\w\|]+)"/> - <property name="onCommentFormat" value="CHECKSTYLE.ON\: ([\w\|]+)"/> - <property name="checkFormat" value="$1"/> - </module> <module name="SuppressionFilter"> <property name="file" value="${checkstyle.suppressions.file}" default="suppressions.xml" /> </module> @@ -90,6 +84,13 @@ This file is based on the checkstyle file of Apache Beam. <!-- All Java AST specific tests live under TreeWalker module. --> <module name="TreeWalker"> + <!-- Allow use of comment to suppress javadocstyle --> + <module name="SuppressionCommentFilter"> + <property name="offCommentFormat" value="CHECKSTYLE.OFF\: ([\w\|]+)"/> + <property name="onCommentFormat" value="CHECKSTYLE.ON\: ([\w\|]+)"/> + <property name="checkFormat" value="$1"/> + </module> + <!-- FLINK CUSTOM CHECKS @@ -263,8 +264,8 @@ This file is based on the checkstyle file of Apache Beam. <property name="allowMissingThrowsTags" value="true"/> <property name="allowThrowsTagsForSubclasses" value="true"/> <property name="allowUndeclaredRTE" value="true"/> - <!-- This check sometimes failed for with "Unable to get class information for @throws tag" for custom exceptions --> - <property name="suppressLoadErrors" value="true"/> + <!-- This check sometimes failed for with "Unable to get class information for @throws tag" for custom exceptions --> + <property name="suppressLoadErrors" value="true"/> </module> <!-- Check that paragraph tags are used correctly in Javadoc. --> @@ -484,15 +485,15 @@ This file is based on the checkstyle file of Apache Beam. --> <module name="EmptyLineSeparator"> - <!-- Checks for empty line separator between tokens. The only + <!-- Checks for empty line separator between tokens. The only excluded token is VARIABLE_DEF, allowing class fields to be declared on consecutive lines. --> - <property name="allowMultipleEmptyLines" value="false"/> - <property name="allowMultipleEmptyLinesInsideClassMembers" value="false"/> - <property name="tokens" value="PACKAGE_DEF, IMPORT, CLASS_DEF, - INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, - CTOR_DEF"/> + <property name="allowMultipleEmptyLines" value="false"/> + <property name="allowMultipleEmptyLinesInsideClassMembers" value="false"/> + <property name="tokens" value="PACKAGE_DEF, IMPORT, CLASS_DEF, + INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, + CTOR_DEF"/> </module> <module name="WhitespaceAround"> @@ -559,9 +560,6 @@ This file is based on the checkstyle file of Apache Beam. <property name="severity" value="error"/> </module> - <!-- Required to support SuppressWarningsComment --> - <module name="FileContentsHolder"/> - </module> </module>