[flink] 01/01: Revert "[FLINK-30567][hive] Fix wrong behavior for insert overwrite with Hive dialect when the table contains uppercase character (#21602) (#21781)"

[jingzhang]

This is an automated email from the ASF dual-hosted git repository.

jingzhang pushed a commit to branch revert-21781-release-1.16-FLINK-30567
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 311a786d1e0e90d173fdeef739faaeb7590382ee
Author: Jing Zhang <beyond1...@gmail.com>
AuthorDate: Mon Jan 30 22:53:20 2023 +0800

    Revert "[FLINK-30567][hive] Fix wrong behavior for insert overwrite with 
Hive dialect when the table contains uppercase character  (#21602) (#21781)"
    
    This reverts commit 63bbd14d24525a94d125fe599900505e4bca74e1.
---
 .../planner/delegation/hive/HiveParserDMLHelper.java    | 11 +----------
 .../apache/flink/connectors/hive/HiveDialectITCase.java | 17 -----------------
 2 files changed, 1 insertion(+), 27 deletions(-)

diff --git 
a/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java
 
b/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java
index 97fb461b7da..fa886195821 100644
--- 
a/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java
+++ 
b/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/HiveParserDMLHelper.java
@@ -316,16 +316,7 @@ public class HiveParserDMLHelper {
                 
topQB.getParseInfo().getInsertOverwriteTables().keySet().stream()
                         .map(String::toLowerCase)
                         .collect(Collectors.toSet())
-                        .contains(tableName.toLowerCase());
-
-        boolean isInsertInto = 
topQB.getParseInfo().isInsertIntoTable(tableName);
-
-        Preconditions.checkArgument(
-                overwrite | isInsertInto,
-                "Inconsistent data structure detected: we are writing to "
-                        + tableName
-                        + ", but it's not in isInsertIntoTable() or 
getInsertOverwriteTables()."
-                        + " This is a bug. Please consider filing an issue.");
+                        .contains(tableName);
 
         Tuple4<ObjectIdentifier, QueryOperation, Map<String, String>, Boolean> 
insertOperationInfo =
                 createInsertOperationInfo(
diff --git 
a/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
 
b/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
index 1f345573d48..32548dd731a 100644
--- 
a/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
+++ 
b/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectITCase.java
@@ -395,23 +395,6 @@ public class HiveDialectITCase {
                 .isEqualTo("[+I[1, a, 100.45], +I[1, b, 100.45], +I[1, c, 
100.45]]");
     }
 
-    @Test
-    public void testInsertOverwrite() throws Exception {
-        tableEnv.executeSql("create table T1(a int, b string)");
-        tableEnv.executeSql("insert into T1 values(1, 'v1')").await();
-        tableEnv.executeSql("create table T2(a int, b string) partitioned by 
(dt string)");
-        tableEnv.executeSql(
-                        "insert overwrite table default.T2 partition (dt = 
'2023-01-01') select * from default.T1")
-                .await();
-        List<Row> rows = queryResult(tableEnv.sqlQuery("select * from T2"));
-        assertThat(rows.toString()).isEqualTo("[+I[1, v1, 2023-01-01]]");
-        tableEnv.executeSql(
-                        "insert overwrite table default.T2 partition (dt = 
'2023-01-01') select * from default.T1")
-                .await();
-        rows = queryResult(tableEnv.sqlQuery("select * from T2"));
-        assertThat(rows.toString()).isEqualTo("[+I[1, v1, 2023-01-01]]");
-    }
-
     @Test
     public void testAlterTable() throws Exception {
         tableEnv.executeSql("create table tbl (x int) 
tblproperties('k1'='v1')");