This is an automated email from the ASF dual-hosted git repository. guoyangze pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit 6f60e6b3b0a55251e63f7fb8ebbd1068990e1b26 Author: Xiangyu Feng <xiangyu...@gmail.com> AuthorDate: Tue Oct 10 16:16:43 2023 +0800 [hotfix][runtime] Fix the typos in DefaultResourceAllocationStrategy comments --- .../slotmanager/DefaultResourceAllocationStrategy.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java index de6eb7b2663..012bfb4d50f 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java @@ -53,13 +53,13 @@ import static org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerUt * resources and cannot fit into the pre-defined total resource profile. * * <p>Note: This strategy tries to find a feasible allocation result, rather than an optimal one (in - * term of resource utilization). It also does not guarantee always finding a feasible solution when - * exist. + * terms of resource utilization). It also does not guarantee always finding a feasible solution + * when exists. * * <p>Note: The current implementation of this strategy is non-optimal, in terms of computation * efficiency. In the worst case, for each distinctly profiled requirement it checks all registered * and pending resources. Further optimization requires complex data structures for ordering - * multi-dimensional resource profiles. The complexity is not necessary. + * multidimensional resource profiles. The complexity is not necessary. */ public class DefaultResourceAllocationStrategy implements ResourceAllocationStrategy { private final ResourceProfile defaultSlotResourceProfile; @@ -71,7 +71,7 @@ public class DefaultResourceAllocationStrategy implements ResourceAllocationStra /** * Always use any matching strategy for pending resources to use as less pending workers as - * possible, so that the rest can be canceled + * possible, so that the rest can be canceled. */ private final ResourceMatchingStrategy pendingResourceMatchingStrategy = AnyMatchingResourceMatchingStrategy.INSTANCE; @@ -144,7 +144,7 @@ public class DefaultResourceAllocationStrategy implements ResourceAllocationStra // to the latest state after a new PendingTaskManager is created, // tryFulFillRequiredResources will not update pendingResources even after new // PendingTaskManagers are created. - // This is because the pendingResources are no longer needed afterwards. + // This is because the pendingResources are no longer needed afterward. tryFulFillRequiredResources( registeredResources, pendingResources, totalCurrentResources, resultBuilder); return resultBuilder.build();