This is an automated email from the ASF dual-hosted git repository. martijnvisser pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/flink.git
commit ffd34d42b6ef2746645fb0373950ce48a6faa28b Author: sammieliu <sammie...@tencent.com> AuthorDate: Mon May 22 12:49:37 2023 +0800 address reveiw comment --- .../flink/connector/hbase/util/HBaseTimestampGenerator.java | 2 +- .../flink/connector/hbase/util/HBaseTimestampGeneratorTest.java | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseTimestampGenerator.java b/flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseTimestampGenerator.java index 6fd0f449889..0126631535d 100644 --- a/flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseTimestampGenerator.java +++ b/flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseTimestampGenerator.java @@ -18,7 +18,7 @@ package org.apache.flink.connector.hbase.util; -/** Generate timestamp for hbase mutation. */ +/** Generate timestamp for HBase mutation. */ public abstract class HBaseTimestampGenerator { private static final long START_SYSTEM_TIME_NANO = System.currentTimeMillis() * 1_000_000L; private static final long START_JVM_TIME_NANO = System.nanoTime(); diff --git a/flink-connectors/flink-connector-hbase-base/src/test/java/org/apache/flink/connector/hbase/util/HBaseTimestampGeneratorTest.java b/flink-connectors/flink-connector-hbase-base/src/test/java/org/apache/flink/connector/hbase/util/HBaseTimestampGeneratorTest.java index 92b6ec1760c..15f414ded35 100644 --- a/flink-connectors/flink-connector-hbase-base/src/test/java/org/apache/flink/connector/hbase/util/HBaseTimestampGeneratorTest.java +++ b/flink-connectors/flink-connector-hbase-base/src/test/java/org/apache/flink/connector/hbase/util/HBaseTimestampGeneratorTest.java @@ -29,15 +29,15 @@ public class HBaseTimestampGeneratorTest { HBaseTimestampGenerator timestampGenerator = HBaseTimestampGenerator.stronglyIncreasing(); long lastTimestamp = 0; for (int i = 0; i < 100_000_000; i++) { - long now = timestampGenerator.get(); + final long now = timestampGenerator.get(); if (lastTimestamp > 0) { - assertTrue(lastTimestamp < now); + assertTrue(now > lastTimestamp); } lastTimestamp = now; } - final long now = timestampGenerator.getCurrentSystemTimeNano(); + final long realNow = timestampGenerator.getCurrentSystemTimeNano(); assertTrue( "The increasing timestamp should not exceed the current actual timestamp after 100 million tests", - lastTimestamp <= now); + realNow >= lastTimestamp); } }