This is an automated email from the ASF dual-hosted git repository.

dwysakowicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 04337dd  [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
04337dd is described below

commit 04337dd94d582033db9729a1888353480a1a3028
Author: Dawid Wysakowicz <dwysakow...@apache.org>
AuthorDate: Fri Apr 17 10:31:39 2020 +0200

    [FLINK-17211] Enable JUnit 4 tests in flink-sql-parser module
    
    Added junit 4 vintage engine to run junit 4 tests in junit 5
    environment.
---
 flink-table/flink-sql-parser/pom.xml | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/flink-table/flink-sql-parser/pom.xml 
b/flink-table/flink-sql-parser/pom.xml
index 87bbf21..dc8946d 100644
--- a/flink-table/flink-sql-parser/pom.xml
+++ b/flink-table/flink-sql-parser/pom.xml
@@ -175,13 +175,22 @@ under the License.
                        <type>test-jar</type>
                </dependency>
                <!-- Because Calcite tests use Junit5 and we extend from its 
SqlParserTest,
-                        add this dependency to make Junit4 tests compatible 
with Junit5 environment. -->
+                        we need the Junit5 runner. -->
                <dependency>
                        <groupId>org.junit.jupiter</groupId>
                        <artifactId>junit-jupiter-engine</artifactId>
                        <version>5.5.2</version>
                        <scope>test</scope>
                </dependency>
+               <!-- As we switched to JUnit5 runner to use the Calcite tests 
infrastructure we need
+                        to add this dependency to make our own Junit4 tests 
compatible with the Junit5
+                        environment.-->
+               <dependency>
+                       <groupId>org.junit.vintage</groupId>
+                       <artifactId>junit-vintage-engine</artifactId>
+                       <version>5.5.2</version>
+                       <scope>test</scope>
+               </dependency>
        </dependencies>
 
        <build>

Reply via email to