This is an automated email from the ASF dual-hosted git repository.

xtsong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 08b9a12  [hotfx][runtime] Add explainations about managed memory 
fraction contracts in StreamingJobGraphGenerator.
08b9a12 is described below

commit 08b9a12403775ef01e3b9c1fc0d115590ee8eb57
Author: Xintong Song <tonysong...@gmail.com>
AuthorDate: Thu Nov 19 18:50:55 2020 +0800

    [hotfx][runtime] Add explainations about managed memory fraction contracts 
in StreamingJobGraphGenerator.
    
    This closes #14135.
---
 .../apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java   | 3 +++
 1 file changed, 3 insertions(+)

diff --git 
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
 
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
index c9a697f..045bf41 100644
--- 
a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
+++ 
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
@@ -1030,6 +1030,9 @@ public class StreamingJobGraphGenerator {
                        final Set<ManagedMemoryUseCase> groupSlotScopeUseCases,
                        final StreamConfig operatorConfig) {
 
+               // For each operator, make sure fractions are set for all use 
cases in the group, even if the operator does not
+               // have the use case (set the fraction to 0.0). This allows us 
to learn which use cases exist in the group from
+               // either one of the stream configs.
                if (groupResourceSpec.equals(ResourceSpec.UNKNOWN)) {
                        for (Map.Entry<ManagedMemoryUseCase, Integer> entry : 
groupManagedMemoryWeights.entrySet()) {
                                final ManagedMemoryUseCase useCase = 
entry.getKey();

Reply via email to