Re: [PR] chore(java): add comments for loop unrolling. [incubator-fury]

2024-04-06 Thread via GitHub
chaokunyang merged PR #1450: URL: https://github.com/apache/incubator-fury/pull/1450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] chore(java): add comments for loop unrolling. [incubator-fury]

2024-04-06 Thread via GitHub
LiangliangSui commented on PR #1450: URL: https://github.com/apache/incubator-fury/pull/1450#issuecomment-2041108710 > @LiangliangSui There are some conflict between your branch and main branch, could you resolve the conflict? Updated, ptal. -- This is an automated message from the

Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]

2024-04-05 Thread via GitHub
chaokunyang commented on PR #1450: URL: https://github.com/apache/incubator-fury/pull/1450#issuecomment-2040991342 @LiangliangSui There are some conflict between your branch and main branch, could you resolve the conflict? -- This is an automated message from the Apache Git Service. To re

Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]

2024-04-05 Thread via GitHub
chaokunyang commented on code in PR #1450: URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1554535283 ## java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java: ## @@ -1316,24 +1316,15 @@ public int readPositiveVarInt() { } private int

Re: [PR] chore(java): Add comments for loop unrolling [incubator-fury]

2024-04-02 Thread via GitHub
LiangliangSui commented on code in PR #1450: URL: https://github.com/apache/incubator-fury/pull/1450#discussion_r1549004814 ## java/fury-core/src/main/java/org/apache/fury/memory/MemoryBuffer.java: ## @@ -1316,24 +1316,15 @@ public int readPositiveVarInt() { } private in