Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-1998975821 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_15) [incubator-gluten]

2024-03-14 Thread via GitHub
yma11 commented on PR #4965: URL: https://github.com/apache/incubator-gluten/pull/4965#issuecomment-1998964658 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [CORE] Add Complete case match in PullOutPreProject [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 commented on PR #4968: URL: https://github.com/apache/incubator-gluten/pull/4968#issuecomment-1998942739 cc @zzcclp @ulysses-you, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add Complete case match in PullOutPreProject [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4968: URL: https://github.com/apache/incubator-gluten/pull/4968#issuecomment-1998937430 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add Complete case match in PullOutPreProject [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4968: URL: https://github.com/apache/incubator-gluten/pull/4968#issuecomment-1998937231 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Add Complete case match in PullOutPreProject [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 opened a new pull request, #4968: URL: https://github.com/apache/incubator-gluten/pull/4968 ## What changes were proposed in this pull request? Since ClickHouse has an optimizer rule `MergeTwoPhasesHashBaseAggregate` which will merge two aggregates and change the

Re: [PR] [GLUTEN-3378][VL] Feat: Support read iceberg mor table for Velox backend [incubator-gluten]

2024-03-14 Thread via GitHub
GlutenPerfBot commented on PR #4779: URL: https://github.com/apache/incubator-gluten/pull/4779#issuecomment-1998927078 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Update iceberg version to 1.4.3 for Spark 3.3 and above [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4967: URL: https://github.com/apache/incubator-gluten/pull/4967#issuecomment-1998924900 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Update iceberg version to 1.4.3 for Spark 3.3 and above [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4967: URL: https://github.com/apache/incubator-gluten/pull/4967#issuecomment-1998924754 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Update iceberg version to 1.4.3 for Spark 3.3 and above [incubator-gluten]

2024-03-14 Thread via GitHub
yma11 opened a new pull request, #4967: URL: https://github.com/apache/incubator-gluten/pull/4967 ## What changes were proposed in this pull request? Update iceberg version to 1.4.3 for Spark 3.3 and above, as v1.3.1 is not compatible with Spark 3.5. Note that iceberg's latest

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-199992 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4796][VL] Force fallback for orc char type scan [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-199555 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4675][CH] Support write mergetree to s3 [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4676: URL: https://github.com/apache/incubator-gluten/pull/4676#issuecomment-1998887916 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-3378][VL] Feat: Support read iceberg mor table for Velox backend (#4779)

2024-03-14 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 80bb0cff3 [GLUTEN-3378][VL] Feat:

Re: [PR] [GLUTEN-3378][VL] Feat: Support read iceberg mor table for Velox backend [incubator-gluten]

2024-03-14 Thread via GitHub
zhouyuan merged PR #4779: URL: https://github.com/apache/incubator-gluten/pull/4779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1998886038 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-14 Thread via GitHub
kerwin-zk commented on code in PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#discussion_r1525712679 ## pom.xml: ## @@ -47,7 +47,7 @@ 3.2 3.4.2 spark-sql-columnar-shims-spark32 -0.3.0-incubating +0.3.2-incubating Review Comment:

Re: [PR] [GLUTEN-4896] Upgrade Spark33 version to Spark3.3.4 [incubator-gluten]

2024-03-14 Thread via GitHub
zwangsheng commented on PR #4897: URL: https://github.com/apache/incubator-gluten/pull/4897#issuecomment-1998872024 > I think this may need to upgrade the docker image which contains Spark 331 code https://github.com/apache/incubator-gluten/blob/main/.github/workflows/velox_be.yml#L177

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-14 Thread via GitHub
ulysses-you commented on code in PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#discussion_r1525702778 ## gluten-celeborn/common/src/main/java/org/apache/spark/shuffle/gluten/celeborn/CelebornShuffleManager.java: ## @@ -284,24 +300,57 @@ public

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-14 Thread via GitHub
ulysses-you commented on code in PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#discussion_r1525704092 ## gluten-celeborn/common/src/main/java/org/apache/spark/shuffle/gluten/celeborn/CelebornShuffleManager.java: ## @@ -284,24 +300,57 @@ public

Re: [PR] [GLUTEN-4896] Upgrade Spark33 version to Spark3.3.4 [incubator-gluten]

2024-03-14 Thread via GitHub
zwangsheng commented on PR #4897: URL: https://github.com/apache/incubator-gluten/pull/4897#issuecomment-1998863357 > I think this may need to upgrade the docker image which contains Spark 331 code https://github.com/apache/incubator-gluten/blob/main/.github/workflows/velox_be.yml#L177

Re: [PR] [Velox] add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-14 Thread via GitHub
gaoyangxiaozhu commented on PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#issuecomment-1998857707 @zhouyuan / @yma11 / @zhli1142015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-1998852635 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [GLUTEN-4263][VL] Compression type 2 not supported [incubator-gluten]

2024-03-14 Thread via GitHub
zhztheplayer commented on issue #4263: URL: https://github.com/apache/incubator-gluten/issues/4263#issuecomment-1998850924 @sagarlakshmipathy @rhh777 @loukey-lj For compression type 2, It might because of lack of compression type LZ4 (not 100% sure about it, the message

Re: [PR] [GLUTEN-4796][VL] Force fallback for orc char type scan [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1998847118 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Crash when writing an array of struct [incubator-gluten]

2024-03-14 Thread via GitHub
zhouyuan commented on issue #4964: URL: https://github.com/apache/incubator-gluten/issues/4964#issuecomment-1998834795 It seems the complex data type is not correctly fallback there https://github.com/apache/incubator-gluten/issues/4110 CC: @JkSelf -- This is an automated

Re: [PR] [GLUTEN-3378][VL] Feat: Support read iceberg mor table for Velox backend [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4779: URL: https://github.com/apache/incubator-gluten/pull/4779#issuecomment-1998828822 https://github.com/apache/incubator-gluten/issues/3378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(incubator-gluten-site) branch asf-site updated: Automatic Site Publish by Buildbot

2024-03-14 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/asf-site by this push: new b78ae4f Automatic

(incubator-gluten-site) branch main updated: fix github page branch issue (#12)

2024-03-14 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new 856a0fd fix github page branch

Re: [PR] fix github page branch issue [incubator-gluten-site]

2024-03-14 Thread via GitHub
weiting-chen merged PR #12: URL: https://github.com/apache/incubator-gluten-site/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix github page branch issue [incubator-gluten-site]

2024-03-14 Thread via GitHub
weiting-chen opened a new pull request, #12: URL: https://github.com/apache/incubator-gluten-site/pull/12 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Support read iceberg mor table for Velox backend [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 commented on PR #4779: URL: https://github.com/apache/incubator-gluten/pull/4779#issuecomment-1998785507 > @liujiayi771 There's a small conflict, could you please help to do a rebase? > > thanks, -yuan Done. -- This is an automated message from the Apache Git

Re: [PR] [VL] Enable make_timestamp [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4746: URL: https://github.com/apache/incubator-gluten/pull/4746#issuecomment-1998779875 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix regexp_replace function [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4411: URL: https://github.com/apache/incubator-gluten/pull/4411#issuecomment-1998773893 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Fix regexp_replace function [incubator-gluten]

2024-03-14 Thread via GitHub
PHILO-HE opened a new pull request, #4411: URL: https://github.com/apache/incubator-gluten/pull/4411 ## What changes were proposed in this pull request? In the main code, gluten will make regexp_replace fall back if its last `pos` arg is specified by user with a non-default value. We

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240315) [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4966: URL: https://github.com/apache/incubator-gluten/pull/4966#issuecomment-1998764867 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240315) [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4966: URL: https://github.com/apache/incubator-gluten/pull/4966#issuecomment-1998764180 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240315) [incubator-gluten]

2024-03-14 Thread via GitHub
lwz9103 opened a new pull request, #4966: URL: https://github.com/apache/incubator-gluten/pull/4966 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [GLUTEN-4084][CORE][VL] Verify supported file system [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4086: URL: https://github.com/apache/incubator-gluten/pull/4086#issuecomment-1998760529 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-4084][CORE][VL] Verify supported file system [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] closed pull request #4086: [GLUTEN-4084][CORE][VL] Verify supported file system URL: https://github.com/apache/incubator-gluten/pull/4086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-4251][CH]Bug fix empty as default nullable string [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] closed pull request #4252: [GLUTEN-4251][CH]Bug fix empty as default nullable string URL: https://github.com/apache/incubator-gluten/pull/4252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-4251][CH]Bug fix empty as default nullable string [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4252: URL: https://github.com/apache/incubator-gluten/pull/4252#issuecomment-1998760416 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [VL] Fix regexp_replace function [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] closed pull request #4411: [VL] Fix regexp_replace function URL: https://github.com/apache/incubator-gluten/pull/4411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240119) [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4448: URL: https://github.com/apache/incubator-gluten/pull/4448#issuecomment-1998760213 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [VL] Fix regexp_replace function [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4411: URL: https://github.com/apache/incubator-gluten/pull/4411#issuecomment-1998760318 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240119) [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] closed pull request #4448: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240119) URL: https://github.com/apache/incubator-gluten/pull/4448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-4479][VL] Map unbase64 to a presto function [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4482: URL: https://github.com/apache/incubator-gluten/pull/4482#issuecomment-1998759998 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated

Re: [PR] [VL] run UT skip spark compile [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-1998744849 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
GlutenPerfBot commented on PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958#issuecomment-1998680039 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Daily Update Velox Version (2024_03_15) [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4965: URL: https://github.com/apache/incubator-gluten/pull/4965#issuecomment-1998673981 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_03_15) [incubator-gluten]

2024-03-14 Thread via GitHub
GlutenPerfBot opened a new pull request, #4965: URL: https://github.com/apache/incubator-gluten/pull/4965 Velox Upstream New Commits: ```txt 8f9520868 by Masha Basmanova, Document usage of generic types in Simple Function API (9084) adc016630 by Masha Basmanova, Harden

Re: [PR] [VL] run UT skip spark compile [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-1998660707 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [GLUTEN-4263][VL] Compression type 2 not supported [incubator-gluten]

2024-03-14 Thread via GitHub
sagarlakshmipathy commented on issue #4263: URL: https://github.com/apache/incubator-gluten/issues/4263#issuecomment-1998633580 I'm seeing this on Q95 ``` 24/03/14 22:20:30 ERROR YarnScheduler: Lost executor 7 on ip-10-0-105-199.us-west-2.compute.internal: Container from a bad

[I] Crash when writing an array of struct [incubator-gluten]

2024-03-14 Thread via GitHub
clee704 opened a new issue, #4964: URL: https://github.com/apache/incubator-gluten/issues/4964 ### Backend VL (Velox) ### Bug description This write operation crashes: `spark.sql("select array(struct(1), null)").write.mode("overwrite").save("X")` ### Spark

[I] Hadoop file system options doesn't work [incubator-gluten]

2024-03-14 Thread via GitHub
felipepessoto opened a new issue, #4963: URL: https://github.com/apache/incubator-gluten/issues/4963 ### Backend VL (Velox) ### Bug description The issue happens when running this Delta unit test with Gluten/Velox:

Re: [PR] [DNM] Simple function interface decimal avg test [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4962: URL: https://github.com/apache/incubator-gluten/pull/4962#issuecomment-1997714196 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [DNM] Simple function interface decimal avg test [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 opened a new pull request, #4962: URL: https://github.com/apache/incubator-gluten/pull/4962 ## What changes were proposed in this pull request? Simple function interface decimal avg test. ## How was this patch tested? N/A -- This is an automated

Re: [I] Gluten Roadmap in 2024 [incubator-gluten]

2024-03-14 Thread via GitHub
weiting-chen commented on issue #4709: URL: https://github.com/apache/incubator-gluten/issues/4709#issuecomment-1997647325 > @weiting-chen, for item > > * Data Lake Support([[VL] Unified design for data lake read support in Gluten + Velox 

Re: [PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4961: URL: https://github.com/apache/incubator-gluten/pull/4961#issuecomment-1997642408 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 commented on PR #4961: URL: https://github.com/apache/incubator-gluten/pull/4961#issuecomment-1997643266 cc @rui-mo, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [VL] Add velox decimal avg sum large precision test case [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 opened a new pull request, #4961: URL: https://github.com/apache/incubator-gluten/pull/4961 ## What changes were proposed in this pull request? When the input decimal precision is very large, the precision of sum and avg may exceed 38, and we should not infer the

Re: [PR] [VL] run UT skip spark compile [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-1997529626 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
GlutenPerfBot commented on PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958#issuecomment-1997530002 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] run UT skip spark compile [incubator-gluten]

2024-03-14 Thread via GitHub
zhouyuan commented on code in PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#discussion_r1524931318 ## .github/workflows/velox_be.yml: ## @@ -301,10 +301,19 @@ jobs: $PATH_TO_GLUTEN_TE/$OS_IMAGE_NAME/gha/gha-checkout/exec.sh ' cd

Re: [PR] [DNM]collect scan fallback info [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4960: URL: https://github.com/apache/incubator-gluten/pull/4960#issuecomment-1997462831 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] skip spark comile [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-1997452257 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][Minor] Update micro benchmark [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4959: URL: https://github.com/apache/incubator-gluten/pull/4959#issuecomment-1997439391 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][Minor] Update micro benchmark [incubator-gluten]

2024-03-14 Thread via GitHub
marin-ma opened a new pull request, #4959: URL: https://github.com/apache/incubator-gluten/pull/4959 1. Fix typos in the document 2. Rename option `--write-file` to `--save-output` for saving the output from micro benchmark. The former one can get easily mixed up with another option

(incubator-gluten) branch main updated: Remove glog level config in Scala UT (#4958)

2024-03-14 Thread marong
This is an automated email from the ASF dual-hosted git repository. marong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 58a459bf4 Remove glog level config in

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
marin-ma merged PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
marin-ma commented on PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958#issuecomment-1997412879 @liujiayi771 Thanks for the clean up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-14 Thread via GitHub
zjuwangg commented on code in PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#discussion_r1524811879 ## gluten-ut/spark33/src/test/scala/org/apache/spark/sql/execution/GlutenReplaceHashWithSortAggSuite.scala: ## @@ -72,6 +72,7 @@ class

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 commented on PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958#issuecomment-1997357941 cc @PHILO-HE, @rui-mo, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-1997288825 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] support partial window in Spark 3.5 [incubator-gluten]

2024-03-14 Thread via GitHub
ayushi-agarwal commented on issue #4836: URL: https://github.com/apache/incubator-gluten/issues/4836#issuecomment-1997183192 @JkSelf There are three functions, row_number, rank and dense_rank which are supported by WindowGroupLimit operator in spark. We can map row_number to TopNRowNumber

Re: [PR] [CORE] Refactor the inheritance relationship of joins [incubator-gluten]

2024-03-14 Thread via GitHub
GlutenPerfBot commented on PR #4950: URL: https://github.com/apache/incubator-gluten/pull/4950#issuecomment-1997182502 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Untangle code of TransformPreOverrides [incubator-gluten]

2024-03-14 Thread via GitHub
GlutenPerfBot commented on PR #4888: URL: https://github.com/apache/incubator-gluten/pull/4888#issuecomment-1997085063 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-2163][CH] support aggregate function approx_percentile [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4829: URL: https://github.com/apache/incubator-gluten/pull/4829#issuecomment-1997075713 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-3452][CH]Bug fix decimal divide [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4951: URL: https://github.com/apache/incubator-gluten/pull/4951#issuecomment-1997071471 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Velox] add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#issuecomment-1997064752 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 commented on PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958#issuecomment-1997062078 Hi @marin-ma, Could you help check if we can remove the settings for glog and debug mode? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 commented on PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958#issuecomment-1997060177 After `NativeBenchmarkPlanGenerator`, all test case will use `glog=0`. https://github.com/apache/incubator-gluten/assets/13622031/d88b81d1-73c4-4cc0-8c5b-3590876e1c45;>

Re: [PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4958: URL: https://github.com/apache/incubator-gluten/pull/4958#issuecomment-1997058449 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Remove glog level config in unit test [incubator-gluten]

2024-03-14 Thread via GitHub
liujiayi771 opened a new pull request, #4958: URL: https://github.com/apache/incubator-gluten/pull/4958 ## What changes were proposed in this pull request? Currently, in the Velox backend, the configuration of glog is reused at the process level. If the glog level is set in a test

Re: [PR] [GLUTEN-4943][CH] Reserved padding area in Memory should never be read or written [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4957: URL: https://github.com/apache/incubator-gluten/pull/4957#issuecomment-1997043848 https://github.com/apache/incubator-gluten/issues/4943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4943][CH] Reserved padding area in Memory should never be read or written [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4957: URL: https://github.com/apache/incubator-gluten/pull/4957#issuecomment-1997044126 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4796][VL] Force fallback for orc char type scan [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1997033136 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Refactor the inheritance relationship of joins [incubator-gluten]

2024-03-14 Thread via GitHub
ulysses-you merged PR #4950: URL: https://github.com/apache/incubator-gluten/pull/4950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Results are mismatch with vanilla Spark when get_json_object({"dScore":0.0215434648799772}, "$.dScore") [incubator-gluten]

2024-03-14 Thread via GitHub
kecookier commented on issue #4928: URL: https://github.com/apache/incubator-gluten/issues/4928#issuecomment-1996983543 > Hi @kecookier, it looks the below small patch can fix this issue. Please help verify it. Thanks! > >

Re: [PR] [VL] Daily Update Velox Version (2024_03_14) [incubator-gluten]

2024-03-14 Thread via GitHub
GlutenPerfBot commented on PR #4949: URL: https://github.com/apache/incubator-gluten/pull/4949#issuecomment-1996982788 = Performance report for TPCH SF2000 with Velox backend, for reference only query

[I] [CH] Diff while parse string with blank prefix to number [incubator-gluten]

2024-03-14 Thread via GitHub
taiyang-li opened a new issue, #4956: URL: https://github.com/apache/incubator-gluten/issues/4956 ### Backend CH (ClickHouse) ### Bug description ``` 0: jdbc:hive2://localhost:1/> set spark.gluten.enabled = true; +---++ |

Re: [PR] [VL] skip spark comile [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-1996908525 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] skip spark comile [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-1996908092 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Support read iceberg mor table for Velox backend [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4779: URL: https://github.com/apache/incubator-gluten/pull/4779#issuecomment-1996898448 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support read iceberg mor table for Velox backend [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4779: URL: https://github.com/apache/incubator-gluten/pull/4779#issuecomment-1996890880 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Results are mismatch with vanilla Spark when get_json_object({"dScore":0.0215434648799772}, "$.dScore") [incubator-gluten]

2024-03-14 Thread via GitHub
PHILO-HE commented on issue #4928: URL: https://github.com/apache/incubator-gluten/issues/4928#issuecomment-1996885771 Hi @kecookier, it looks the below small patch can fix this issue. Please help verify it. Thanks!

(incubator-gluten) branch main updated: [VL] Untangle code of TransformPreOverrides (#4888)

2024-03-14 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 52c0a2978 [VL] Untangle code of

Re: [PR] [VL] Untangle code of TransformPreOverrides [incubator-gluten]

2024-03-14 Thread via GitHub
zhztheplayer merged PR #4888: URL: https://github.com/apache/incubator-gluten/pull/4888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4796][VL] Force fallback for orc char type scan [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1996864680 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-14 Thread via GitHub
github-actions[bot] commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1996865247 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >