Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 for Ubuntu and Debian [incubator-gluten]

2024-03-15 Thread via GitHub
GlutenPerfBot commented on PR #4977: URL: https://github.com/apache/incubator-gluten/pull/4977#issuecomment-2001698396 = Performance report for TPCH SF2000 with Velox backend, for reference only query

(incubator-gluten) branch main updated: [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 for Ubuntu and Debian (#4977)

2024-03-15 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 2ca27fb04 [GLUTEN-4973][VL] Upgrade

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 for Ubuntu and Debian [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan merged PR #4977: URL: https://github.com/apache/incubator-gluten/pull/4977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DNM][VL]Support map_from_entries in Gluten [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4667: URL: https://github.com/apache/incubator-gluten/pull/4667#issuecomment-2001488581 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][VL]Support map_from_entries in Gluten [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4667: URL: https://github.com/apache/incubator-gluten/pull/4667#issuecomment-2001413767 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [CH] regexp_extract work with strings with a null value,throw Index value 1 is out of range, should be in [0, 1) [incubator-gluten]

2024-03-15 Thread via GitHub
ditgittube commented on issue #4774: URL: https://github.com/apache/incubator-gluten/issues/4774#issuecomment-2001211254 @liuneng1994 please help me look up this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [GLUTEN-4981] Add MacOS specific .DS_Store file to .gitignore [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4982: URL: https://github.com/apache/incubator-gluten/pull/4982#issuecomment-2001076388 https://github.com/apache/incubator-gluten/issues/4981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Add MacOS specific .DS_Store file to .gitignore [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4982: URL: https://github.com/apache/incubator-gluten/pull/4982#issuecomment-2001066934 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[I] Ignore MacOS specific file: .DS_Store [incubator-gluten]

2024-03-15 Thread via GitHub
xumingming opened a new issue, #4981: URL: https://github.com/apache/incubator-gluten/issues/4981 ### Description `.DS_Store` is a MacOS specific file we need to ignore(seems not much gluten developer using MacOS?) ![Screenshot 2024-03-16 at 09 42

Re: [PR] [VL] Copy the libsodium.so with version number in dynamic packaging [incubator-gluten]

2024-03-15 Thread via GitHub
GlutenPerfBot commented on PR #4978: URL: https://github.com/apache/incubator-gluten/pull/4978#issuecomment-2000912682 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4796][VL] Force fallback for orc char type scan [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-2000881019 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Copy the libsodium.so with version number in dynamic packaging (#4978)

2024-03-15 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new df6f75563 [VL] Copy the libsodium.so

Re: [PR] [VL] Copy the libsodium.so with version number in dynamic packaging [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan merged PR #4978: URL: https://github.com/apache/incubator-gluten/pull/4978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_03_16) [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4980: URL: https://github.com/apache/incubator-gluten/pull/4980#issuecomment-2000725230 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_03_16) [incubator-gluten]

2024-03-15 Thread via GitHub
GlutenPerfBot opened a new pull request, #4980: URL: https://github.com/apache/incubator-gluten/pull/4980 Velox Upstream New Commits: ```txt eee2710b3 by Bikramjeet Vig, Minor refactor in hash build (8933) 82c2ff5cf by Kevin Wilfong, Fix race condition in MultiThreadedTaskCursor

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240316) [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4979: URL: https://github.com/apache/incubator-gluten/pull/4979#issuecomment-2000608874 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240316) [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4979: URL: https://github.com/apache/incubator-gluten/pull/4979#issuecomment-2000608711 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240316) [incubator-gluten]

2024-03-15 Thread via GitHub
lwz9103 opened a new pull request, #4979: URL: https://github.com/apache/incubator-gluten/pull/4979 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Gluten Roadmap in 2024 [incubator-gluten]

2024-03-15 Thread via GitHub
felipepessoto commented on issue #4709: URL: https://github.com/apache/incubator-gluten/issues/4709#issuecomment-2000172899 Thanks @weiting-chen By Delta Deletion Vector support you mean for reads and writes? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-15 Thread via GitHub
zjuwangg commented on code in PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#discussion_r1526517788 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -232,7 +232,24 @@ class SparkPlanExecApiImpl extends

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#issuecomment-191813 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Copy the libsodium.so with version number [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on PR #4978: URL: https://github.com/apache/incubator-gluten/pull/4978#issuecomment-121834 https://github.com/apache/incubator-gluten/assets/13622031/7b0bebff-1d07-44a0-9c3f-c02e6f97b8d3;> -- This is an automated message from the Apache Git Service. To

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 for Ubuntu and Debian [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on PR #4977: URL: https://github.com/apache/incubator-gluten/pull/4977#issuecomment-1999888654 cc @zhouyuan @PHILO-HE, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [VL] Copy the libsodium.so with version number [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on PR #4978: URL: https://github.com/apache/incubator-gluten/pull/4978#issuecomment-1999882567 @PHILO-HE If we not pack and load libsodium, and not use yum to install sodium-devel, it will failed to load libvelox.so just like the description in #4870. -- This is

Re: [PR] [VL] Fix generic benchmark usage when both split and data exists [incubator-gluten]

2024-03-15 Thread via GitHub
Yohahaha commented on PR #4972: URL: https://github.com/apache/incubator-gluten/pull/4972#issuecomment-1999823375 > Thanks. I'm a bit confused about which kind of stage would get such plan that contains both scan and shuffle read. Is it BHJ stage? Could you update in the PR description?

Re: [PR] [VL] Copy the libsodium.so with version number [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on PR #4978: URL: https://github.com/apache/incubator-gluten/pull/4978#issuecomment-1999768830 cc @zhouyuan, @PHILO-HE, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Copy the libsodium.so with version number [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4978: URL: https://github.com/apache/incubator-gluten/pull/4978#issuecomment-1999768103 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Copy the libsodium.so with version number [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 opened a new pull request, #4978: URL: https://github.com/apache/incubator-gluten/pull/4978 ## What changes were proposed in this pull request? #4870 Add libsodium.so in `SharedLibraryLoaderCentos8`. However, it should not link `libsodium.so` to `libsodium.so`, as this would

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_03_15) (#4965)

2024-03-15 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new da137d6a3 [VL] Daily Update Velox

Re: [PR] [VL] Daily Update Velox Version (2024_03_15) [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan merged PR #4965: URL: https://github.com/apache/incubator-gluten/pull/4965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 for Ubuntu and Debian [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4977: URL: https://github.com/apache/incubator-gluten/pull/4977#issuecomment-1999703563 https://github.com/apache/incubator-gluten/issues/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 for Ubuntu and Debian [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 opened a new pull request, #4977: URL: https://github.com/apache/incubator-gluten/pull/4977 ## What changes were proposed in this pull request? Fix #4973 ## How was this patch tested? N/A -- This is an automated message from the Apache Git Service.

Re: [PR] [VL] Add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#issuecomment-1999683760 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
GlutenPerfBot commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999665406 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999665249 @zhouyuan I can continue adapting Ubuntu and Debian. I encountered debugging issues with Boost in my environment, so I submitted a quick fix. -- This is an automated

Re: [I] [VL] remove dynamic packaging and use static packaing [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan commented on issue #4942: URL: https://github.com/apache/incubator-gluten/issues/4942#issuecomment-1999568915 > > We may mention this in dev maillist. > > Hey @zhouyuan @FelixYBW Since we're in Apache incubator community now, if we decide to use dev maillist, better update

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan merged PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated (62746c40e -> 1b47f7323)

2024-03-15 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 62746c40e [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn (#4913) add 1b47f7323

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999563040 @liujiayi771 thanks for the patch, will follow up on ubuntu and other OS. Thanks, -yuan -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan closed issue #4973: [VL] Upgrade boost version to 1.84.0 URL: https://github.com/apache/incubator-gluten/issues/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
gaoyangxiaozhu commented on PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#issuecomment-1999471758 can you help re-trigger for fail job ? @PHILO-HE / @zhouyuan / @zhli1142015 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-15 Thread via GitHub
GlutenPerfBot commented on PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913#issuecomment-1999421094 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] disable some physic plan transform [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on issue #4970: URL: https://github.com/apache/incubator-gluten/issues/4970#issuecomment-1999407298 @RaoZhiRou-Z Yes. But you can check the actual plan node name of the scan in vanilla Spark, is it `FileScan` or `BatchScan` or `HiveTableScan`. There are three kinds

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-1999362810 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Make Gluten project size small [incubator-gluten]

2024-03-15 Thread via GitHub
ulysses-you commented on issue #4976: URL: https://github.com/apache/incubator-gluten/issues/4976#issuecomment-1999351093 > /docs/image/gluten_golden_file_upload.png cc @zwangsheng > 29M./gluten-core/src/test/resources/tpch-data 30M

Re: [PR] [VL] spark_partition_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
gaoyangxiaozhu commented on code in PR #4969: URL: https://github.com/apache/incubator-gluten/pull/4969#discussion_r1526046751 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -609,7 +609,9 @@ class SparkPlanExecApiImpl

Re: [I] [VL] remove dynamic packaging and use static packaing [incubator-gluten]

2024-03-15 Thread via GitHub
boneanxs commented on issue #4942: URL: https://github.com/apache/incubator-gluten/issues/4942#issuecomment-1999310507 > We may mention this in dev maillist. Hey @zhouyuan @FelixYBW Since we're in Apache incubator community now, if we decide to use dev maillist, better update

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
PHILO-HE commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999307183 @boneanxs, let's firstly merge this patch to remove blocking issue for https://github.com/apache/incubator-gluten/pull/4965. As yuan said, package.sh will be deprecated and

Re: [PR] [GLUTEN-4899][VL]Fix build with -Pspark-ut [incubator-gluten]

2024-03-15 Thread via GitHub
ayushi-agarwal commented on PR #4975: URL: https://github.com/apache/incubator-gluten/pull/4975#issuecomment-1999302565 @zhztheplayer @JkSelf Could you please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
boneanxs commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999302314 > the package.sh is outdated for a while, I'm proposing to use static build: #4942 Make sense, I also fount fmt version inside velox is at least 9, but in Ubuntu and

Re: [PR] [GLUTEN-4899][VL]Fix build with -Pspark-ut [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4975: URL: https://github.com/apache/incubator-gluten/pull/4975#issuecomment-1999300651 https://github.com/apache/incubator-gluten/issues/4899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL][4899] Fix build with -Pspark-ut [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4975: URL: https://github.com/apache/incubator-gluten/pull/4975#issuecomment-1999299037 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][4899] Fix build with -Pspark-ut [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4975: URL: https://github.com/apache/incubator-gluten/pull/4975#issuecomment-1999298389 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][4899] Fix build with -Pspark-ut [incubator-gluten]

2024-03-15 Thread via GitHub
ayushi-agarwal opened a new pull request, #4975: URL: https://github.com/apache/incubator-gluten/pull/4975 ## What changes were proposed in this pull request? This change will fix the spark 3.5 build issue with -Pspark-ut (Fixes: \#4899) ## How was this patch tested?

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999279900 the package.sh is outdated for a while, I'm proposing to use static build: https://github.com/apache/incubator-gluten/issues/4942 -- This is an automated message from the

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
boneanxs commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999272516 What abt ubuntu? https://github.com/facebookincubator/velox/pull/8679 also upgrade boost to 1.84 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [VL] Daily Update Velox Version (2024_03_15) [incubator-gluten]

2024-03-15 Thread via GitHub
PHILO-HE commented on PR #4965: URL: https://github.com/apache/incubator-gluten/pull/4965#issuecomment-1999271420 > @PHILO-HE Jiayi made a patch here: #4974 Let's merge #4974 firstly. After that, let's rebase this PR. FYI, this rebase includes some velox code requires higher

Re: [PR] [DNM][VL] check ci apache jenkins [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-1999267954 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_15) [incubator-gluten]

2024-03-15 Thread via GitHub
zhouyuan commented on PR #4965: URL: https://github.com/apache/incubator-gluten/pull/4965#issuecomment-1999255651 @PHILO-HE Jiayi made a patch here: https://github.com/apache/incubator-gluten/pull/4974 -- This is an automated message from the Apache Git Service. To respond to the

(incubator-gluten) branch main updated: [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn (#4913)

2024-03-15 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 62746c40e [GLUTEN-4903][CELEBORN]

Re: [PR] [GLUTEN-4903][CELEBORN] Support multiple versions of Celeborn [incubator-gluten]

2024-03-15 Thread via GitHub
ulysses-you merged PR #4913: URL: https://github.com/apache/incubator-gluten/pull/4913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4796][VL] Force fallback for orc char type scan [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4797: URL: https://github.com/apache/incubator-gluten/pull/4797#issuecomment-1999246849 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#issuecomment-1999242663 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4974: URL: https://github.com/apache/incubator-gluten/pull/4974#issuecomment-1999241216 https://github.com/apache/incubator-gluten/issues/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4973][VL] Upgrade boost version to 1.84.0 [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 opened a new pull request, #4974: URL: https://github.com/apache/incubator-gluten/pull/4974 ## What changes were proposed in this pull request? Fix #4973. ## How was this patch tested? N/A -- This is an automated message from the Apache Git

Re: [PR] [VL] run UT skip spark compile [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4955: URL: https://github.com/apache/incubator-gluten/pull/4955#issuecomment-1999240051 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#issuecomment-1999239603 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#issuecomment-1999236463 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
gaoyangxiaozhu commented on code in PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#discussion_r1525955281 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -609,7 +609,9 @@ class SparkPlanExecApiImpl

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#issuecomment-1999193204 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-1999187799 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Error running VeloxTPCHIcebergSuite [incubator-gluten]

2024-03-15 Thread via GitHub
zhztheplayer commented on issue #4915: URL: https://github.com/apache/incubator-gluten/issues/4915#issuecomment-1999175838 Thanks @liujiayi771! Will have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] disable some physic plan transform [incubator-gluten]

2024-03-15 Thread via GitHub
RaoZhiRou-Z commented on issue #4970: URL: https://github.com/apache/incubator-gluten/issues/4970#issuecomment-1999172533 > @RaoZhiRou-Z I am not very familiar with the CH backend. You need to change the issue title to start with [CH] so that the people related to CH can assist you.

Re: [PR] [DNM][VL] check ci apache jenkins [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4936: URL: https://github.com/apache/incubator-gluten/pull/4936#issuecomment-1999171437 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] disable some physic plan transform [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on issue #4970: URL: https://github.com/apache/incubator-gluten/issues/4970#issuecomment-1999164441 @RaoZhiRou-Z I am not very familiar with the CH backend. You need to change the issue title to start with [CH] so that the people related to CH can assist you. --

Re: [PR] [VL] spark_partition_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
PHILO-HE commented on code in PR #4969: URL: https://github.com/apache/incubator-gluten/pull/4969#discussion_r1525910754 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -609,7 +609,9 @@ class SparkPlanExecApiImpl extends

Re: [PR] [VL] Add spark monotonically_increasing_id function support [incubator-gluten]

2024-03-15 Thread via GitHub
PHILO-HE commented on code in PR #4954: URL: https://github.com/apache/incubator-gluten/pull/4954#discussion_r1525907862 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -609,7 +609,9 @@ class SparkPlanExecApiImpl extends

Re: [PR] [VL] Fix generic benchmark usage when both split and data exists [incubator-gluten]

2024-03-15 Thread via GitHub
marin-ma commented on PR #4972: URL: https://github.com/apache/incubator-gluten/pull/4972#issuecomment-1999156259 Thanks. I'm a bit confused about which kind of stage would get such plan that contains both scan and shuffle read. Is it BHJ stage? Could you update in the PR description?

Re: [I] disable some physic plan transform [incubator-gluten]

2024-03-15 Thread via GitHub
RaoZhiRou-Z commented on issue #4970: URL: https://github.com/apache/incubator-gluten/issues/4970#issuecomment-1999155194 i use clickhouse backend and add (spark.gluten.sql.columnar.filescan = false、spark.gluten.sql.native.writer.enabled = false), but But there are still errors: --

Re: [PR] [VL] Fix generic benchmark usage when both split and data exists [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4972: URL: https://github.com/apache/incubator-gluten/pull/4972#issuecomment-1999146960 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix generic benchmark usage when both split and data exists [incubator-gluten]

2024-03-15 Thread via GitHub
Yohahaha opened a new pull request, #4972: URL: https://github.com/apache/incubator-gluten/pull/4972 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CORE] Add Complete case match in PullOutPreProject [incubator-gluten]

2024-03-15 Thread via GitHub
GlutenPerfBot commented on PR #4968: URL: https://github.com/apache/incubator-gluten/pull/4968#issuecomment-1999139568 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Error running VeloxTPCHIcebergSuite [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on issue #4915: URL: https://github.com/apache/incubator-gluten/issues/4915#issuecomment-1999129442 I know this issue, you need to add a configure in idea. Could you try to set working dir to gluten-iceberg?

Re: [I] disable some physic plan transform [incubator-gluten]

2024-03-15 Thread via GitHub
RaoZhiRou-Z commented on issue #4970: URL: https://github.com/apache/incubator-gluten/issues/4970#issuecomment-1999125981 > Maybe you can use these configurations: > > * spark.gluten.sql.columnar.filescan = false > * spark.gluten.sql.native.writer.enabled = false thanks! i

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-15 Thread via GitHub
ulysses-you commented on code in PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#discussion_r1525886786 ## backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/SparkPlanExecApiImpl.scala: ## @@ -232,7 +232,24 @@ class SparkPlanExecApiImpl extends

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-1999125019 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] disable some physic plan transform [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on issue #4970: URL: https://github.com/apache/incubator-gluten/issues/4970#issuecomment-1999123285 Maybe you can use these configurations: * spark.gluten.sql.columnar.filescan = false * spark.gluten.sql.native.writer.enabled = false -- This is an automated

Re: [PR] [GLUTEN-3378][VL][FOLLOWUP] Use List to store delete file info [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4971: URL: https://github.com/apache/incubator-gluten/pull/4971#issuecomment-1999114947 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-3378][VL][FOLLOWUP] Use List to store delete file info [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4971: URL: https://github.com/apache/incubator-gluten/pull/4971#issuecomment-1999112902 https://github.com/apache/incubator-gluten/issues/3378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Use List to store delete file info [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4971: URL: https://github.com/apache/incubator-gluten/pull/4971#issuecomment-1999111854 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Use List to store delete file info [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 commented on PR #4971: URL: https://github.com/apache/incubator-gluten/pull/4971#issuecomment-1999111516 cc @yma11, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [VL] Use List to store delete file info [incubator-gluten]

2024-03-15 Thread via GitHub
liujiayi771 opened a new pull request, #4971: URL: https://github.com/apache/incubator-gluten/pull/4971 ## What changes were proposed in this pull request? The file information such as `paths` and `starts` stored in `LocalFilesNode` is organized and stored using `List`. Iceberg

Re: [PR] [VL] Daily Update Velox Version (2024_03_15) [incubator-gluten]

2024-03-15 Thread via GitHub
PHILO-HE commented on PR #4965: URL: https://github.com/apache/incubator-gluten/pull/4965#issuecomment-1999098111 @yma11, we have updated centos-8 docker image for fixing the CI failure. Please change the version for all boost libs from 1.72.0 to 1.84.0 in this Gluten script.

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240315) [incubator-gluten]

2024-03-15 Thread via GitHub
baibaichen commented on PR #4966: URL: https://github.com/apache/incubator-gluten/pull/4966#issuecomment-1999094919 we need Merge due to rebase fail with https://github.com/ClickHouse/ClickHouse/pull/61323 -- This is an automated message from the Apache Git Service. To respond to the

(incubator-gluten) branch main updated: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240315) (#4966)

2024-03-15 Thread changchen
Update Clickhouse Version (20240315) (#4966) 0436cb8a4 is described below commit 0436cb8a40e2bacebfb15a8a3d75feb61321606d Author: Wenzheng Liu AuthorDate: Fri Mar 15 15:39:38 2024 +0800 [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240315) (#4966) Co-authored-by: kyligence-git

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240315) [incubator-gluten]

2024-03-15 Thread via GitHub
baibaichen merged PR #4966: URL: https://github.com/apache/incubator-gluten/pull/4966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4875][VL]Support spark sql conf sortBeforeRepartition to avoid stage partial retry casuing result mismatch [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #4872: URL: https://github.com/apache/incubator-gluten/pull/4872#issuecomment-1999093615 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add Complete case match in PullOutPreProject [incubator-gluten]

2024-03-15 Thread via GitHub
ulysses-you merged PR #4968: URL: https://github.com/apache/incubator-gluten/pull/4968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [CORE] Add Complete case match in PullOutPreProject (#4968)

2024-03-15 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new c0b9efc80 [CORE] Add Complete case

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-03-15 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-1999060161 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   >