Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538964666 ## .github/workflows/velox_docker.yml: ## @@ -155,32 +146,39 @@ jobs: name: velox-native-lib-${{github.sha}} path:

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538961770 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

(incubator-gluten) branch main updated (8aefd875e -> eb047b0f6)

2024-03-26 Thread marong
This is an automated email from the ASF dual-hosted git repository. marong pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 8aefd875e [VL] Daily Update Velox Version (2024_03_26) (#5115) add eb047b0f6 [VL] Supports register udf

Re: [PR] [VL] Supports register udf with different signatures [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma merged PR #5104: URL: https://github.com/apache/incubator-gluten/pull/5104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Move memory off-heap conf checks to driver plugin [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5128: URL: https://github.com/apache/incubator-gluten/pull/5128#issuecomment-2020010712 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Move memory off-heap conf checks to driver plugin [incubator-gluten]

2024-03-26 Thread via GitHub
wForget opened a new pull request, #5128: URL: https://github.com/apache/incubator-gluten/pull/5128 ## What changes were proposed in this pull request? Move memory off-heap conf checks to driver plugin to fail quickly when misconfigured ## How was this patch tested?

Re: [PR] Move memory off-heap conf checks to driver plugin [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5128: URL: https://github.com/apache/incubator-gluten/pull/5128#issuecomment-2020010044 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2020007086 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_03_26) [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma merged PR #5115: URL: https://github.com/apache/incubator-gluten/pull/5115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_03_26) (#5115)

2024-03-26 Thread marong
This is an automated email from the ASF dual-hosted git repository. marong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 8aefd875e [VL] Daily Update Velox Version

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019918106 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4884][VL] Call getPartitions once in WholeStageTransformer [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4885: URL: https://github.com/apache/incubator-gluten/pull/4885#issuecomment-2019916469 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2019889392 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019885042 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Results are mismatch with vanilla Spark when get_json_object({"dScore":0.0215434648799772}, "$.dScore") [incubator-gluten]

2024-03-26 Thread via GitHub
kecookier commented on issue #4928: URL: https://github.com/apache/incubator-gluten/issues/4928#issuecomment-2019868668 Hi @PHILO-HE , I have tested it, and that patch can fix the bug. > > Hi @kecookier, it looks the below small patch can fix this issue. Please help verify it.

Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5127: URL: https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2019852660 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5127: URL: https://github.com/apache/incubator-gluten/pull/5127#issuecomment-2019848724 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Velox patch to avoid installing libunwind-dev no longer works [incubator-gluten]

2024-03-26 Thread via GitHub
zhztheplayer opened a new pull request, #5127: URL: https://github.com/apache/incubator-gluten/pull/5127 For the background of this, please refer to https://github.com/apache/incubator-gluten/blob/main/docs/velox-backend-troubleshooting.md#fatal-error-after-native-exception-is-thrown

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
zhouyuan commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538805865 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven run: |

Re: [PR] [VL][DNM]Test Q95 post probe spill [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5063: URL: https://github.com/apache/incubator-gluten/pull/5063#issuecomment-2019827061 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM] Velox test [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4929: URL: https://github.com/apache/incubator-gluten/pull/4929#issuecomment-2019815611 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [MINOR] Remove redundant string format [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5126: URL: https://github.com/apache/incubator-gluten/pull/5126#issuecomment-2019807589 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [MINOR] Remove redundant string format [incubator-gluten]

2024-03-26 Thread via GitHub
wForget opened a new pull request, #5126: URL: https://github.com/apache/incubator-gluten/pull/5126 ## What changes were proposed in this pull request? Minor fix: remove redundant string format ## How was this patch tested? no need -- This is an automated

Re: [PR] [MINOR] Remove redundant string format [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5126: URL: https://github.com/apache/incubator-gluten/pull/5126#issuecomment-2019807959 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support YearMonthIntervalType and enable make_ym_interval [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #4798: URL: https://github.com/apache/incubator-gluten/pull/4798#issuecomment-2019795729 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2019784668 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] Support CollectLimitExec [incubator-gluten]

2024-03-26 Thread via GitHub
guixiaowen opened a new issue, #5125: URL: https://github.com/apache/incubator-gluten/issues/5125 ### Description Support CollectLimitExec -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019564540 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Supports register udf with different signatures [incubator-gluten]

2024-03-26 Thread via GitHub
marin-ma commented on PR #5104: URL: https://github.com/apache/incubator-gluten/pull/5104#issuecomment-2019523715 @PHILO-HE Could you help to review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [VL][MINOR] Refactor operator/function tests [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on PR #5037: URL: https://github.com/apache/incubator-gluten/pull/5037#issuecomment-2019517217 @rui-mo, do you have any comment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [GLUTEN-5123][INFRA]set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2019514210 https://github.com/apache/incubator-gluten/issues/5123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2019512640 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5124: URL: https://github.com/apache/incubator-gluten/pull/5124#issuecomment-2019512369 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] set up java and maven according to os in build_bundle_package.yml [incubator-gluten]

2024-03-26 Thread via GitHub
dcoliversun opened a new pull request, #5124: URL: https://github.com/apache/incubator-gluten/pull/5124 ## What changes were proposed in this pull request? Set up java and maven according to os in build_bundle_package.yml (Fixes: \#5123) ## How was this patch tested?

(incubator-gluten) branch main updated: fix spark35 ut build (#5111)

2024-03-26 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 766ada5dc fix spark35 ut build (#5111)

Re: [PR] [Gluten][Spark 3.5] Fix spark35 ut build [incubator-gluten]

2024-03-26 Thread via GitHub
FelixYBW merged PR #5111: URL: https://github.com/apache/incubator-gluten/pull/5111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019477532 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] Build bundle package in Github actions failed with centos:8 [incubator-gluten]

2024-03-26 Thread via GitHub
dcoliversun opened a new issue, #5123: URL: https://github.com/apache/incubator-gluten/issues/5123 ### Problem description https://github.com/dcoliversun/gluten/actions/runs/8431129692/job/23089193957 With centos:8, `Build bundle package` fails with error ```plain

Re: [I] Build bundle package in Github actions failed with centos:8 [incubator-gluten]

2024-03-26 Thread via GitHub
dcoliversun commented on issue #5123: URL: https://github.com/apache/incubator-gluten/issues/5123#issuecomment-2019476409 @wangyum could you please have a look :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019472931 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

<    1   2