Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240404) [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5289: URL: https://github.com/apache/incubator-gluten/pull/5289#issuecomment-2036229122 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: Fix build due to https://github.com/ClickHouse/ClickHouse/pull/62170 (#5291)

2024-04-03 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 54461b8ba Fix build due to

Re: [PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-04-03 Thread via GitHub
baibaichen merged PR #5291: URL: https://github.com/apache/incubator-gluten/pull/5291 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-04-03 Thread via GitHub
baibaichen commented on PR #5291: URL: https://github.com/apache/incubator-gluten/pull/5291#issuecomment-2036227947 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1550938563 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1238,53 @@ class TestOperator extends

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1550938563 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1238,53 @@ class TestOperator extends

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1550934905 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1236,34 @@ class TestOperator extends

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#issuecomment-2036208853 > @rui-mo This PR is ready to review. At the begin, the test failures are the result that I set the expectedAnswer in `checkAnswer` to `df.show`. In spark, timestamp behaves

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1550934905 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1236,34 @@ class TestOperator extends

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
rui-mo commented on PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#issuecomment-2036192553 @PHILO-HE Could you help confirm? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-5219][CH]Fix the table metadata sync issue for the CH backend [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5221: URL: https://github.com/apache/incubator-gluten/pull/5221#issuecomment-2036119725 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][DOC] Reformat velox-backend-support-progress.md and add regr_avgx regr_avgy regr_count [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5292: URL: https://github.com/apache/incubator-gluten/pull/5292#issuecomment-2036080414 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][DOC] Reformat velox-backend-support-progress.md and add regr_avgx regr_avgy regr_count [incubator-gluten]

2024-04-03 Thread via GitHub
liujiayi771 opened a new pull request, #5292: URL: https://github.com/apache/incubator-gluten/pull/5292 ## What changes were proposed in this pull request? * Reformat Function support markdown table. * Add regr_avgx regr_avgy regr_count. ## How was this patch tested?

Re: [PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5291: URL: https://github.com/apache/incubator-gluten/pull/5291#issuecomment-2035999092 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-04-03 Thread via GitHub
baibaichen opened a new pull request, #5291: URL: https://github.com/apache/incubator-gluten/pull/5291 ## What changes were proposed in this pull request? Fix build due to https://github.com/ClickHouse/ClickHouse/pull/62170, which avoids public dependency on `CurrentThread.h` and

Re: [PR] [CH][Minor] Fix build due to Clickhouse Refactor [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5291: URL: https://github.com/apache/incubator-gluten/pull/5291#issuecomment-2035998882 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240404) [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5289: URL: https://github.com/apache/incubator-gluten/pull/5289#issuecomment-2035994323 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_04_04) [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5290: URL: https://github.com/apache/incubator-gluten/pull/5290#issuecomment-2035832324 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Enable unix_date Spark function [incubator-gluten]

2024-04-03 Thread via GitHub
acvictor commented on PR #5287: URL: https://github.com/apache/incubator-gluten/pull/5287#issuecomment-2035826135 @PHILO-HE can you please review? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [VL] Some queries have performance regression on release-1.1 compared to version 20230831 [incubator-gluten]

2024-04-03 Thread via GitHub
kecookier commented on issue #5251: URL: https://github.com/apache/incubator-gluten/issues/5251#issuecomment-2035800510 DAG of the stage. ![image](https://github.com/apache/incubator-gluten/assets/3390068/652e34af-be10-4567-ac3a-14a1714982c8) -- This is an automated message from the

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240404) [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5289: URL: https://github.com/apache/incubator-gluten/pull/5289#issuecomment-2035758471 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240404) [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5289: URL: https://github.com/apache/incubator-gluten/pull/5289#issuecomment-2035759775 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240404) [incubator-gluten]

2024-04-03 Thread via GitHub
kyligence-git opened a new pull request, #5289: URL: https://github.com/apache/incubator-gluten/pull/5289 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-4917][VL] Enable iceberg/delta in new CI [incubator-gluten]

2024-04-03 Thread via GitHub
GlutenPerfBot commented on PR #5230: URL: https://github.com/apache/incubator-gluten/pull/5230#issuecomment-2035371125 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Update weekday Spark function mapping [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5288: URL: https://github.com/apache/incubator-gluten/pull/5288#issuecomment-2035278972 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Update weekday Spark function mapping [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5288: URL: https://github.com/apache/incubator-gluten/pull/5288#issuecomment-2035278651 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Enable unix_date Spark function [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5287: URL: https://github.com/apache/incubator-gluten/pull/5287#issuecomment-2035267421 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable unix_date Spark function [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5287: URL: https://github.com/apache/incubator-gluten/pull/5287#issuecomment-2035190709 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable unix_date Spark function [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5287: URL: https://github.com/apache/incubator-gluten/pull/5287#issuecomment-2035189949 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Enable make_date Spark function [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5286: URL: https://github.com/apache/incubator-gluten/pull/5286#issuecomment-2035168584 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Enable make_date Spark function [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5286: URL: https://github.com/apache/incubator-gluten/pull/5286#issuecomment-2035169040 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Use collect_list aggregate function in velox [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5285: URL: https://github.com/apache/incubator-gluten/pull/5285#issuecomment-2034993498 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Use collect_list aggregate function in velox [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5285: URL: https://github.com/apache/incubator-gluten/pull/5285#issuecomment-2034993928 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Use collect_list aggregate function in velox [incubator-gluten]

2024-04-03 Thread via GitHub
liujiayi771 opened a new pull request, #5285: URL: https://github.com/apache/incubator-gluten/pull/5285 ## What changes were proposed in this pull request? https://github.com/facebookincubator/velox/pull/9231 implemented a new `collect_list` aggregate function based on the semantics

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
dcoliversun commented on PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#issuecomment-2034747357 @rui-mo This PR is ready to review. At the begin, the test failures are the result that I set the expectedAnswer in `checkAnswer` to `df.show`. In spark, timestamp behaves

Re: [PR] [VL] Daily Update Velox Version (2024_04_03) [incubator-gluten]

2024-04-03 Thread via GitHub
GlutenPerfBot commented on PR #5272: URL: https://github.com/apache/incubator-gluten/pull/5272#issuecomment-2034567489 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-03 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2034525510 https://github.com/apache/incubator-gluten/issues/5248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [VL] Some queries have performance regression on release-1.1 compared to version 20230831 [incubator-gluten]

2024-04-03 Thread via GitHub
FelixYBW commented on issue #5251: URL: https://github.com/apache/incubator-gluten/issues/5251#issuecomment-2034523338 what's the stage doing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [GLUTEN-4917][VL] Enable iceberg/delta in new CI [incubator-gluten]

2024-04-03 Thread via GitHub
zhouyuan merged PR #5230: URL: https://github.com/apache/incubator-gluten/pull/5230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-4917][VL] Enable iceberg/delta in new CI (#5230)

2024-04-03 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b5b454fc7 [GLUTEN-4917][VL] Enable

Re: [PR] [GLUTEN-4479][VL] Map `unbase64` to corr. Presto function [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on code in PR #5242: URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1549590827 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -144,6 +144,7 @@ class VeloxTestSettings extends

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-04-03 Thread via GitHub
summaryzb commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2034387196 Uniffle run tpcds with only one worker may encounter some stability issues occasionally,so this integration test only run with tpch -- This is an automated message from the

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-04-03 Thread via GitHub
summaryzb commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2034381626 @PHILO-HE PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5182] [CH] fix fail to parse post join filter [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5183: URL: https://github.com/apache/incubator-gluten/pull/5183#issuecomment-2034241994 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2034222613 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5283: URL: https://github.com/apache/incubator-gluten/pull/5283#issuecomment-2034122546 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
dcoliversun commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1549392276 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1238,52 @@ class TestOperator extends

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_03) (#5272)

2024-04-03 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 7c60ec2f5 [VL] Daily Update Velox Version

Re: [PR] [VL][DOC] Update velox-backend-support-progress.md [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE merged PR #5284: URL: https://github.com/apache/incubator-gluten/pull/5284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_04_03) [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE merged PR #5272: URL: https://github.com/apache/incubator-gluten/pull/5272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL][DOC] Update velox-backend-support-progress.md (#5284)

2024-04-03 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new f9a14f97a [VL][DOC] Update

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2034080743 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
dcoliversun commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1549344491 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1238,52 @@ class TestOperator extends

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
rui-mo commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1549362852 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1238,52 @@ class TestOperator extends

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2034062336 Just removed the below supported functions from the above list. Thanks for the contribution! `last_day, unhex, lead, lag, minute, second, may_keys` -- This is an

Re: [PR] [GLUTEN-4479][VL] Map `unbase64` to corr. Presto function [incubator-gluten]

2024-04-03 Thread via GitHub
fyp711 commented on code in PR #5242: URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1549346548 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -144,6 +144,7 @@ class VeloxTestSettings extends

Re: [PR] [GLUTEN-5102][VL] Support cast date as timestamp in velox [incubator-gluten]

2024-04-03 Thread via GitHub
dcoliversun commented on code in PR #5240: URL: https://github.com/apache/incubator-gluten/pull/5240#discussion_r1549344491 ## backends-velox/src/test/scala/org/apache/gluten/execution/TestOperator.scala: ## @@ -1236,4 +1238,52 @@ class TestOperator extends

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2034042510 > @PHILO-HE , I'd like to pick up base64 and unbase64, please. > > (FYI, looks like there was a PR above for unbase64, but it seems to have been closed without

(incubator-gluten) branch main updated: [VL] Support regr_intercept aggregate function (#5273)

2024-04-03 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 7e5b4fc7a [VL] Support regr_intercept

Re: [PR] [VL] Support regr_intercept aggregate function [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE merged PR #5273: URL: https://github.com/apache/incubator-gluten/pull/5273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2034018894 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#issuecomment-2034018443 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][DOC] Update velox-backend-support-progress.md [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5284: URL: https://github.com/apache/incubator-gluten/pull/5284#issuecomment-2034011765 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][DOC] Update velox-backend-support-progress.md [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE opened a new pull request, #5284: URL: https://github.com/apache/incubator-gluten/pull/5284 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5283: URL: https://github.com/apache/incubator-gluten/pull/5283#issuecomment-2034011172 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5283: URL: https://github.com/apache/incubator-gluten/pull/5283#issuecomment-2034010714 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled [incubator-gluten]

2024-04-03 Thread via GitHub
Yohahaha opened a new pull request, #5283: URL: https://github.com/apache/incubator-gluten/pull/5283 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2034004642 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] fix restore meta bug for s3 [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5282: URL: https://github.com/apache/incubator-gluten/pull/5282#issuecomment-2034000371 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] fix restore meta bug for s3 [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5282: URL: https://github.com/apache/incubator-gluten/pull/5282#issuecomment-203364 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Support regr_intercept aggregate function [incubator-gluten]

2024-04-03 Thread via GitHub
liujiayi771 commented on PR #5273: URL: https://github.com/apache/incubator-gluten/pull/5273#issuecomment-2033998589 @PHILO-HE CI passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Fix kParquetWriteTimestampUnit to kParquetWriteTimestampUnitSession [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5281: URL: https://github.com/apache/incubator-gluten/pull/5281#issuecomment-2033995490 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix kParquetWriteTimestampUnit to kParquetWriteTimestampUnitSession [incubator-gluten]

2024-04-03 Thread via GitHub
Yohahaha opened a new pull request, #5281: URL: https://github.com/apache/incubator-gluten/pull/5281 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CH]feat: Support external sort shuffle, reduce shuffle memory usage when the number of partitions is high [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5279: URL: https://github.com/apache/incubator-gluten/pull/5279#issuecomment-2033969819 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4917][VL] Enable iceberg/delta in new CI [incubator-gluten]

2024-04-03 Thread via GitHub
zhouyuan commented on PR #5230: URL: https://github.com/apache/incubator-gluten/pull/5230#issuecomment-2033961750 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5277] Add a notebook example for enabling Gluten in PySpark [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE merged PR #5278: URL: https://github.com/apache/incubator-gluten/pull/5278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated (55818ed78 -> ee7a68bd1)

2024-04-03 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 55818ed78 [VL] Enable array_remove Spark function (#5268) add ee7a68bd1 [GLUTEN-5277] Add a notebook

(incubator-gluten) branch main updated: [VL] Enable array_remove Spark function (#5268)

2024-04-03 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 55818ed78 [VL] Enable array_remove Spark

Re: [PR] [VL] Enable array_remove Spark function [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE merged PR #5268: URL: https://github.com/apache/incubator-gluten/pull/5268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2033933876 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Re-enable some failed CI jobs [incubator-gluten]

2024-04-03 Thread via GitHub
zhztheplayer commented on PR #5224: URL: https://github.com/apache/incubator-gluten/pull/5224#issuecomment-2033922576 Should wait for https://github.com/facebookincubator/velox/pull/9334 to be merged -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [CH][CI] StackOverflowError at java.base/java.security.AccessController.doPrivileged [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE closed issue #5274: [CH][CI] StackOverflowError at java.base/java.security.AccessController.doPrivileged URL: https://github.com/apache/incubator-gluten/issues/5274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [CH][CI] StackOverflowError at java.base/java.security.AccessController.doPrivileged [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on issue #5274: URL: https://github.com/apache/incubator-gluten/issues/5274#issuecomment-2033921533 This issue disappears now. Closing it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [GLUTEN-4917][VL] Enable celeborn test in CI [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE merged PR #5247: URL: https://github.com/apache/incubator-gluten/pull/5247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-4917][VL] Enable celeborn test in CI (#5247)

2024-04-03 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 6b9d97c2a [GLUTEN-4917][VL] Enable

Re: [PR] [GLUTEN-4917][VL] Enable celeborn test in CI [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on code in PR #5247: URL: https://github.com/apache/incubator-gluten/pull/5247#discussion_r1549215779 ## .github/workflows/velox_docker.yml: ## @@ -284,6 +284,52 @@ jobs: # -d=OFFHEAP_SIZE:2g,spark.memory.offHeap.size=2g \ #

Re: [I] [VL] Fix typos in velox-backend-support-progress.md [incubator-gluten]

2024-04-03 Thread via GitHub
zhztheplayer commented on issue #5211: URL: https://github.com/apache/incubator-gluten/issues/5211#issuecomment-2033865889 Closing since fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [VL] Fix typos in velox-backend-support-progress.md [incubator-gluten]

2024-04-03 Thread via GitHub
zhztheplayer closed issue #5211: [VL] Fix typos in velox-backend-support-progress.md URL: https://github.com/apache/incubator-gluten/issues/5211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-4917][VL] Enable celeborn test in CI [incubator-gluten]

2024-04-03 Thread via GitHub
kerwin-zk commented on code in PR #5247: URL: https://github.com/apache/incubator-gluten/pull/5247#discussion_r1549143204 ## .github/workflows/velox_docker.yml: ## @@ -284,6 +284,52 @@ jobs: # -d=OFFHEAP_SIZE:2g,spark.memory.offHeap.size=2g \ #

Re: [PR] [CELEBORN] Whether to compress shuffle data should be aligned with spark.shuffle.compress first [incubator-gluten]

2024-04-03 Thread via GitHub
kerwin-zk commented on PR #5228: URL: https://github.com/apache/incubator-gluten/pull/5228#issuecomment-2033815322 > lgtm, can we update `velox_docker.yml` to make CI work for celeborn only change ? @ulysses-you Just wait until #5114 is merged. -- This is an automated message

Re: [PR] [CELEBORN] Whether to compress shuffle data should be aligned with spark.shuffle.compress first [incubator-gluten]

2024-04-03 Thread via GitHub
ulysses-you commented on PR #5228: URL: https://github.com/apache/incubator-gluten/pull/5228#issuecomment-2033801252 lgtm, can we update `velox_docker.yml` to make CI work for celeborn only change ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CH]feat: Support external sort shuffle, reduce shuffle memory usage when the number of partitions is high [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5279: URL: https://github.com/apache/incubator-gluten/pull/5279#issuecomment-2033782647 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CELEBORN] Whether to compress shuffle data should be aligned with spark.shuffle.compress first [incubator-gluten]

2024-04-03 Thread via GitHub
kerwin-zk commented on PR #5228: URL: https://github.com/apache/incubator-gluten/pull/5228#issuecomment-2033778238 @ulysses-you cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] RAS: Add EnumeratedApplier to manage columnar rule applications when ras is enabled [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5276: URL: https://github.com/apache/incubator-gluten/pull/5276#issuecomment-2033777181 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5219][CH]Fix the table metadata sync issue for the CH backend [incubator-gluten]

2024-04-03 Thread via GitHub
zzcclp commented on code in PR #5221: URL: https://github.com/apache/incubator-gluten/pull/5221#discussion_r1549088356 ## backends-clickhouse/src/main/scala/org/apache/spark/sql/execution/datasources/utils/MergeTreePartsPartitionsUtil.scala: ## @@ -55,6 +55,9 @@ object

Re: [PR] [VL][CL] Add a nightly build job [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5280: URL: https://github.com/apache/incubator-gluten/pull/5280#issuecomment-2033764972 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5219][CH]Fix the table metadata sync issue for the CH backend [incubator-gluten]

2024-04-03 Thread via GitHub
github-actions[bot] commented on PR #5221: URL: https://github.com/apache/incubator-gluten/pull/5221#issuecomment-2033759046 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4917][VL] Enable celeborn test in CI [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on code in PR #5247: URL: https://github.com/apache/incubator-gluten/pull/5247#discussion_r1549065602 ## .github/workflows/velox_docker.yml: ## @@ -284,6 +284,52 @@ jobs: # -d=OFFHEAP_SIZE:2g,spark.memory.offHeap.size=2g \ #

Re: [PR] [GLUTEN-5277] Add a notebook example for enabling Gluten in PySpark [incubator-gluten]

2024-04-03 Thread via GitHub
yma11 commented on code in PR #5278: URL: https://github.com/apache/incubator-gluten/pull/5278#discussion_r1549037971 ## docs/get-started/Work-with-pyspark.ipynb: ## @@ -0,0 +1,145 @@ +{ + "cells": [ + { + "cell_type": "code", + "execution_count": 1, + "id":

Re: [I] [VL] support partial window in Spark 3.5 [incubator-gluten]

2024-04-03 Thread via GitHub
ayushi-agarwal commented on issue #4836: URL: https://github.com/apache/incubator-gluten/issues/4836#issuecomment-2033707688 @JkSelf Apologies for not mentioning it my previous comment. This is drawback of going through this approach, here only performance gain that we will see will come

  1   2   >