Re: [PR] [VL][DOC] Reformat velox-backend-support-progress.md and add regr_avgx regr_avgy regr_count [incubator-gluten]

2024-04-06 Thread via GitHub
Yohahaha merged PR #5292: URL: https://github.com/apache/incubator-gluten/pull/5292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_04_06) [incubator-gluten]

2024-04-06 Thread via GitHub
PHILO-HE closed pull request #5297: [VL] Daily Update Velox Version (2024_04_06) URL: https://github.com/apache/incubator-gluten/pull/5297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_07) (#5299)

2024-04-06 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b96a6ea31 [VL] Daily Update Velox Version

Re: [PR] [VL] Support regr_sxy aggregate function [incubator-gluten]

2024-04-06 Thread via GitHub
PHILO-HE commented on code in PR #5295: URL: https://github.com/apache/incubator-gluten/pull/5295#discussion_r1554821285 ## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala: ## @@ -428,6 +428,25 @@ abstract class

Re: [PR] [VL] Daily Update Velox Version (2024_04_06) [incubator-gluten]

2024-04-06 Thread via GitHub
PHILO-HE commented on PR #5297: URL: https://github.com/apache/incubator-gluten/pull/5297#issuecomment-2041324062 Closing this pr, since covered by https://github.com/apache/incubator-gluten/pull/5299. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [VL] Daily Update Velox Version (2024_04_07) [incubator-gluten]

2024-04-06 Thread via GitHub
PHILO-HE merged PR #5299: URL: https://github.com/apache/incubator-gluten/pull/5299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Re-enable some failed CI jobs

2024-04-06 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 2378d1fd6 [VL] Re-enable some failed CI

Re: [PR] [VL] Re-enable some failed CI jobs [incubator-gluten]

2024-04-06 Thread via GitHub
zhztheplayer merged PR #5224: URL: https://github.com/apache/incubator-gluten/pull/5224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Re-enable some failed CI jobs [incubator-gluten]

2024-04-06 Thread via GitHub
zhztheplayer commented on PR #5224: URL: https://github.com/apache/incubator-gluten/pull/5224#issuecomment-2041319511 Note: Join post-spill is still not working as expected so a Q95 case is still disabled, although the regression was fixed

Re: [PR] [VL] Re-enable some failed CI jobs [incubator-gluten]

2024-04-06 Thread via GitHub
zhztheplayer commented on PR #5224: URL: https://github.com/apache/incubator-gluten/pull/5224#issuecomment-2041317010 @JkSelf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Support regr_sxy aggregate function [incubator-gluten]

2024-04-06 Thread via GitHub
liujiayi771 commented on code in PR #5295: URL: https://github.com/apache/incubator-gluten/pull/5295#discussion_r1554818580 ## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala: ## @@ -428,6 +428,25 @@ abstract class

(incubator-gluten) branch main updated: [GLUTEN-4917][VL][CI] update to use apache/gluten docker (#5186)

2024-04-06 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 7ebfa2347 [GLUTEN-4917][VL][CI] update

Re: [PR] [GLUTEN-4917][VL][CI] update to use apache/gluten docker [incubator-gluten]

2024-04-06 Thread via GitHub
zhouyuan merged PR #5186: URL: https://github.com/apache/incubator-gluten/pull/5186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] RAS: Add EnumeratedApplier to manage columnar rule applications when ras is enabled (#5276)

2024-04-06 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new dc4bc629a [VL] RAS: Add EnumeratedApplier

Re: [PR] [VL] RAS: Add EnumeratedApplier to manage columnar rule applications when ras is enabled [incubator-gluten]

2024-04-06 Thread via GitHub
zhztheplayer merged PR #5276: URL: https://github.com/apache/incubator-gluten/pull/5276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] RAS: Add EnumeratedApplier to manage columnar rule applications when ras is enabled [incubator-gluten]

2024-04-06 Thread via GitHub
zhztheplayer commented on PR #5276: URL: https://github.com/apache/incubator-gluten/pull/5276#issuecomment-2041301797 Thanks for reviewing @PHILO-HE . I'll add some comments to newly added components in further PR. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [VL] RAS: Add EnumeratedApplier to manage columnar rule applications when ras is enabled [incubator-gluten]

2024-04-06 Thread via GitHub
PHILO-HE commented on code in PR #5276: URL: https://github.com/apache/incubator-gluten/pull/5276#discussion_r1554810308 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/heuristic/HeuristicApplier.scala: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2041299324 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Add EnumeratedApplier to manage columnar rule applications when ras is enabled [incubator-gluten]

2024-04-06 Thread via GitHub
zhztheplayer commented on code in PR #5276: URL: https://github.com/apache/incubator-gluten/pull/5276#discussion_r1554809691 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/heuristic/HeuristicApplier.scala: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache

Re: [PR] [VL] RAS: Add EnumeratedApplier to manage columnar rule applications when ras is enabled [incubator-gluten]

2024-04-06 Thread via GitHub
PHILO-HE commented on code in PR #5276: URL: https://github.com/apache/incubator-gluten/pull/5276#discussion_r1554807763 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/heuristic/HeuristicApplier.scala: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240407) [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #5298: URL: https://github.com/apache/incubator-gluten/pull/5298#issuecomment-2041293046 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] support partial window in Spark 3.5 [incubator-gluten]

2024-04-06 Thread via GitHub
JkSelf commented on issue #4836: URL: https://github.com/apache/incubator-gluten/issues/4836#issuecomment-2041285118 @ayushi-agarwal Yes, Method 1 cannot solve the PartialWindow issue; not only is there no performance improvement, but it also fails to address the out-of-memory (oom)

(incubator-gluten) branch main updated: [GLUTEN-5219][CH]Fix the table metadata sync issue for the CH backend (#5221)

2024-04-06 Thread zhangzc
This is an automated email from the ASF dual-hosted git repository. zhangzc pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b0b3a6399 [GLUTEN-5219][CH]Fix the table

Re: [I] [CH]Fix the table metadata sync issue for the CH backend [incubator-gluten]

2024-04-06 Thread via GitHub
zzcclp closed issue #5219: [CH]Fix the table metadata sync issue for the CH backend URL: https://github.com/apache/incubator-gluten/issues/5219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5219][CH]Fix the table metadata sync issue for the CH backend [incubator-gluten]

2024-04-06 Thread via GitHub
zzcclp merged PR #5221: URL: https://github.com/apache/incubator-gluten/pull/5221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5219][CH]Fix the table metadata sync issue for the CH backend [incubator-gluten]

2024-04-06 Thread via GitHub
zzcclp commented on code in PR #5221: URL: https://github.com/apache/incubator-gluten/pull/5221#discussion_r1554800242 ## backends-clickhouse/src/main/scala/org/apache/spark/sql/execution/datasources/utils/MergeTreePartsPartitionsUtil.scala: ## @@ -55,6 +55,9 @@ object

Re: [PR] [GLUTEN-5182] [CH] fix fail to parse post join filter [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #5183: URL: https://github.com/apache/incubator-gluten/pull/5183#issuecomment-2041273882 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled [incubator-gluten]

2024-04-06 Thread via GitHub
Yohahaha commented on code in PR #5283: URL: https://github.com/apache/incubator-gluten/pull/5283#discussion_r1554795692 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala: ## @@ -74,5 +72,6 @@ class GlutenBroadcastJoinSuite

Re: [PR] [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled [incubator-gluten]

2024-04-06 Thread via GitHub
zhztheplayer commented on code in PR #5283: URL: https://github.com/apache/incubator-gluten/pull/5283#discussion_r1554794866 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/joins/GlutenBroadcastJoinSuite.scala: ## @@ -74,5 +72,6 @@ class

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2041269473 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4058][CORE] Support JDK 11 and 17 for Gluten [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #4059: URL: https://github.com/apache/incubator-gluten/pull/4059#issuecomment-2041269466 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated

Re: [PR] [CORE] [UT] Ensure GlutenBroadcastJoinSuite run with Gluten enabled [incubator-gluten]

2024-04-06 Thread via GitHub
Yohahaha commented on PR #5283: URL: https://github.com/apache/incubator-gluten/pull/5283#issuecomment-2041268891 @PHILO-HE please help take a look, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [VL] Fix kParquetWriteTimestampUnit to kParquetWriteTimestampUnitSession [incubator-gluten]

2024-04-06 Thread via GitHub
Yohahaha commented on PR #5281: URL: https://github.com/apache/incubator-gluten/pull/5281#issuecomment-2041268743 @rui-mo please help take a look, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2041266672 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support regr_sxy aggregate function [incubator-gluten]

2024-04-06 Thread via GitHub
yma11 commented on code in PR #5295: URL: https://github.com/apache/incubator-gluten/pull/5295#discussion_r1554778787 ## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxAggregateFunctionsSuite.scala: ## @@ -428,6 +428,25 @@ abstract class

Re: [PR] [VL] Support columnar collect limit [incubator-gluten]

2024-04-06 Thread via GitHub
yma11 commented on PR #5266: URL: https://github.com/apache/incubator-gluten/pull/5266#issuecomment-2041257509 @ulysses-you I noticed that there is an existing [PR](https://github.com/apache/incubator-gluten/pull/5269) about collect limit support but may have some different coverage. You

Re: [PR] [GLUTEN-5125]Support CollectLimitExec #5125 [incubator-gluten]

2024-04-06 Thread via GitHub
yma11 commented on code in PR #5269: URL: https://github.com/apache/incubator-gluten/pull/5269#discussion_r1554762055 ## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxTPCHSuite.scala: ## @@ -259,6 +259,19 @@ abstract class VeloxTPCHSuite extends

[PR] [VL] Daily Update Velox Version (2024_04_07) [incubator-gluten]

2024-04-06 Thread via GitHub
GlutenPerfBot opened a new pull request, #5299: URL: https://github.com/apache/incubator-gluten/pull/5299 Upstream Velox's New Commits: ```txt 84ae6bfd6 by willsfeng, Handling MAP_FAILED in MmapAllocator (9228) a42079c46 by Jialiang Tan, Add early flushed bytes runtime metrics

Re: [PR] [VL] Daily Update Velox Version (2024_04_07) [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #5299: URL: https://github.com/apache/incubator-gluten/pull/5299#issuecomment-2041243160 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240407) [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #5298: URL: https://github.com/apache/incubator-gluten/pull/5298#issuecomment-2041226766 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240407) [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #5298: URL: https://github.com/apache/incubator-gluten/pull/5298#issuecomment-2041226725 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240407) [incubator-gluten]

2024-04-06 Thread via GitHub
kyligence-git opened a new pull request, #5298: URL: https://github.com/apache/incubator-gluten/pull/5298 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Daily Update Velox Version (2024_04_05) [incubator-gluten]

2024-04-06 Thread via GitHub
GlutenPerfBot commented on PR #5294: URL: https://github.com/apache/incubator-gluten/pull/5294#issuecomment-2041220655 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5219][CH]Fix the table metadata sync issue for the CH backend [incubator-gluten]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #5221: URL: https://github.com/apache/incubator-gluten/pull/5221#issuecomment-2041047934 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to