Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#issuecomment-2050989358 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on code in PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#discussion_r1562020106 ## gluten-core/src/test/scala/org/apache/spark/sql/GlutenQueryTest.scala: ## @@ -44,13 +44,18 @@ abstract class GlutenQueryTest extends PlanTest {

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#issuecomment-2050987987 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#issuecomment-2050985263 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] spillRun.rows.empty() Error [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer commented on issue #5348: URL: https://github.com/apache/incubator-gluten/issues/5348#issuecomment-2050983886 I have mirrored the test into Scala and could not reproduce this issue in newest Gluten code. ```scala // with setting spark.memory.offHeap.size=1g

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on code in PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#discussion_r1562000377 ## gluten-core/src/test/scala/org/apache/spark/sql/GlutenQueryTest.scala: ## @@ -44,13 +44,18 @@ abstract class GlutenQueryTest extends PlanTest {

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer commented on code in PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#discussion_r1561998560 ## gluten-core/src/test/scala/org/apache/spark/sql/GlutenQueryTest.scala: ## @@ -44,13 +44,18 @@ abstract class GlutenQueryTest extends PlanTest {

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2050933036 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2050928067 > Hey, @PHILO-HE , what's the plan with concat_ws ? It says "PR Ready" and I see that you have committed an implementation to this branch:

(incubator-gluten) branch main updated: [CORE] Support KnownNullable and KnownNotNull (#5365)

2024-04-11 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 62fc60381 [CORE] Support KnownNullable and

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2050926169 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support KnownNullable and KnownNotNull [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE merged PR #5365: URL: https://github.com/apache/incubator-gluten/pull/5365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#issuecomment-2050922130 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#issuecomment-2050921892 https://github.com/apache/incubator-gluten/issues/5381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 opened a new pull request, #5382: URL: https://github.com/apache/incubator-gluten/pull/5382 ## What changes were proposed in this pull request? Currently in the test method testWithSpecifiedSparkVersion, it uses SPARK_VERSION_SHORT for comparison directly which with value

[I] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 opened a new issue, #5381: URL: https://github.com/apache/incubator-gluten/issues/5381 ### Backend VL (Velox) ### Bug description Currently in the test method `testWithSpecifiedSparkVersion`, it uses `SPARK_VERSION_SHORT` for comparison directly which with value

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2050898351 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2050892440 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix and enable some uts of spark 3.5 [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5379: URL: https://github.com/apache/incubator-gluten/pull/5379#issuecomment-2050880805 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix and enable some uts of spark 3.5 [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5379: URL: https://github.com/apache/incubator-gluten/pull/5379#issuecomment-2050880680 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [I] [CH] HiveText format file read diff from spark [incubator-gluten]

2024-04-11 Thread via GitHub
KevinyhZou closed issue #5208: [CH] HiveText format file read diff from spark URL: https://github.com/apache/incubator-gluten/issues/5208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#issuecomment-2050862217 This PR is pending on fix of [5362](https://github.com/apache/incubator-gluten/issues/5362). -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on PR #5377: URL: https://github.com/apache/incubator-gluten/pull/5377#issuecomment-2050861392 Minor: Update title with association with the issue number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-5341] Support iceberg bucketjoin for Spark3.5 [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#issuecomment-2050852265 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Support iceberg bucketjoin for Spark3.5 [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#issuecomment-2050852091 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(incubator-gluten) branch main updated: [Gluten-5152][CH] fix bugs for optimizing tables on s3 (#5282)

2024-04-11 Thread liuneng
This is an automated email from the ASF dual-hosted git repository. liuneng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new a8b316141 [Gluten-5152][CH] fix bugs for

Re: [PR] [CORE] Upgrade Arrow to 15.0.0 [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5174: URL: https://github.com/apache/incubator-gluten/pull/5174#issuecomment-2050839958 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Gluten-5152][CH] fix bugs for optimizing tables on s3 [incubator-gluten]

2024-04-11 Thread via GitHub
liuneng1994 merged PR #5282: URL: https://github.com/apache/incubator-gluten/pull/5282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5377: URL: https://github.com/apache/incubator-gluten/pull/5377#issuecomment-2050832638 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite [incubator-gluten]

2024-04-11 Thread via GitHub
gaoyangxiaozhu opened a new pull request, #5377: URL: https://github.com/apache/incubator-gluten/pull/5377 Fix Spark 35 UT of GlutenFileMetadataStructSuite SPARK-41896: Filter on row_index and a stored column at the same time SPARK-43450: Filter on full _metadata column struct

Re: [PR] spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5377: URL: https://github.com/apache/incubator-gluten/pull/5377#issuecomment-2050832462 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2050817670 We can keep this PR, after the fix in meta Velox is merged, we can use this PR to remove the ignored tests. -- This is an automated message from the Apache Git Service.

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2050817189 Failure related to https://github.com/facebookincubator/velox/commit/ecf811833da61d951e60f927f745b78969f27213 -- This is an automated message from the Apache Git

Re: [PR] [VL] Fix timestamp precision in broadcast serializer [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5376: URL: https://github.com/apache/incubator-gluten/pull/5376#issuecomment-2050816895 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix timestamp precision in broadcast serializer [incubator-gluten]

2024-04-11 Thread via GitHub
zhli1142015 opened a new pull request, #5376: URL: https://github.com/apache/incubator-gluten/pull/5376 ## What changes were proposed in this pull request? Timestamps data would loss prescision when doing broadcast serialization. ``` import

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2050812702 @yma11 Alright, after my modifications, the TPCH tests are passing. I didn't pay attention to other cases, but I will make sure to get the upstream PR merged as soon as

Re: [I] [VL] Issues related to Timestamp type [incubator-gluten]

2024-04-11 Thread via GitHub
zhouyuan commented on issue #5364: URL: https://github.com/apache/incubator-gluten/issues/5364#issuecomment-2050786937 CC @boneanxs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2050783108 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE merged PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer commented on code in PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#discussion_r1561884835 ## .gitattributes: ## @@ -0,0 +1 @@ +backends-velox/src/test/resources/tpch-approved-plan/** linguist-generated Review Comment: But sadly by

(incubator-gluten) branch main updated: [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test (#5345)

2024-04-11 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 5af585d4c [GLUTEN-5344][VL] Add some

(incubator-gluten) branch main updated: [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded (#5342)

2024-04-11 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new bf820853f [GLUTEN-5309][VL] Enable

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
zhouyuan merged PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2050767148 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2050764207 @liujiayi771 Thanks for trying fix but seems don't cover all the cases. Your fix at velox makes more sense. -- This is an automated message from the Apache Git Service. To

[PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-11 Thread via GitHub
GlutenPerfBot opened a new pull request, #5375: URL: https://github.com/apache/incubator-gluten/pull/5375 Upstream Velox's New Commits: ```txt 0643556a7 by duanmeng, Add pool name regex in TestScopedSpillInjection (9413) efb0213a4 by Masha Basmanova, Optimize cast(JSON as ROW)

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2050744701 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2050692068 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2050691934 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-11 Thread via GitHub
kyligence-git opened a new pull request, #5374: URL: https://github.com/apache/incubator-gluten/pull/5374 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5336][DOC] Update build parameters #5338 [incubator-gluten]

2024-04-11 Thread via GitHub
GlutenPerfBot commented on PR #5340: URL: https://github.com/apache/incubator-gluten/pull/5340#issuecomment-2050662530 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-11 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2050366675 #5372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-11 Thread via GitHub
FelixYBW commented on PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345#issuecomment-2050136502 > @FelixYBW okay to merge this PR? Yes, let's merge it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-11 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2050122134 > #5366 UPdated desc. thank you. do you know which function (cast, avg, round ) caused the issue? -- This is an automated message from the Apache Git

Re: [PR] [GLUTEN-5344][VL] Add some parquet example files from parquet-mr for native read test [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on PR #5345: URL: https://github.com/apache/incubator-gluten/pull/5345#issuecomment-204919 @FelixYBW okay to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2049958234 @zhztheplayer This is another way to fix it, and it won't affect reading partitioned tables. We can use this method to restore the ability to read partitioned tables with

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2049920760 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 opened a new pull request, #5373: URL: https://github.com/apache/incubator-gluten/pull/5373 ## What changes were proposed in this pull request? Fix #5362. ## How was this patch tested? N/A -- This is an automated message from the Apache Git

Re: [I] VeloxTPCHIcebergSuite is failing [incubator-gluten]

2024-04-11 Thread via GitHub
liujiayi771 commented on issue #5362: URL: https://github.com/apache/incubator-gluten/issues/5362#issuecomment-2049878832 https://github.com/facebookincubator/velox/pull/9450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [GLUTEN-5336][DOC] Update build parameters #5338 [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha merged PR #5340: URL: https://github.com/apache/incubator-gluten/pull/5340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-5336][DOC] Update build parameters (#5340)

2024-04-11 Thread yangzy
This is an automated email from the ASF dual-hosted git repository. yangzy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 8abf48f43 [GLUTEN-5336][DOC] Update build

Re: [I] [GLUTEN-5336]update the doc of the velox of build_parameters [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha closed issue #5336: [GLUTEN-5336]update the doc of the velox of build_parameters URL: https://github.com/apache/incubator-gluten/issues/5336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-11 Thread via GitHub
supermem613 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2049850094 Hey, @PHILO-HE , what's the plan with concat_ws ? It says "PR Ready" and I see that you have committed an implementation to this branch:

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2049791908 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix weekofyear function [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on code in PR #5371: URL: https://github.com/apache/incubator-gluten/pull/5371#discussion_r1560956787 ## backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala: ## @@ -747,4 +747,14 @@ class ScalarFunctionsValidateSuite

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2049593587 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
yma11 commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2049593271 > has confict @yma11 Thanks for reminder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[I] [VL] Results are mismatch with Vanilla Spark after multi left-join and complex group-by in release-1.1 [incubator-gluten]

2024-04-11 Thread via GitHub
kecookier opened a new issue, #5372: URL: https://github.com/apache/incubator-gluten/issues/5372 ### Backend VL (Velox) ### Bug description ```SQL select lu.uuid uuid, lu.user_id user_id, lu.poi_id poi_id, ex.1day_exposure

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
gaoyangxiaozhu commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2049514783 has confict @yma11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2049386027 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2049374555 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Fix wrong result for try_add (#5356)

2024-04-11 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 41b002f2e [VL] Fix wrong result for

Re: [PR] [VL] Fix wrong result for try_add [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE merged PR #5356: URL: https://github.com/apache/incubator-gluten/pull/5356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Remove the registry for Velox's prestosql scalar functions [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE commented on PR #5202: URL: https://github.com/apache/incubator-gluten/pull/5202#issuecomment-2049359904 > > > Hi, could you share the current status? > > > > > > @Yohahaha, this pr depends on a velox pr:

Re: [PR] [CORE] Upgrade Arrow to 15.0.0 [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5174: URL: https://github.com/apache/incubator-gluten/pull/5174#issuecomment-2049360983 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Fix weekofyear function [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha opened a new pull request, #5371: URL: https://github.com/apache/incubator-gluten/pull/5371 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Fix weekofyear function [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5371: URL: https://github.com/apache/incubator-gluten/pull/5371#issuecomment-2049349331 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Fix weekofyear function [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha closed pull request #5370: [VL] Fix weekofyear function URL: https://github.com/apache/incubator-gluten/pull/5370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Remove the registry for Velox's prestosql scalar functions [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha commented on PR #5202: URL: https://github.com/apache/incubator-gluten/pull/5202#issuecomment-2049330517 > > Hi, could you share the current status? > > @Yohahaha, this pr depends on a velox pr:

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
zwangsheng commented on code in PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#discussion_r1560744631 ## .gitattributes: ## @@ -0,0 +1 @@ +backends-velox/src/test/resources/tpch-approved-plan/** linguist-generated Review Comment: Nice job! -- This

Re: [PR] [VL] Fix weekofyear function [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5370: URL: https://github.com/apache/incubator-gluten/pull/5370#issuecomment-2049316051 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix weekofyear function [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha opened a new pull request, #5370: URL: https://github.com/apache/incubator-gluten/pull/5370 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(incubator-gluten) 01/01: fix

2024-04-11 Thread yangzy
This is an automated email from the ASF dual-hosted git repository. yangzy pushed a commit to branch fix-week-of-year in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git commit aba3d4fc214d81acd56af5d67f4aba3c1b33bf8a Author: Yang Zhang AuthorDate: Thu Apr 11 17:32:28 2024

(incubator-gluten) branch fix-week-of-year created (now aba3d4fc2)

2024-04-11 Thread yangzy
This is an automated email from the ASF dual-hosted git repository. yangzy pushed a change to branch fix-week-of-year in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git at aba3d4fc2 fix This branch includes the following new commits: new aba3d4fc2 fix The 1

Re: [PR] [VL] Daily Update Velox Version (2024_04_11) [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer merged PR #5360: URL: https://github.com/apache/incubator-gluten/pull/5360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_11) (#5360)

2024-04-11 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 154f8750e [VL] Daily Update Velox Version

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-04-11 Thread via GitHub
jackylee-ch merged PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2049290838 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Add uniffle integration (#3767)

2024-04-11 Thread jackylee
This is an automated email from the ASF dual-hosted git repository. jackylee pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b9408f995 [VL] Add uniffle integration

Re: [PR] [VL] Remove the registry for Velox's prestosql scalar functions [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE commented on PR #5202: URL: https://github.com/apache/incubator-gluten/pull/5202#issuecomment-2049279881 > Hi, could you share the current status? @Yohahaha, this pr depends on a velox pr: https://github.com/facebookincubator/velox/pull/9425. I will try to push the review

Re: [PR] [VL] Remove the registry for Velox's prestosql scalar functions [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha commented on PR #5202: URL: https://github.com/apache/incubator-gluten/pull/5202#issuecomment-2049271513 Hi, could you share the current status? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2049257244 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Exclude golden files from PR diff [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer closed pull request #5368: [VL] Exclude golden files from PR diff URL: https://github.com/apache/incubator-gluten/pull/5368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] [VL] Support GetArrayStructFields [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha opened a new issue, #5369: URL: https://github.com/apache/incubator-gluten/issues/5369 ### Description n/a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2049222344 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Exclude golden files from PR diff [incubator-gluten]

2024-04-11 Thread via GitHub
zhztheplayer opened a new pull request, #5368: URL: https://github.com/apache/incubator-gluten/pull/5368 Still not sure if this could work. https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github -- This is an

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2049223282 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Exclude golden files from PR diff [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5368: URL: https://github.com/apache/incubator-gluten/pull/5368#issuecomment-2049220371 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5309][VL] Enable Spark3.5 UTs with failed ones excluded [incubator-gluten]

2024-04-11 Thread via GitHub
github-actions[bot] commented on PR #5342: URL: https://github.com/apache/incubator-gluten/pull/5342#issuecomment-2049219092 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-11 Thread via GitHub
zwangsheng commented on PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367#issuecomment-2049214173 > @zwangsheng It feels messy that golden files are being considered into PR/contribution line count. Do you think we can binarize the golden files? > Sounds good

  1   2   >