Re: [PR] [GLUTEN-5341] Fix and enable delta UTs for Spark3.5 [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5393: URL: https://github.com/apache/incubator-gluten/pull/5393#issuecomment-2053487589 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5341] Fix and enable delta UTs for Spark3.5 [incubator-gluten]

2024-04-12 Thread via GitHub
yma11 opened a new pull request, #5393: URL: https://github.com/apache/incubator-gluten/pull/5393 ## What changes were proposed in this pull request? Fix and enable delta UTs for Spark3.5 ## How was this patch tested? UT -- This is an automated message from the

Re: [PR] [GLUTEN-5335][VL] Use common name for both celeborn and uniffle [incubator-gluten]

2024-04-12 Thread via GitHub
summaryzb commented on PR #5385: URL: https://github.com/apache/incubator-gluten/pull/5385#issuecomment-2053311663 @jackylee-ch @PHILO-HE PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [GLUTEN-5391][CH] Fix equalTo NaN issue [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5392: URL: https://github.com/apache/incubator-gluten/pull/5392#issuecomment-2053230132 https://github.com/apache/incubator-gluten/issues/5391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CH] Fix equalTo NaN issue (#5391) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5392: URL: https://github.com/apache/incubator-gluten/pull/5392#issuecomment-2053060791 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [CH]equal to NaN result is wrong [incubator-gluten]

2024-04-12 Thread via GitHub
loudongfeng opened a new issue, #5391: URL: https://github.com/apache/incubator-gluten/issues/5391 ### Backend CH (ClickHouse) ### Bug description when value is NaN, but expression value='NaN' will return false for CH backend while spark returns true. Example:

Re: [PR] [GLUTEN-5335][VL] Use common name for both celeborn and uniffle [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5385: URL: https://github.com/apache/incubator-gluten/pull/5385#issuecomment-2052950838 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5335][VL] Use common name for both celeborn and uniffle [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5385: URL: https://github.com/apache/incubator-gluten/pull/5385#issuecomment-2052943766 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4502][VL] Allow TIMESTAMP & complex types in cast expression [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #4509: URL: https://github.com/apache/incubator-gluten/pull/4509#issuecomment-2052912172 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated

Re: [PR] [VL] Enable locate function [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #4791: URL: https://github.com/apache/incubator-gluten/pull/4791#issuecomment-2052912107 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated

Re: [PR] [GLUTEN-5103][VL] Support JVM libhdfs in velox [incubator-gluten]

2024-04-12 Thread via GitHub
zhouyuan commented on PR #5384: URL: https://github.com/apache/incubator-gluten/pull/5384#issuecomment-2052761897 Hi Yang, thanks for the inputs. We are still trying to figure what’s best way to integrate this feature, will definitely keep the original libhdfs3 and allow to optionally

Re: [PR] [VL] Daily Update Velox Version (2024_04_13) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5390: URL: https://github.com/apache/incubator-gluten/pull/5390#issuecomment-2052714053 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_04_13) [incubator-gluten]

2024-04-12 Thread via GitHub
GlutenPerfBot opened a new pull request, #5390: URL: https://github.com/apache/incubator-gluten/pull/5390 Upstream Velox's New Commits: ```txt 7a3607098 by PHILO-HE, Set minimum boost version to 1.77.0 (9094) 80ef831c3 by wutiangan, Enable find static package of gflags (8940)

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240413) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5389: URL: https://github.com/apache/incubator-gluten/pull/5389#issuecomment-2052668066 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240413) [incubator-gluten]

2024-04-12 Thread via GitHub
kyligence-git opened a new pull request, #5389: URL: https://github.com/apache/incubator-gluten/pull/5389 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240413) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5389: URL: https://github.com/apache/incubator-gluten/pull/5389#issuecomment-2052667919 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CH] [Minor] fix ut due to https://github.com/ClickHouse/ClickHouse/pull/61216 [incubator-gluten]

2024-04-12 Thread via GitHub
GlutenPerfBot commented on PR #5388: URL: https://github.com/apache/incubator-gluten/pull/5388#issuecomment-2052637866 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5103][VL] Support JVM libhdfs in velox [incubator-gluten]

2024-04-12 Thread via GitHub
FelixYBW commented on PR #5384: URL: https://github.com/apache/incubator-gluten/pull/5384#issuecomment-2052602276 Is there related changes in oap/velox? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2051978865 with https://github.com/apache/incubator-gluten/pull/5388, we needn't upgrade ch -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240404) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5289: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240404) URL: https://github.com/apache/incubator-gluten/pull/5289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240408) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5312: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240408) URL: https://github.com/apache/incubator-gluten/pull/5312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240403) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5275: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240403) URL: https://github.com/apache/incubator-gluten/pull/5275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240405) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5293: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240405) URL: https://github.com/apache/incubator-gluten/pull/5293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240331) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5217: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240331) URL: https://github.com/apache/incubator-gluten/pull/5217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240411) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5359: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240411) URL: https://github.com/apache/incubator-gluten/pull/5359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240410) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5346: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240410) URL: https://github.com/apache/incubator-gluten/pull/5346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240406) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5296: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240406) URL: https://github.com/apache/incubator-gluten/pull/5296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240401) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5222: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240401) URL: https://github.com/apache/incubator-gluten/pull/5222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240402) [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen closed pull request #5243: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240402) URL: https://github.com/apache/incubator-gluten/pull/5243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-205185 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: fix ut due to https://github.com/ClickHouse/ClickHouse/pull/61216 (#5388)

2024-04-12 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new a06a2fdc8 fix ut due to

Re: [PR] [CH] [Minor] fix ut due to https://github.com/ClickHouse/ClickHouse/pull/61216 [incubator-gluten]

2024-04-12 Thread via GitHub
baibaichen merged PR #5388: URL: https://github.com/apache/incubator-gluten/pull/5388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CH] [Minor] fix ut due to https://github.com/ClickHouse/ClickHouse/pull/61216 [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5388: URL: https://github.com/apache/incubator-gluten/pull/5388#issuecomment-2051630137 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite [incubator-gluten]

2024-04-12 Thread via GitHub
yma11 commented on PR #5377: URL: https://github.com/apache/incubator-gluten/pull/5377#issuecomment-2051625085 > Not sure why this PR's CI was passed but it seems that multiple other PRs are failing on Spark35 UT CI > >

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2051618794 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4483][CH]Improve divide [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5387: URL: https://github.com/apache/incubator-gluten/pull/5387#issuecomment-2051588593 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240412) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5374: URL: https://github.com/apache/incubator-gluten/pull/5374#issuecomment-2051585214 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4483][CH]Improve divide [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5387: URL: https://github.com/apache/incubator-gluten/pull/5387#issuecomment-2051584697 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4483][CH]Improve divide [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5387: URL: https://github.com/apache/incubator-gluten/pull/5387#issuecomment-2051584370 https://github.com/apache/incubator-gluten/issues/4483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4483][CH]Improve divide function [incubator-gluten]

2024-04-12 Thread via GitHub
KevinyhZou commented on PR #4484: URL: https://github.com/apache/incubator-gluten/pull/4484#issuecomment-2051578585 reopen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
zhztheplayer merged PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
zhztheplayer commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2051570322 Failure may be caused by https://github.com/apache/incubator-gluten/pull/5377 -- This is an automated message from the Apache Git Service. To respond to the message,

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_12) (#5375)

2024-04-12 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new fd06368f3 [VL] Daily Update Velox Version

Re: [PR] [VL] Spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite [incubator-gluten]

2024-04-12 Thread via GitHub
zhztheplayer commented on PR #5377: URL: https://github.com/apache/incubator-gluten/pull/5377#issuecomment-2051569793 Not sure why this PR's CI was passed but it seems that multiple other PRs are failing on Spark35 UT CI

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2051512195 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5335][VL] Use common name for both celeborn and uniffle [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5385: URL: https://github.com/apache/incubator-gluten/pull/5385#issuecomment-2051472249 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5381] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5382: URL: https://github.com/apache/incubator-gluten/pull/5382#issuecomment-2051453568 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix year_of_week function [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5386: URL: https://github.com/apache/incubator-gluten/pull/5386#issuecomment-2051366121 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Fix timestamp precision loss in serializer [incubator-gluten]

2024-04-12 Thread via GitHub
zhli1142015 commented on PR #5376: URL: https://github.com/apache/incubator-gluten/pull/5376#issuecomment-2051365100 > Thanks for this fix. Looks like it's already set to true in Velox Spill

Re: [PR] [GLUTEN-4483][CH]Improve divide function [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #4484: URL: https://github.com/apache/incubator-gluten/pull/4484#issuecomment-2051327646 https://github.com/apache/incubator-gluten/issues/4483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(incubator-gluten) branch main updated: [VL] Spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite (#5377)

2024-04-12 Thread zhli
This is an automated email from the ASF dual-hosted git repository. zhli pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 6c989af27 [VL] Spark 3.5: fix and enable

Re: [PR] [VL] Spark 3.5: fix and enable all ut for GlutenFileMetadataStructSuite [incubator-gluten]

2024-04-12 Thread via GitHub
zhli1142015 merged PR #5377: URL: https://github.com/apache/incubator-gluten/pull/5377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-12 Thread via GitHub
Yohahaha commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2051313485 I'd like take get function, as known as GetArrayItem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2051312612 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
zhztheplayer commented on code in PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#discussion_r1562232303 ## .github/workflows/velox_docker.yml: ## @@ -245,7 +245,8 @@ jobs: -d=OFFHEAP_SIZE:6g,spark.memory.offHeap.size=6g \

Re: [PR] [GLUTEN-5335][VL] Use common name for both celeborn and uniffle [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5385: URL: https://github.com/apache/incubator-gluten/pull/5385#issuecomment-2051295932 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5335][VL] Use common name for both celeborn and uniffle [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5385: URL: https://github.com/apache/incubator-gluten/pull/5385#issuecomment-2051295475 https://github.com/apache/incubator-gluten/issues/5335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2051284036 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5103][VL] Support JVM libhdfs in velox [incubator-gluten]

2024-04-12 Thread via GitHub
Yohahaha commented on PR #5384: URL: https://github.com/apache/incubator-gluten/pull/5384#issuecomment-2051281994 will we keep an option to let user disable this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [VL] Fix timestamp precision loss in serializer [incubator-gluten]

2024-04-12 Thread via GitHub
marin-ma commented on PR #5376: URL: https://github.com/apache/incubator-gluten/pull/5376#issuecomment-2051256345 Thanks for this fix. Looks like it's already set to true in Velox Spill

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2051237749 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix timestamp precision loss in serializer [incubator-gluten]

2024-04-12 Thread via GitHub
zhli1142015 commented on PR #5376: URL: https://github.com/apache/incubator-gluten/pull/5376#issuecomment-2051178101 BTW, from this setting's comments, it's used for spilling also, not sure if this should be set to true for spilling also?

Re: [PR] [CH]feat: Support external sort shuffle, reduce shuffle memory usage when the number of partitions is high [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5279: URL: https://github.com/apache/incubator-gluten/pull/5279#issuecomment-2051170595 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix timestamp precision loss in serializer [incubator-gluten]

2024-04-12 Thread via GitHub
zhli1142015 commented on PR #5376: URL: https://github.com/apache/incubator-gluten/pull/5376#issuecomment-2051168720 cc @PHILO-HE and @marin-ma , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [CH] Fix diff of factorial function [incubator-gluten]

2024-04-12 Thread via GitHub
liuneng1994 merged PR #5330: URL: https://github.com/apache/incubator-gluten/pull/5330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [CH] Fix diff of factorial function (#5330)

2024-04-12 Thread liuneng
This is an automated email from the ASF dual-hosted git repository. liuneng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 9cf62cf24 [CH] Fix diff of factorial

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2051156696 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5103][VL] Support JVM libhdfs in velox [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5384: URL: https://github.com/apache/incubator-gluten/pull/5384#issuecomment-2051146112 https://github.com/apache/incubator-gluten/issues/5103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5380][CH] Support bin function [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5383: URL: https://github.com/apache/incubator-gluten/pull/5383#issuecomment-2051141970 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable weekofyear function [incubator-gluten]

2024-04-12 Thread via GitHub
PHILO-HE merged PR #5371: URL: https://github.com/apache/incubator-gluten/pull/5371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Enable weekofyear function (#5371)

2024-04-12 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 4ffd2b1e3 [VL] Enable weekofyear function

Re: [PR] [VL] Support libhdfs in velox [incubator-gluten]

2024-04-12 Thread via GitHub
JkSelf commented on PR #5384: URL: https://github.com/apache/incubator-gluten/pull/5384#issuecomment-2051137045 @zhouyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [VL] Support libhdfs in velox [incubator-gluten]

2024-04-12 Thread via GitHub
JkSelf opened a new pull request, #5384: URL: https://github.com/apache/incubator-gluten/pull/5384 ## What changes were proposed in this pull request? Add libhdfs API support in velox backend. ## How was this patch tested? Locally testing TPC-DS queries to loading data

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
zhztheplayer commented on code in PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#discussion_r1562110809 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1249,6 +1251,13 @@ object GlutenConfig { .checkValues(Set("none",

Re: [PR] [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5254: URL: https://github.com/apache/incubator-gluten/pull/5254#issuecomment-2051123247 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Integrate filter rules into enumerated transform [incubator-gluten]

2024-04-12 Thread via GitHub
zhztheplayer merged PR #5367: URL: https://github.com/apache/incubator-gluten/pull/5367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2051108360 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5380][CH] Support bin function [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5383: URL: https://github.com/apache/incubator-gluten/pull/5383#issuecomment-2051105962 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5380][CH] Support bin function [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5383: URL: https://github.com/apache/incubator-gluten/pull/5383#issuecomment-2051105645 https://github.com/apache/incubator-gluten/issues/5380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5380][CH] Support bin function [incubator-gluten]

2024-04-12 Thread via GitHub
exmy opened a new pull request, #5383: URL: https://github.com/apache/incubator-gluten/pull/5383 ## What changes were proposed in this pull request? (Fixes: \#5380) ## How was this patch tested? Pass CI -- This is an automated message from the Apache Git

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
zhouyuan commented on code in PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#discussion_r1562095505 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1249,6 +1251,13 @@ object GlutenConfig { .checkValues(Set("none", "auto"))

Re: [PR] [GLUTEN-4479][VL] Map `unbase64` to corr. Presto function [incubator-gluten]

2024-04-12 Thread via GitHub
PHILO-HE commented on code in PR #5242: URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1562093829 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -144,6 +144,7 @@ class VeloxTestSettings extends

Re: [PR] [VL] Fix weekofyear function [incubator-gluten]

2024-04-12 Thread via GitHub
Yohahaha commented on code in PR #5371: URL: https://github.com/apache/incubator-gluten/pull/5371#discussion_r1562083382 ## backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala: ## @@ -747,4 +747,14 @@ class ScalarFunctionsValidateSuite

Re: [PR] [VL] Daily Update Velox Version (2024_04_12) [incubator-gluten]

2024-04-12 Thread via GitHub
github-actions[bot] commented on PR #5375: URL: https://github.com/apache/incubator-gluten/pull/5375#issuecomment-2051040250 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to