Re: [I] [VL] Some queries have performance regression on release-1.1 compared to version 20230831 [incubator-gluten]

2024-04-16 Thread via GitHub
FelixYBW commented on issue #5251: URL: https://github.com/apache/incubator-gluten/issues/5251#issuecomment-2060429808 You may try the two config and see if they work spark.gluten.sql.columnar.backend.velox.maxSpillFileSize default is 1G

Re: [PR] [VL] Daily Update Velox Version (2024_04_17) [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5429: URL: https://github.com/apache/incubator-gluten/pull/5429#issuecomment-2060391370 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Support columnar collect limit [incubator-gluten]

2024-04-16 Thread via GitHub
ulysses-you commented on PR #5266: URL: https://github.com/apache/incubator-gluten/pull/5266#issuecomment-2060354493 thank you @zhztheplayer and @guixiaowen, I'm on vacation so please go ahead with your pr. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [VL] Fallback window operator when the range frame contain literal [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5431: URL: https://github.com/apache/incubator-gluten/pull/5431#issuecomment-2060342543 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Add a bad test case when bloom_filter_agg is fallen back while might_contain is not [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5433: URL: https://github.com/apache/incubator-gluten/pull/5433#issuecomment-2060311948 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated (fe4c70f22 -> cb4ae9abb)

2024-04-16 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from fe4c70f22 [VL] Fallback window operator when the range frame contain literal (#5431) add cb4ae9abb [VL]

Re: [PR] [VL] Daily Update Velox Version (2024_04_17) [incubator-gluten]

2024-04-16 Thread via GitHub
zhztheplayer merged PR #5429: URL: https://github.com/apache/incubator-gluten/pull/5429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Add a bad test case when bloom_filter_agg is fallen back while might_contain is not [incubator-gluten]

2024-04-16 Thread via GitHub
zhztheplayer commented on code in PR #5433: URL: https://github.com/apache/incubator-gluten/pull/5433#discussion_r1568187545 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformHintRule.scala: ## @@ -324,7 +324,7 @@ case class

Re: [PR] [VL] Add a bad test case when bloom_filter_agg is fallen back while might_contain is not [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5433: URL: https://github.com/apache/incubator-gluten/pull/5433#issuecomment-2060305824 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Add a bad test case when bloom_filter_agg is fallen back while might_contain is not [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5433: URL: https://github.com/apache/incubator-gluten/pull/5433#issuecomment-2060305631 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Add a bad test case when bloom_filter_agg is fallen back while might_contain is not [incubator-gluten]

2024-04-16 Thread via GitHub
zhztheplayer opened a new pull request, #5433: URL: https://github.com/apache/incubator-gluten/pull/5433 So far the case fails with error ``` org.apache.gluten.exception.GlutenException: java.lang.RuntimeException: Exception: VeloxUserError Error Source: USER Error Code:

Re: [PR] [VL] Daily Update Velox Version (2024_04_17) [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5429: URL: https://github.com/apache/incubator-gluten/pull/5429#issuecomment-2060302690 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Some queries have performance regression on release-1.1 compared to version 20230831 [incubator-gluten]

2024-04-16 Thread via GitHub
kecookier commented on issue #5251: URL: https://github.com/apache/incubator-gluten/issues/5251#issuecomment-2060287603 The spill directory of task contains more than `1321410(130W+)` files. ``` I20240415 20:58:58.384371 107493 Task.cpp:] All drivers (1) finished for task

Re: [PR] [GLUTEN-4039][VL] Add array forall function support [incubator-gluten]

2024-04-16 Thread via GitHub
lyy-pineapple commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2060275057 Could you please review this PR, @PHILO-HE ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [VL] Daily Update Velox Version (2024_04_17) [incubator-gluten]

2024-04-16 Thread via GitHub
zhouyuan commented on PR #5429: URL: https://github.com/apache/incubator-gluten/pull/5429#issuecomment-2060267053 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(incubator-gluten) branch main updated (2553768eb -> fe4c70f22)

2024-04-16 Thread kejia
This is an automated email from the ASF dual-hosted git repository. kejia pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 2553768eb [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table (#5421)

Re: [PR] [VL] Fallback window operator when the range frame contain literal [incubator-gluten]

2024-04-16 Thread via GitHub
JkSelf merged PR #5431: URL: https://github.com/apache/incubator-gluten/pull/5431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2060265617 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move memory off-heap conf checks to driver plugin [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5128: URL: https://github.com/apache/incubator-gluten/pull/5128#issuecomment-2060251594 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Link lib jemalloc produced by custom building [incubator-gluten]

2024-04-16 Thread via GitHub
PHILO-HE commented on PR #4747: URL: https://github.com/apache/incubator-gluten/pull/4747#issuecomment-2060250649 > @PHILO-HE can the PR still necessary? I remember the issue is fixed in my env but I'm not sure if I ported the PR or not. @FelixYBW, yes, it can be used for debugging.

(incubator-gluten) branch main updated (b8e4c0935 -> 2553768eb)

2024-04-16 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from b8e4c0935 [CORE] Move memory off-heap conf checks to driver plugin (#5128) add 2553768eb

Re: [PR] [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
baibaichen merged PR #5421: URL: https://github.com/apache/incubator-gluten/pull/5421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
baibaichen closed issue #5419: [CH] Support writing and reading the mergetree data by the path based table URL: https://github.com/apache/incubator-gluten/issues/5419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [CH] Support shuffle function [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5432: URL: https://github.com/apache/incubator-gluten/pull/5432#issuecomment-2060217388 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CH] Support shuffle function [incubator-gluten]

2024-04-16 Thread via GitHub
exmy opened a new pull request, #5432: URL: https://github.com/apache/incubator-gluten/pull/5432 ## What changes were proposed in this pull request? ## How was this patch tested? Pass CI -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CH] Support shuffle function [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5432: URL: https://github.com/apache/incubator-gluten/pull/5432#issuecomment-2060217514 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [CORE] Move memory off-heap conf checks to driver plugin (#5128)

2024-04-16 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b8e4c0935 [CORE] Move memory off-heap

Re: [PR] [CORE] Move memory off-heap conf checks to driver plugin [incubator-gluten]

2024-04-16 Thread via GitHub
zhztheplayer merged PR #5128: URL: https://github.com/apache/incubator-gluten/pull/5128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
loneylee commented on PR #5421: URL: https://github.com/apache/incubator-gluten/pull/5421#issuecomment-2060207683 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CORE] Upgrade Arrow to 15.0.0 [incubator-gluten]

2024-04-16 Thread via GitHub
PHILO-HE commented on PR #5174: URL: https://github.com/apache/incubator-gluten/pull/5174#issuecomment-2060198124 Hi @Yohahaha, it's strange that a few UT fails. Do you have any clues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [VL] Upgrade Arrow java version to 15.0.0 [incubator-gluten]

2024-04-16 Thread via GitHub
PHILO-HE commented on PR #5430: URL: https://github.com/apache/incubator-gluten/pull/5430#issuecomment-2060195015 There is a pending pr: https://github.com/apache/incubator-gluten/pull/5174 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [GLUTEN-5341][VL] Enable UT of GlutenExpressionMappingSuite [incubator-gluten]

2024-04-16 Thread via GitHub
gaoyangxiaozhu commented on PR #5423: URL: https://github.com/apache/incubator-gluten/pull/5423#issuecomment-2060188438 @yma11 / @zhouyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Fallback window operator when the range frame contain literal [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5431: URL: https://github.com/apache/incubator-gluten/pull/5431#issuecomment-2060173341 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fallback window operator when the range frame contain literal [incubator-gluten]

2024-04-16 Thread via GitHub
JkSelf opened a new pull request, #5431: URL: https://github.com/apache/incubator-gluten/pull/5431 ## What changes were proposed in this pull request? The Velox Window operator does not support range frames with literal values, such as 'RANGE BETWEEN CURRENT ROW AND 2 FOLLOWING'.

Re: [PR] [VL] Remove fallback for rand function with user-specified seed [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #4879: URL: https://github.com/apache/incubator-gluten/pull/4879#issuecomment-2060165181 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][GLUTEN-5362] Not passing the partition column info of the Iceberg table to the read split [incubator-gluten]

2024-04-16 Thread via GitHub
yma11 commented on PR #5373: URL: https://github.com/apache/incubator-gluten/pull/5373#issuecomment-2060150467 > We can keep this PR, after the fix in meta Velox is merged, we can use this PR to remove the ignored tests. @liujiayi771 I see your upstream PR is merged, you can go

Re: [PR] [GLUTEN-4479][VL] Map `unbase64` to corr. Presto function [incubator-gluten]

2024-04-16 Thread via GitHub
PHILO-HE commented on code in PR #5242: URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1568072701 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -144,6 +144,7 @@ class VeloxTestSettings extends

Re: [PR] [VL] Upgrade Arrow java version to 15.0.0 [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5430: URL: https://github.com/apache/incubator-gluten/pull/5430#issuecomment-2060115680 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Upgrade Arrow java version to 15.0.0 [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5430: URL: https://github.com/apache/incubator-gluten/pull/5430#issuecomment-206011 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Upgrade Arrow java version to 15.0.0 [incubator-gluten]

2024-04-16 Thread via GitHub
jinchengchenghh opened a new pull request, #5430: URL: https://github.com/apache/incubator-gluten/pull/5430 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Daily Update Velox Version (2024_04_17) [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5429: URL: https://github.com/apache/incubator-gluten/pull/5429#issuecomment-2060097789 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_04_17) [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot opened a new pull request, #5429: URL: https://github.com/apache/incubator-gluten/pull/5429 Upstream Velox's New Commits: ```txt da6a3d305 by aditi-pandit, Fix nulls ordering for Range frames (9271) beacf30ca by Huameng (Michael) Jiang, Minimize memory of unused

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240417) [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5428: URL: https://github.com/apache/incubator-gluten/pull/5428#issuecomment-2060046924 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240417) [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5428: URL: https://github.com/apache/incubator-gluten/pull/5428#issuecomment-2060046730 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240417) [incubator-gluten]

2024-04-16 Thread via GitHub
kyligence-git opened a new pull request, #5428: URL: https://github.com/apache/incubator-gluten/pull/5428 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Fix ORC reader for ByteType [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5416: URL: https://github.com/apache/incubator-gluten/pull/5416#issuecomment-2060014586 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5424: URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059843337 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5424: URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059829472 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
ayushi-agarwal closed pull request #5424: [GLUTEN-5341]Fix test write parquet with compression codec URL: https://github.com/apache/incubator-gluten/pull/5424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
ayushi-agarwal commented on PR #5424: URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059825557 The tests won't pass till issue https://github.com/apache/incubator-gluten/issues/5427 gets fixed. -- This is an automated message from the Apache Git Service. To

[I] Support for read and write of parquet file with lz4_raw compression codec in velox [incubator-gluten]

2024-04-16 Thread via GitHub
ayushi-agarwal opened a new issue, #5427: URL: https://github.com/apache/incubator-gluten/issues/5427 ### Description From spark 3.5 parquet has been upgraded to 1.13.0 which supports LZ4_RAW codec. Spark now supports read and write of parquet data with this codec

Re: [PR] [GLUTEN-5341] Fix VeloxParquetWriteForHiveSuite.scala [incubator-gluten]

2024-04-16 Thread via GitHub
ayushi-agarwal commented on PR #5426: URL: https://github.com/apache/incubator-gluten/pull/5426#issuecomment-2059661526 @zhli1142015 @JkSelf Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-4479][VL] Map `unbase64` to corr. Presto function [incubator-gluten]

2024-04-16 Thread via GitHub
sujithjay commented on code in PR #5242: URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1567551366 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -144,6 +144,7 @@ class VeloxTestSettings extends

Re: [PR] [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5421: URL: https://github.com/apache/incubator-gluten/pull/5421#issuecomment-2059340682 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] DNR [incubator-gluten]

2024-04-16 Thread via GitHub
acvictor closed pull request #5322: DNR URL: https://github.com/apache/incubator-gluten/pull/5322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Enable second Spark function [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5131: URL: https://github.com/apache/incubator-gluten/pull/5131#issuecomment-2059191335 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fix VeloxParquetWriteForHiveSuite.scala [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5426: URL: https://github.com/apache/incubator-gluten/pull/5426#issuecomment-2059191652 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5341] Fix VeloxParquetWriteForHiveSuite.scala [incubator-gluten]

2024-04-16 Thread via GitHub
ayushi-agarwal opened a new pull request, #5426: URL: https://github.com/apache/incubator-gluten/pull/5426 ## What changes were proposed in this pull request? Fixes the tests in VeloxParquetWriteForHiveSuite.scala (Fixes: \#5341) ## How was this patch tested? Ran UTs

Re: [PR] [VL] Fix: add validate check for Generate [incubator-gluten]

2024-04-16 Thread via GitHub
supermem613 commented on PR #3682: URL: https://github.com/apache/incubator-gluten/pull/3682#issuecomment-2059110628 > > @PHILO-HE, quick question: why was from_json marked as black-list with this PR? From a cursory glance it seems to run without issue. Are there any issues associated

Re: [PR] [GLUTEN-4479][VL] Map `unbase64` to corr. Presto function [incubator-gluten]

2024-04-16 Thread via GitHub
supermem613 commented on code in PR #5242: URL: https://github.com/apache/incubator-gluten/pull/5242#discussion_r1567364933 ## gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala: ## @@ -144,6 +144,7 @@ class VeloxTestSettings extends

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5424: URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059095567 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove fallback for rand function with user-specified seed [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #4879: URL: https://github.com/apache/incubator-gluten/pull/4879#issuecomment-2059079188 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove fallback for rand function with user-specified seed [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #4879: URL: https://github.com/apache/incubator-gluten/pull/4879#issuecomment-2059073139 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][UT] Fix scalar-subquery-select.sql in spark35 [incubator-gluten]

2024-04-16 Thread via GitHub
liujiayi771 commented on PR #5425: URL: https://github.com/apache/incubator-gluten/pull/5425#issuecomment-2059021541 cc @yma11, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Fix ORC reader for ByteType [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5416: URL: https://github.com/apache/incubator-gluten/pull/5416#issuecomment-2059011503 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] Refine testWithSpecifiedSparkVersion to compare major version [incubator-gluten]

2024-04-16 Thread via GitHub
PHILO-HE closed issue #5381: Refine testWithSpecifiedSparkVersion to compare major version URL: https://github.com/apache/incubator-gluten/issues/5381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [VL] Use common name for both celeborn and uniffle [incubator-gluten]

2024-04-16 Thread via GitHub
PHILO-HE closed issue #5335: [VL] Use common name for both celeborn and uniffle URL: https://github.com/apache/incubator-gluten/issues/5335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(incubator-gluten) branch main updated: [VL] Fix ORC reader for ByteType (#5416)

2024-04-16 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 33d183203 [VL] Fix ORC reader for

Re: [PR] [VL] Fix ORC reader for ByteType [incubator-gluten]

2024-04-16 Thread via GitHub
zhouyuan merged PR #5416: URL: https://github.com/apache/incubator-gluten/pull/5416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL][UT] Fix scalar-subquery-select.sql in spark35 [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5425: URL: https://github.com/apache/incubator-gluten/pull/5425#issuecomment-2058857873 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][UT] Fix scalar-subquery-select.sql in spark35 [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5425: URL: https://github.com/apache/incubator-gluten/pull/5425#issuecomment-2058857463 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][UT] Fix scalar-subquery-select.sql in spark35 [incubator-gluten]

2024-04-16 Thread via GitHub
liujiayi771 opened a new pull request, #5425: URL: https://github.com/apache/incubator-gluten/pull/5425 ## What changes were proposed in this pull request? Currently in the gluten-ut of spark35, `scalar-subquery-select.sql` and `scalar-subquery-select.sql.out` were directly copied

Re: [PR] [GLUTEN-4039][VL] Add array forall function support [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2058841714 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
ayushi-agarwal commented on PR #5424: URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2058804683 @JkSelf Could you please review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5421: URL: https://github.com/apache/incubator-gluten/pull/5421#issuecomment-2058791857 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5424: URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2058782640 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5424: URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2058781590 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]

2024-04-16 Thread via GitHub
ayushi-agarwal opened a new pull request, #5424: URL: https://github.com/apache/incubator-gluten/pull/5424 ## What changes were proposed in this pull request? LZ4_RAW is currently not supported in velox, so fallback to non-native write when user specifies this compression codec.

Re: [PR] [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5421: URL: https://github.com/apache/incubator-gluten/pull/5421#issuecomment-2058777950 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2058760151 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_04_16) [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5413: URL: https://github.com/apache/incubator-gluten/pull/5413#issuecomment-2058741857 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5341][VL] Enable UT of GlutenExpressionMappingSuite [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5423: URL: https://github.com/apache/incubator-gluten/pull/5423#issuecomment-2058725435 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5341][VL] Enable UT of GlutenExpressionMappingSuite [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5423: URL: https://github.com/apache/incubator-gluten/pull/5423#issuecomment-2058725934 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-5341][VL] Enable UT of GlutenExpressionMappingSuite [incubator-gluten]

2024-04-16 Thread via GitHub
gaoyangxiaozhu opened a new pull request, #5423: URL: https://github.com/apache/incubator-gluten/pull/5423 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) https://github.com/apache/incubator-gluten/issues/5341 ## How was this

Re: [PR] [GLUTEN-4039][VL] Add array forall function support [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2058702259 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] Support expm1 function [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5422: URL: https://github.com/apache/incubator-gluten/pull/5422#issuecomment-2058688658 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CH] Support expm1 function [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5422: URL: https://github.com/apache/incubator-gluten/pull/5422#issuecomment-2058689145 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [CH] Support expm1 function [incubator-gluten]

2024-04-16 Thread via GitHub
exmy opened a new pull request, #5422: URL: https://github.com/apache/incubator-gluten/pull/5422 ## What changes were proposed in this pull request? ## How was this patch tested? Pass CI -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5421: URL: https://github.com/apache/incubator-gluten/pull/5421#issuecomment-2058679008 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5419][CH] Support writing and reading the mergetree data by the path based table [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5421: URL: https://github.com/apache/incubator-gluten/pull/5421#issuecomment-2058678595 https://github.com/apache/incubator-gluten/issues/5419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4039][VL] Add array forall function support [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2058669501 https://github.com/apache/incubator-gluten/issues/4039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4039][VL] Add array forall function support [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #5420: URL: https://github.com/apache/incubator-gluten/pull/5420#issuecomment-2058669906 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-4039][VL] Add array forall function support [incubator-gluten]

2024-04-16 Thread via GitHub
lyy-pineapple opened a new pull request, #5420: URL: https://github.com/apache/incubator-gluten/pull/5420 ## What changes were proposed in this pull request? Add partial support of `forall` function for velox backend. This PR leverages existing all_match function in velox which

Re: [PR] [VL] Add independent operator for top-n processing in TakeOrderedAndProjectExecTransformer [incubator-gluten]

2024-04-16 Thread via GitHub
GlutenPerfBot commented on PR #5409: URL: https://github.com/apache/incubator-gluten/pull/5409#issuecomment-2058649535 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2058631779 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-16 Thread via GitHub
lyy-pineapple commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2058588022 @PHILO-HE hello, I'd like take forall function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-5405][CH] Add rewrite todate function [incubator-gluten]

2024-04-16 Thread via GitHub
lgbo-ustc commented on PR #5406: URL: https://github.com/apache/incubator-gluten/pull/5406#issuecomment-2058569868 Is it similar to https://github.com/apache/incubator-gluten/pull/4617? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_16) (#5413)

2024-04-16 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 9e39cb90b [VL] Daily Update Velox Version

Re: [PR] [VL] Daily Update Velox Version (2024_04_16) [incubator-gluten]

2024-04-16 Thread via GitHub
zhztheplayer merged PR #5413: URL: https://github.com/apache/incubator-gluten/pull/5413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated (3e80977bf -> 607068bd7)

2024-04-16 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 3e80977bf [GLUTEN-5249] [CH] fix throw Unexpected empty column when reading csv file (#5254) add

  1   2   >