Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2067551369 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] array type return different result [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu commented on issue #4517: URL: https://github.com/apache/incubator-gluten/issues/4517#issuecomment-2067533112 hey @weiting-chen the issue only happen in 3.2 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2067522002 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
GlutenPerfBot commented on PR #5466: URL: https://github.com/apache/incubator-gluten/pull/5466#issuecomment-2067496481 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
zhouyuan commented on PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#issuecomment-2067424505 CC @JkSelf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] UT failures for Spark3.5 [incubator-gluten]

2024-04-19 Thread via GitHub
zhouyuan closed issue #5341: UT failures for Spark3.5 URL: https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(incubator-gluten) branch main updated: [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite (#5466)

2024-04-19 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 708a50f67 [GLUTEN-5341] Fix and enable

Re: [PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
zhouyuan merged PR #5466: URL: https://github.com/apache/incubator-gluten/pull/5466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240420) [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5468: URL: https://github.com/apache/incubator-gluten/pull/5468#issuecomment-2067376998 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240420) [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5468: URL: https://github.com/apache/incubator-gluten/pull/5468#issuecomment-2067377179 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240420) [incubator-gluten]

2024-04-19 Thread via GitHub
kyligence-git opened a new pull request, #5468: URL: https://github.com/apache/incubator-gluten/pull/5468 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5454][CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta [incubator-gluten]

2024-04-19 Thread via GitHub
GlutenPerfBot commented on PR #5460: URL: https://github.com/apache/incubator-gluten/pull/5460#issuecomment-2067353132 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2066909306 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu commented on PR #5466: URL: https://github.com/apache/incubator-gluten/pull/5466#issuecomment-2066838685 @zhouyuan / @PHILO-HE and @yma11 for help sign. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu commented on PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#issuecomment-2066839218 @yma11 / @zhouyuan for help sign -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] add how to contribute to Gluten [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen merged PR #17: URL: https://github.com/apache/incubator-gluten-site/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten-site) branch asf-site updated: Automatic Site Publish by Buildbot

2024-04-19 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e8b568a Automatic

(incubator-gluten-site) branch main updated: add how to contribute to Gluten (#17)

2024-04-19 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new 2f040b4 add how to contribute

[PR] add how to contribute to Gluten [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen opened a new pull request, #17: URL: https://github.com/apache/incubator-gluten-site/pull/17 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(incubator-gluten-site) branch asf-site updated: Automatic Site Publish by Buildbot

2024-04-19 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 244d9b0 Automatic

Re: [PR] add incubating in index [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen merged PR #16: URL: https://github.com/apache/incubator-gluten-site/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten-site) branch main updated: add incubating in index (#16)

2024-04-19 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new 7563b27 add incubating in

[PR] add incubating in index [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen opened a new pull request, #16: URL: https://github.com/apache/incubator-gluten-site/pull/16 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2066727793 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten-site) branch asf-site updated: Automatic Site Publish by Buildbot

2024-04-19 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/asf-site by this push: new c77282a Automatic

(incubator-gluten-site) branch main updated: remove vendor name in contact-us (#15)

2024-04-19 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new 1b2eb6e remove vendor name in

Re: [PR] remove vendor name in contact-us [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen merged PR #15: URL: https://github.com/apache/incubator-gluten-site/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] remove vendor name in contact-us [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen opened a new pull request, #15: URL: https://github.com/apache/incubator-gluten-site/pull/15 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(incubator-gluten-site) branch asf-site updated: Automatic Site Publish by Buildbot

2024-04-19 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/asf-site by this push: new e483dd5 Automatic

(incubator-gluten-site) branch main updated: fix contact-us issues (#14)

2024-04-19 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new 4d95dc3 fix contact-us issues

Re: [PR] fix contact-us issues [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen merged PR #14: URL: https://github.com/apache/incubator-gluten-site/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix contact-us issues [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen opened a new pull request, #14: URL: https://github.com/apache/incubator-gluten-site/pull/14 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(incubator-gluten-site) branch asf-site updated: Automatic Site Publish by Buildbot

2024-04-19 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/asf-site by this push: new aae69f3 Automatic

(incubator-gluten-site) branch main updated: fix gluten release page issues (#13)

2024-04-19 Thread weitingchen
This is an automated email from the ASF dual-hosted git repository. weitingchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten-site.git The following commit(s) were added to refs/heads/main by this push: new 57f23ea fix gluten release

Re: [PR] fix gluten release page issues [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen merged PR #13: URL: https://github.com/apache/incubator-gluten-site/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix gluten release page issues [incubator-gluten-site]

2024-04-19 Thread via GitHub
weiting-chen opened a new pull request, #13: URL: https://github.com/apache/incubator-gluten-site/pull/13 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2066587958 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] UT failures for Spark3.5 [incubator-gluten]

2024-04-19 Thread via GitHub
ayushi-agarwal commented on issue #5341: URL: https://github.com/apache/incubator-gluten/issues/5341#issuecomment-2066490636 > for test case `SPARK-42782: Hive compatibility check for get_json_object` > > it fail due to this PR

Re: [PR] [GLUTEN-5341] Fixes SPARK-42782: Hive compatibility check for get_json_object [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5467: URL: https://github.com/apache/incubator-gluten/pull/5467#issuecomment-2066481817 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fixes SPARK-42782: Hive compatibility check for get_json_object [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5467: URL: https://github.com/apache/incubator-gluten/pull/5467#issuecomment-2066481415 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5341] Fixes SPARK-42782: Hive compatibility check for get_json_object [incubator-gluten]

2024-04-19 Thread via GitHub
ayushi-agarwal opened a new pull request, #5467: URL: https://github.com/apache/incubator-gluten/pull/5467 ## What changes were proposed in this pull request? Fixes get_json_object test introduced in spark 3.5 to check compatibility with hive. * character is not supported in velox in

Re: [PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5466: URL: https://github.com/apache/incubator-gluten/pull/5466#issuecomment-2066388722 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5466: URL: https://github.com/apache/incubator-gluten/pull/5466#issuecomment-2066352530 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] UT failures for Spark3.5 [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu commented on issue #5341: URL: https://github.com/apache/incubator-gluten/issues/5341#issuecomment-2066346023 > @yma11 @zhouyuan I will help to check the regr related UTs. oh, @yma11 i missed this comment, i have already send PR to fix it

Re: [PR] [GLUTEN-5352][GLUTEN-5459][CH]Fix and improve year function [incubator-gluten]

2024-04-19 Thread via GitHub
KevinyhZou closed pull request #5455: [GLUTEN-5352][GLUTEN-5459][CH]Fix and improve year function URL: https://github.com/apache/incubator-gluten/pull/5455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#issuecomment-2066313673 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#discussion_r1572184239 ## backends-velox/src/test/scala/org/apache/spark/sql/execution/VeloxParquetWriteSuite.scala: ## @@ -77,7 +72,7 @@ class VeloxParquetWriteSuite extends

Re: [I] UT failures for Spark3.5 [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu commented on issue #5341: URL: https://github.com/apache/incubator-gluten/issues/5341#issuecomment-2066276184 for test case `SPARK-42782: Hive compatibility check for get_json_object` it fail due to this PR

Re: [PR] [GLUTEN-5341] Fix some Spark 3.5 UTs [incubator-gluten]

2024-04-19 Thread via GitHub
ayushi-agarwal commented on code in PR #5445: URL: https://github.com/apache/incubator-gluten/pull/5445#discussion_r1572135719 ## backends-velox/src/test/scala/org/apache/gluten/execution/VeloxHashJoinSuite.scala: ## @@ -88,6 +87,8 @@ class VeloxHashJoinSuite extends

Re: [PR] [GLUTEN-5461] ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2066230966 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2066229158 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414][VL] Support read CSV [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2066196244 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5466: URL: https://github.com/apache/incubator-gluten/pull/5466#issuecomment-2066169015 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5466: URL: https://github.com/apache/incubator-gluten/pull/5466#issuecomment-2066168664 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5341] Fix and enable all ut of VeloxAggregateFunctionsSuite [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu opened a new pull request, #5466: URL: https://github.com/apache/incubator-gluten/pull/5466 ## What changes were proposed in this pull request? fix below uts of VeloxAggregateFunctionsSuite regr_r2 regr_slope regr_intercept regr_sxy

(incubator-gluten) branch main updated: [GLUTEN-5454][CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta (#5460)

2024-04-19 Thread changchen
This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 24947fa5c [GLUTEN-5454][CH] Support

Re: [PR] [GLUTEN-5454][CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta [incubator-gluten]

2024-04-19 Thread via GitHub
baibaichen merged PR #5460: URL: https://github.com/apache/incubator-gluten/pull/5460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta [incubator-gluten]

2024-04-19 Thread via GitHub
baibaichen closed issue #5454: [CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta URL: https://github.com/apache/incubator-gluten/issues/5454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5454][CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta [incubator-gluten]

2024-04-19 Thread via GitHub
loneylee commented on PR #5460: URL: https://github.com/apache/incubator-gluten/pull/5460#issuecomment-2066148253 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Refine install libhdfs3 script [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5465: URL: https://github.com/apache/incubator-gluten/pull/5465#issuecomment-2066120826 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Refine install libhdfs3 script [incubator-gluten]

2024-04-19 Thread via GitHub
Yohahaha opened a new pull request, #5465: URL: https://github.com/apache/incubator-gluten/pull/5465 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Rework co-fallback mechanism of bloom-filter might_contain/agg [incubator-gluten]

2024-04-19 Thread via GitHub
GlutenPerfBot commented on PR #5435: URL: https://github.com/apache/incubator-gluten/pull/5435#issuecomment-2066117967 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-19 Thread via GitHub
Yohahaha commented on PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#issuecomment-2066107913 > I remember split preloading has memory issue you mentioned before, does that fixed? I see the PR has merged in upstream Velox, thank you! -- This is an automated

Re: [PR] [VL] Add a bad test case when bloom_filter_agg is fallen back while might_contain is not [incubator-gluten]

2024-04-19 Thread via GitHub
zhztheplayer commented on code in PR #5433: URL: https://github.com/apache/incubator-gluten/pull/5433#discussion_r1572009913 ## gluten-ut/spark33/src/test/scala/org/apache/spark/sql/GlutenBloomFilterAggregateQuerySuite.scala: ## @@ -113,4 +113,37 @@ class

Re: [PR] [DNM][GLUTEN-5341] enable "test write parquet with compression codec" for Spark3.5 [incubator-gluten]

2024-04-19 Thread via GitHub
yma11 closed pull request #5453: [DNM][GLUTEN-5341] enable "test write parquet with compression codec" for Spark3.5 URL: https://github.com/apache/incubator-gluten/pull/5453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
yma11 commented on code in PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#discussion_r1572008458 ## backends-velox/src/test/scala/org/apache/spark/sql/execution/VeloxParquetWriteSuite.scala: ## @@ -77,7 +72,7 @@ class VeloxParquetWriteSuite extends

Re: [PR] [GLUTEN-5461] ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2066065400 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Rename velox backendsapi to make consistent with CH [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5464: URL: https://github.com/apache/incubator-gluten/pull/5464#issuecomment-2066053104 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] Rename velox backendsapi to make consistent with CH [incubator-gluten]

2024-04-19 Thread via GitHub
yma11 opened a new pull request, #5464: URL: https://github.com/apache/incubator-gluten/pull/5464 ## What changes were proposed in this pull request? Rename velox backendsapi to make consistent with CH and make it easier to distinguish it's Velox's impl ## How was this patch

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#issuecomment-2066051883 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5341] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5463: URL: https://github.com/apache/incubator-gluten/pull/5463#issuecomment-2066051148 https://github.com/apache/incubator-gluten/issues/5341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5341] [Part 2] fix fail 3.5 ut of VeloxParquetWriteSuite [incubator-gluten]

2024-04-19 Thread via GitHub
gaoyangxiaozhu opened a new pull request, #5463: URL: https://github.com/apache/incubator-gluten/pull/5463 ## What changes were proposed in this pull request? fix test write parquet with compression codec ut of VeloxParquetWriteSuite (Fixes: \#5341) ## How was this patch

Re: [PR] [GLUTEN-5448][VL] Fix the issue of cleaning when left with previous build in velox-backends part [incubator-gluten]

2024-04-19 Thread via GitHub
Donvi commented on code in PR #5449: URL: https://github.com/apache/incubator-gluten/pull/5449#discussion_r1571995391 ## dev/builddeps-veloxbe.sh: ## @@ -189,7 +189,7 @@ function build_velox { function build_gluten_cpp { echo "Start to Gluten CPP" cd $GLUTEN_DIR/cpp -

Re: [PR] [VL] Rework co-fallback mechanism of bloom-filter might_contain/agg [incubator-gluten]

2024-04-19 Thread via GitHub
GlutenPerfBot commented on PR #5435: URL: https://github.com/apache/incubator-gluten/pull/5435#issuecomment-2066023039 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] spillRun.rows.empty() Error [incubator-gluten]

2024-04-19 Thread via GitHub
zhztheplayer commented on issue #5348: URL: https://github.com/apache/incubator-gluten/issues/5348#issuecomment-2066009960 I used Gluten+Uniffle bundle from newest main code to run the test but still didn't repeat the error. Spark config (3.2.2): ``` spark.app.id

(incubator-gluten) branch main updated: [VL] Rework co-fallback mechanism of bloom-filter might_contain/agg (#5435)

2024-04-19 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 884ef6470 [VL] Rework co-fallback

Re: [PR] [VL] Rework co-fallback mechanism of bloom-filter might_contain/agg [incubator-gluten]

2024-04-19 Thread via GitHub
zhztheplayer merged PR #5435: URL: https://github.com/apache/incubator-gluten/pull/5435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Rework co-fallback mechanism of bloom-filter might_contain/agg [incubator-gluten]

2024-04-19 Thread via GitHub
zhztheplayer commented on code in PR #5435: URL: https://github.com/apache/incubator-gluten/pull/5435#discussion_r1571958524 ## gluten-ut/spark35/src/test/scala/org/apache/spark/sql/GlutenBloomFilterAggregateQuerySuite.scala: ## @@ -106,11 +107,52 @@ class

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-19 Thread via GitHub
Yohahaha commented on PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#issuecomment-2065932193 I remember split preloading has memory issue you mentioned before, does that fixed? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-19 Thread via GitHub
Yohahaha commented on code in PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#discussion_r1571943131 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1211,7 +1211,7 @@ object GlutenConfig { .internal() .doc("The IO

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-19 Thread via GitHub
Yohahaha commented on code in PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#discussion_r1571944849 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1211,7 +1211,7 @@ object GlutenConfig { .internal() .doc("The IO

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-19 Thread via GitHub
Yohahaha commented on code in PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#discussion_r1571943131 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1211,7 +1211,7 @@ object GlutenConfig { .internal() .doc("The IO

Re: [PR] [VL] Daily Update Velox Version (2024_04_19) [incubator-gluten]

2024-04-19 Thread via GitHub
GlutenPerfBot commented on PR #5452: URL: https://github.com/apache/incubator-gluten/pull/5452#issuecomment-2065899314 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Rework co-fallback mechanism of bloom-filter might_contain/agg [incubator-gluten]

2024-04-19 Thread via GitHub
marin-ma commented on code in PR #5435: URL: https://github.com/apache/incubator-gluten/pull/5435#discussion_r1571926642 ## gluten-ut/spark35/src/test/scala/org/apache/spark/sql/GlutenBloomFilterAggregateQuerySuite.scala: ## @@ -106,11 +107,52 @@ class

Re: [PR] [VL] Add uniffle integration [incubator-gluten]

2024-04-19 Thread via GitHub
zhztheplayer commented on code in PR #3767: URL: https://github.com/apache/incubator-gluten/pull/3767#discussion_r1571919125 ## .github/workflows/velox_docker.yml: ## @@ -326,6 +327,66 @@ jobs: --local --preset=velox --benchmark-type=ds --error-on-memleak -s=30.0

Re: [PR] [GLUTEN-5461] ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2065871092 https://github.com/apache/incubator-gluten/issues/5461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5461] ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2065871410 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [GLUTEN-5461] ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
yma11 opened a new pull request, #5462: URL: https://github.com/apache/incubator-gluten/pull/5462 ## What changes were proposed in this pull request? ColumnarArrowPythonEvalExec support for Velox backend. In this PR, a typical case using arrow udf w/o additional projection is

Re: [PR] [GLUTEN-5352][GLUTEN-5459][CH]Fix and improve year function [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5455: URL: https://github.com/apache/incubator-gluten/pull/5455#issuecomment-2065862109 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-19 Thread via GitHub
yma11 opened a new issue, #5461: URL: https://github.com/apache/incubator-gluten/issues/5461 ### Description Currently for `PythonEvalExec`, Gluten will try to offload if backend has same implementation as udf in its built-in functions and fallback if native validation failed. For

Re: [PR] [GLUTEN-4990] [CH] fix data loss for dynamic patition [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #4991: URL: https://github.com/apache/incubator-gluten/pull/4991#issuecomment-2065851740 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Rework co-fallback mechanism of bloom-filter might_contain/agg [incubator-gluten]

2024-04-19 Thread via GitHub
zhztheplayer commented on PR #5435: URL: https://github.com/apache/incubator-gluten/pull/5435#issuecomment-2065852238 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5454][CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5460: URL: https://github.com/apache/incubator-gluten/pull/5460#issuecomment-2065848934 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-5457][CH] Fix merge cause an error log when use mergetree (#5458)

2024-04-19 Thread zhangzc
This is an automated email from the ASF dual-hosted git repository. zhangzc pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new f839eaf5c [GLUTEN-5457][CH] Fix merge

Re: [PR] [GLUTEN-5457][CH] Fix merge cause an error log when use mergetree [incubator-gluten]

2024-04-19 Thread via GitHub
zzcclp merged PR #5458: URL: https://github.com/apache/incubator-gluten/pull/5458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Merge cause an error log when use mergetree [incubator-gluten]

2024-04-19 Thread via GitHub
zzcclp closed issue #5457: [CH] Merge cause an error log when use mergetree URL: https://github.com/apache/incubator-gluten/issues/5457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5454][CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5460: URL: https://github.com/apache/incubator-gluten/pull/5460#issuecomment-2065844112 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Support regr_sxx and regr_syy aggregate functions for Spark 3.4 [incubator-gluten]

2024-04-19 Thread via GitHub
GlutenPerfBot commented on PR #5444: URL: https://github.com/apache/incubator-gluten/pull/5444#issuecomment-2065843646 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5454][CH] Support delete/update/optimize/vacuum API for the MergeTree + Delta [incubator-gluten]

2024-04-19 Thread via GitHub
github-actions[bot] commented on PR #5460: URL: https://github.com/apache/incubator-gluten/pull/5460#issuecomment-2065841565 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4836][VL]Add support for WindowGroupLimitExec in gluten [incubator-gluten]

2024-04-19 Thread via GitHub
zhztheplayer commented on code in PR #5398: URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1571875031 ## gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto: ## @@ -319,6 +319,15 @@ message WindowRel { } } +message

  1   2   >