Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
jinchengchenghh commented on code in PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578903451 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1460,6 +1462,13 @@ object GlutenConfig { .booleanConf

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
jinchengchenghh commented on code in PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578902257 ## gluten-core/src/main/scala/org/apache/gluten/utils/PlanUtil.scala: ## @@ -70,6 +70,9 @@ object PlanUtil { case _: InputAdapter => false

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#issuecomment-2076415548 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] CI: Split SF30 job to 4 jobs to speed up execution [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5526: URL: https://github.com/apache/incubator-gluten/pull/5526#issuecomment-2076410402 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer commented on code in PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578851690 ## gluten-data/src/main/scala/org/apache/gluten/utils/ArrowUtil.scala: ## @@ -86,4 +101,223 @@ object ArrowUtil extends Logging { } new

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer commented on code in PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578836085 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1460,6 +1462,13 @@ object GlutenConfig { .booleanConf

Re: [PR] [VL] Enable remaining passed 3.5 UT [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494#issuecomment-2076358833 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] CI: Split SF30 job to 4 jobs to speed up execution [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5526: URL: https://github.com/apache/incubator-gluten/pull/5526#issuecomment-2076354418 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer commented on code in PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578831193 ## gluten-data/src/main/scala/org/apache/gluten/utils/ArrowUtil.scala: ## @@ -86,4 +101,223 @@ object ArrowUtil extends Logging { } new

Re: [PR] [GLUTEN-5525][BUILD] Run `mvn clean` fails if a spark profile is not specified [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer commented on code in PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#discussion_r1578827650 ## pom.xml: ## @@ -47,9 +47,14 @@ 2.12 2.12.15 3 -3.2 +3.4 Review Comment: Does it mean when no `-Pspark-` specified, Spark

Re: [PR] [CH] Support celeborn on external sort shuffle [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5516: URL: https://github.com/apache/incubator-gluten/pull/5516#issuecomment-2076325256 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] CI: Split SF30 job to 4 jobs to speed up execution [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5526: URL: https://github.com/apache/incubator-gluten/pull/5526#issuecomment-2076321891 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] CI: Split SF30 job to 4 jobs to speed up execution [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5526: URL: https://github.com/apache/incubator-gluten/pull/5526#issuecomment-2076321773 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] CI: Split SF30 job to 4 jobs to speed up execution [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer opened a new pull request, #5526: URL: https://github.com/apache/incubator-gluten/pull/5526 Added a new `gluten-it` option `--shard` to achieve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer merged PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [CORE] Untangle AddTransformHintRule to extract pre-validation code out (#5514)

2024-04-24 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new ed1f7b613 [CORE] Untangle

(incubator-gluten) branch main updated: enable all passed 3.5 ut (#5494)

2024-04-24 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new c09d79330 enable all passed 3.5 ut

Re: [PR] [VL] Enable remaining passed 3.5 UT [incubator-gluten]

2024-04-24 Thread via GitHub
FelixYBW merged PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Fix velox parquet suite (#5483)

2024-04-24 Thread kejia
This is an automated email from the ASF dual-hosted git repository. kejia pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 417a36e01 [VL] Fix velox parquet suite

Re: [PR] [VL] Fix Velox Parquet Write UT [incubator-gluten]

2024-04-24 Thread via GitHub
JkSelf merged PR #5483: URL: https://github.com/apache/incubator-gluten/pull/5483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2076282826 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] Support celeborn on external sort shuffle [incubator-gluten]

2024-04-24 Thread via GitHub
liuneng1994 merged PR #5516: URL: https://github.com/apache/incubator-gluten/pull/5516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [CH] Support celeborn on external sort shuffle

2024-04-24 Thread liuneng
This is an automated email from the ASF dual-hosted git repository. liuneng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new a9a07a878 [CH] Support celeborn on

Re: [PR] [CH] Support celeborn on external sort shuffle [incubator-gluten]

2024-04-24 Thread via GitHub
loneylee commented on PR #5516: URL: https://github.com/apache/incubator-gluten/pull/5516#issuecomment-2076281288 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Use slice instead of resize in ensureFlattened [incubator-gluten]

2024-04-24 Thread via GitHub
jinchengchenghh commented on PR #5523: URL: https://github.com/apache/incubator-gluten/pull/5523#issuecomment-2076278275 Can you add a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [GLUTEN-5525][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#issuecomment-2076259078 https://github.com/apache/incubator-gluten/issues/5525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[I] `mvn clean` fails if a spark profile is not specified [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyifan279 opened a new issue, #5525: URL: https://github.com/apache/incubator-gluten/issues/5525 ### Problem description ### Expected behavior mvn clean executes successfully. ### Actual behavior Run mvn clean fails with the following message: ``` [INFO] Scanning

Re: [PR] [GLUTEN-5103][VL] Support JVM libhdfs in velox [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5384: URL: https://github.com/apache/incubator-gluten/pull/5384#issuecomment-2076204769 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
jinchengchenghh commented on code in PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578769775 ## gluten-data/src/main/scala/org/apache/gluten/utils/ArrowUtil.scala: ## @@ -86,4 +101,223 @@ object ArrowUtil extends Logging { } new

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
jinchengchenghh commented on code in PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#discussion_r1578769775 ## gluten-data/src/main/scala/org/apache/gluten/utils/ArrowUtil.scala: ## @@ -86,4 +101,223 @@ object ArrowUtil extends Logging { } new

Re: [PR] [GLUTEN-5103][VL] Support JVM libhdfs in velox [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5384: URL: https://github.com/apache/incubator-gluten/pull/5384#issuecomment-2076200378 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [VL] date_format returns wrong results [incubator-gluten]

2024-04-24 Thread via GitHub
clee704 opened a new issue, #5524: URL: https://github.com/apache/incubator-gluten/issues/5524 ### Backend VL (Velox) ### Bug description Velox evaluates `date_format(timestamp'12345-01-01 01:01:01', '-MM')` to `'12345-07'`, whereas vanilla Spark evaluates the same

Re: [PR] [VL] Fix Velox Parquet Write UT [incubator-gluten]

2024-04-24 Thread via GitHub
gaoyangxiaozhu commented on PR #5483: URL: https://github.com/apache/incubator-gluten/pull/5483#issuecomment-2076182122 > @JkSelf / @zhouyuan > > the test case before always fallback which is actually not cover velox native write scenario ping again -- This is an automated

Re: [PR] [VL] Enable remaining passed 3.5 UT [incubator-gluten]

2024-04-24 Thread via GitHub
gaoyangxiaozhu commented on PR #5494: URL: https://github.com/apache/incubator-gluten/pull/5494#issuecomment-2076181977 > hey @zhouyuan / @zhli1142015 / @yma11 can you help sign ? ping again -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Fix array_intersect and array_except [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #4800: URL: https://github.com/apache/incubator-gluten/pull/4800#issuecomment-2076176073 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [VL] Fix array_intersect and array_except [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] closed pull request #4800: [VL] Fix array_intersect and array_except URL: https://github.com/apache/incubator-gluten/pull/4800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2076163845 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL][DOC] Add ABFS doc (#5479)

2024-04-24 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new bdc4998de [VL][DOC] Add ABFS doc (#5479)

Re: [PR] [VL][DOC] Add ABFS doc [incubator-gluten]

2024-04-24 Thread via GitHub
PHILO-HE merged PR #5479: URL: https://github.com/apache/incubator-gluten/pull/5479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#issuecomment-2076134648 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] No need to increment the fixedWidthIdx variable [incubator-gluten]

2024-04-24 Thread via GitHub
marin-ma commented on PR #5520: URL: https://github.com/apache/incubator-gluten/pull/5520#issuecomment-2076127371 cc: @PHILO-HE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Use slice instead of resize in ensureFlattened [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5523: URL: https://github.com/apache/incubator-gluten/pull/5523#issuecomment-2076126760 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#issuecomment-2076123366 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#issuecomment-2076122307 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#issuecomment-2076120508 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2076107116 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [GLUTEN-5341] Support iceberg bucketjoin for Spark3.5 (#5378)

2024-04-24 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b3edec3ac [GLUTEN-5341] Support iceberg

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyuan merged PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-24 Thread via GitHub
yma11 commented on PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#issuecomment-2076088596 Hi @zhouyuan can you help review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [VL] Daily Update Velox Version (2024_04_25) [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5522: URL: https://github.com/apache/incubator-gluten/pull/5522#issuecomment-2076087641 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240425) [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5521: URL: https://github.com/apache/incubator-gluten/pull/5521#issuecomment-2076004272 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240425) [incubator-gluten]

2024-04-24 Thread via GitHub
kyligence-git opened a new pull request, #5521: URL: https://github.com/apache/incubator-gluten/pull/5521 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240425) [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5521: URL: https://github.com/apache/incubator-gluten/pull/5521#issuecomment-2076004603 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2076001325 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] UD(A)F doesn't support array type [incubator-gluten]

2024-04-24 Thread via GitHub
FelixYBW closed issue #5236: UD(A)F doesn't support array type URL: https://github.com/apache/incubator-gluten/issues/5236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2075393783 = Performance report for TPCH SF2000 with Velox backend, for reference only query

(incubator-gluten) branch main updated: [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type (#5513)

2024-04-24 Thread zhangzc
This is an automated email from the ASF dual-hosted git repository. zhangzc pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 89015c915 [GLUTEN-5512][CH] Fix the

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
zzcclp merged PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5511] Fix GCC 11 warns that writing 1 byte into a region of size 0 [-Wstringop-overflow=] [incubator-gluten]

2024-04-24 Thread via GitHub
yma11 closed pull request #5507: [GLUTEN-5511] Fix GCC 11 warns that writing 1 byte into a region of size 0 [-Wstringop-overflow=] URL: https://github.com/apache/incubator-gluten/pull/5507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [GLUTEN-5511] Fix GCC 11 warns that writing 1 byte into a region of size 0 [-Wstringop-overflow=] [incubator-gluten]

2024-04-24 Thread via GitHub
yma11 commented on PR #5507: URL: https://github.com/apache/incubator-gluten/pull/5507#issuecomment-2075271207 Close this PR as this change will ignore other related warning that should be fixed. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-24 Thread via GitHub
SinghAsDev commented on PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#issuecomment-2075255729 Great, thanks! Best Regards, Ashish On Wed, Apr 24, 2024 at 8:39 AM Yan Ma ***@***.***> wrote: > ***@***. commented on this pull request. >

Re: [PR] [GLUTEN-5341] Support iceberg bucket join for Spark3.5 [incubator-gluten]

2024-04-24 Thread via GitHub
yma11 commented on code in PR #5378: URL: https://github.com/apache/incubator-gluten/pull/5378#discussion_r1578108219 ## gluten-iceberg/src/test/scala/org/apache/gluten/execution/VeloxIcebergSuite.scala: ## @@ -58,8 +58,7 @@ class VeloxIcebergSuite extends

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2074960504 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074917200 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] No need to increment the fixedWidthIdx variable [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5520: URL: https://github.com/apache/incubator-gluten/pull/5520#issuecomment-2074842055 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [I] I can't build gluten on an Intel MacOS machine [incubator-gluten]

2024-04-24 Thread via GitHub
NEUpanning commented on issue #5491: URL: https://github.com/apache/incubator-gluten/issues/5491#issuecomment-2074785343 @xumingming Thanks for your suggestion. 1. I already installed protobuf@21. Here is the output of `brew list protobuf@21` ``` ➜ velox git:(note) ✗ brew search

Re: [PR] [GLUTEN-489][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyifan279 commented on code in PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#discussion_r1577725761 ## pom.xml: ## @@ -47,9 +47,14 @@ 2.12 2.12.15 3 -3.2 +3.4 3.4.2 - spark-sql-columnar-shims-spark32 +spark34 +

Re: [PR] [GLUTEN-489][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyifan279 commented on code in PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#discussion_r1577705188 ## pom.xml: ## @@ -129,11 +134,9 @@ spark-3.2 - Review Comment: When profile java-8 is activated, all profiles that are

Re: [PR] [GLUTEN-489][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyifan279 commented on PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#issuecomment-2074713288 cc @yaooqinn @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [VL] Daily Update Velox Version (2024_04_24) [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5510: URL: https://github.com/apache/incubator-gluten/pull/5510#issuecomment-2074711602 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-489][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#issuecomment-2074698817 https://github.com/apache/incubator-gluten/issues/489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-489][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyifan279 commented on code in PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#discussion_r1577705188 ## pom.xml: ## @@ -129,11 +134,9 @@ spark-3.2 - Review Comment: When profile java-8 is activated, all profiles that are

Re: [PR] [GLUTEN-489][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyifan279 commented on code in PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#discussion_r1577705188 ## pom.xml: ## @@ -129,11 +134,9 @@ spark-3.2 - Review Comment: When profile java-8 is activated, all profiles that are

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074666068 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#issuecomment-2074674475 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5519: URL: https://github.com/apache/incubator-gluten/pull/5519#issuecomment-2074674076 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
zzcclp commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074673446 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [VL] Not support GMT+8 timezone [incubator-gluten]

2024-04-24 Thread via GitHub
PHILO-HE commented on issue #5169: URL: https://github.com/apache/incubator-gluten/issues/5169#issuecomment-2074651764 We have one PR in upstream velox: https://github.com/facebookincubator/velox/pull/9591. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [VL] CI: Minor optimizations for cache build settings [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5517: URL: https://github.com/apache/incubator-gluten/pull/5517#issuecomment-2074638762 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4914][CH][FOLLOWUP] Fix exceptions in ASTParser [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5518: URL: https://github.com/apache/incubator-gluten/pull/5518#issuecomment-2074609499 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4914][CH][FOLLOWUP] Fix exceptions in ASTParser [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5518: URL: https://github.com/apache/incubator-gluten/pull/5518#issuecomment-2074609044 https://github.com/apache/incubator-gluten/issues/4914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-24 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2074589292 > hey @zhouyuan could you help add `format_string` and `format_number` in the list and I would take `format_string` and `format_number` later @gaoyangxiaozhu, just

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-24 Thread via GitHub
gaoyangxiaozhu commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2074550645 hey @zhouyuan could you help add `format_string` and `format_number` in the list and I would take `format_string` and `format_number` later -- This is an

Re: [PR] [DNR] test dynamic setting [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5506: URL: https://github.com/apache/incubator-gluten/pull/5506#issuecomment-2074545466 = Performance report for TPCH SF2000 with Velox backend, for reference only query

(incubator-gluten) branch main updated (dc281ce93 -> a683e318d)

2024-04-24 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from dc281ce93 [VL] CI: Minor optimizations for cache build settings add a683e318d [VL] Daily Update Velox

Re: [PR] [VL] Daily Update Velox Version (2024_04_24) [incubator-gluten]

2024-04-24 Thread via GitHub
zhouyuan merged PR #5510: URL: https://github.com/apache/incubator-gluten/pull/5510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] CI: Add TPC-H / TPC-DS job at SF30 with Spark 3.4 [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5490: URL: https://github.com/apache/incubator-gluten/pull/5490#issuecomment-2074447070 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
loneylee commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074432861 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#issuecomment-2074432850 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#issuecomment-2074430202 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074421385 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#issuecomment-2074416320 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#issuecomment-2074384307 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5512][CH] Fix the incorrect transformer for the round function with the decimal data type [incubator-gluten]

2024-04-24 Thread via GitHub
zzcclp commented on code in PR #5513: URL: https://github.com/apache/incubator-gluten/pull/5513#discussion_r1577498529 ## gluten-core/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala: ## @@ -419,7 +419,7 @@ trait SparkPlanExecApi { substraitExprName:

Re: [PR] [VL] Refactor VeloxParquetDatasource [incubator-gluten]

2024-04-24 Thread via GitHub
GlutenPerfBot commented on PR #5486: URL: https://github.com/apache/incubator-gluten/pull/5486#issuecomment-2074347206 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5461] FEAT: ColumnarArrowPythonEvalExec support for Velox backend [incubator-gluten]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #5462: URL: https://github.com/apache/incubator-gluten/pull/5462#issuecomment-2074313095 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer commented on code in PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#discussion_r1577443815 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache

Re: [PR] [VL] CI: Minor optimizations for cache build settings [incubator-gluten]

2024-04-24 Thread via GitHub
zhztheplayer merged PR #5517: URL: https://github.com/apache/incubator-gluten/pull/5517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated (48f481fcb -> dc281ce93)

2024-04-24 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git from 48f481fcb [VL] CI: Add TPC-H / TPC-DS job at SF30 with Spark 3.4 (#5490) add dc281ce93 [VL] CI: Minor

Re: [PR] [CORE] Untangle AddTransformHintRule to extract pre-validation code out [incubator-gluten]

2024-04-24 Thread via GitHub
PHILO-HE commented on code in PR #5514: URL: https://github.com/apache/incubator-gluten/pull/5514#discussion_r1577418864 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/validator/Validators.scala: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software

  1   2   >