Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081941062 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Reuse broadcast exchange for different build keys with same table [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5563: URL: https://github.com/apache/incubator-gluten/pull/5563#issuecomment-2081931631 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081921086 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [CORE] Reuse broadcast exchange for different build keys with same table (#5563)

2024-04-28 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 7dad958e4 [CORE] Reuse broadcast

Re: [PR] [CORE] Reuse broadcast exchange for different build keys with same table [incubator-gluten]

2024-04-28 Thread via GitHub
ulysses-you merged PR #5563: URL: https://github.com/apache/incubator-gluten/pull/5563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5571][DOC] Update Velox build info #5571 [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5572: URL: https://github.com/apache/incubator-gluten/pull/5572#issuecomment-2081857090 https://github.com/apache/incubator-gluten/issues/5571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Enable array_size Spark function [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5539: URL: https://github.com/apache/incubator-gluten/pull/5539#issuecomment-2081838763 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081837625 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [BUILD] package step consume more time after upgrade Arrow 15 [incubator-gluten]

2024-04-28 Thread via GitHub
Yohahaha opened a new issue, #5570: URL: https://github.com/apache/incubator-gluten/issues/5570 ### Problem description After upgrade to Arrow 15, maven package step consume more time(~30s) than before. ### System information n/a ### CMake log _No

Re: [PR] [GLUTEN-4652] Fix min_by/max_by result mismatch [incubator-gluten]

2024-04-28 Thread via GitHub
rui-mo commented on code in PR #5544: URL: https://github.com/apache/incubator-gluten/pull/5544#discussion_r1582500791 ## cpp/velox/operators/functions/RowFunctionWithNull.h: ## @@ -42,15 +44,26 @@ class RowFunctionWithNull final : public facebook::velox::exec::VectorFunction

Re: [PR] [GLUTEN-5414] [VL] Support Arrow native memory pool usage track [incubator-gluten]

2024-04-28 Thread via GitHub
zhztheplayer commented on PR #5550: URL: https://github.com/apache/incubator-gluten/pull/5550#issuecomment-2081789655 @jinchengchenghh Would you like to move the newly added components to a new package, say `org.apache.gluten.memory.arrow.pool` ? Also refactor previous

Re: [PR] [GLUTEN-4652] Fix min_by/max_by result mismatch [incubator-gluten]

2024-04-28 Thread via GitHub
yma11 commented on code in PR #5544: URL: https://github.com/apache/incubator-gluten/pull/5544#discussion_r1582488826 ## backends-velox/src/main/scala/org/apache/gluten/utils/VeloxIntermediateData.scala: ## @@ -159,7 +159,10 @@ object VeloxIntermediateData { *

Re: [I] [VL] row_constructor in gluten will make top-level struct to null if its child fields have null value [incubator-gluten]

2024-04-28 Thread via GitHub
yma11 commented on issue #1303: URL: https://github.com/apache/incubator-gluten/issues/1303#issuecomment-2081784793 I didn't check the functions because I think the root cause of these issues are caused by the additional projects we added. From the functions perspective, it will do

Re: [PR] [CORE] Reuse broadcast exchange for different build keys with same table [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5563: URL: https://github.com/apache/incubator-gluten/pull/5563#issuecomment-2081766810 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Reuse broadcast exchange for different build keys with same table [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5563: URL: https://github.com/apache/incubator-gluten/pull/5563#issuecomment-2081764339 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] row_constructor in gluten will make top-level struct to null if its child fields have null value [incubator-gluten]

2024-04-28 Thread via GitHub
rui-mo commented on issue #1303: URL: https://github.com/apache/incubator-gluten/issues/1303#issuecomment-2081759646 > Seems we still need the hack because tpch/tpcds failed after removing it. @yma11 Thanks for checking. Have you noticed which function causes the failure? -- This

Re: [PR] [GLUTEN-4652] Fix min_by/max_by result mismatch [incubator-gluten]

2024-04-28 Thread via GitHub
rui-mo commented on code in PR #5544: URL: https://github.com/apache/incubator-gluten/pull/5544#discussion_r1582474605 ## backends-velox/src/main/scala/org/apache/gluten/utils/VeloxIntermediateData.scala: ## @@ -159,7 +159,10 @@ object VeloxIntermediateData { *

Re: [PR] [GLUTEN-5565][VL][BUILD] Fix setup-macos.sh: folly is installed twice [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5566: URL: https://github.com/apache/incubator-gluten/pull/5566#issuecomment-2081755963 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081750526 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081748719 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [CORE] Fix delta.package.name error (#5564)

2024-04-28 Thread ulyssesyou
This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new aeae0a693 [CORE] Fix

Re: [PR] [CORE] Fix delta.package.name error [incubator-gluten]

2024-04-28 Thread via GitHub
ulysses-you merged PR #5564: URL: https://github.com/apache/incubator-gluten/pull/5564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5565][VL][BUILD] Fix setup-macos.sh: folly is installed twice [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE merged PR #5566: URL: https://github.com/apache/incubator-gluten/pull/5566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-5565][VL][BUILD] Fix setup-macos.sh: folly is installed twice (#5566)

2024-04-28 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new eaa202fe3 [GLUTEN-5565][VL][BUILD] Fix

(incubator-gluten) branch main updated: [VL] Fix year_of_week function (#5386)

2024-04-28 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 8ff22d9df [VL] Fix year_of_week function

Re: [PR] [VL] Fix year_of_week function [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE merged PR #5386: URL: https://github.com/apache/incubator-gluten/pull/5386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [VL] Daily Update Velox Version (2024_04_29) [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot opened a new pull request, #5568: URL: https://github.com/apache/incubator-gluten/pull/5568 Upstream Velox's New Commits: ```txt 1426f33bc by Jialiang Tan, Fix MultiFragmentTest.compression (9639) ``` -- This is an automated message from the Apache Git Service.

Re: [PR] [VL] Daily Update Velox Version (2024_04_29) [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5568: URL: https://github.com/apache/incubator-gluten/pull/5568#issuecomment-2081717779 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081700557 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240429) [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5567: URL: https://github.com/apache/incubator-gluten/pull/5567#issuecomment-2081689346 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240429) [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5567: URL: https://github.com/apache/incubator-gluten/pull/5567#issuecomment-2081689266 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240429) [incubator-gluten]

2024-04-28 Thread via GitHub
kyligence-git opened a new pull request, #5567: URL: https://github.com/apache/incubator-gluten/pull/5567 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] Daily Update Velox Version (2024_04_28) [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5558: URL: https://github.com/apache/incubator-gluten/pull/5558#issuecomment-2081605301 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL][CI] Fix nightly build job [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE commented on PR #5562: URL: https://github.com/apache/incubator-gluten/pull/5562#issuecomment-2081528446 Depends on https://github.com/facebookincubator/velox/pull/9648 to get duckdb dep pre-installed. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [GLUTEN-5565][BUILD] folly installed twice in velox_ep/scripts/setup-macos.sh [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5566: URL: https://github.com/apache/incubator-gluten/pull/5566#issuecomment-2081523806 https://github.com/apache/incubator-gluten/issues/5565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Daily Update Velox Version (2024_04_28) [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5558: URL: https://github.com/apache/incubator-gluten/pull/5558#issuecomment-2081523701 = Performance report for TPCH SF2000 with Velox backend, for reference only query

[I] folly is installed twice in velox_ep/scripts/setup-macos.sh [incubator-gluten]

2024-04-28 Thread via GitHub
zhouyifan279 opened a new issue, #5565: URL: https://github.com/apache/incubator-gluten/issues/5565 ### Problem description folly is installed twice in velox_ep/scripts/setup-macos.sh ### System information Velox System Info v0.0.2 Commit:

Re: [PR] [GLUTEN-4039][VL] Add flatten function support [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5551: URL: https://github.com/apache/incubator-gluten/pull/5551#issuecomment-2081517101 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_28) (#5558)

2024-04-28 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new b62bc2f38 [VL] Daily Update Velox

Re: [PR] [VL] Daily Update Velox Version (2024_04_28) [incubator-gluten]

2024-04-28 Thread via GitHub
zhouyuan merged PR #5558: URL: https://github.com/apache/incubator-gluten/pull/5558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_04_28) [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5558: URL: https://github.com/apache/incubator-gluten/pull/5558#issuecomment-2081508533 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081477348 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix delta.package.name error [incubator-gluten]

2024-04-28 Thread via GitHub
yma11 commented on code in PR #5564: URL: https://github.com/apache/incubator-gluten/pull/5564#discussion_r1582149396 ## pom.xml: ## @@ -139,8 +139,8 @@ spark32 spark-sql-columnar-shims-spark32 3.2.2 - 1.3.1 - delta-core +1.3.1

Re: [PR] [CORE] Fix delta.package.name error [incubator-gluten]

2024-04-28 Thread via GitHub
ulysses-you commented on code in PR #5564: URL: https://github.com/apache/incubator-gluten/pull/5564#discussion_r1582143817 ## pom.xml: ## @@ -139,8 +139,8 @@ spark32 spark-sql-columnar-shims-spark32 3.2.2 - 1.3.1 - delta-core +

Re: [I] [VL] row_constructor in gluten will make top-level struct to null if its child fields have null value [incubator-gluten]

2024-04-28 Thread via GitHub
yma11 commented on issue #1303: URL: https://github.com/apache/incubator-gluten/issues/1303#issuecomment-2081465784 Seems we still need the hack because tpch/tpcds failed after removing it. But the existing hack doesn't cover case for `min_by`/`max_by`, so I update it in PR

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-28 Thread via GitHub
yma11 commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2081463239 > > > 3. max_by function return wrong result > > > > > > @yma11 Did you submit a fix to the issue? > > Not yet. Only have pushed to golden branch and will

Re: [PR] [VL] Daily Update Velox Version (2024_04_28) [incubator-gluten]

2024-04-28 Thread via GitHub
zhouyuan commented on PR #5558: URL: https://github.com/apache/incubator-gluten/pull/5558#issuecomment-2081461984 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [CORE] Fix delta.package.name error [incubator-gluten]

2024-04-28 Thread via GitHub
yma11 commented on code in PR #5564: URL: https://github.com/apache/incubator-gluten/pull/5564#discussion_r1582136303 ## pom.xml: ## @@ -139,8 +139,8 @@ spark32 spark-sql-columnar-shims-spark32 3.2.2 - 1.3.1 - delta-core +1.3.1

Re: [PR] [GLUTEN-4652] Fix min_by/max_by result mismatch [incubator-gluten]

2024-04-28 Thread via GitHub
yma11 commented on PR #5544: URL: https://github.com/apache/incubator-gluten/pull/5544#issuecomment-2081455390 @rui-mo Can you help review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [CORE] Fix delta.package.name error [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5564: URL: https://github.com/apache/incubator-gluten/pull/5564#issuecomment-2081443950 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix delta.package.name error [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5564: URL: https://github.com/apache/incubator-gluten/pull/5564#issuecomment-2081443911 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Fix delta.package.name error [incubator-gluten]

2024-04-28 Thread via GitHub
ulysses-you opened a new pull request, #5564: URL: https://github.com/apache/incubator-gluten/pull/5564 ## What changes were proposed in this pull request? The `delta.package.name` of Spark3.5 is `delta-spark`, we should use property to specify the delta artifactId. ## How was

Re: [PR] [CORE] Reuse broadcast exchange for different build keys with same table [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5563: URL: https://github.com/apache/incubator-gluten/pull/5563#issuecomment-2081438797 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Reuse broadcast exchange for different build keys with same table [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5563: URL: https://github.com/apache/incubator-gluten/pull/5563#issuecomment-2081438729 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Reuse broadcast exchange for different build keys with same table [incubator-gluten]

2024-04-28 Thread via GitHub
ulysses-you opened a new pull request, #5563: URL: https://github.com/apache/incubator-gluten/pull/5563 ## What changes were proposed in this pull request? Vanilla Spark build HashRelation at driver side, so it is build keys sensitive. But we broadcast byte array and build

Re: [PR] [GLUTEN-5559][VL] Fix threads number setting for building gluten cpp on MacOS [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5560: URL: https://github.com/apache/incubator-gluten/pull/5560#issuecomment-2081433731 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081433304 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL][CI] Fix nightly build job [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5562: URL: https://github.com/apache/incubator-gluten/pull/5562#issuecomment-2081428421 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][CI] Fix nightly build job [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE opened a new pull request, #5562: URL: https://github.com/apache/incubator-gluten/pull/5562 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Fix literal bound fallback for window range frame [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5561: URL: https://github.com/apache/incubator-gluten/pull/5561#issuecomment-2081419763 = Performance report for TPCH SF2000 with Velox backend, for reference only query

(incubator-gluten) branch main updated: [GLUTEN-5559][VL] Fix build threads setting for gluten cpp on MacOS (#5560)

2024-04-28 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 26edf4f2a [GLUTEN-5559][VL] Fix build

Re: [I] nproc command in compile.sh isn't compatible with MacOS [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE closed issue #5559: nproc command in compile.sh isn't compatible with MacOS URL: https://github.com/apache/incubator-gluten/issues/5559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5559][VL] Fix threads number setting for building gluten cpp on MacOS [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE merged PR #5560: URL: https://github.com/apache/incubator-gluten/pull/5560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Fix literal bound fallback for window range frame (#5561)

2024-04-28 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new d985c5424 [VL] Fix literal bound fallback

Re: [PR] [VL] Fix literal bound fallback for window range frame [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE merged PR #5561: URL: https://github.com/apache/incubator-gluten/pull/5561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5414] [VL] Support Arrow native memory pool usage track [incubator-gluten]

2024-04-28 Thread via GitHub
jinchengchenghh commented on code in PR #5550: URL: https://github.com/apache/incubator-gluten/pull/5550#discussion_r1582049213 ## gluten-data/pom.xml: ## @@ -137,6 +137,12 @@ compile + + org.apache.arrow + arrow-dataset + 14.0.1 Review

Re: [PR] [VL] Fallback window operator when the range frame contain literal [incubator-gluten]

2024-04-28 Thread via GitHub
PHILO-HE commented on PR #5431: URL: https://github.com/apache/incubator-gluten/pull/5431#issuecomment-2081372284 > Still failed. Query: > > ``` > sum(x) OVER ( > PARTITION BY id,sur > ORDER BY date RANGE BETWEEN 6 preceding AND CURRENT ROW > ) > ```

Re: [PR] [GLUTEN-5414] [VL] Support Arrow native memory pool usage track [incubator-gluten]

2024-04-28 Thread via GitHub
Yohahaha commented on code in PR #5550: URL: https://github.com/apache/incubator-gluten/pull/5550#discussion_r1582048320 ## gluten-data/pom.xml: ## @@ -137,6 +137,12 @@ compile + + org.apache.arrow + arrow-dataset + 14.0.1 Review

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081370967 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix window range frame fallback issue [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5561: URL: https://github.com/apache/incubator-gluten/pull/5561#issuecomment-2081368074 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [I] Clean up some dead code in GlutenPlugin [incubator-gluten]

2024-04-28 Thread via GitHub
ulysses-you closed issue #5532: Clean up some dead code in GlutenPlugin URL: https://github.com/apache/incubator-gluten/issues/5532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] nproc command in compile.sh isn't compatible with MacOS [incubator-gluten]

2024-04-28 Thread via GitHub
ulysses-you commented on issue #5559: URL: https://github.com/apache/incubator-gluten/issues/5559#issuecomment-2081367115 In general, we can use nproc on macOS by `brew install coreutils`. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#issuecomment-2081358066 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-28 Thread via GitHub
zhli1142015 commented on PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#issuecomment-2081357451 cc @FelixYBW and @zhouyuan , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-28 Thread via GitHub
zhli1142015 commented on code in PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#discussion_r1582037271 ## shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala: ## @@ -1211,7 +1211,7 @@ object GlutenConfig { .internal() .doc("The IO

Re: [PR] [UT] Add ignoreGluten method [incubator-gluten]

2024-04-28 Thread via GitHub
GlutenPerfBot commented on PR #5553: URL: https://github.com/apache/incubator-gluten/pull/5553#issuecomment-2081356672 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081355647 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_04_28) [incubator-gluten]

2024-04-28 Thread via GitHub
zhztheplayer commented on PR #5558: URL: https://github.com/apache/incubator-gluten/pull/5558#issuecomment-2081353910 > the failure seems related with: [facebookincubator/velox#9557](https://github.com/facebookincubator/velox/pull/9557)

Re: [PR] fix shuffle OOM if input batch is extremely large [incubator-gluten]

2024-04-28 Thread via GitHub
guhaiyan0221 commented on code in PR #5536: URL: https://github.com/apache/incubator-gluten/pull/5536#discussion_r1582031041 ## cpp/velox/shuffle/VeloxShuffleWriter.cc: ## @@ -340,25 +340,42 @@ arrow::Status VeloxShuffleWriter::split(std::shared_ptr cb, int64

Re: [PR] [GLUTEN-5414][VL] FEAT: Support read CSV [incubator-gluten]

2024-04-28 Thread via GitHub
github-actions[bot] commented on PR #5447: URL: https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2081350890 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to