Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-29 Thread via GitHub
Donvi commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2084419656 I'd like and am working in the math function expm1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [DNM][GLUTEN-5548][VL] test dynamic setting [incubator-gluten]

2024-04-29 Thread via GitHub
GlutenPerfBot commented on PR #5506: URL: https://github.com/apache/incubator-gluten/pull/5506#issuecomment-2084408605 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5434] Add script for parquet read fuzzer test [incubator-gluten]

2024-04-29 Thread via GitHub
yma11 commented on PR #5437: URL: https://github.com/apache/incubator-gluten/pull/5437#issuecomment-2084406167 @zhouyuan @FelixYBW @marin-ma Scripts for building parquet read fuzzer job are all here. Please help take a review. I will need monitor the job for some days and collect initial

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_30) (#5583)

2024-04-29 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new d1f4f03fc [VL] Daily Update Velox

Re: [PR] [VL] Daily Update Velox Version (2024_04_30) [incubator-gluten]

2024-04-29 Thread via GitHub
FelixYBW merged PR #5583: URL: https://github.com/apache/incubator-gluten/pull/5583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DNM][GLUTEN-5548][VL] test dynamic setting [incubator-gluten]

2024-04-29 Thread via GitHub
zhli1142015 commented on PR #5506: URL: https://github.com/apache/incubator-gluten/pull/5506#issuecomment-2084358881 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Daily Update Velox Version (2024_04_30) [incubator-gluten]

2024-04-29 Thread via GitHub
GlutenPerfBot commented on PR #5583: URL: https://github.com/apache/incubator-gluten/pull/5583#issuecomment-2084340812 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-29 Thread via GitHub
honeyhexin commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2084334638 I'd like to take cot, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [DNM][GLUTEN-5548][VL] test dynamic setting [incubator-gluten]

2024-04-29 Thread via GitHub
zhli1142015 commented on PR #5506: URL: https://github.com/apache/incubator-gluten/pull/5506#issuecomment-2084313882 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] I can't build gluten on an Intel MacOS machine [incubator-gluten]

2024-04-29 Thread via GitHub
acvictor commented on issue #5491: URL: https://github.com/apache/incubator-gluten/issues/5491#issuecomment-2084311339 Can you try installing `PkgConfig` as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [VL] Enable split preloading by default [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5456: URL: https://github.com/apache/incubator-gluten/pull/5456#issuecomment-2084301680 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_04_30) [incubator-gluten]

2024-04-29 Thread via GitHub
zhouyuan commented on PR #5583: URL: https://github.com/apache/incubator-gluten/pull/5583#issuecomment-2084297493 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [VL]java.lang.UnsupportedOperationException [incubator-gluten]

2024-04-29 Thread via GitHub
acvictor commented on issue #5508: URL: https://github.com/apache/incubator-gluten/issues/5508#issuecomment-2084296096 @RaoZhiRou-Z can you please share a repro? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2084295020 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2084293802 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
ulysses-you commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2084293844 @Yohahaha oh, I see your concern now.. I added test for the case `spark.gluten.sql.columnar.backend.velox.loadQuantum` -- This is an automated message from the Apache Git

Re: [I] [VL] It's crash when load libgluten.so [incubator-gluten]

2024-04-29 Thread via GitHub
SonixLegend closed issue #5531: [VL] It's crash when load libgluten.so URL: https://github.com/apache/incubator-gluten/issues/5531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [VL] It's crash when load libgluten.so [incubator-gluten]

2024-04-29 Thread via GitHub
SonixLegend commented on issue #5531: URL: https://github.com/apache/incubator-gluten/issues/5531#issuecomment-2084283360 It's solved. When using AMD CPU, suggest use VMware instead of VirtualBox. And where to use and where to compile, even Ubuntu based on Debian can't use static

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5585: URL: https://github.com/apache/incubator-gluten/pull/5585#issuecomment-2084236911 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5585: URL: https://github.com/apache/incubator-gluten/pull/5585#issuecomment-2084224028 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5585: URL: https://github.com/apache/incubator-gluten/pull/5585#issuecomment-2084222626 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
kyligence-git opened a new pull request, #5585: URL: https://github.com/apache/incubator-gluten/pull/5585 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [VL] TPCDS bloom filter all fallbacked [incubator-gluten]

2024-04-29 Thread via GitHub
ulysses-you commented on issue #5577: URL: https://github.com/apache/incubator-gluten/issues/5577#issuecomment-2084184488 @zhouyuan it should be ok, the golden files have checked both shuffled hash join(by disabling autoBroadcastThreshold) and broadcast hash join. @liujiayi771 yeah,

[I] ERROR: cannot verify repo.anaconda.com's certificate [incubator-gluten]

2024-04-29 Thread via GitHub
ychris78 opened a new issue, #5584: URL: https://github.com/apache/incubator-gluten/issues/5584 ### Description When I compile gluten on Alibaba Cloud ECS according to **_docs/developers/docker_centos7.md_** in the project, the following error always occurs. **Error log:**

Re: [I] [VL] TPCDS bloom filter all fallbacked [incubator-gluten]

2024-04-29 Thread via GitHub
zhouyuan commented on issue #5577: URL: https://github.com/apache/incubator-gluten/issues/5577#issuecomment-2084153015 @ulysses-you currently the tests are using scale factor 1 and I find BHJ are always used. We may need to increase the scale factor or do more configurations to get a more

Re: [I] [VL] TPCDS bloom filter all fallbacked [incubator-gluten]

2024-04-29 Thread via GitHub
ulysses-you commented on issue #5577: URL: https://github.com/apache/incubator-gluten/issues/5577#issuecomment-2084132504 For now, golden files only cover tpch.. tpcds is on the way cc @zwangsheng -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [VL] TPCDS bloom filter all fallbacked [incubator-gluten]

2024-04-29 Thread via GitHub
Yohahaha commented on issue #5577: URL: https://github.com/apache/incubator-gluten/issues/5577#issuecomment-2084123116 I'm curious why golden file check is passed when there is fallback? cc @ulysses-you -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-4896] Upgrade Spark33 version to Spark3.3.4 [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #4897: URL: https://github.com/apache/incubator-gluten/pull/4897#issuecomment-2084118115 This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. -- This is an automated

Re: [PR] [VL][DOC] Fix certificate expired when build on CentOS 7 [incubator-gluten]

2024-04-29 Thread via GitHub
PHILO-HE merged PR #5576: URL: https://github.com/apache/incubator-gluten/pull/5576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL][DOC] Fix certificate expired when build on CentOS 7 (#5576)

2024-04-29 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new e624dc7e8 [VL][DOC] Fix certificate

Re: [PR] [GLUTEN-5476][CH] Triger merge on insert task [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5529: URL: https://github.com/apache/incubator-gluten/pull/5529#issuecomment-2084106504 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
Yohahaha commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2084105568 > yes, it works. > > ``` > VeloxBackend.cc:140] VeloxBackend config: > ... > [spark.gluten.sql.columnar.backend.velox.loadQuantum, 128m] > ... > ```

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
baibaichen closed pull request #5582: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) URL: https://github.com/apache/incubator-gluten/pull/5582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
baibaichen commented on PR #5582: URL: https://github.com/apache/incubator-gluten/pull/5582#issuecomment-2084087625 Close it because rebase issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
ulysses-you commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2084032224 @Yohahaha is there any more comments ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(incubator-gluten) branch main updated: [Gluten-5534][VL] Fix shuffle OOM if input batch is extremely large (#5536)

2024-04-29 Thread marong
This is an automated email from the ASF dual-hosted git repository. marong pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 14ab4e828 [Gluten-5534][VL] Fix shuffle

Re: [I] [VL] shuffle writer OOM if input RowVector is extremely large [incubator-gluten]

2024-04-29 Thread via GitHub
marin-ma closed issue #5534: [VL] shuffle writer OOM if input RowVector is extremely large URL: https://github.com/apache/incubator-gluten/issues/5534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix shuffle OOM if input batch is extremely large [incubator-gluten]

2024-04-29 Thread via GitHub
marin-ma merged PR #5536: URL: https://github.com/apache/incubator-gluten/pull/5536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-29 Thread via GitHub
yma11 commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2083951216 > > @FelixYBW This fix should be done at cpp side. The formal fix is in [PR](https://github.com/apache/incubator-gluten/pull/5544). Can you help review it? > > Is it

Re: [PR] [VL] Bloom-filter expressions are unexpectedly fallen back [incubator-gluten]

2024-04-29 Thread via GitHub
zhztheplayer merged PR #5579: URL: https://github.com/apache/incubator-gluten/pull/5579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Bloom-filter expressions are unexpectedly fallen back (#5579)

2024-04-29 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 6a04248dc [VL] Bloom-filter expressions

Re: [I] [VL] TPCDS bloom filter all fallbacked [incubator-gluten]

2024-04-29 Thread via GitHub
zhztheplayer closed issue #5577: [VL] TPCDS bloom filter all fallbacked URL: https://github.com/apache/incubator-gluten/issues/5577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [VL] Daily Update Velox Version (2024_04_30) [incubator-gluten]

2024-04-29 Thread via GitHub
GlutenPerfBot opened a new pull request, #5583: URL: https://github.com/apache/incubator-gluten/pull/5583 Upstream Velox's New Commits: ```txt 85fd5c6d1 by Mike Lui, arrow_testing autodeps 4a0383b11 by cindyyyang, Mark 'arbitrary' Presto aggregate function order sensitive

Re: [PR] [VL] Daily Update Velox Version (2024_04_30) [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5583: URL: https://github.com/apache/incubator-gluten/pull/5583#issuecomment-2083904773 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5582: URL: https://github.com/apache/incubator-gluten/pull/5582#issuecomment-2083831082 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5582: URL: https://github.com/apache/incubator-gluten/pull/5582#issuecomment-2083830836 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240430) [incubator-gluten]

2024-04-29 Thread via GitHub
kyligence-git opened a new pull request, #5582: URL: https://github.com/apache/incubator-gluten/pull/5582 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

(incubator-gluten) branch main updated: Update function suppport (#5578)

2024-04-29 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new ce4652808 Update function suppport

Re: [PR] [VL][Doc] Update Velox backend support progress [incubator-gluten]

2024-04-29 Thread via GitHub
FelixYBW merged PR #5578: URL: https://github.com/apache/incubator-gluten/pull/5578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL][Doc] Update Velox backend support progress [incubator-gluten]

2024-04-29 Thread via GitHub
FelixYBW commented on PR #5578: URL: https://github.com/apache/incubator-gluten/pull/5578#issuecomment-2083749487 Thank you for update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(incubator-gluten) branch main updated: [GLUTEN-5571][DOC] Update Velox build info #5571 (#5572)

2024-04-29 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 59103801e [GLUTEN-5571][DOC] Update

Re: [I] [GLUTEN-5571][DOC] Update Velox build info [incubator-gluten]

2024-04-29 Thread via GitHub
FelixYBW closed issue #5571: [GLUTEN-5571][DOC] Update Velox build info URL: https://github.com/apache/incubator-gluten/issues/5571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5571][DOC] Update Velox build info #5571 [incubator-gluten]

2024-04-29 Thread via GitHub
FelixYBW merged PR #5572: URL: https://github.com/apache/incubator-gluten/pull/5572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Result mismatch issues Tracker [incubator-gluten]

2024-04-29 Thread via GitHub
FelixYBW commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2083300105 > @FelixYBW This fix should be done at cpp side. The formal fix is in [PR](https://github.com/apache/incubator-gluten/pull/5544). Can you help review it? Is it a

Re: [PR] [VL] Fallback window operator when the range frame contain literal [incubator-gluten]

2024-04-29 Thread via GitHub
FelixYBW commented on PR #5431: URL: https://github.com/apache/incubator-gluten/pull/5431#issuecomment-2083293543 > > @FelixYBW, I just submitted a pr to fix this issue: #5561. Thank you! Does Spark UT cover this case? -- This is an automated message from the Apache Git

Re: [PR] [VL] Enable array_size Spark function [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5539: URL: https://github.com/apache/incubator-gluten/pull/5539#issuecomment-2082852171 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable array_size Spark function [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5539: URL: https://github.com/apache/incubator-gluten/pull/5539#issuecomment-2082787239 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Bloom-filter expressions are unexpectedly fallen back [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5579: URL: https://github.com/apache/incubator-gluten/pull/5579#issuecomment-2082750799 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5580][CH]Fix cast to int exceed max [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5581: URL: https://github.com/apache/incubator-gluten/pull/5581#issuecomment-2082666475 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [CH] Result different from spark while cast float to int while the value exceed int max [incubator-gluten]

2024-04-29 Thread via GitHub
KevinyhZou opened a new issue, #5580: URL: https://github.com/apache/incubator-gluten/issues/5580 ### Backend CH (ClickHouse) ### Bug description When select cast(17139619200/100 as int) the gluten value is INT32.MIN, but spark value is INT32.MAX ###

Re: [PR] [GLUTEN-5580][CH]Fix cast to int exceed max [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5581: URL: https://github.com/apache/incubator-gluten/pull/5581#issuecomment-2082665799 https://github.com/apache/incubator-gluten/issues/5580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Bloom-filter expressions are unexpectedly fallen back [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5579: URL: https://github.com/apache/incubator-gluten/pull/5579#issuecomment-2082595095 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Bloom-filter expressions are unexpectedly fallen back [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5579: URL: https://github.com/apache/incubator-gluten/pull/5579#issuecomment-2082565155 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Bloom-filter expressions are unexpectedly fallen back [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5579: URL: https://github.com/apache/incubator-gluten/pull/5579#issuecomment-2082564713 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
ulysses-you commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2082458192 yes, it works. ``` VeloxBackend.cc:140] VeloxBackend config: ... [spark.gluten.sql.columnar.backend.velox.loadQuantum, 128m] ... ``` -- This is an

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
Yohahaha commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2082436619 > @Yohahaha It affects the gluten config which use `createOptional`. So far, there is no valid config be affected, It is to avoid potential issue in future. would you

Re: [I] [VL] TPCDS bloom filter all fallbacked [incubator-gluten]

2024-04-29 Thread via GitHub
Yohahaha commented on issue #5577: URL: https://github.com/apache/incubator-gluten/issues/5577#issuecomment-2082430490 > @Yohahaha hi yang, no, this is not expected. Hongze is still refactoring on the RAS part if i understand correctly > > thanks, > -yuan thank you for the

Re: [I] [VL] TPCDS bloom filter all fallbacked [incubator-gluten]

2024-04-29 Thread via GitHub
zhouyuan commented on issue #5577: URL: https://github.com/apache/incubator-gluten/issues/5577#issuecomment-2082418024 @Yohahaha hi yang, no, this is not expected. Hongze is still refactoring on the RAS part if i understand correctly thanks, -yuan -- This is an automated

Re: [PR] [VL][Doc] Update Velox backend support progress [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5578: URL: https://github.com/apache/incubator-gluten/pull/5578#issuecomment-2082402042 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][Doc] Update Velox backend support progress [incubator-gluten]

2024-04-29 Thread via GitHub
acvictor opened a new pull request, #5578: URL: https://github.com/apache/incubator-gluten/pull/5578 Update Velox support progress for `bit_xor` and `array_remove`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [VL][Doc] Update Velox backend support progress [incubator-gluten]

2024-04-29 Thread via GitHub
acvictor commented on PR #5578: URL: https://github.com/apache/incubator-gluten/pull/5578#issuecomment-2082402484 @PHILO-HE can you please review? These 2 functions have expression mappings in Gluten. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-5476][CH] Triger merge on insert task [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5529: URL: https://github.com/apache/incubator-gluten/pull/5529#issuecomment-2082388438 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable array_size Spark function [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5539: URL: https://github.com/apache/incubator-gluten/pull/5539#issuecomment-2082349788 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
ulysses-you commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2082336011 @Yohahaha It affects the gluten config which use `createOptional`. So far, there is no valid config be affected, It is to avoid potential issue in future. -- This is an

Re: [PR] [VL][DOC] Fix certificate expired when build on CentOS 7 [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5576: URL: https://github.com/apache/incubator-gluten/pull/5576#issuecomment-2082317406 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL][DOC] Fix certificate expired when build on CentOS 7 [incubator-gluten]

2024-04-29 Thread via GitHub
zml1206 opened a new pull request, #5576: URL: https://github.com/apache/incubator-gluten/pull/5576 ## What changes were proposed in this pull request? Build error: ``` --2024-04-29 09:21:36-- https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh Resolving

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
Yohahaha commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2082299498 may I ask which config be affected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_04_29) (#5568)

2024-04-29 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new c505fe93d [VL] Daily Update Velox

Re: [PR] [VL] Daily Update Velox Version (2024_04_29) [incubator-gluten]

2024-04-29 Thread via GitHub
zhouyuan merged PR #5568: URL: https://github.com/apache/incubator-gluten/pull/5568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] RAS: Include rewrite rules used by RewriteSparkPlanRulesManager in EnumeratedTransform [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5575: URL: https://github.com/apache/incubator-gluten/pull/5575#issuecomment-2082261043 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2082121590 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4652][VL] Fix min_by/max_by result mismatch [incubator-gluten]

2024-04-29 Thread via GitHub
zhouyuan merged PR #5544: URL: https://github.com/apache/incubator-gluten/pull/5544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-4652][VL] Fix min_by/max_by result mismatch (#5544)

2024-04-29 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 049a47750 [GLUTEN-4652][VL] Fix

Re: [PR] [VL] RAS: Include RewriteSparkPlanRulesManager in EnumeratedApplier [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5575: URL: https://github.com/apache/incubator-gluten/pull/5575#issuecomment-2082087484 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Include RewriteSparkPlanRulesManager in EnumeratedApplier [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5575: URL: https://github.com/apache/incubator-gluten/pull/5575#issuecomment-2082082568 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Include RewriteSparkPlanRulesManager in EnumeratedApplier [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5575: URL: https://github.com/apache/incubator-gluten/pull/5575#issuecomment-2082083693 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Include RewriteSparkPlanRulesManager in EnumeratedApplier [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5575: URL: https://github.com/apache/incubator-gluten/pull/5575#issuecomment-2082074154 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Include RewriteSparkPlanRulesManager in EnumeratedApplier [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5575: URL: https://github.com/apache/incubator-gluten/pull/5575#issuecomment-2082066717 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] RAS: Include RewriteSparkPlanRulesManager in EnumeratedApplier [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5575: URL: https://github.com/apache/incubator-gluten/pull/5575#issuecomment-2082066361 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] RAS: Include RewriteSparkPlanRulesManager in EnumeratedApplier [incubator-gluten]

2024-04-29 Thread via GitHub
zhztheplayer opened a new pull request, #5575: URL: https://github.com/apache/incubator-gluten/pull/5575 The patch improves EnumerabledApplier to move RewriteSparkPlanRulesManager from heuristic rule list to RAS rule list. 1. Add guard

Re: [PR] [GLUTEN-4652] Fix min_by/max_by result mismatch [incubator-gluten]

2024-04-29 Thread via GitHub
yma11 commented on PR #5544: URL: https://github.com/apache/incubator-gluten/pull/5544#issuecomment-2082022644 @rui-mo your comments are addressed. Please help review again. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-4652] Fix min_by/max_by result mismatch [incubator-gluten]

2024-04-29 Thread via GitHub
yma11 commented on code in PR #5544: URL: https://github.com/apache/incubator-gluten/pull/5544#discussion_r1582619840 ## cpp/velox/operators/functions/RowConstructorWithAllNull.h: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2081987726 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #5573: URL: https://github.com/apache/incubator-gluten/pull/5573#issuecomment-2081987410 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Fix gluten createOptional config contains Some [incubator-gluten]

2024-04-29 Thread via GitHub
ulysses-you opened a new pull request, #5573: URL: https://github.com/apache/incubator-gluten/pull/5573 ## What changes were proposed in this pull request? `OptionalConfigEntry.readFrom(reader).toString` would return `Some(xxx)` rather than `xxx`. It affects the gluten config which