github-actions[bot] commented on PR #5717:
URL:
https://github.com/apache/incubator-gluten/pull/5717#issuecomment-2106713071
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhztheplayer commented on PR #5723:
URL:
https://github.com/apache/incubator-gluten/pull/5723#issuecomment-2106713027
> InheritFromCaseClass
I'll add some documents addressing this, In the next PR. Thank you for the
suggestion.
--
This is an automated message from the Apache Git
FelixYBW commented on issue #3030:
URL:
https://github.com/apache/incubator-gluten/issues/3030#issuecomment-2106707094
Hash-join(build) Velox community is working on this now
update: PR merged. https://github.com/facebookincubator/velox/pull/8894
Enabling in Gluten
--
This is an
gaoyangxiaozhu commented on issue #5315:
URL:
https://github.com/apache/incubator-gluten/issues/5315#issuecomment-2106701134
kindly ping @zhouyuan / @rui-mo / @FelixYBW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gaoyangxiaozhu closed pull request #5706: [DNM] Test CI with Main
URL: https://github.com/apache/incubator-gluten/pull/5706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 74f3061d8 [GLUTEN-5708][VL] Minor wording
PHILO-HE merged PR #5707:
URL: https://github.com/apache/incubator-gluten/pull/5707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gaoyangxiaozhu commented on PR #5351:
URL:
https://github.com/apache/incubator-gluten/pull/5351#issuecomment-2106683468
@yma11 / @zhouyuan / @rui-mo / @FelixYBW could you help review for this
change ?
--
This is an automated message from the Apache Git Service.
To respond to the
yma11 commented on PR #5711:
URL:
https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106682216
> @yma11 Did you reproduced the problem I mentioned above based on the
master gluten branch? That is what I'm trying to fix.
I mean which part of your code changes in this
This is an automated email from the ASF dual-hosted git repository.
ulyssesyou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 7324ffe22 [BUILD] Remove duplicated
ulysses-you merged PR #5703:
URL: https://github.com/apache/incubator-gluten/pull/5703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhztheplayer commented on PR #5723:
URL:
https://github.com/apache/incubator-gluten/pull/5723#issuecomment-2106642881
cc @PHILO-HE @JkSelf @zzcclp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on PR #5723:
URL:
https://github.com/apache/incubator-gluten/pull/5723#issuecomment-2106635608
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5723:
URL:
https://github.com/apache/incubator-gluten/pull/5723#issuecomment-2106635374
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
github-actions[bot] commented on PR #5722:
URL:
https://github.com/apache/incubator-gluten/pull/5722#issuecomment-2106635340
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhztheplayer opened a new pull request, #5723:
URL: https://github.com/apache/incubator-gluten/pull/5723
This uses Scala linter `wartremover` and its maven plugin. And I wrote a
custom wart for this.
The jar including the custom wart:
github-actions[bot] commented on PR #5722:
URL:
https://github.com/apache/incubator-gluten/pull/5722#issuecomment-2106635149
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
zhli1142015 opened a new pull request, #5722:
URL: https://github.com/apache/incubator-gluten/pull/5722
## What changes were proposed in this pull request?
Add test for shuffle function.
## How was this patch tested?
UT.
--
This is an automated message from the
jinchengchenghh commented on PR #5654:
URL:
https://github.com/apache/incubator-gluten/pull/5654#issuecomment-2106601759
Can you help merge it? Thanks! @zhouyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
zhouyifan279 commented on PR #5711:
URL:
https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106594968
> I think I used to test the `"spark.default.parallelism", "2"` in previous
fix and it worked. So what's the root cause of the failure as you tested? which
part is the
github-actions[bot] commented on PR #5692:
URL:
https://github.com/apache/incubator-gluten/pull/5692#issuecomment-2106587307
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zhouyifan279 commented on PR #5711:
URL:
https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106586947
@yma11 Did you reproduced the problem I mentioned
[here](https://github.com/apache/incubator-gluten/pull/5544#issuecomment-2106285804)
based on the master gluten branch?
xumingming commented on code in PR #5707:
URL: https://github.com/apache/incubator-gluten/pull/5707#discussion_r1597838391
##
docs/developers/NewToGluten.md:
##
@@ -78,18 +76,18 @@ If you need to debug the tests in /gluten-ut, You
need to compile java c
# Java/scala code
acvictor commented on PR #5632:
URL:
https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2106576935
> can't we leverage `metadatacolumns` for this since it already contains
`fileSize` and `modifyTime` ?
Does `metadatacolumns` always contain file size and modification
gaoyangxiaozhu commented on PR #5632:
URL:
https://github.com/apache/incubator-gluten/pull/5632#issuecomment-2106556570
can't we leverage `metadatacolumns` for this since it already contains
`fileSize` and `modifyTime` ?
--
This is an automated message from the Apache Git Service.
To
FelixYBW commented on issue #5700:
URL:
https://github.com/apache/incubator-gluten/issues/5700#issuecomment-2106549620
In our plan, the validation should all happens in native library. native
library should have all the info it supports the expression/operators or not.
But Velox itself
zhouyuan closed pull request #5719: [VL] Daily Update Velox Version (2024_05_13)
URL: https://github.com/apache/incubator-gluten/pull/5719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
PHILO-HE commented on issue #4652:
URL:
https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2106541754
> @PHILO-HE Any update of the issues here?
@FelixYBW, Some were actually fixed. Just updated the list. Will fix or seek
help to fix other issues.
--
This is an
yma11 commented on code in PR #5697:
URL: https://github.com/apache/incubator-gluten/pull/5697#discussion_r1597809927
##
gluten-core/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala:
##
@@ -738,5 +739,7 @@ trait SparkPlanExecApi {
def
FelixYBW commented on PR #5447:
URL:
https://github.com/apache/incubator-gluten/pull/5447#issuecomment-2106536617
Th
> TPCH SF2000 Q6 performance, query: `select sum(l_extendedprice *
l_discount) as revenue from lineitem where l_shipdate >= '1994-01-01' and
l_shipdate <
github-actions[bot] commented on PR #5697:
URL:
https://github.com/apache/incubator-gluten/pull/5697#issuecomment-2106535242
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
philo pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
from 09950de2d [GLUTEN-5414] [VL] Move ArrowFileScanExec class to module
backends-velox
add c8c17ddde
PHILO-HE merged PR #5670:
URL: https://github.com/apache/incubator-gluten/pull/5670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
PHILO-HE closed issue #5682: [VL]isNull and isNotNull both exist in filter
condition, the result is not correct
URL: https://github.com/apache/incubator-gluten/issues/5682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #5351:
URL:
https://github.com/apache/incubator-gluten/pull/5351#issuecomment-2106534149
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
zjuwangg commented on code in PR #5670:
URL: https://github.com/apache/incubator-gluten/pull/5670#discussion_r1597802334
##
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##
@@ -375,6 +377,8 @@ class SubstraitToVeloxPlanConverter {
bool nullAllowed_ = false;
bool
zjuwangg commented on code in PR #5670:
URL: https://github.com/apache/incubator-gluten/pull/5670#discussion_r1597802334
##
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##
@@ -375,6 +377,8 @@ class SubstraitToVeloxPlanConverter {
bool nullAllowed_ = false;
bool
zjuwangg commented on code in PR #5670:
URL: https://github.com/apache/incubator-gluten/pull/5670#discussion_r1597801707
##
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##
@@ -375,6 +377,8 @@ class SubstraitToVeloxPlanConverter {
bool nullAllowed_ = false;
bool
github-actions[bot] commented on PR #5690:
URL:
https://github.com/apache/incubator-gluten/pull/5690#issuecomment-2106516847
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kecookier commented on issue #5638:
URL:
https://github.com/apache/incubator-gluten/issues/5638#issuecomment-2106511503
Yes, we can pass the table schema parameter (dataColumns) when creating a
HiveTableHandle, but currently it's set to nullptr.
kecookier commented on issue #5638:
URL:
https://github.com/apache/incubator-gluten/issues/5638#issuecomment-2106505004
https://github.com/apache/incubator-gluten/blob/main/cpp/velox/substrait/SubstraitToVeloxPlan.cc#L1094
--
This is an automated message from the Apache Git Service.
To
PHILO-HE commented on code in PR #5707:
URL: https://github.com/apache/incubator-gluten/pull/5707#discussion_r1597789310
##
docs/developers/NewToGluten.md:
##
@@ -78,18 +76,18 @@ If you need to debug the tests in /gluten-ut, You
need to compile java c
# Java/scala code
github-actions[bot] commented on PR #5155:
URL:
https://github.com/apache/incubator-gluten/pull/5155#issuecomment-2106489789
This PR is stale because it has been open 45 days with no activity. Remove
stale label or comment or this will be closed in 10 days.
--
This is an automated
PHILO-HE commented on issue #5700:
URL:
https://github.com/apache/incubator-gluten/issues/5700#issuecomment-2106480847
> > Maybe, there are some cases that the expected fallback doesn't happen
when validation fails. Do you have any findings that need us to fix?
>
> @PHILO-HE thanks
This is an automated email from the ASF dual-hosted git repository.
hongze pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 09950de2d [GLUTEN-5414] [VL] Move
zhztheplayer merged PR #5667:
URL: https://github.com/apache/incubator-gluten/pull/5667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yma11 commented on PR #5711:
URL:
https://github.com/apache/incubator-gluten/pull/5711#issuecomment-210644
I think I used to test the `"spark.default.parallelism", "2"` in previous
fix and it worked. So what's the root cause of the failure as you tested? which
part is the
jinchengchenghh commented on code in PR #5697:
URL: https://github.com/apache/incubator-gluten/pull/5697#discussion_r1597774118
##
gluten-core/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala:
##
@@ -738,5 +739,7 @@ trait SparkPlanExecApi {
def
yma11 commented on PR #5697:
URL:
https://github.com/apache/incubator-gluten/pull/5697#issuecomment-2106459377
@jinchengchenghh @zhouyuan please help take a review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
PHILO-HE commented on code in PR #5670:
URL: https://github.com/apache/incubator-gluten/pull/5670#discussion_r1597772087
##
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##
@@ -375,6 +377,8 @@ class SubstraitToVeloxPlanConverter {
bool nullAllowed_ = false;
bool
PHILO-HE commented on code in PR #5670:
URL: https://github.com/apache/incubator-gluten/pull/5670#discussion_r1597772087
##
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##
@@ -375,6 +377,8 @@ class SubstraitToVeloxPlanConverter {
bool nullAllowed_ = false;
bool
zhouyuan opened a new issue, #5720:
URL: https://github.com/apache/incubator-gluten/issues/5720
### Description
By default gluten with Velox backend will use Shuffled Hash Join to get
better performance. Sort Merge Join is still useful in some cases 1) very big
table on build side
GlutenPerfBot opened a new pull request, #5719:
URL: https://github.com/apache/incubator-gluten/pull/5719
Upstream Velox's New Commits:
```txt
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #5719:
URL:
https://github.com/apache/incubator-gluten/pull/5719#issuecomment-2106422429
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
github-actions[bot] commented on PR #5717:
URL:
https://github.com/apache/incubator-gluten/pull/5717#issuecomment-2106415368
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
FelixYBW commented on issue #5718:
URL:
https://github.com/apache/incubator-gluten/issues/5718#issuecomment-2106413392
@zhztheplayer what does arrowcontext used for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
FelixYBW opened a new issue, #5718:
URL: https://github.com/apache/incubator-gluten/issues/5718
### Description
```
rror Source: RUNTIME
Error Code: INVALID_STATE
Reason: Operator::getOutput failed for [operator: ValueStream, plan node ID:
0]: Error during calling Java code
github-actions[bot] commented on PR #5717:
URL:
https://github.com/apache/incubator-gluten/pull/5717#issuecomment-2106412894
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on PR #5717:
URL:
https://github.com/apache/incubator-gluten/pull/5717#issuecomment-2106412827
https://github.com/apache/incubator-gluten/issues/5414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jinchengchenghh opened a new pull request, #5717:
URL: https://github.com/apache/incubator-gluten/pull/5717
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FelixYBW opened a new issue, #5716:
URL: https://github.com/apache/incubator-gluten/issues/5716
### Backend
VL (Velox)
### Bug description
```
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Operator::getOutput failed for [operator: ValueStream, plan
zhouyuan commented on PR #5654:
URL:
https://github.com/apache/incubator-gluten/pull/5654#issuecomment-2106412392
https://github.com/apache/incubator-gluten/issues/5679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
FelixYBW opened a new issue, #5715:
URL: https://github.com/apache/incubator-gluten/issues/5715
### Backend
VL (Velox)
### Bug description
```
24/05/09 02:47:34 WARN [task-result-getter-0] scheduler.TaskSetManager: Lost
task 123.0 in stage 0.0 (TID 123)
FelixYBW opened a new issue, #5714:
URL: https://github.com/apache/incubator-gluten/issues/5714
### Backend
VL (Velox)
### Bug description
```
rror Source: RUNTIME
Error Code: INVALID_STATE
Reason: Operator::getOutput failed for [operator: ValueStream, plan node
FelixYBW opened a new issue, #5713:
URL: https://github.com/apache/incubator-gluten/issues/5713
### Backend
VL (Velox)
### Bug description
```
rror Source: RUNTIME
Error Code: INVALID_STATE
Reason: (0 vs. 0)
Retriable: False
Expression: offsetInRun_ <
FelixYBW closed issue #4678: [VL] result mismatch on hash aggregate
URL: https://github.com/apache/incubator-gluten/issues/4678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
FelixYBW commented on issue #4678:
URL:
https://github.com/apache/incubator-gluten/issues/4678#issuecomment-2106411150
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FelixYBW closed issue #706: [Velox backend] Track mapped memory allocation
URL: https://github.com/apache/incubator-gluten/issues/706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FelixYBW closed issue #544: Velox Operator Support List
URL: https://github.com/apache/incubator-gluten/issues/544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FelixYBW closed issue #683: Nan isn't supported in Velox backend
URL: https://github.com/apache/incubator-gluten/issues/683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FelixYBW closed issue #1025: [VL] bug of parquet read
URL: https://github.com/apache/incubator-gluten/issues/1025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FelixYBW closed issue #1026: [VL] arrow conversion bug
URL: https://github.com/apache/incubator-gluten/issues/1026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FelixYBW closed issue #2813: [VL] partition write support
URL: https://github.com/apache/incubator-gluten/issues/2813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
FelixYBW closed issue #953: [Gluten-Velox] To do list in 2023
URL: https://github.com/apache/incubator-gluten/issues/953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jinchengchenghh commented on PR #5654:
URL:
https://github.com/apache/incubator-gluten/pull/5654#issuecomment-2106408216
Can you help rerun the failed test? This failure is not related to the PR.
@zhouyuan
--
This is an automated message from the Apache Git Service.
To respond to the
jinchengchenghh commented on PR #5654:
URL:
https://github.com/apache/incubator-gluten/pull/5654#issuecomment-2106407716
Spark 33 result:
http://schemas.microsoft.com/office/2004/12/omml;
xmlns="http://www.w3.org/TR/REC-html40;>