(incubator-gluten) branch main updated: [VL] CI: Gluten-it: Fix unreadable test reporting when there are query failures (#5753)

2024-05-14 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 3b8ea67f4 [VL] CI: Gluten-it: Fix

Re: [PR] [VL] CI: Gluten-it: Fix unreadable test reporting when there are query failures [incubator-gluten]

2024-05-14 Thread via GitHub
zhztheplayer merged PR #5753: URL: https://github.com/apache/incubator-gluten/pull/5753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Fallback Window operator if there is a mismatch in output type [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5554: URL: https://github.com/apache/incubator-gluten/pull/5554#issuecomment-2111641669 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fallback Window operator if there is a mismatch in output type [incubator-gluten]

2024-05-14 Thread via GitHub
JkSelf commented on PR #5554: URL: https://github.com/apache/incubator-gluten/pull/5554#issuecomment-2111634623 > Is it spark only? if Not is it easy to fix in Velox? Can you open an issue to track in Velox? > > Let's merge this until it's fixed in Velox. @FelixYBW This is a

(incubator-gluten) branch main updated: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240515) (#5747)

2024-05-14 Thread changchen
100644 --- a/cpp-ch/clickhouse.version +++ b/cpp-ch/clickhouse.version @@ -1,3 +1,3 @@ CH_ORG=Kyligence -CH_BRANCH=rebase_ch/20240514 -CH_COMMIT=c0d37f6fa5b \ No newline at end of file +CH_BRANCH=rebase_ch/20240515 +CH_COMMIT=00867009134 \ No newline at end of file diff --git a/cpp-ch/local-engine

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240515) [incubator-gluten]

2024-05-14 Thread via GitHub
baibaichen merged PR #5747: URL: https://github.com/apache/incubator-gluten/pull/5747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [VL] Drop the test table after all tests in FallbackSuite (#5737)

2024-05-14 Thread philo
This is an automated email from the ASF dual-hosted git repository. philo pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new ba64f4c22 [VL] Drop the test table after

Re: [PR] [VL] Drop the test table after all tests in FallbackSuite [incubator-gluten]

2024-05-14 Thread via GitHub
PHILO-HE merged PR #5737: URL: https://github.com/apache/incubator-gluten/pull/5737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Unify all configs into GlutenConfig.h [incubator-gluten]

2024-05-14 Thread via GitHub
FelixYBW commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2111613633 > I do believe we don't yet have a very clear design for relationship between these Scala/CPP modules. But until we start a complete refactor, I think we can just follow the

Re: [PR] [VL] CI: Gluten-it: Fix unreadable test reporting when there are query failures [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5753: URL: https://github.com/apache/incubator-gluten/pull/5753#issuecomment-2111601200 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] CI: Gluten-it: Fix unreadable test reporting when there are query failures [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5753: URL: https://github.com/apache/incubator-gluten/pull/5753#issuecomment-2111592269 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] CI: Gluten-it: Fix unreadable test reporting when there are query failures [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5753: URL: https://github.com/apache/incubator-gluten/pull/5753#issuecomment-2111591781 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] CI: Gluten-it: Fix unreadable test reporting when there are query failures [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5753: URL: https://github.com/apache/incubator-gluten/pull/5753#issuecomment-2111591581 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] CI: Gluten-it: Fix unreadable test reporting when there are query failures [incubator-gluten]

2024-05-14 Thread via GitHub
zhztheplayer opened a new pull request, #5753: URL: https://github.com/apache/incubator-gluten/pull/5753 1. Avoid exception during test reporting if not query was passed; 2. Avoid swallowing console output with query failures; Tested locally. -- This is an automated message from

Re: [PR] [GLUTEN-5414] [VL] Support datasource v2 scan csv [incubator-gluten]

2024-05-14 Thread via GitHub
liujiayi771 commented on PR #5717: URL: https://github.com/apache/incubator-gluten/pull/5717#issuecomment-2111564702 I have found an issue: when reading large CSV files, for example, when a single CSV file in a table is 300M, the peak memory usage of arrow memory pool during

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111536591 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2111530688 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2111527701 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2111526654 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Spark 3.5 Unit Tests track [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on issue #5309: URL: https://github.com/apache/incubator-gluten/issues/5309#issuecomment-2111521825 The PR for enable `GlutenParquetRowIndexSuite` https://github.com/apache/incubator-gluten/pull/5740 -- This is an automated message from the Apache Git Service.

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111520790 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5752: URL: https://github.com/apache/incubator-gluten/pull/5752#issuecomment-2111520635 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Add decimal precision tests [incubator-gluten]

2024-05-14 Thread via GitHub
ulysses-you opened a new pull request, #5752: URL: https://github.com/apache/incubator-gluten/pull/5752 ## What changes were proposed in this pull request? - Port `DecimalPrecisionSuite` into gluten. - Add dataType in `ExpressionTransformer` to help check data type ## How

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600889837 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#issuecomment-2111519146 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
JkSelf commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600900081 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */ package

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
JkSelf commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600899036 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */ package

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
JkSelf commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600899036 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */ package

Re: [PR] [VL] Unify all configs into GlutenConfig.h [incubator-gluten]

2024-05-14 Thread via GitHub
Yohahaha commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2111514831 > I would second this. Would you like to use that approach, temporarily? ok, I will do this. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#issuecomment-2111514323 @zhli1142015 could you help merge ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600897170 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */

Re: [I] [VL] Support customize options for parquet native write [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on issue #5751: URL: https://github.com/apache/incubator-gluten/issues/5751#issuecomment-2111513538 @JkSelf let use this issue to track the customized `block_size`, `page_size` not support problem. -- This is an automated message from the Apache Git Service.

Re: [PR] [CORE] Remove wrong comment for JoinSelectionOverrides [incubator-gluten]

2024-05-14 Thread via GitHub
zhztheplayer commented on PR #5730: URL: https://github.com/apache/incubator-gluten/pull/5730#issuecomment-2111513577 cc @rui-mo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] [VL] Support customize options for parquet native write [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu opened a new issue, #5751: URL: https://github.com/apache/incubator-gluten/issues/5751 ### Description Currently, parquet native write doesn't support customized option as `block_size`, `page_size` etc. when write data. There is a onging PR in velox side

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2111509172 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2111509008 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-14 Thread via GitHub
zml1206 opened a new pull request, #5750: URL: https://github.com/apache/incubator-gluten/pull/5750 ## What changes were proposed in this pull request? Background history: [SPARK-36612](https://issues.apache.org/jira/browse/SPARK-36612) support left outer join build left or right outer

Re: [PR] [VL] Fix build script in Alinux3 [incubator-gluten]

2024-05-14 Thread via GitHub
Yohahaha commented on PR #5749: URL: https://github.com/apache/incubator-gluten/pull/5749#issuecomment-2111508598 @liujiayi771 @kerwin-zk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Fix build script in Alinux3 [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5749: URL: https://github.com/apache/incubator-gluten/pull/5749#issuecomment-2111508569 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix build script in Alinux3 [incubator-gluten]

2024-05-14 Thread via GitHub
Yohahaha opened a new pull request, #5749: URL: https://github.com/apache/incubator-gluten/pull/5749 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [VL] Unify all configs into GlutenConfig.h [incubator-gluten]

2024-05-14 Thread via GitHub
zhztheplayer commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2111505746 > And there is no reason to separate native configs into different place, since all configs has already been unified in java side. If some design is not solid now, why it

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600889837 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600889837 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
zhli1142015 commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600885835 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
JkSelf commented on code in PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#discussion_r1600876926 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -16,6 +16,337 @@ */ package

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
gaoyangxiaozhu commented on PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#issuecomment-2111475792 add @zhli1142015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Fallback Window operator if there is a mismatch in output type [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5554: URL: https://github.com/apache/incubator-gluten/pull/5554#issuecomment-2111465234 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Unify all configs into GlutenConfig.h [incubator-gluten]

2024-05-14 Thread via GitHub
Yohahaha commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2111454937 another way is put common configs into GlutenConfig.h and velox configs into velox/VeloxConfig.h, but I dont find the real difference between these. -- This is an automated

Re: [PR] [VL] Unify all configs into GlutenConfig.h [incubator-gluten]

2024-05-14 Thread via GitHub
Yohahaha commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2111446860 > I think there was some initial consideration about storing only general configurations in `cpp/core` as well as `GlutenConfig.h`. > > I do believe we don't yet have a

Re: [PR] [VL] Enable GlutenParqutRowIndexSuite for Spark 3.4/3.5 [incubator-gluten]

2024-05-14 Thread via GitHub
zhouyuan commented on PR #5740: URL: https://github.com/apache/incubator-gluten/pull/5740#issuecomment-2111444256 CC @JkSelf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5414] [VL] Support datasource v2 scan csv [incubator-gluten]

2024-05-14 Thread via GitHub
jinchengchenghh commented on PR #5717: URL: https://github.com/apache/incubator-gluten/pull/5717#issuecomment-2111433581 Can you help review. thanks! @zhztheplayer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [CH][WIP] Refactor: Remove headers [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5043: URL: https://github.com/apache/incubator-gluten/pull/5043#issuecomment-2111432034 This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks. -- This is an automated

Re: [PR] [CH][WIP] Refactor: Remove headers [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] closed pull request #5043: [CH][WIP] Refactor: Remove headers URL: https://github.com/apache/incubator-gluten/pull/5043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Add supported backend information in Sig (signature for a expression) [incubator-gluten]

2024-05-14 Thread via GitHub
ivoson commented on issue #5700: URL: https://github.com/apache/incubator-gluten/issues/5700#issuecomment-2111427727 > @ivoson, some functions have multiple signatures. And it is possible that not all signatures are supported by native engine. If we add a fag in `ExpressionMappings`, we

Re: [I] Add supported backend information in Sig (signature for a expression) [incubator-gluten]

2024-05-14 Thread via GitHub
ivoson closed issue #5700: Add supported backend information in Sig (signature for a expression) URL: https://github.com/apache/incubator-gluten/issues/5700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [VL] Daily Update Velox Version (2024_05_14) [incubator-gluten]

2024-05-14 Thread via GitHub
rui-mo commented on PR #5733: URL: https://github.com/apache/incubator-gluten/pull/5733#issuecomment-2111420101 @FelixYBW Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Unify all configs into GlutenConfig.h [incubator-gluten]

2024-05-14 Thread via GitHub
zhztheplayer commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2111413019 I think there was some initial consideration about storing only general configurations in `cpp/core` as well as `GlutenConfig.h`. I do believe we don't yet have a

Re: [I] Add supported backend information in Sig (signature for a expression) [incubator-gluten]

2024-05-14 Thread via GitHub
PHILO-HE commented on issue #5700: URL: https://github.com/apache/incubator-gluten/issues/5700#issuecomment-2111412864 @ivoson, some functions have multiple signatures. And it is possible that not all signatures are supported by native engine. If we add a fag in `ExpressionMappings`, we

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2111410162 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240515) [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5747: URL: https://github.com/apache/incubator-gluten/pull/5747#issuecomment-2111389631 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5668][CH] Support mixed inequal conditions in hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2111361536 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_05_15) [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5748: URL: https://github.com/apache/incubator-gluten/pull/5748#issuecomment-2111355315 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_05_15) [incubator-gluten]

2024-05-14 Thread via GitHub
GlutenPerfBot opened a new pull request, #5748: URL: https://github.com/apache/incubator-gluten/pull/5748 Upstream Velox's New Commits: ```txt 54db95234 by Zac Wen, Use mutex lock to protect cache shutdown (9770) 40661a025 by Jialiang Tan, Add spill stats reporting to

Re: [PR] [GLUTEN-5414] [VL] Support datasource v2 scan csv [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5717: URL: https://github.com/apache/incubator-gluten/pull/5717#issuecomment-2111310045 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240515) [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5747: URL: https://github.com/apache/incubator-gluten/pull/5747#issuecomment-2111302441 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240515) [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5747: URL: https://github.com/apache/incubator-gluten/pull/5747#issuecomment-2111302277 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240515) [incubator-gluten]

2024-05-14 Thread via GitHub
kyligence-git opened a new pull request, #5747: URL: https://github.com/apache/incubator-gluten/pull/5747 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [VL] [Test] test dense rank support in RowsStreamingWindow [incubator-gluten]

2024-05-14 Thread via GitHub
FelixYBW commented on PR #5728: URL: https://github.com/apache/incubator-gluten/pull/5728#issuecomment-2110939989 @JkSelf can you add row_number function as well? ``` ROW_NUMBER() OVER (PARTITION BY IF(userid=0, unauthId, userid),

(incubator-gluten) branch main updated: [VL] Daily Update Velox Version (2024_05_14) (#5733)

2024-05-14 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 37be4aa02 [VL] Daily Update Velox

Re: [PR] [VL] Daily Update Velox Version (2024_05_14) [incubator-gluten]

2024-05-14 Thread via GitHub
FelixYBW merged PR #5733: URL: https://github.com/apache/incubator-gluten/pull/5733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Unify all configs into GlutenConfig.h [incubator-gluten]

2024-05-14 Thread via GitHub
FelixYBW commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2110856628 Not sure if we can have a better way to use a config file then automatically generate the GlutenConfig.h and GlutenConfig.scala. The initial design is to add all configs

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240514) [incubator-gluten]

2024-05-14 Thread via GitHub
GlutenPerfBot commented on PR #5732: URL: https://github.com/apache/incubator-gluten/pull/5732#issuecomment-2110849511 = Performance report for TPCDS SF2000 with Velox backend, for reference only query

Re: [I] Add more comments for Generator related logic in cpp code [incubator-gluten]

2024-05-14 Thread via GitHub
FelixYBW closed issue #5745: Add more comments for Generator related logic in cpp code URL: https://github.com/apache/incubator-gluten/issues/5745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(incubator-gluten) branch main updated: [GLUTEN-5745][VL] Add more comments for GenerateRel conversion logic (#5746)

2024-05-14 Thread felixybw
This is an automated email from the ASF dual-hosted git repository. felixybw pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new 3888f45e0 [GLUTEN-5745][VL] Add more

Re: [PR] [GLUTEN-5745][VL] Add more comments for GenerateRel conversion logic [incubator-gluten]

2024-05-14 Thread via GitHub
FelixYBW merged PR #5746: URL: https://github.com/apache/incubator-gluten/pull/5746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240514) (#5732)

2024-05-14 Thread changchen
Update Clickhouse Version (20240514) (#5732) c7306128a is described below commit c7306128a1d5808521c4b15931f53b939bb84f51 Author: Kyligence Git AuthorDate: Tue May 14 11:13:03 2024 -0500 [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240514) (#5732) Co-authored-by: kyligence-git

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240514) [incubator-gluten]

2024-05-14 Thread via GitHub
baibaichen merged PR #5732: URL: https://github.com/apache/incubator-gluten/pull/5732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240514) [incubator-gluten]

2024-05-14 Thread via GitHub
baibaichen commented on PR #5732: URL: https://github.com/apache/incubator-gluten/pull/5732#issuecomment-2110622530 We need merge due to https://github.com/ClickHouse/ClickHouse/pull/60469, since we also update ci pipeline to clang18 -- This is an automated message from the Apache Git

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110582368 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5745][VL] Add more comments for GenerateRel conversion logic [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5746: URL: https://github.com/apache/incubator-gluten/pull/5746#issuecomment-2110464156 https://github.com/apache/incubator-gluten/issues/5745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5745][VL] Add more comments for GenerateRel conversion logic [incubator-gluten]

2024-05-14 Thread via GitHub
xumingming opened a new pull request, #5746: URL: https://github.com/apache/incubator-gluten/pull/5746 ## What changes were proposed in this pull request? (Fixes: \#5745) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110297522 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-211029 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110244501 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5668][CH] Support mixed inequal conditions in hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2110087479 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2110044454 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5668][CH] Support mixed inequal conditions in hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2110021674 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5668][CH] Support mixed inequal conditions in hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2110019495 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5668][CH] Support mixed inequal conditions in hash join [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2110016141 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109842234 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [CH] Crash on exit with Poco exception [incubator-gluten]

2024-05-14 Thread via GitHub
zhanglistar commented on issue #5744: URL: https://github.com/apache/incubator-gluten/issues/5744#issuecomment-2109819191 (gdb) bt #0 0x7fab0a920428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x7fab0a92202a in __GI_abort () at

Re: [I] [CH] Crash on gluten exit [incubator-gluten]

2024-05-14 Thread via GitHub
zhanglistar commented on issue #5741: URL: https://github.com/apache/incubator-gluten/issues/5741#issuecomment-2109812995 (gdb) bt #0 0x7fda35788428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x7fda3578a02a in __GI_abort () at

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109813010 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109800277 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240514) [incubator-gluten]

2024-05-14 Thread via GitHub
lwz9103 commented on PR #5732: URL: https://github.com/apache/incubator-gluten/pull/5732#issuecomment-2109794890 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [WIP][VL] Support celeborn sort based shuffle [incubator-gluten]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #5675: URL: https://github.com/apache/incubator-gluten/pull/5675#issuecomment-2109789645 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5620][CORE] Remove check_overflow and refactor code [incubator-gluten]

2024-05-14 Thread via GitHub
zhouyuan merged PR #5654: URL: https://github.com/apache/incubator-gluten/pull/5654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(incubator-gluten) branch main updated: [GLUTEN-5620][CORE] Remove check_overflow and refactor code (#5654)

2024-05-14 Thread yuanzhou
This is an automated email from the ASF dual-hosted git repository. yuanzhou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git The following commit(s) were added to refs/heads/main by this push: new e80785625 [GLUTEN-5620][CORE] Remove

Re: [PR] [GLUTEN-5620][CORE] Remove check_overflow and refactor code [incubator-gluten]

2024-05-14 Thread via GitHub
zhouyuan commented on PR #5654: URL: https://github.com/apache/incubator-gluten/pull/5654#issuecomment-2109774190 @baibaichen @ulysses-you I assume the questions on this refactor work is solved. chengcheng and I will follow up if required -- This is an automated message from

[I] [CH] Crash on exit with Poco exception [incubator-gluten]

2024-05-14 Thread via GitHub
zhanglistar opened a new issue, #5744: URL: https://github.com/apache/incubator-gluten/issues/5744 ### Backend CH (ClickHouse) ### Bug description Log is: ``` 2024/05/14 16:27:30,975 INFO [dispatcher-Executor] JniLibLoader: Library

  1   2   >