Re: [PR] [VL] Make ColumnarBatch::getRowBytes leak-safe [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #6002: URL: https://github.com/apache/incubator-gluten/pull/6002#issuecomment-2151427814 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Rename CoalesceExecTransformer to ColumnarCoalesceExec [incubator-gluten]

2024-06-05 Thread via GitHub
ulysses-you merged PR #6000: URL: https://github.com/apache/incubator-gluten/pull/6000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Rename CoalesceExecTransformer to ColumnarCoalesceExec [incubator-gluten]

2024-06-05 Thread via GitHub
ulysses-you commented on PR #6000: URL: https://github.com/apache/incubator-gluten/pull/6000#issuecomment-2151367581 cc @zhztheplayer @PHILO-HE thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [VL] Failed to build cmake-3.29 [incubator-gluten]

2024-06-05 Thread via GitHub
boobpoop commented on issue #5912: URL: https://github.com/apache/incubator-gluten/issues/5912#issuecomment-2151368019 @kecookier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-5841][CH]Fix session timezone diff [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892#issuecomment-2151363728 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Make ColumnarBatch::getRowBytes leak-safe [incubator-gluten]

2024-06-05 Thread via GitHub
zhztheplayer commented on PR #6002: URL: https://github.com/apache/incubator-gluten/pull/6002#issuecomment-2151346111 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [Gluten-229] Support Spark SortShuffleManager for ClickHouse Backend [incubator-gluten]

2024-06-05 Thread via GitHub
zml1206 commented on code in PR #230: URL: https://github.com/apache/incubator-gluten/pull/230#discussion_r1628729346 ## jvm/src/main/scala/io/glutenproject/extension/StrategyOverrides.scala: ## @@ -76,8 +69,26 @@ object JoinSelectionOverrides extends Strategy with

Re: [PR] [VL] Make ColumnarBatch::getRowBytes leak-safe [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #6002: URL: https://github.com/apache/incubator-gluten/pull/6002#issuecomment-2151343641 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5787][CH]Make pipeline and shuffle exit gracefully when tasks in executors are killed or interrupted [incubator-gluten]

2024-06-05 Thread via GitHub
liuneng1994 merged PR #5839: URL: https://github.com/apache/incubator-gluten/pull/5839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628716297 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends SQLConfHelper

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628713141 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends

Re: [PR] [GLUTEN-5957][CH]Fix get_json_object on filter condition [incubator-gluten]

2024-06-05 Thread via GitHub
liuneng1994 merged PR #5989: URL: https://github.com/apache/incubator-gluten/pull/5989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Function get_json_object return nothing when the `get_json_object` field in where conditions [incubator-gluten]

2024-06-05 Thread via GitHub
liuneng1994 closed issue #5957: [CH] Function get_json_object return nothing when the `get_json_object` field in where conditions URL: https://github.com/apache/incubator-gluten/issues/5957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628706746 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends SQLConfHelper

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628706746 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends SQLConfHelper

Re: [I] [CH] Result diff from valina spark while set config `spark.sql.session.timeZone` [incubator-gluten]

2024-06-05 Thread via GitHub
liuneng1994 closed issue #5841: [CH] Result diff from valina spark while set config `spark.sql.session.timeZone` URL: https://github.com/apache/incubator-gluten/issues/5841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [GLUTEN-5841][CH]Fix session timezone diff [incubator-gluten]

2024-06-05 Thread via GitHub
liuneng1994 merged PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5981][CH] Make the result be null when the queried field is `null` [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #6001: URL: https://github.com/apache/incubator-gluten/pull/6001#issuecomment-2151301641 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240606) [incubator-gluten]

2024-06-05 Thread via GitHub
baibaichen commented on PR #5999: URL: https://github.com/apache/incubator-gluten/pull/5999#issuecomment-2151299549 We need updgrade ch, due to 1. https://github.com/ClickHouse/ClickHouse/pull/64562 for https://github.com/apache/incubator-gluten/pull/5911 2. Fix rebase failed due to

Re: [PR] [GLUTEN-5981][CH] Make the result be null when the queried field is `null` [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #6001: URL: https://github.com/apache/incubator-gluten/pull/6001#issuecomment-2151299556 https://github.com/apache/incubator-gluten/issues/5981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5981][CH] Make the result be null when the queried field is `null` [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #6001: URL: https://github.com/apache/incubator-gluten/pull/6001#issuecomment-2151299746 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628697272 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628696612 ## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala: ## @@ -123,42 +123,50 @@ class VeloxSparkPlanExecApi

Re: [PR] [GLUTEN-5720][VL] Enable left and right semi join type in smj [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5825: URL: https://github.com/apache/incubator-gluten/pull/5825#issuecomment-2151291585 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [CH] DIff result for get_json_object to get null value [incubator-gluten]

2024-06-05 Thread via GitHub
lgbo-ustc commented on issue #5981: URL: https://github.com/apache/incubator-gluten/issues/5981#issuecomment-2151268883 I will fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [CH] DIff result for get_json_object to get null value [incubator-gluten]

2024-06-05 Thread via GitHub
lgbo-ustc commented on issue #5981: URL: https://github.com/apache/incubator-gluten/issues/5981#issuecomment-2151251002 the result from `JSON_QUERY` in `CH` is a string value -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [CORE] Rename CoalesceExecTransformer to ColumnarCoalesceExec [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #6000: URL: https://github.com/apache/incubator-gluten/pull/6000#issuecomment-2151246762 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Rename CoalesceExecTransformer to ColumnarCoalesceExec [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #6000: URL: https://github.com/apache/incubator-gluten/pull/6000#issuecomment-2151246591 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [CORE] Rename CoalesceExecTransformer to ColumnarCoalesceExec [incubator-gluten]

2024-06-05 Thread via GitHub
ulysses-you opened a new pull request, #6000: URL: https://github.com/apache/incubator-gluten/pull/6000 ## What changes were proposed in this pull request? This pr renames CoalesceExecTransformer to ColumnarCoalesceExec. - xxxTransformer is used for operator which support offload

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628603742 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends SQLConfHelper

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1628607266 ## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala: ## @@ -123,42 +123,50 @@ class VeloxSparkPlanExecApi extends

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
ulysses-you commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2151203486 @baibaichen , this pr erases the `InputAdaptor` in tree string (for explain string) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240606) [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5999: URL: https://github.com/apache/incubator-gluten/pull/5999#issuecomment-2151197309 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240606) [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5999: URL: https://github.com/apache/incubator-gluten/pull/5999#issuecomment-2151196747 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5720][VL] Enable left and right semi join type in smj [incubator-gluten]

2024-06-05 Thread via GitHub
JkSelf merged PR #5825: URL: https://github.com/apache/incubator-gluten/pull/5825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240606) [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5999: URL: https://github.com/apache/incubator-gluten/pull/5999#issuecomment-2151193071 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240606) [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5999: URL: https://github.com/apache/incubator-gluten/pull/5999#issuecomment-2151192764 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240606) [incubator-gluten]

2024-06-05 Thread via GitHub
kyligence-git opened a new pull request, #5999: URL: https://github.com/apache/incubator-gluten/pull/5999 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5996][CH] Fixed missing columns in join with mixed conditions [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5997: URL: https://github.com/apache/incubator-gluten/pull/5997#issuecomment-2151160902 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2150850754 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2150720902 = Performance report for TPCDS SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-06-05 Thread via GitHub
WangGuangxin commented on code in PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#discussion_r1627991908 ## gluten-core/src/main/scala/org/apache/gluten/utils/PullOutProjectHelper.scala: ## @@ -143,8 +144,39 @@ trait PullOutProjectHelper {

Re: [PR] [Gluten-229] Support Spark SortShuffleManager for ClickHouse Backend [incubator-gluten]

2024-06-05 Thread via GitHub
zml1206 commented on code in PR #230: URL: https://github.com/apache/incubator-gluten/pull/230#discussion_r1627944846 ## jvm/src/main/scala/io/glutenproject/extension/StrategyOverrides.scala: ## @@ -76,8 +69,26 @@ object JoinSelectionOverrides extends Strategy with

Re: [PR] [VL] Remove unnecessary arrow compile option [incubator-gluten]

2024-06-05 Thread via GitHub
Yohahaha commented on PR #5976: URL: https://github.com/apache/incubator-gluten/pull/5976#issuecomment-2150016022 convert status to draft, will update when I back from OOO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2149955831 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
baibaichen commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2149859186 @ulysses-you By the way, what problem does this PR need to solve? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
baibaichen commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2149855010 It looks like an unstable case, let's keep observing it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627674762 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#issuecomment-2149725950 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627674762 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#issuecomment-2149696778 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_06_04) [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5968: URL: https://github.com/apache/incubator-gluten/pull/5968#issuecomment-2149691787 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
ulysses-you commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2149589013 not related this pr, cc @baibaichen it seems CH backend tests have failed ``` 16:17:43 - TPCH Decimal(38,19) 16:17:43 Q17[allowPrecisionLoss=true] *** FAILED ***

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
ulysses-you merged PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Add unknown type to shuffle cpp ut [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5973: URL: https://github.com/apache/incubator-gluten/pull/5973#issuecomment-2149501383 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#issuecomment-2149450704 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627460879 ## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala: ## @@ -123,42 +123,44 @@ class VeloxSparkPlanExecApi

Re: [PR] [GLUTEN-3582][CH] Using ParquetBlockInputFormat instead of VectorizedParquetBlockInputFormat for complex type [incubator-gluten]

2024-06-05 Thread via GitHub
zzcclp merged PR #5995: URL: https://github.com/apache/incubator-gluten/pull/5995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH]Improve parquet reader performacne [incubator-gluten]

2024-06-05 Thread via GitHub
zzcclp closed issue #3582: [CH]Improve parquet reader performacne URL: https://github.com/apache/incubator-gluten/issues/3582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627437914 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627436223 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends SQLConfHelper

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627435656 ## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala: ## @@ -123,42 +123,44 @@ class VeloxSparkPlanExecApi extends

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
PHILO-HE commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627430941 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [VL] Daily Update Velox Version (2024_06_05) [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5998: URL: https://github.com/apache/incubator-gluten/pull/5998#issuecomment-2149410975 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_06_05) [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot opened a new pull request, #5998: URL: https://github.com/apache/incubator-gluten/pull/5998 Upstream Velox's New Commits: ```txt a6bb4d81f by xiaoxmeng, Fix memory pool lock order reversion detected by Meta internal tsan test (10051) 3a7f8a88a by Masha Basmanova,

Re: [PR] [VL] Daily Update Velox Version (2024_06_04) [incubator-gluten]

2024-06-05 Thread via GitHub
PHILO-HE merged PR #5968: URL: https://github.com/apache/incubator-gluten/pull/5968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Daily Update Velox Version (2024_06_04) [incubator-gluten]

2024-06-05 Thread via GitHub
PHILO-HE commented on PR #5968: URL: https://github.com/apache/incubator-gluten/pull/5968#issuecomment-2149408551 Will fix static build issue when GCS is enabled in a follow-up pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627417541 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [VL] Daily Update Velox Version (2024_06_04) [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5968: URL: https://github.com/apache/incubator-gluten/pull/5968#discussion_r1627414040 ## dev/ci-velox-buildstatic.sh: ## @@ -6,4 +6,4 @@ cd $GITHUB_WORKSPACE/ source ./dev/vcpkg/env.sh sed -i '/^headers/d'

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627410680 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627410680 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends

Re: [PR] [VL] Fix uniffle ci for Non-default scan partition [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5994: URL: https://github.com/apache/incubator-gluten/pull/5994#issuecomment-2149388122 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627399732 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [GLUTEN-5787][CH]Make pipeline and shuffle exit gracefully when tasks in executors are killed or interrupted [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5839: URL: https://github.com/apache/incubator-gluten/pull/5839#issuecomment-2149365992 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Core] Spark assert_true and raise_error function support [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on issue #5991: URL: https://github.com/apache/incubator-gluten/issues/5991#issuecomment-2149363474 > We need a fundamental way to test all the Spark functions. @rui-mo Can your velox_Spark fuzzer test achieve this? @FelixYBW With this tool, the result of a Velox

Re: [PR] [TESTS] Tune spark.gluten.sql.complexType.scan.fallback.enabled to false for tests [incubator-gluten]

2024-06-05 Thread via GitHub
ulysses-you commented on PR #5990: URL: https://github.com/apache/incubator-gluten/pull/5990#issuecomment-2149351913 char type in map type test failed: ``` 2024-06-05T08:37:45.5647132Z - char type values should be padded: nested in map key *** FAILED ***

Re: [PR] [VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5933: URL: https://github.com/apache/incubator-gluten/pull/5933#issuecomment-2149346305 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
rui-mo commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627369020 ## gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala: ## @@ -563,18 +563,68 @@ object ExpressionConverter extends SQLConfHelper

Re: [PR] [VL] Add unknown type to shuffle cpp ut [incubator-gluten]

2024-06-05 Thread via GitHub
marin-ma merged PR #5973: URL: https://github.com/apache/incubator-gluten/pull/5973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5827][CH]support utc timestamp transfrom [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5828: URL: https://github.com/apache/incubator-gluten/pull/5828#issuecomment-2149314070 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627335359 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#issuecomment-2149297479 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
PHILO-HE commented on code in PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#discussion_r1627315319 ## cpp/velox/operators/functions/RegistrationAllFunctions.cc: ## @@ -67,6 +68,10 @@ void registerFunctionOverwrite() { kRowConstructorWithAllNull,

Re: [PR] [GLUTEN-5996][CH] Fixed missing columns in join with mixed conditions [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5997: URL: https://github.com/apache/incubator-gluten/pull/5997#issuecomment-2149231535 https://github.com/apache/incubator-gluten/issues/5996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5996][CH] Fixed missing columns in join with mixed conditions [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5997: URL: https://github.com/apache/incubator-gluten/pull/5997#issuecomment-2149232062 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [CH] Not found column when the mixed join condition involves right keys [incubator-gluten]

2024-06-05 Thread via GitHub
lgbo-ustc opened a new issue, #5996: URL: https://github.com/apache/incubator-gluten/issues/5996 ### Backend CH (ClickHouse) ### Bug description [Expected behavior] and [actual behavior]. Following query fails ```sql select t1.key, t1.attr from join_t1 as t1

Re: [PR] [VL] Do not skip updating children's metrics while visiting an operator with NoopMetricsUpdater [incubator-gluten]

2024-06-05 Thread via GitHub
zhztheplayer merged PR #5933: URL: https://github.com/apache/incubator-gluten/pull/5933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5787][CH]Make pipeline and shuffle exit gracefully when tasks in executors are killed or interrupted [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5839: URL: https://github.com/apache/incubator-gluten/pull/5839#issuecomment-2149158460 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-06-05 Thread via GitHub
WangGuangxin commented on code in PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#discussion_r1627175448 ## gluten-core/src/main/scala/org/apache/gluten/utils/PullOutProjectHelper.scala: ## @@ -143,8 +144,39 @@ trait PullOutProjectHelper {

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#issuecomment-2149106875 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix uniffle ci for Non-default scan partition [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5994: URL: https://github.com/apache/incubator-gluten/pull/5994#issuecomment-2149089733 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Drop inputAdaptor in plan tree string [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5993: URL: https://github.com/apache/incubator-gluten/pull/5993#issuecomment-2149076535 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5841][CH]Fix session timezone diff [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892#issuecomment-2149071824 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5787][CH]Make pipeline and shuffle exit gracefully when tasks in executors are killed or interrupted [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5839: URL: https://github.com/apache/incubator-gluten/pull/5839#issuecomment-2149063768 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] ExpandFallbackPolicy should propagate fallback reason to vanilla SparkPlan [incubator-gluten]

2024-06-05 Thread via GitHub
GlutenPerfBot commented on PR #5971: URL: https://github.com/apache/incubator-gluten/pull/5971#issuecomment-2149032070 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-06-05 Thread via GitHub
zml1206 commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2149023181 > > > > > If the custom strategy can be removed by moving the code to ColumnarOverrides (without more workarounds), Personally I will be inclined to do that since it: > > >

Re: [PR] [VL] Handle try_subtract, try_multiply, try_divide [incubator-gluten]

2024-06-05 Thread via GitHub
zhli1142015 commented on PR #5985: URL: https://github.com/apache/incubator-gluten/pull/5985#issuecomment-2149020428 cc @rui-mo and @PHILO-HE , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5841][CH]Fix session timezone diff [incubator-gluten]

2024-06-05 Thread via GitHub
KevinyhZou commented on PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892#issuecomment-2149012827 .exclude("SPARK-34721: add a year-month interval to a date") .exclude("SPARK-34739: add a year-month interval to a timestamp") 排除这两个Spark-UT,原因是其中含有-8:00,+9:30

[PR] [GLUTEN-3582][CH] Using ParquetBlockInputFormat instead of VectorizedParquetBlockInputFormat for complex type [incubator-gluten]

2024-06-05 Thread via GitHub
baibaichen opened a new pull request, #5995: URL: https://github.com/apache/incubator-gluten/pull/5995 ## What changes were proposed in this pull request? We introduce `VectorizedParquetBlockInputFormat` in https://github.com/apache/incubator-gluten/pull/4634, which onlu support

Re: [PR] [GLUTEN-5841][CH]Fix session timezone diff [incubator-gluten]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892#issuecomment-2149009569 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

<    1   2   3   4   5   6   7   8   9   10   >