Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you merged PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Fix shuffle with round robin partitioning fail [incubator-gluten]

2024-05-30 Thread via GitHub
marin-ma merged PR #5928: URL: https://github.com/apache/incubator-gluten/pull/5928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4942][VL] Adding arrow port in VCPKG [incubator-gluten]

2024-05-30 Thread via GitHub
zhouyuan commented on PR #5926: URL: https://github.com/apache/incubator-gluten/pull/5926#issuecomment-2141040386 @FelixYBW Spark UT is working on static building now. https://github.com/apache/incubator-gluten/pull/5906 We may need extra 2-3 patches for 1) allow Velox to use

Re: [PR] [VL] Daily Update Velox Version (2024_05_31) [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5931: URL: https://github.com/apache/incubator-gluten/pull/5931#issuecomment-2141038783 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Daily Update Velox Version (2024_05_31) [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot opened a new pull request, #5931: URL: https://github.com/apache/incubator-gluten/pull/5931 Upstream Velox's New Commits: ```txt f9ae45acb by Sergey Pershin, Advance version of simdjson to the latest. (9985) a3239ff74 by Ke, Add initial table writer fuzzer (9685)

Re: [PR] [CORE] Offload TakeOrderedAndProjectExec at planning time rather than at runtime [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5927: URL: https://github.com/apache/incubator-gluten/pull/5927#issuecomment-2141003562 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240531) [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5930: URL: https://github.com/apache/incubator-gluten/pull/5930#issuecomment-2140980827 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240531) [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5930: URL: https://github.com/apache/incubator-gluten/pull/5930#issuecomment-2140980645 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240531) [incubator-gluten]

2024-05-30 Thread via GitHub
kyligence-git opened a new pull request, #5930: URL: https://github.com/apache/incubator-gluten/pull/5930 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5904][CH] Convert `nan` to `null` which comes from `stddev` [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5913: URL: https://github.com/apache/incubator-gluten/pull/5913#issuecomment-2140732909 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5904][CH] Convert `nan` to `null` which comes from `stddev` [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5913: URL: https://github.com/apache/incubator-gluten/pull/5913#issuecomment-2140567463 = Performance report for TPCDS SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4942][VL] Adding arrow port in VCPKG [incubator-gluten]

2024-05-30 Thread via GitHub
FelixYBW commented on PR #5926: URL: https://github.com/apache/incubator-gluten/pull/5926#issuecomment-2140556250 @zhouyuan how far we can move to static build as default? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [VL] Optimize sort based shuffle [incubator-gluten]

2024-05-30 Thread via GitHub
FelixYBW commented on issue #5929: URL: https://github.com/apache/incubator-gluten/issues/5929#issuecomment-2140514389 Thank you for reporting, @XinShuoWang . we noted the issue and trying to fix. We plan to rewrite the logic. -- This is an automated message from the Apache Git Service.

Re: [I] [VL] Static build failed on ubuntu 22.04 [incubator-gluten]

2024-05-30 Thread via GitHub
FelixYBW commented on issue #5924: URL: https://github.com/apache/incubator-gluten/issues/5924#issuecomment-2140506886 @marin-ma It's because the jemalloc conflict. You need to uninstall jemalloc from system. It's marked here:

Re: [PR] [GLUTEN-5701][VL] Add overflow test case for from_unixtime function [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5894: URL: https://github.com/apache/incubator-gluten/pull/5894#issuecomment-2139990116 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [CH] Mismatched results from `stddev` [incubator-gluten]

2024-05-30 Thread via GitHub
zzcclp closed issue #5904: [CH] Mismatched results from `stddev` URL: https://github.com/apache/incubator-gluten/issues/5904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [GLUTEN-5904][CH] Convert `nan` to `null` which comes from `stddev` [incubator-gluten]

2024-05-30 Thread via GitHub
zzcclp merged PR #5913: URL: https://github.com/apache/incubator-gluten/pull/5913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5701][VL] Add overflow test case for from_unixtime function [incubator-gluten]

2024-05-30 Thread via GitHub
PHILO-HE merged PR #5894: URL: https://github.com/apache/incubator-gluten/pull/5894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [VL] Results are mismatch with vanilla Spark when uses from_unixtime with overflowed parameter and query config setted time zone [incubator-gluten]

2024-05-30 Thread via GitHub
PHILO-HE closed issue #5701: [VL] Results are mismatch with vanilla Spark when uses from_unixtime with overflowed parameter and query config setted time zone URL: https://github.com/apache/incubator-gluten/issues/5701 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [VL] Daily Update Velox Version (2024_05_30) [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5919: URL: https://github.com/apache/incubator-gluten/pull/5919#issuecomment-2139678729 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Daily Update Velox Version (2024_05_30) [incubator-gluten]

2024-05-30 Thread via GitHub
PHILO-HE merged PR #5919: URL: https://github.com/apache/incubator-gluten/pull/5919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#issuecomment-2139529557 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-05-30 Thread via GitHub
WangGuangxin commented on code in PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#discussion_r1620692238 ## gluten-core/src/main/java/org/apache/gluten/substrait/expression/WindowFunctionNode.java: ## @@ -80,20 +92,53 @@ private

Re: [PR] [GLUTEN-5691][CH] Enable merge on local disk first after insert into mergetree [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5692: URL: https://github.com/apache/incubator-gluten/pull/5692#issuecomment-2139487389 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-30 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2139430047 > And there is a test for `collect_set` which used array_sort > >

Re: [PR] [VL] Fix shuffle with round robin partitioning fail [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you commented on PR #5928: URL: https://github.com/apache/incubator-gluten/pull/5928#issuecomment-2139419757 @marin-ma never mind.. I will drop null type column in this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Fix shuffle with round robin partitioning fail [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you commented on PR #5928: URL: https://github.com/apache/incubator-gluten/pull/5928#issuecomment-2139413259 @marin-ma Is null type the only unsupported data type for hash expression ? If so, I can drop null column before going to hash expression. -- This is an automated

Re: [PR] [VL] Fix shuffle with round robin partitioning fail [incubator-gluten]

2024-05-30 Thread via GitHub
marin-ma commented on PR #5928: URL: https://github.com/apache/incubator-gluten/pull/5928#issuecomment-2139406256 Thanks. Seems like this failure is because we creates a hash computation for all input columns. If there are any NullType in the input, those column types will be converted to

Re: [PR] [VL] Fix shuffle with round robin partitioning fail [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you commented on PR #5928: URL: https://github.com/apache/incubator-gluten/pull/5928#issuecomment-2139385648 cc @zhztheplayer @marin-ma thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [VL] Fix shuffle with round robin partitioning fail [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5928: URL: https://github.com/apache/incubator-gluten/pull/5928#issuecomment-2139383237 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Fix shuffle with round robin partitioning fail [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you opened a new pull request, #5928: URL: https://github.com/apache/incubator-gluten/pull/5928 ## What changes were proposed in this pull request? We should validate the project before sort rather than using ProjectExecTransformer directly. The hash expression may not

Re: [PR] [VL] Daily Update Velox Version (2024_05_30) [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5919: URL: https://github.com/apache/incubator-gluten/pull/5919#issuecomment-2139377368 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5701][VL] Add overflow test case for from_unixtime function [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5894: URL: https://github.com/apache/incubator-gluten/pull/5894#issuecomment-2139354772 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5901][CH] Support CH backend parquet + delta [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5902: URL: https://github.com/apache/incubator-gluten/pull/5902#issuecomment-2139277084 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_05_30) [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5919: URL: https://github.com/apache/incubator-gluten/pull/5919#issuecomment-2139264073 = Performance report for TPCDS SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-30 Thread via GitHub
zml1206 commented on code in PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#discussion_r1620377219 ## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala: ## @@ -376,13 +376,8 @@ object VeloxBackendSettings extends

Re: [PR] [GLUTEN-5691][CH] Enable merge on local disk first after insert into mergetree [incubator-gluten]

2024-05-30 Thread via GitHub
zzcclp merged PR #5692: URL: https://github.com/apache/incubator-gluten/pull/5692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Enable merge on local disk first after insert into mergetree [incubator-gluten]

2024-05-30 Thread via GitHub
zzcclp closed issue #5691: [CH] Enable merge on local disk first after insert into mergetree URL: https://github.com/apache/incubator-gluten/issues/5691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CORE] Offload TakeOrderedAndProjectExec at planning time rather than at runtime [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5927: URL: https://github.com/apache/incubator-gluten/pull/5927#issuecomment-2139139030 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Result mismatch when data contains empty map [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you commented on issue #4587: URL: https://github.com/apache/incubator-gluten/issues/4587#issuecomment-2139134174 @yma11 @zhouyuan does this issue still exist ? it seems has been fixed by https://github.com/facebookincubator/velox/pull/9187 -- This is an automated message from

Re: [PR] [GLUTEN-5921][CH] Function trim of trim_character support value from column [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5922: URL: https://github.com/apache/incubator-gluten/pull/5922#issuecomment-2139125130 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5656][CORE][FOLLOWUP] Support GetStructField with NullLiteralNode as subqueries not executing during validation [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5923: URL: https://github.com/apache/incubator-gluten/pull/5923#issuecomment-2139117782 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2139107237 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5898][CH] Fix regexp_extract function use bracket has diff behaver with spark [incubator-gluten]

2024-05-30 Thread via GitHub
zzcclp merged PR #5908: URL: https://github.com/apache/incubator-gluten/pull/5908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Unexpected csv result when use use_excel_serialization=true [incubator-gluten]

2024-05-30 Thread via GitHub
zzcclp closed issue #5898: [CH] Unexpected csv result when use use_excel_serialization=true URL: https://github.com/apache/incubator-gluten/issues/5898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2139087029 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you commented on code in PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#discussion_r1620283224 ## gluten-core/src/main/scala/org/apache/gluten/backendsapi/ListenerApi.scala: ## @@ -16,11 +16,11 @@ */ package org.apache.gluten.backendsapi

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you commented on code in PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#discussion_r1620281220 ## gluten-core/src/main/scala/org/apache/gluten/backendsapi/TransformerApi.scala: ## @@ -70,4 +70,6 @@ trait TransformerApi { def

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2139070735 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Daily Update Velox Version (2024_05_30) [incubator-gluten]

2024-05-30 Thread via GitHub
zhouyuan commented on PR #5919: URL: https://github.com/apache/incubator-gluten/pull/5919#issuecomment-2139069444 /Benchmark Velox TPCDS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CORE] Offload TakeOrderedAndProjectExec at planning time rather than at runtime [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5927: URL: https://github.com/apache/incubator-gluten/pull/5927#issuecomment-2139068211 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Offload TakeOrderedAndProjectExec at planning time rather than at runtime [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5927: URL: https://github.com/apache/incubator-gluten/pull/5927#issuecomment-2139066716 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Offload TakeOrderedAndProjectExec at planning time rather than at runtime [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5927: URL: https://github.com/apache/incubator-gluten/pull/5927#issuecomment-2139050164 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Offload TakeOrderedAndProjectExec at planning time rather than at runtime [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5927: URL: https://github.com/apache/incubator-gluten/pull/5927#issuecomment-2139049434 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Offload TakeOrderedAndProjectExec at planning time rather than at runtime [incubator-gluten]

2024-05-30 Thread via GitHub
zhztheplayer opened a new pull request, #5927: URL: https://github.com/apache/incubator-gluten/pull/5927 ### Single Top N Plan before: ``` VeloxColumnarToRowExec (53) +- TakeOrderedAndProjectExecTransformer (52) +- ^ RegularHashAggregateExecTransformer (50)

Re: [PR] [GLUTEN-5904][CH] Convert `nan` to `null` which comes from `stddev` [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5913: URL: https://github.com/apache/incubator-gluten/pull/5913#issuecomment-2139043089 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
zhztheplayer commented on code in PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#discussion_r1620253404 ## gluten-core/src/main/scala/org/apache/gluten/backendsapi/TransformerApi.scala: ## @@ -70,4 +70,6 @@ trait TransformerApi { def

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
zhztheplayer commented on code in PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#discussion_r1620251065 ## gluten-core/src/main/scala/org/apache/gluten/backendsapi/ListenerApi.scala: ## @@ -16,11 +16,11 @@ */ package org.apache.gluten.backendsapi

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
zhztheplayer commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2138995448 > @zhztheplayer @baibaichen IIUC, Velox backend follows the vanilla Spark broadcast exchange way. I'm not sure why do we need additional lifecycle. I assume CH

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
ulysses-you commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2138970685 @zhztheplayer @baibaichen IIUC, Velox backend follows the vanilla Spark broadcast exchange way. I'm not sure why do we need additional lifecycle. -- This is an

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-30 Thread via GitHub
xumingming commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2138963209 > > `shuffle`, `array_sort` are already supported, can be marked as complete. > > @xumingming, seems `sort_array` is supported, but `array_sort` is not. Please

Re: [PR] [GLUTEN-5656][CORE][FOLLOWUP] Support GetStructField with NullLiteralNode as subqueries not executing during validation [incubator-gluten]

2024-05-30 Thread via GitHub
jackylee-ch merged PR #5923: URL: https://github.com/apache/incubator-gluten/pull/5923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4942][VL] Adding arrow port in VCPKG [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5926: URL: https://github.com/apache/incubator-gluten/pull/5926#issuecomment-2138851558 https://github.com/apache/incubator-gluten/issues/4942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4942][VL] Adding arrow port in VCPKG [incubator-gluten]

2024-05-30 Thread via GitHub
zhouyuan opened a new pull request, #5926: URL: https://github.com/apache/incubator-gluten/pull/5926 ## What changes were proposed in this pull request? this patch adds arrow port in vcpkg list also restore the change in package-vcpkg.sh ## How was this patch tested?

Re: [PR] [DNM] check spark ut with static build [incubator-gluten]

2024-05-30 Thread via GitHub
zhouyuan closed pull request #5515: [DNM] check spark ut with static build URL: https://github.com/apache/incubator-gluten/pull/5515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [GLUTEN-4917][VL] CI: update GHA docker image [incubator-gluten]

2024-05-30 Thread via GitHub
zhouyuan commented on PR #5907: URL: https://github.com/apache/incubator-gluten/pull/5907#issuecomment-2138809522 note: vcpkg is not able to detect the changes on compile flags - in this case it needs to force recompile the lib -- This is an automated message from the Apache Git

Re: [PR] [GLUTEN-5691][CH] Enable merge on local disk first after insert into mergetree [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5692: URL: https://github.com/apache/incubator-gluten/pull/5692#issuecomment-2138807204 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Gluten-it: Optimize Maven dependency list [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5925: URL: https://github.com/apache/incubator-gluten/pull/5925#issuecomment-2138806502 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Gluten-it: Optimize Maven dependency list [incubator-gluten]

2024-05-30 Thread via GitHub
zhztheplayer opened a new pull request, #5925: URL: https://github.com/apache/incubator-gluten/pull/5925 As title. Optimize Maven dependency list, clarify dependency scopes and visibilities. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [GLUTEN-5921][CH] Function trim of trim_character support value from column [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5922: URL: https://github.com/apache/incubator-gluten/pull/5922#issuecomment-2138806290 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Gluten-it: Optimize Maven dependency list [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5925: URL: https://github.com/apache/incubator-gluten/pull/5925#issuecomment-2138806171 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2138780356 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5904][CH] Convert `nan` to `null` which comes from `stddev` [incubator-gluten]

2024-05-30 Thread via GitHub
github-actions[bot] commented on PR #5913: URL: https://github.com/apache/incubator-gluten/pull/5913#issuecomment-2138772042 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-30 Thread via GitHub
baibaichen commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2138761241 > So this lifecycle feature is not really that common for all backends? (cc @baibaichen) @ulysses-you @zhztheplayer We use such mechanism to free memory

Re: [PR] [CH] Adaptive sort memory controll and support memory sort shuffle [incubator-gluten]

2024-05-30 Thread via GitHub
GlutenPerfBot commented on PR #5893: URL: https://github.com/apache/incubator-gluten/pull/5893#issuecomment-2138759814 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-30 Thread via GitHub
rui-mo commented on code in PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#discussion_r1620002926 ## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala: ## @@ -376,13 +376,8 @@ object VeloxBackendSettings extends

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-29 Thread via GitHub
github-actions[bot] commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2138738297 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240523) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5846: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240523) URL: https://github.com/apache/incubator-gluten/pull/5846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240530) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5916: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240530) URL: https://github.com/apache/incubator-gluten/pull/5916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240529) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5899: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240529) URL: https://github.com/apache/incubator-gluten/pull/5899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240528) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5885: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240528) URL: https://github.com/apache/incubator-gluten/pull/5885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240525) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5866: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240525) URL: https://github.com/apache/incubator-gluten/pull/5866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240521) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5817: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240521) URL: https://github.com/apache/incubator-gluten/pull/5817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240520) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5806: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240520) URL: https://github.com/apache/incubator-gluten/pull/5806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240519) [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen closed pull request #5804: [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240519) URL: https://github.com/apache/incubator-gluten/pull/5804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-29 Thread via GitHub
zhztheplayer commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2138710742 So this lifecycle feature is not really that common for all backends? (cc @baibaichen) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [GLUTEN-5569][VL] Hide child WriteFilesExec from VeloxColumnarWriteFilesExec on UI [incubator-gluten]

2024-05-29 Thread via GitHub
github-actions[bot] commented on PR #5698: URL: https://github.com/apache/incubator-gluten/pull/5698#issuecomment-2138698310 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Noisy wrong fallback message after case-class refactor [incubator-gluten]

2024-05-29 Thread via GitHub
zhztheplayer commented on issue #5880: URL: https://github.com/apache/incubator-gluten/issues/5880#issuecomment-2138698607 A proposed fix was included in https://github.com/apache/incubator-gluten/pull/5698. @Yohahaha -- This is an automated message from the Apache Git Service. To

Re: [PR] [GLUTEN-4942][VL] refine vcpkg package script [incubator-gluten]

2024-05-29 Thread via GitHub
GlutenPerfBot commented on PR #5900: URL: https://github.com/apache/incubator-gluten/pull/5900#issuecomment-2138694462 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CH] Adaptive sort memory controll and support memory sort shuffle [incubator-gluten]

2024-05-29 Thread via GitHub
baibaichen merged PR #5893: URL: https://github.com/apache/incubator-gluten/pull/5893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5898][CH] Fix regexp_extract function use bracket has diff behaver with spark [incubator-gluten]

2024-05-29 Thread via GitHub
github-actions[bot] commented on PR #5908: URL: https://github.com/apache/incubator-gluten/pull/5908#issuecomment-2138653148 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Move driver/executor endpoint to CH backend [incubator-gluten]

2024-05-29 Thread via GitHub
ulysses-you commented on PR #5914: URL: https://github.com/apache/incubator-gluten/pull/5914#issuecomment-2138642953 cc @zhztheplayer @PHILO-HE @binmahone @zzcclp thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-4942][VL] refine vcpkg package script [incubator-gluten]

2024-05-29 Thread via GitHub
zhouyuan merged PR #5900: URL: https://github.com/apache/incubator-gluten/pull/5900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Following #5889, correct / simplify the table indenting algorithm [incubator-gluten]

2024-05-29 Thread via GitHub
GlutenPerfBot commented on PR #5917: URL: https://github.com/apache/incubator-gluten/pull/5917#issuecomment-2138635179 = Performance report for TPCH SF2000 with Velox backend, for reference only query

[I] [VL] Static build failed on ubuntu 22.04 [incubator-gluten]

2024-05-29 Thread via GitHub
marin-ma opened a new issue, #5924: URL: https://github.com/apache/incubator-gluten/issues/5924 ### Backend VL (Velox) ### Bug description OS: 5.19.0-32-generic #33~22.04.1-Ubuntu gcc: gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04) command: ``` cd

Re: [I] [VL] Failed to build cmake-3.29 [incubator-gluten]

2024-05-29 Thread via GitHub
boobpoop commented on issue #5912: URL: https://github.com/apache/incubator-gluten/issues/5912#issuecomment-2138621236 > looks velox uses 3.28. > > [facebookincubator/velox#9861](https://github.com/facebookincubator/velox/pull/9861) Building cmake 3.28 will also fail. --

Re: [PR] [GLUTEN-5701][VL] Add overflow test case for from_unixtime function [incubator-gluten]

2024-05-29 Thread via GitHub
github-actions[bot] commented on PR #5894: URL: https://github.com/apache/incubator-gluten/pull/5894#issuecomment-2138618152 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5656][CORE][FOLLOWUP] Support GetStructField with NullLiteralNode as subqueries not executing during validation [incubator-gluten]

2024-05-29 Thread via GitHub
github-actions[bot] commented on PR #5923: URL: https://github.com/apache/incubator-gluten/pull/5923#issuecomment-2138609928 https://github.com/apache/incubator-gluten/issues/5656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5656][CORE][FOLLOWUP] Support GetStructField with NullLiteralNode as subqueries not executing during validation [incubator-gluten]

2024-05-29 Thread via GitHub
jackylee-ch opened a new pull request, #5923: URL: https://github.com/apache/incubator-gluten/pull/5923 ## What changes were proposed in this pull request? After #5658 , we met validation failed with q24a ad q24b while using bloomFilter. ## How was this patch tested? manul

Re: [PR] [GLUTEN-5921][CH] Function trim of trim_character support value from column [incubator-gluten]

2024-05-29 Thread via GitHub
github-actions[bot] commented on PR #5922: URL: https://github.com/apache/incubator-gluten/pull/5922#issuecomment-2138597887 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

<    2   3   4   5   6   7   8   9   10   11   >