Re: [I] [VL] Support file cache spill in Gluten [incubator-gluten]

2024-05-28 Thread via GitHub
zhli1142015 commented on issue #5884: URL: https://github.com/apache/incubator-gluten/issues/5884#issuecomment-2136292333 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5889: URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2136275977 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Arrow CSV reader peak memory is very large [incubator-gluten]

2024-05-28 Thread via GitHub
jinchengchenghh commented on issue #5766: URL: https://github.com/apache/incubator-gluten/issues/5766#issuecomment-2136264870 I think it is because arrow does not support to add file start and length to split a file, so it's peak memory is high for a very big CSV file. -- This is an

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240529) [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5899: URL: https://github.com/apache/incubator-gluten/pull/5899#issuecomment-2136243563 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240529) [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5899: URL: https://github.com/apache/incubator-gluten/pull/5899#issuecomment-2136243348 https://github.com/apache/incubator-gluten/issues/1632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240529) [incubator-gluten]

2024-05-28 Thread via GitHub
kyligence-git opened a new pull request, #5899: URL: https://github.com/apache/incubator-gluten/pull/5899 Auto commit by gluten daily build, please check the build status and merge it if it's green. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [GLUTEN-5314][VL] Separate FileSink instantiation for different file systems [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5881: URL: https://github.com/apache/incubator-gluten/pull/5881#issuecomment-2135959661 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [I] [VL] Support file cache spill in Gluten [incubator-gluten]

2024-05-28 Thread via GitHub
FelixYBW commented on issue #5884: URL: https://github.com/apache/incubator-gluten/issues/5884#issuecomment-2135956052 @zhli1142015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [VL] Noisy wrong fallback message after case-class refactor [incubator-gluten]

2024-05-28 Thread via GitHub
FelixYBW commented on issue #5880: URL: https://github.com/apache/incubator-gluten/issues/5880#issuecomment-2135940860 Can we create an exception for each fallback reason? then put the message in the exception? @zhztheplayer Let's have a sync on this. -- This is an automated message

Re: [PR] [GLUTEN-5314][VL] Separate FileSink instantiation for different file systems [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5881: URL: https://github.com/apache/incubator-gluten/pull/5881#issuecomment-2135862670 = Performance report for TPCDS SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Use conf to control C2R occupied memory [incubator-gluten]

2024-05-28 Thread via GitHub
FelixYBW commented on PR #5799: URL: https://github.com/apache/incubator-gluten/pull/5799#issuecomment-2135797262 why the PR is closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Enable partial merge mode for HLL [incubator-gluten]

2024-05-28 Thread via GitHub
liujiayi771 commented on code in PR #5754: URL: https://github.com/apache/incubator-gluten/pull/5754#discussion_r1617565686 ## backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala: ## @@ -241,21 +226,21 @@ abstract class

Re: [PR] [GLUTEN-5314][VL] Separate FileSink instantiation for different file systems [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5881: URL: https://github.com/apache/incubator-gluten/pull/5881#issuecomment-2135478487 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Upgrade folly to v2024.04.01.00 [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5314: URL: https://github.com/apache/incubator-gluten/pull/5314#issuecomment-2135308946 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2135163595 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Add a config to ignore fallback cost for scan [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5617: URL: https://github.com/apache/incubator-gluten/pull/5617#issuecomment-2135105055 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Remove fallback for rand function with user-specified seed [incubator-gluten]

2024-05-28 Thread via GitHub
PHILO-HE closed pull request #4879: [VL] Remove fallback for rand function with user-specified seed URL: https://github.com/apache/incubator-gluten/pull/4879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [GLUTEN-5314][VL] Separate FileSink instantiation for different file systems [incubator-gluten]

2024-05-28 Thread via GitHub
PHILO-HE merged PR #5881: URL: https://github.com/apache/incubator-gluten/pull/5881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2135039289 = Performance report for TPCDS SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5314][VL] Separate FileSink instantiation for different file systems [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5881: URL: https://github.com/apache/incubator-gluten/pull/5881#issuecomment-2135036265 https://github.com/apache/incubator-gluten/issues/5314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [VL] Upgrade folly to v2024.04.01.00 [incubator-gluten]

2024-05-28 Thread via GitHub
PHILO-HE merged PR #5314: URL: https://github.com/apache/incubator-gluten/pull/5314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Enable partial merge mode for HLL [incubator-gluten]

2024-05-28 Thread via GitHub
zhli1142015 commented on PR #5754: URL: https://github.com/apache/incubator-gluten/pull/5754#issuecomment-2134957304 cc @liujiayi771 and @PHILO-HE , thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [VL] Fix build error [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5891: URL: https://github.com/apache/incubator-gluten/pull/5891#issuecomment-2134904825 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5890][Core] Enhance jni signature with a more readable way [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5888: URL: https://github.com/apache/incubator-gluten/pull/5888#issuecomment-2134883011 https://github.com/apache/incubator-gluten/issues/5890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] The optimization for the method signature [incubator-gluten]

2024-05-28 Thread via GitHub
Donvi commented on issue #5890: URL: https://github.com/apache/incubator-gluten/issues/5890#issuecomment-2134861093 A good example is splitResultConstructor, which seems not matched with java definition. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [GLUTEN-5668][CH] Support mixed conditions in shuffle hash join [incubator-gluten]

2024-05-28 Thread via GitHub
liuneng1994 commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2134856212 ![image](https://github.com/apache/incubator-gluten/assets/16730247/a42d742e-a40c-4911-b97d-7bc6b43bfc0e) spark.sql.autoBroadcastJoinThreshold=100MB -- This is an

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2134822983 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-28 Thread via GitHub
zml1206 commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2134801039 /Benchmark Velox TPCDS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CORE] Use the smaller table to build hashmap in shuffled hash join [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5750: URL: https://github.com/apache/incubator-gluten/pull/5750#issuecomment-2134798702 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [CH] Unexpected csv result when use use_excel_serialization=true [incubator-gluten]

2024-05-28 Thread via GitHub
loneylee opened a new issue, #5898: URL: https://github.com/apache/incubator-gluten/issues/5898 ### Backend CH (ClickHouse) ### Bug description ``` 1,"123%"; 2,"123%123%"; ``` spark result: [[1, "123%";] [2,"123%123%";]] gluten result:

[I] [CH] Different behavior on function regexp_extract with spark [incubator-gluten]

2024-05-28 Thread via GitHub
loneylee opened a new issue, #5897: URL: https://github.com/apache/incubator-gluten/issues/5897 ### Backend CH (ClickHouse) ### Bug description select regexp_extract('1-A', '([0-9][[\.][0-9]]*)', 1) Spark behavior: `1` actual behavior: ``

Re: [PR] [GLUTEN-5625][VL] Support window range frame [incubator-gluten]

2024-05-28 Thread via GitHub
PHILO-HE commented on code in PR #5626: URL: https://github.com/apache/incubator-gluten/pull/5626#discussion_r1616704118 ## gluten-core/src/main/java/org/apache/gluten/substrait/expression/WindowFunctionNode.java: ## @@ -80,20 +91,50 @@ private

Re: [PR] [VL] Include ClickBench benchmark in gluten-it [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5887: URL: https://github.com/apache/incubator-gluten/pull/5887#issuecomment-2134757597 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [CH] Adaptive sort memory controll and support memory sort shuffle [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5893: URL: https://github.com/apache/incubator-gluten/pull/5893#issuecomment-2134735990 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] [CH] Function `greatest` result diff from valina spark while the input params has NULL value [incubator-gluten]

2024-05-28 Thread via GitHub
KevinyhZou opened a new issue, #5896: URL: https://github.com/apache/incubator-gluten/issues/5896 ### Backend CH (ClickHouse) ### Bug description If the params has NULL value, like greatest(123, NULL), the spark return result 123, but gluten return NULL. ###

Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5889: URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2134682832 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Results are mismatch with vanilla Spark when uses from_unixtime with overflowed parameter and query config setted time zone [incubator-gluten]

2024-05-28 Thread via GitHub
NEUpanning commented on issue #5701: URL: https://github.com/apache/incubator-gluten/issues/5701#issuecomment-2134627434 @PHILO-HE Yes. I also think we should add a unit test for this case. I've opened a [PR](https://github.com/apache/incubator-gluten/pull/5894) for this could you help to

Re: [PR] [GLUTEN-5840][VL] Fix udaf register simple intermediate type [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5876: URL: https://github.com/apache/incubator-gluten/pull/5876#issuecomment-2134627985 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5701][VL] Add unit test for from_unixtime function [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5894: URL: https://github.com/apache/incubator-gluten/pull/5894#issuecomment-2134623355 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5701][VL] Add unit test for from_unixtime function [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5894: URL: https://github.com/apache/incubator-gluten/pull/5894#issuecomment-2134622875 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] [DNM] Test window oom [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5895: URL: https://github.com/apache/incubator-gluten/pull/5895#issuecomment-2134623955 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [GLUTEN-5701][VL] Add unit test for from_unixtime function [incubator-gluten]

2024-05-28 Thread via GitHub
NEUpanning opened a new pull request, #5894: URL: https://github.com/apache/incubator-gluten/pull/5894 # What changes were proposed in this pull request? After https://github.com/facebookincubator/velox/issues/9778 is fixed, add unit test for from_unixtime with overflowed argument and

Re: [PR] [GLUTEN-5841][CH]Fix session timezone diff [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892#issuecomment-2134610304 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] Adaptive sort memory controll and support memory sort shuffle [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5893: URL: https://github.com/apache/incubator-gluten/pull/5893#issuecomment-2134606515 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CH] Adaptive sort memory controll and support memory sort shuffle [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5893: URL: https://github.com/apache/incubator-gluten/pull/5893#issuecomment-2134606358 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5841][CH]Bug fix session timezone diff [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892#issuecomment-2134595859 https://github.com/apache/incubator-gluten/issues/5841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5841][CH]Bug fix session timezone diff [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5892: URL: https://github.com/apache/incubator-gluten/pull/5892#issuecomment-2134596318 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Fix build error [incubator-gluten]

2024-05-28 Thread via GitHub
ulysses-you merged PR #5891: URL: https://github.com/apache/incubator-gluten/pull/5891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] [GLUTEN-5841][CH]Bug fix session timezone diff [incubator-gluten]

2024-05-28 Thread via GitHub
KevinyhZou opened a new pull request, #5892: URL: https://github.com/apache/incubator-gluten/pull/5892 ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) (Fixes: \#5841) ## How was this patch tested? TEST BY UT

Re: [PR] [VL] Fix build error [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5891: URL: https://github.com/apache/incubator-gluten/pull/5891#issuecomment-2134590019 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[I] The optimization for the method signature [incubator-gluten]

2024-05-28 Thread via GitHub
Donvi opened a new issue, #5890: URL: https://github.com/apache/incubator-gluten/issues/5890 ### Description Current the method signature is set with current plain text, which is not so good to maintain and read like "(J[J[II[B)V" and confusing for onboarding and in maintenance.

Re: [PR] [VL] Fix build error [incubator-gluten]

2024-05-28 Thread via GitHub
zhli1142015 commented on PR #5891: URL: https://github.com/apache/incubator-gluten/pull/5891#issuecomment-2134589827 cc @ulysses-you , thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Fix build error [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5891: URL: https://github.com/apache/incubator-gluten/pull/5891#issuecomment-2134589536 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [GLUTEN-5668][CH] Support mixed conditions in shuffle hash join [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2134584885 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Arrow CSV reader peak memory is very large [incubator-gluten]

2024-05-28 Thread via GitHub
liujiayi771 commented on issue #5766: URL: https://github.com/apache/incubator-gluten/issues/5766#issuecomment-2134574129 @jinchengchenghh I tested the latest code, and the peak memory usage is still relatively high. I did not add logs in `ArrowReservationListener.reserve`. Printing logs

Re: [I] [VL] Support file cache spill in Gluten [incubator-gluten]

2024-05-28 Thread via GitHub
yma11 commented on issue #5884: URL: https://github.com/apache/incubator-gluten/issues/5884#issuecomment-2134559957 @zhouyuan @zhztheplayer Can you help take a review at this draft design? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CORE] Only materialize subquery before doing transform [incubator-gluten]

2024-05-28 Thread via GitHub
ulysses-you merged PR #5862: URL: https://github.com/apache/incubator-gluten/pull/5862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5889: URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2134490755 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5889: URL: https://github.com/apache/incubator-gluten/pull/5889#issuecomment-2134490412 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Gluten-it: Simplify queries-compare test report [incubator-gluten]

2024-05-28 Thread via GitHub
zhztheplayer opened a new pull request, #5889: URL: https://github.com/apache/incubator-gluten/pull/5889 This just simplifies the representation of test report of subcommand `queries-compare`. Before: ``` ... | Query ID| Was Passed| Expected Row Count| Actual Row Count|

Re: [PR] [GLUTEN-5852] [CH] fix mismatch result columns size exception [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5853: URL: https://github.com/apache/incubator-gluten/pull/5853#issuecomment-2134489028 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Only materialize subquery before doing transform [incubator-gluten]

2024-05-28 Thread via GitHub
GlutenPerfBot commented on PR #5862: URL: https://github.com/apache/incubator-gluten/pull/5862#issuecomment-2134486562 = Performance report for TPCDS SF2000 with Velox backend, for reference only query

Re: [PR] [VL] Include ClickBench benchmark in gluten-it [incubator-gluten]

2024-05-28 Thread via GitHub
zhztheplayer merged PR #5887: URL: https://github.com/apache/incubator-gluten/pull/5887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5668][CH] Support mixed conditions in shuffle hash join [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2134459908 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5668][CH] Support mixed conditions in shuffle hash join [incubator-gluten]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2134457374 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Add SampleExec operator support [incubator-gluten]

2024-05-28 Thread via GitHub
zhli1142015 closed issue #5315: [VL] Add SampleExec operator support URL: https://github.com/apache/incubator-gluten/issues/5315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [VL][Core] SampleExec Operator Native Support [incubator-gluten]

2024-05-28 Thread via GitHub
zhli1142015 merged PR #5856: URL: https://github.com/apache/incubator-gluten/pull/5856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [CH] Crash on exit with Poco exception [incubator-gluten]

2024-05-28 Thread via GitHub
zhanglistar closed issue #5744: [CH] Crash on exit with Poco exception URL: https://github.com/apache/incubator-gluten/issues/5744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [VL] Support Row Index Metadata Column [incubator-gluten]

2024-05-28 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5351: URL: https://github.com/apache/incubator-gluten/pull/5351#discussion_r1616670085 ## shims/spark32/src/main/scala/org/apache/gluten/sql/shims/spark32/Spark32Shims.scala: ## @@ -189,8 +189,15 @@ class Spark32Shims extends SparkShims {

Re: [PR] [GLUTEN-5852] [CH] fix mismatch result columns size exception [incubator-gluten]

2024-05-28 Thread via GitHub
shuai-xu commented on code in PR #5853: URL: https://github.com/apache/incubator-gluten/pull/5853#discussion_r1616669009 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/rewrite/PullOutPreProject.scala: ## @@ -158,9 +158,11 @@ object PullOutPreProject extends

Re: [PR] [VL] Support Row Index Metadata Column [incubator-gluten]

2024-05-28 Thread via GitHub
gaoyangxiaozhu commented on code in PR #5351: URL: https://github.com/apache/incubator-gluten/pull/5351#discussion_r1616669627 ## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala: ## @@ -272,6 +272,10 @@ object VeloxBackendSettings extends

Re: [PR] [GLUTEN-5840][VL] Fix udaf register simple intermediate type [incubator-gluten]

2024-05-28 Thread via GitHub
marin-ma merged PR #5876: URL: https://github.com/apache/incubator-gluten/pull/5876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Error when intermedia data type is not a struct type [incubator-gluten]

2024-05-28 Thread via GitHub
marin-ma closed issue #5840: Error when intermedia data type is not a struct type URL: https://github.com/apache/incubator-gluten/issues/5840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Enhance jni signature with a more readable way [incubator-gluten]

2024-05-28 Thread via GitHub
Yohahaha commented on code in PR #5888: URL: https://github.com/apache/incubator-gluten/pull/5888#discussion_r1616653295 ## cpp/core/jni/JniCommon.h: ## @@ -31,6 +31,11 @@ #include "utils/exception.h" static jint jniVersion = JNI_VERSION_1_8; +static map type2sig =

Re: [I] [VL] Noisy wrong fallback message after case-class refactor [incubator-gluten]

2024-05-28 Thread via GitHub
Yohahaha commented on issue #5880: URL: https://github.com/apache/incubator-gluten/issues/5880#issuecomment-2134421357 > I see there is already a

Re: [PR] [CH] Add Compatibility test found by internal [incubator-gluten]

2024-05-28 Thread via GitHub
zzcclp merged PR #5882: URL: https://github.com/apache/incubator-gluten/pull/5882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Only materialize subquery before doing transform [incubator-gluten]

2024-05-28 Thread via GitHub
PHILO-HE commented on PR #5862: URL: https://github.com/apache/incubator-gluten/pull/5862#issuecomment-2134406912 > @PHILO-HE @zhztheplayer I'm not sure the TPCDS benchmark has triggered and run successfully, can you help check the internal state? thank you! It's triggered, but not

Re: [PR] Enhance jni signature with a more readable way [incubator-gluten]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5888: URL: https://github.com/apache/incubator-gluten/pull/5888#issuecomment-2134399584 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] Enhance jni signature with a more readable way [incubator-gluten]

2024-05-27 Thread via GitHub
Donvi opened a new pull request, #5888: URL: https://github.com/apache/incubator-gluten/pull/5888 ## What changes were proposed in this pull request? This is to optimize current const text in code like "([B)V", which means the jbooleanArray with void return. So we currently have

Re: [PR] [VL] Support Row Index Metadata Column [incubator-gluten]

2024-05-27 Thread via GitHub
yma11 commented on code in PR #5351: URL: https://github.com/apache/incubator-gluten/pull/5351#discussion_r1616625080 ## gluten-ut/spark34/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/GlutenParquetRowIndexSuite.scala: ## @@ -315,10 +311,10 @@ class

Re: [PR] [VL] Support Row Index Metadata Column [incubator-gluten]

2024-05-27 Thread via GitHub
yma11 commented on code in PR #5351: URL: https://github.com/apache/incubator-gluten/pull/5351#discussion_r1616608418 ## shims/spark32/src/main/scala/org/apache/gluten/sql/shims/spark32/Spark32Shims.scala: ## @@ -189,8 +189,15 @@ class Spark32Shims extends SparkShims { def

Re: [PR] [VL] Daily Update Velox Version (2024_05_28) [incubator-gluten]

2024-05-27 Thread via GitHub
PHILO-HE commented on PR #5886: URL: https://github.com/apache/incubator-gluten/pull/5886#issuecomment-2134382782 No code change from Velox. Let's closing this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [VL] Daily Update Velox Version (2024_05_28) [incubator-gluten]

2024-05-27 Thread via GitHub
PHILO-HE closed pull request #5886: [VL] Daily Update Velox Version (2024_05_28) URL: https://github.com/apache/incubator-gluten/pull/5886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GLUTEN-5414] [VL] Support arrow csv option and schema [incubator-gluten]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5850: URL: https://github.com/apache/incubator-gluten/pull/5850#issuecomment-2134365549 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-5569][VL] Hide child WriteFilesExec from VeloxColumnarWriteFilesExec on UI [incubator-gluten]

2024-05-27 Thread via GitHub
zhztheplayer commented on PR #5698: URL: https://github.com/apache/incubator-gluten/pull/5698#issuecomment-2134349360 > I agree, each code sync between community and out internal repo takes lots time No real refactors can be done if an OSS takes the rebase effort of forked

Re: [I] [VL] Noisy wrong fallback message after case-class refactor [incubator-gluten]

2024-05-27 Thread via GitHub
zhztheplayer commented on issue #5880: URL: https://github.com/apache/incubator-gluten/issues/5880#issuecomment-2134315906 I see there is already a

Re: [PR] [VL] Separate FileSink instantiation for different file systems [incubator-gluten]

2024-05-27 Thread via GitHub
PHILO-HE commented on PR #5881: URL: https://github.com/apache/incubator-gluten/pull/5881#issuecomment-2134305455 @RaoZhiRou-Z, could you confirm whether this patch can fix you issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [GLUTEN-5668][CH] Support mixed conditions in shuffle hash join [incubator-gluten]

2024-05-27 Thread via GitHub
lgbo-ustc commented on PR #5735: URL: https://github.com/apache/incubator-gluten/pull/5735#issuecomment-2134296123 分析了下`StorageJoinFromReadBuffer::StorageJoinFromReadBuffer`和`StorageJoinFromReadBuffer::getJoinLocked`在变动前后的耗时变化。 - before ``` 2024-05-28 11:38:49.246

Re: [PR] [GLUTEN-5852] [CH] fix mismatch result columns size exception [incubator-gluten]

2024-05-27 Thread via GitHub
liujiayi771 commented on code in PR #5853: URL: https://github.com/apache/incubator-gluten/pull/5853#discussion_r1616541251 ## gluten-core/src/main/scala/org/apache/gluten/utils/PullOutProjectHelper.scala: ## @@ -70,6 +76,19 @@ trait PullOutProjectHelper {

Re: [PR] [VL] Use conf to control C2R occupied memory [incubator-gluten]

2024-05-27 Thread via GitHub
XinShuoWang closed pull request #5799: [VL] Use conf to control C2R occupied memory URL: https://github.com/apache/incubator-gluten/pull/5799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Include ClickBench benchmark in gluten-it [incubator-gluten]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5887: URL: https://github.com/apache/incubator-gluten/pull/5887#issuecomment-2134278069 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

Re: [PR] [VL] Include ClickBench benchmark in gluten-it [incubator-gluten]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5887: URL: https://github.com/apache/incubator-gluten/pull/5887#issuecomment-2134278248 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [VL] Include ClickBench benchmark in gluten-it [incubator-gluten]

2024-05-27 Thread via GitHub
zhztheplayer opened a new pull request, #5887: URL: https://github.com/apache/incubator-gluten/pull/5887 The patch introduce [ClickBench](https://github.com/ClickHouse/ClickBench) benchmark into gluten-it. The benchmark can be triggered locally and is not yet added to CI. To trigger

Re: [PR] [VL] Following #5861, append some nit changes [incubator-gluten]

2024-05-27 Thread via GitHub
zhztheplayer merged PR #5873: URL: https://github.com/apache/incubator-gluten/pull/5873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Only materialize subquery before doing transform [incubator-gluten]

2024-05-27 Thread via GitHub
zhztheplayer commented on PR #5862: URL: https://github.com/apache/incubator-gluten/pull/5862#issuecomment-2134272255 /Benchmark Velox -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [VL] Support Row Index Metadata Column [incubator-gluten]

2024-05-27 Thread via GitHub
gaoyangxiaozhu commented on PR #5351: URL: https://github.com/apache/incubator-gluten/pull/5351#issuecomment-2134252281 @yma11 / @rui-mo could you help review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [GLUTEN-5852] [CH] fix mismatch result columns size exception [incubator-gluten]

2024-05-27 Thread via GitHub
liujiayi771 commented on code in PR #5853: URL: https://github.com/apache/incubator-gluten/pull/5853#discussion_r1616507635 ## gluten-core/src/main/scala/org/apache/gluten/extension/columnar/rewrite/PullOutPreProject.scala: ## @@ -158,9 +158,11 @@ object PullOutPreProject

Re: [PR] [CORE] Only materialize subquery before doing transform [incubator-gluten]

2024-05-27 Thread via GitHub
ulysses-you commented on PR #5862: URL: https://github.com/apache/incubator-gluten/pull/5862#issuecomment-2134248615 @PHILO-HE @zhztheplayer I'm not sure the TPCDS benchmark has triggered and run successfully, can you help check the internal state? thank you! -- This is an automated

Re: [PR] [VL][Core] SampleExec Operator Native Support [incubator-gluten]

2024-05-27 Thread via GitHub
gaoyangxiaozhu commented on PR #5856: URL: https://github.com/apache/incubator-gluten/pull/5856#issuecomment-2134245248 @zhli1142015 help merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [GLUTEN-5852] [CH] fix mismatch result columns size exception [incubator-gluten]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5853: URL: https://github.com/apache/incubator-gluten/pull/5853#issuecomment-2134244577 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

<    4   5   6   7   8   9   10   11   12   13   >