This is an automated email from the ASF dual-hosted git repository. ulyssesyou pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push: new 879ea76ce [VL] Merge Partial and PartialMerge logic in generateMergeCompanionNode (#4883) 879ea76ce is described below commit 879ea76ce2dae22f97e61c81254464dc5292a1ac Author: Joey <joey....@alibaba-inc.com> AuthorDate: Fri Mar 8 09:52:08 2024 +0800 [VL] Merge Partial and PartialMerge logic in generateMergeCompanionNode (#4883) --- .../execution/HashAggregateExecTransformer.scala | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala b/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala index cc428b592..cc7a1a852 100644 --- a/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala +++ b/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala @@ -217,18 +217,9 @@ abstract class HashAggregateExecTransformer( def generateMergeCompanionNode(): Unit = { aggregateMode match { - case Partial => - val partialNode = ExpressionBuilder.makeAggregateFunction( - VeloxAggregateFunctionsBuilder.create(args, aggregateFunction, aggregateMode), - childrenNodeList, - modeKeyWord, - VeloxIntermediateData.getIntermediateTypeNode(aggregateFunction) - ) - aggregateNodeList.add(partialNode) - case PartialMerge => + case Partial | PartialMerge => val aggFunctionNode = ExpressionBuilder.makeAggregateFunction( - VeloxAggregateFunctionsBuilder - .create(args, aggregateFunction, aggregateMode), + VeloxAggregateFunctionsBuilder.create(args, aggregateFunction, aggregateMode), childrenNodeList, modeKeyWord, VeloxIntermediateData.getIntermediateTypeNode(aggregateFunction) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@gluten.apache.org For additional commands, e-mail: commits-h...@gluten.apache.org