Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-06-05 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2151468471 > > ubase64: #4482 > > I see you've map the from_base64 to unbase64, and respectively I find the base64 is almost the same as to_base64, so it's just a missing or

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-06-05 Thread via GitHub
Donvi commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2151449323 > ubase64: #4482 I see you've map the from_base64 to unbase64, and respectively I find the base64 is almost the same as to_base64, so it's just a missing or is there

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-31 Thread via GitHub
boneanxs commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2141753499 @PHILO-HE I can try to support `array_sort` if no one picked, we internally need this function :) -- This is an automated message from the Apache Git Service. To

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-30 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2139430047 > And there is a test for `collect_set` which used array_sort > >

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-30 Thread via GitHub
xumingming commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2138963209 > > `shuffle`, `array_sort` are already supported, can be marked as complete. > > @xumingming, seems `sort_array` is supported, but `array_sort` is not. Please

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-27 Thread via GitHub
Donvi commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2132826236 As I see only `rand` exists and no `randn`, I'm taking randn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-24 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2128849458 > `shuffle`, `array_sort` are already supported, can be marked as complete. Seems `sort_array` is supported, but `array_sort` is not. Please spare some time to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-24 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2128844727 > > > @PHILO-HE Thanks for your feedback. So i'd like to take date_part. Is to_date supported in gluten now? It doesn't shows in the list. I also would like to pick it.

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-22 Thread via GitHub
xumingming commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2124608290 I will take a look at `bround` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-22 Thread via GitHub
xumingming commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2124030163 `shuffle`, `array_sort` are already supported, can be marked as complete. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-21 Thread via GitHub
NEUpanning commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2121980171 > > @PHILO-HE Thanks for your feedback. So i'd like to take date_part. Is to_date supported in gluten now? It doesn't shows in the list. I also would like to pick it.

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-20 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2121466319 > @PHILO-HE Thanks for your feedback. So i'd like to take date_part. Is to_date supported in gluten now? It doesn't shows in the list. I also would like to pick it.

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-19 Thread via GitHub
NEUpanning commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2119607052 @PHILO-HE Thanks for your feedback. So i'd like to take date_part. Is to_date supported in gluten now? It doesn't shows in the list. I also would like to pick it. --

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-17 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2117417987 > I'd like to take unix_date, thanks. We have supported it in both Gluten & Velox. Just changed its state in the list. Thanks!

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-17 Thread via GitHub
NEUpanning commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2117366460 I'd like to take unix_date, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-14 Thread via GitHub
xumingming commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2109422932 @marin-ma Thanks for the advice, I will take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-13 Thread via GitHub
marin-ma commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2109187441 > I'd like to take a look at `stack` function, it seems like a `Generator`, meaning one row of input might return multiple rows of output, does Velox has this generator

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-13 Thread via GitHub
xumingming commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2109163864 I'd like to take a look at `stack` function, it seems like a `Generator`, meaning one row of input might return multiple rows of output, does Velox has this generator

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-09 Thread via GitHub
ivoson commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2102428935 I'd like to implement `array_append` and `array_insert` for spark 3.4+ -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-05-07 Thread via GitHub
gaoyangxiaozhu commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2098240491 PR for width_bucket support, https://github.com/apache/incubator-gluten/pull/5634 looks still need velox side change for bucket_number <=0 case will send PR in

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-29 Thread via GitHub
Donvi commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2084419656 I'd like and am working in the math function expm1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-29 Thread via GitHub
honeyhexin commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2084334638 I'd like to take cot, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-25 Thread via GitHub
zhli1142015 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2078523538 I'd like to take `soundex` and `levenshtein`, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-24 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2074589292 > hey @zhouyuan could you help add `format_string` and `format_number` in the list and I would take `format_string` and `format_number` later @gaoyangxiaozhu, just

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-24 Thread via GitHub
gaoyangxiaozhu commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2074550645 hey @zhouyuan could you help add `format_string` and `format_number` in the list and I would take `format_string` and `format_number` later -- This is an

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-18 Thread via GitHub
lyy-pineapple commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2063280619 > @PHILO-HE hello, I'd like take forall function. and exists(array) also support -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-17 Thread via GitHub
acvictor commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2060476882 I'd like to try array_size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-17 Thread via GitHub
ivoson commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2060456474 I'd like to take flatten function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-16 Thread via GitHub
lyy-pineapple commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2058588022 @PHILO-HE hello, I'd like take forall function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-15 Thread via GitHub
Yohahaha commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2055471331 I'd like take transform function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-12 Thread via GitHub
Yohahaha commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2051313485 I'd like take get function, as known as GetArrayItem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-11 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2050928067 > Hey, @PHILO-HE , what's the plan with concat_ws ? It says "PR Ready" and I see that you have committed an implementation to this branch:

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-11 Thread via GitHub
supermem613 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2049850094 Hey, @PHILO-HE , what's the plan with concat_ws ? It says "PR Ready" and I see that you have committed an implementation to this branch:

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-11 Thread via GitHub
Yohahaha commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-204919 I'd like take percentile agg function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-08 Thread via GitHub
ivoson commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2042062087 Hi @PHILO-HE I'd like to take filter (array filter), thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2034062336 Just removed the below supported functions from the above list. Thanks for the contribution! `last_day, unhex, lead, lag, minute, second, may_keys` -- This is an

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-04-03 Thread via GitHub
PHILO-HE commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2034042510 > @PHILO-HE , I'd like to pick up base64 and unbase64, please. > > (FYI, looks like there was a PR above for unbase64, but it seems to have been closed without

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-03-26 Thread via GitHub
supermem613 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2020700016 I'd like to pick up base64 and unbase64, please. (FYI, looks like there was a PR above for unbase64, but it seems to have been closed without committing ~45-55

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-03-21 Thread via GitHub
yma11 commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2014391482 @PHILO-HE I would like to take `map_filter`. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] [VL] Unsupported spark function list [please leave a comment if you plan to pick some] [incubator-gluten]

2024-03-21 Thread via GitHub
mskapilks commented on issue #4039: URL: https://github.com/apache/incubator-gluten/issues/4039#issuecomment-2014344838 > I would like to work on `bool_and`, `bool_or` These are already supported it seems. All `bool_and`, `bool_or`, `every`, `some` get converted to min, max of bool