Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2021843842 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
yaooqinn merged PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1540297481 ## docs/get-started/Velox.md: ## @@ -5,28 +5,34 @@ nav_order: 1 parent: Getting-Started --- # Supported Version -| Type | Version

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2021727351 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1539216963 ## .github/workflows/velox_docker.yml: ## @@ -73,6 +73,17 @@ jobs: matrix: os: ["ubuntu:20.04", "ubuntu:22.04"] spark: ["spark-3.2",

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
PHILO-HE commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1539159436 ## .github/workflows/velox_docker.yml: ## @@ -84,69 +95,49 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven run: |

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2020149985 cc @zhztheplayer @zhouyuan @PHILO-HE if you have other comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538964666 ## .github/workflows/velox_docker.yml: ## @@ -155,32 +146,39 @@ jobs: name: velox-native-lib-${{github.sha}} path:

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538961770 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019918106 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019885042 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
zhouyuan commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538805865 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven run: |

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019564540 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019477532 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-26 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019472931 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
zhztheplayer commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538603244 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538596991 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
zhztheplayer commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538580041 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
ulysses-you commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538574833 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019369826 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
zhztheplayer commented on code in PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#discussion_r1538572510 ## .github/workflows/velox_docker.yml: ## @@ -84,31 +89,41 @@ jobs: path: ./cpp/build/releases - name: Setup java and maven

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019321364 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
ulysses-you opened a new pull request, #5120: URL: https://github.com/apache/incubator-gluten/pull/5120 ## What changes were proposed in this pull request? - Add jdk-17 maven profile - Add jdk17 tpcds/tpch github action workflow - Update docs ## How was this patch tested?

Re: [PR] [CORE] Support JDK17 [incubator-gluten]

2024-03-25 Thread via GitHub
github-actions[bot] commented on PR #5120: URL: https://github.com/apache/incubator-gluten/pull/5120#issuecomment-2019321092 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?