Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-21 Thread via GitHub
GlutenPerfBot commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2012691325 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-21 Thread via GitHub
PHILO-HE merged PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on code in PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#discussion_r1533098874 ## cpp/velox/substrait/VeloxSubstraitSignature.cc: ## @@ -159,16 +151,43 @@ TypePtr VeloxSubstraitSignature::fromSubstraitSignature(const std::string& signa

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-20 Thread via GitHub
WangGuangxin commented on code in PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#discussion_r1533084012 ## cpp/velox/substrait/VeloxSubstraitSignature.cc: ## @@ -159,16 +151,43 @@ TypePtr VeloxSubstraitSignature::fromSubstraitSignature(const std::string&

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2010912174 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-20 Thread via GitHub
PHILO-HE commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2008721078 @WangGuangxin, CI reported the below failure. ``` - Support Map type signature *** FAILED *** org.apache.spark.SparkException: Job aborted due to stage failure:

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-19 Thread via GitHub
github-actions[bot] commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2008392076 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-19 Thread via GitHub
PHILO-HE commented on code in PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#discussion_r152690 ## cpp/velox/substrait/VeloxSubstraitSignature.cc: ## @@ -159,16 +151,43 @@ TypePtr VeloxSubstraitSignature::fromSubstraitSignature(const std::string& signa

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-18 Thread via GitHub
WangGuangxin commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2005405115 @jinchengchenghh @PHILO-HE @rui-mo Can you please help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2004287192 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4830][VL] Support MapType substrait signature [incubator-gluten]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #4833: URL: https://github.com/apache/incubator-gluten/pull/4833#issuecomment-2004274465 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to