Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-24 Thread via GitHub
rui-mo merged PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-24 Thread via GitHub
rui-mo commented on code in PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#discussion_r1537055336 ## shims/common/src/main/scala/io/glutenproject/GlutenConfig.scala: ## @@ -1691,4 +1693,10 @@ object GlutenConfig { .doc("Force fallback for orc char

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-24 Thread via GitHub
zzcclp commented on code in PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#discussion_r1537028076 ## shims/common/src/main/scala/io/glutenproject/GlutenConfig.scala: ## @@ -1691,4 +1693,10 @@ object GlutenConfig { .doc("Force fallback for orc char

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-24 Thread via GitHub
loudongfeng commented on code in PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#discussion_r1536970482 ## shims/common/src/main/scala/io/glutenproject/GlutenConfig.scala: ## @@ -1691,4 +1693,10 @@ object GlutenConfig { .doc("Force fallback for orc

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-22 Thread via GitHub
rui-mo commented on code in PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#discussion_r1535496509 ## shims/common/src/main/scala/io/glutenproject/GlutenConfig.scala: ## @@ -1691,4 +1693,10 @@ object GlutenConfig { .doc("Force fallback for orc char

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2011964731 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2011163819 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
loudongfeng commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2011022082 CI failures unrelated. Ready for review. @zzcclp thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2009013231 Run Gluten Clickhouse CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #5048: URL: https://github.com/apache/incubator-gluten/pull/5048#issuecomment-2009012977 https://github.com/apache/incubator-gluten/issues/4946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-4946][CH] Fix avg(bigint) overflow [incubator-gluten]

2024-03-20 Thread via GitHub
loudongfeng opened a new pull request, #5048: URL: https://github.com/apache/incubator-gluten/pull/5048 ## What changes were proposed in this pull request? cast avg input type to double when type is integer types: bigint/int/short... Fixes: \#4946 ## How was this patch