xumingming commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2014063223
> Let's fix this issue at least. It's really not good experience to run `git
commit --amend` each time
>
> @xumingming would you like to take a look?
@FelixYBW
GlutenPerfBot commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2013994909
= Performance report for TPCH SF2000 with Velox backend, for reference
only
query
FelixYBW merged PR #5032:
URL: https://github.com/apache/incubator-gluten/pull/5032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
FelixYBW commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2013432783
>Another issue is that currently script skip the velox build even if we
modified some file in velox because it check the commit id to continue. So we
need a git commit --amend
zhztheplayer commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010986896
Thanks @xumingming for the enhancement.
> can you add one flag like -Dfetch_velox=ON/OFF which can fetch velox or
not before build? by default let's set it ON.
FelixYBW commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010942825
@zhztheplayer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FelixYBW commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010942586
Thank you. It's something we just planed. Since build_velox is always
needed, can you add one flag like -Dfetch_velox=ON/OFF which can fetch velox or
not before build? by
xumingming commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2010850789
@FelixYBW Would you take a look at this one? I think it saves time for
build's debuging.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #5032:
URL:
https://github.com/apache/incubator-gluten/pull/5032#issuecomment-2008338557
https://github.com/apache/incubator-gluten/issues/5024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
