Re: [PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-17 Thread via GitHub
GlutenPerfBot commented on PR #5778: URL: https://github.com/apache/incubator-gluten/pull/5778#issuecomment-2116854197 = Performance report for TPCH SF2000 with Velox backend, for reference only query

Re: [PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-16 Thread via GitHub
FelixYBW merged PR #5778: URL: https://github.com/apache/incubator-gluten/pull/5778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-16 Thread via GitHub
xumingming commented on PR #5778: URL: https://github.com/apache/incubator-gluten/pull/5778#issuecomment-2116443676 @FelixYBW made the following changes: 1. Added the valid versions into doc, it makes the description a little bit long, the whole table for options is reformatted, but

Re: [PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-16 Thread via GitHub
FelixYBW commented on code in PR #5778: URL: https://github.com/apache/incubator-gluten/pull/5778#discussion_r1604203126 ## docs/get-started/build-guide.md: ## @@ -31,7 +31,8 @@ Please set them via `--`, e.g. `--build_type=Release`. | velox_home | Specify your own

Re: [PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-16 Thread via GitHub
xumingming commented on PR #5778: URL: https://github.com/apache/incubator-gluten/pull/5778#issuecomment-2116366850 > The valid command is > > ``` > ./dev/buildbundle-veloxbe.sh ALL > ./dev/buildbundle-veloxbe.sh 3.2 > ./dev/buildbundle-veloxbe.sh 3.3 >

Re: [PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-16 Thread via GitHub
FelixYBW commented on PR #5778: URL: https://github.com/apache/incubator-gluten/pull/5778#issuecomment-2116218987 The valid command is ``` ./dev/buildbundle-veloxbe.sh ALL ./dev/buildbundle-veloxbe.sh 3.2 ./dev/buildbundle-veloxbe.sh 3.3 ./dev/buildbundle-veloxbe.sh 3.4

Re: [PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-16 Thread via GitHub
github-actions[bot] commented on PR #5778: URL: https://github.com/apache/incubator-gluten/pull/5778#issuecomment-2115517617 https://github.com/apache/incubator-gluten/issues/5777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [GLUTEN-5777][VL] Supporting specify spark version when build [incubator-gluten]

2024-05-16 Thread via GitHub
xumingming opened a new pull request, #5778: URL: https://github.com/apache/incubator-gluten/pull/5778 Support a new option: --spark_version for buildbundle-veloxbe.sh and builddeps-veloxbe.sh. By default the version is `ALL` which keeps the same behaviour as now. -- This is an