Re: [PR] [VL] Refine CMAKE_CXX_FLAGS generation logic [incubator-gluten]

Yohahaha commented on code in PR #5769: URL: https://github.com/apache/incubator-gluten/pull/5769#discussion_r1604256354 ## cpp/velox/CMakeLists.txt: ## @@ -52,6 +47,19 @@ if (NOT DEFINED VELOX_HOME) message(STATUS "Set VELOX_HOME to ${VELOX_HOME}") endif()

Re: [PR] [VL] Refine CMAKE_CXX_FLAGS generation logic [incubator-gluten]

marin-ma commented on code in PR #5769: URL: https://github.com/apache/incubator-gluten/pull/5769#discussion_r1604244812 ## cpp/velox/CMakeLists.txt: ## @@ -52,6 +47,19 @@ if (NOT DEFINED VELOX_HOME) message(STATUS "Set VELOX_HOME to ${VELOX_HOME}") endif()

Re: [PR] [VL] Refine CMAKE_CXX_FLAGS generation logic [incubator-gluten]

Yohahaha commented on PR #5769: URL: https://github.com/apache/incubator-gluten/pull/5769#issuecomment-2116481325 @marin-ma @PHILO-HE please help take a look, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [VL] Refine CMAKE_CXX_FLAGS generation logic [incubator-gluten]

Yohahaha commented on PR #5769: URL: https://github.com/apache/incubator-gluten/pull/5769#issuecomment-2116473739 > Is there impact to build process? no changes, just a little refactor. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [VL] Refine CMAKE_CXX_FLAGS generation logic [incubator-gluten]

FelixYBW commented on PR #5769: URL: https://github.com/apache/incubator-gluten/pull/5769#issuecomment-2116232572 Is there impact to build process? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [VL] Refine CMAKE_CXX_FLAGS generation logic [incubator-gluten]

github-actions[bot] commented on PR #5769: URL: https://github.com/apache/incubator-gluten/pull/5769#issuecomment-2114264436 Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues?

[PR] [VL] Refine CMAKE_CXX_FLAGS generation logic [incubator-gluten]

Yohahaha opened a new pull request, #5769: URL: https://github.com/apache/incubator-gluten/pull/5769 ## What changes were proposed in this pull request? After this PR, We can clearly see all the CMAKE_CXX_FLAGS. -- This is an automated message from the Apache Git Service. To